183049 2018-02-22 11:33:11 -0800 Fix build error with !LOG_DISABLED 2018-03-01 09:03:09 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cturner cturner cdumez commit-queue darin dbates esprehn+autocc ews-watchlist kangil.han pnormand webkit-bug-importer oldest_to_newest 1401482 0 cturner 2018-02-22 11:33:11 -0800 Fix build error with !LOG_DISABLED 1401483 1 334460 cturner 2018-02-22 11:34:49 -0800 Created attachment 334460 Patch 1402013 2 334609 cturner 2018-02-26 04:03:48 -0800 Created attachment 334609 Patch 1402016 3 334610 cturner 2018-02-26 04:21:19 -0800 Created attachment 334610 Patch for landing 1402017 4 334610 commit-queue 2018-02-26 04:22:52 -0800 Comment on attachment 334610 Patch for landing Rejecting attachment 334610 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 334610, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/6674187 1402021 5 334611 cturner 2018-02-26 04:32:37 -0800 Created attachment 334611 Patch for landing 1402026 6 334611 commit-queue 2018-02-26 05:07:46 -0800 Comment on attachment 334611 Patch for landing Clearing flags on attachment: 334611 Committed r229004: <https://trac.webkit.org/changeset/229004> 1402027 7 commit-queue 2018-02-26 05:07:48 -0800 All reviewed patches have been landed. Closing bug. 1402028 8 webkit-bug-importer 2018-02-26 05:08:19 -0800 <rdar://problem/37897889> 1402241 9 334611 darin 2018-02-26 18:26:30 -0800 Comment on attachment 334611 Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=334611&action=review > Source/WebCore/dom/messageports/MessagePortChannel.h:64 > String logString() const { return makeString(m_ports[0].logString(), ":", m_ports[1].logString()); } This should be ':' instead of ":" for slightly better performance. 1402314 10 cturner 2018-02-27 02:40:50 -0800 (In reply to Darin Adler from comment #9) > Comment on attachment 334611 [details] > Patch for landing > > View in context: > https://bugs.webkit.org/attachment.cgi?id=334611&action=review > > > Source/WebCore/dom/messageports/MessagePortChannel.h:64 > > String logString() const { return makeString(m_ports[0].logString(), ":", m_ports[1].logString()); } > > This should be ':' instead of ":" for slightly better performance. Can place this into a separate issue if it's causing you performance regressions; this bug wasn't touching that line, I wanted to keep it specific to the build fix rather than speculative performance improvements on my end (I don't have any benchmarking infrastructure for such things) 1402732 11 darin 2018-02-28 14:40:19 -0800 (In reply to Charlie Turner from comment #10) > Can place this into a separate issue Sure that would be fine. But you really don’t have to do anything. > if it's causing you performance regressions That seems like a strange turn of phrase. Definitely no "regression" here. I was just commenting about best practices, as I do whenever I see code near code being reviewed, something I’ve always done through the whole lifetime of the WebKit project. I understand this may be your first time seeing it. > this bug wasn't touching that line, I wanted to keep it > specific to the build fix rather than speculative performance improvements > on my end (I don't have any benchmarking infrastructure for such things) Yes, wasn’t criticizing what you have done. I was pointing out for anyone looking at this bug who cares to learn best practices, including but not limited to you, that this happens to use a slightly less efficient idiom. 1402881 12 cturner 2018-03-01 06:06:19 -0800 Hi Darin, (In reply to Darin Adler from comment #11) > > if it's causing you performance regressions > > That seems like a strange turn of phrase. Definitely no "regression" here. > > I was just commenting about best practices, as I do whenever I see code near > code being reviewed, something I’ve always done through the whole lifetime > of the WebKit project. > > I understand this may be your first time seeing it. I appreciate it :). I assumed you wanted it changing with this patch, but now I know better. I never know what the rdar bug importer is doing, and assumed perhaps Apple was running performance testing builds that flagged it with LOG_DISABLED=0 in release. 1402911 13 darin 2018-03-01 09:03:09 -0800 (In reply to Charlie Turner from comment #12) > I never know what the rdar bug importer is doing The "bug importer" just registers the bug in Apple’s internal bug system. It doesn’t generally mean anything to us working on the WebKit project except that Apple plans to track this bug as it is fixed and the fix is integrated. I wish there was a simple way of annotating WebKit bugs that was less distracting since it has no significance for people outside Apple. There could be some kind of discussion of a bug inside Apple that is not visible in bugs.webkit.org because there are people at Apple who work on WebKit who sit next to each other and they do talk to each other. And there are *occasional* subjects discussed in email and Apple’s internal bug system, but generally seeing the "bug importer" thing on a bug does not indicate anything going on for a particular bug. 334460 2018-02-22 11:34:49 -0800 2018-02-26 04:03:44 -0800 Patch bug-183049-20180222193447.patch text/plain 1177 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4OTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTA3YzgzZTFmYjA5YWY2 YTQ5OTdkMzMyM2FjMzIzODIxOTFlOWU4Ny4uNzg5NmRkNjkxNjBkZjI1MTYyMjMyYjhmNTA5ODI3 ZTViNTZiNmQ1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE4LTAyLTIyICBDaGFy bGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBGaXggYnVpbGQgZXJy b3Igd2l0aCAhTE9HX0RJU0FCTEVECisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODMwNDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGRvbS9tZXNzYWdlcG9ydHMvTWVzc2FnZVBvcnRDaGFubmVsLmg6CisK IDIwMTgtMDItMjIgIE1zMmdlciAgPE1zMmdlckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtd W1dQRV0gRml4IHNvbWUgYnVpbGQgZXJyb3JzIGluIHNlcnZpY2Ugd29ya2VycyBjb2RlCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vbWVzc2FnZXBvcnRzL01lc3NhZ2VQb3J0Q2hhbm5l bC5oIGIvU291cmNlL1dlYkNvcmUvZG9tL21lc3NhZ2Vwb3J0cy9NZXNzYWdlUG9ydENoYW5uZWwu aAppbmRleCA5Yzc4MzI1NmI3YTE5ZDZmMTNjZjQ0OGU0MDNkOGJkY2YzOTU1NDM5Li44ODIyNDM0 MDQxNzc1NWFiZWJiZGVkNTdkMDE0MDUwZGJjNTA1M2Y1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9kb20vbWVzc2FnZXBvcnRzL01lc3NhZ2VQb3J0Q2hhbm5lbC5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9tZXNzYWdlcG9ydHMvTWVzc2FnZVBvcnRDaGFubmVsLmgKQEAgLTYwLDcgKzYw LDcgQEAgcHVibGljOgogCiAgICAgdWludDY0X3QgYmVpbmdUcmFuc2ZlcnJlZENvdW50KCk7CiAK LSNpZm5kZWYgTkRFQlVHCisjaWYgIUxPR19ESVNBQkxFRAogICAgIFN0cmluZyBsb2dTdHJpbmco KSBjb25zdCB7IHJldHVybiBtYWtlU3RyaW5nKG1fcG9ydHNbMF0ubG9nU3RyaW5nKCksICI6Iiwg bV9wb3J0c1sxXS5sb2dTdHJpbmcoKSk7IH0KICNlbmRpZgogCg== 334609 2018-02-26 04:03:48 -0800 2018-02-26 04:21:16 -0800 Patch bug-183049-20180226120346.patch text/plain 2071 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4OTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTRlODM2MzRiNzFmOGFh YjhjY2Q0YjMzYzBhZDQ5ZTYxNDQyYjVlYi4uZTM5ODhhZTAzODVhMWVlN2RiMDFlNGZiZDUyNGFl OWQzZjI1OTI1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE4LTAyLTI2ICBDaGFy bGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBGaXggYnVpbGQgZXJy b3Igd2l0aCAhTE9HX0RJU0FCTEVECisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODMwNDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGUgZm9sbG93aW5nIGVycm9yIG1lc3NhZ2Ugd2FzIGJlaW5nIHJlcG9y dGVkIHdoZW4gZG9pbmcgYQorICAgICAgICByZWxlYXNlIGJ1aWxkIHdpdGggLURMT0dfRElTQUJM RUQ9MDoKKworICAgICAgICAuLi8uLi9Tb3VyY2UvV2ViQ29yZS9kb20vbWVzc2FnZXBvcnRzL01l c3NhZ2VQb3J0Q2hhbm5lbC5jcHA6IEluIG1lbWJlciBmdW5jdGlvbiDigJh2b2lkIFdlYkNvcmU6 Ok1lc3NhZ2VQb3J0Q2hhbm5lbDo6ZW50YW5nbGVQb3J0V2l0aFByb2Nlc3MoY29uc3QgV2ViQ29y ZTo6TWVzc2FnZVBvcnRJZGVudGlmaWVyJiwgV2ViQ29yZTo6UHJvY2Vzc0lkZW50aWZpZXIp4oCZ OgorLi4vLi4vU291cmNlL1dlYkNvcmUvZG9tL21lc3NhZ2Vwb3J0cy9NZXNzYWdlUG9ydENoYW5u ZWwuY3BwOjg1OjExMTogZXJyb3I6IOKAmGxvZ1N0cmluZ+KAmSB3YXMgbm90IGRlY2xhcmVkIGlu IHRoaXMgc2NvcGUKKyAgICAgTE9HKE1lc3NhZ2VQb3J0cywgIk1lc3NhZ2VQb3J0Q2hhbm5lbCAl cyAoJXApIGVudGFuZ2xpbmcgcG9ydCAlcyAodGhhdCBwb3J0IGhhcyAlenUgbWVzc2FnZXMgYXZh aWxhYmxlKSIsIGxvZ1N0cmluZygpLnV0ZjgoKS5kYXRhKCksIHRoaXMsIHBvcnQubG9nU3RyaW5n KCkudXRmOCgpLmRhdGEoKSwgbV9wZW5kaW5nTWVzc2FnZXNbaV0uc2l6ZSgpKTsKKworICAgICAg ICBPdGhlciB1c2VzIG9mIGxvZ1N0cmluZyBhcmUgZ3VhcmRlZCBieSAhTE9HX0RJU0FCTEVEIHJh dGhlciB0aGFuCisgICAgICAgIE5ERUJVRywgd2hpY2ggd2FzIHRoZSBjYXVzZSBvZiB0aGlzIGlz c3VlLgorCisgICAgICAgICogZG9tL21lc3NhZ2Vwb3J0cy9NZXNzYWdlUG9ydENoYW5uZWwuaDog R3VhcmQgdXNpbmcgIUxPR19ESVNBQkxFRAorICAgICAgICByYXRoZXIgdGhhbiBOREVCVUcuCisK IDIwMTgtMDItMjYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgog CiAgICAgICAgIFtHU3RyZWFtZXJdIFVzZXIgY3VycmVudCBleGVjdXRhYmxlIG5hbWUgaW5zdGVh ZCBvZiBnX2dldF9wcmduYW1lKCkgZm9yIGdzdF9pbml0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9kb20vbWVzc2FnZXBvcnRzL01lc3NhZ2VQb3J0Q2hhbm5lbC5oIGIvU291cmNlL1dlYkNv cmUvZG9tL21lc3NhZ2Vwb3J0cy9NZXNzYWdlUG9ydENoYW5uZWwuaAppbmRleCA5Yzc4MzI1NmI3 YTE5ZDZmMTNjZjQ0OGU0MDNkOGJkY2YzOTU1NDM5Li44ODIyNDM0MDQxNzc1NWFiZWJiZGVkNTdk MDE0MDUwZGJjNTA1M2Y1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vbWVzc2FnZXBv cnRzL01lc3NhZ2VQb3J0Q2hhbm5lbC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9tZXNzYWdl cG9ydHMvTWVzc2FnZVBvcnRDaGFubmVsLmgKQEAgLTYwLDcgKzYwLDcgQEAgcHVibGljOgogCiAg ICAgdWludDY0X3QgYmVpbmdUcmFuc2ZlcnJlZENvdW50KCk7CiAKLSNpZm5kZWYgTkRFQlVHCisj aWYgIUxPR19ESVNBQkxFRAogICAgIFN0cmluZyBsb2dTdHJpbmcoKSBjb25zdCB7IHJldHVybiBt YWtlU3RyaW5nKG1fcG9ydHNbMF0ubG9nU3RyaW5nKCksICI6IiwgbV9wb3J0c1sxXS5sb2dTdHJp bmcoKSk7IH0KICNlbmRpZgogCg== 334610 2018-02-26 04:21:19 -0800 2018-02-26 04:32:34 -0800 Patch for landing bug-183049-20180226122118.patch text/plain 2071 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4OTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTRlODM2MzRiNzFmOGFh YjhjY2Q0YjMzYzBhZDQ5ZTYxNDQyYjVlYi4uZTM5ODhhZTAzODVhMWVlN2RiMDFlNGZiZDUyNGFl OWQzZjI1OTI1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE4LTAyLTI2ICBDaGFy bGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBGaXggYnVpbGQgZXJy b3Igd2l0aCAhTE9HX0RJU0FCTEVECisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODMwNDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGUgZm9sbG93aW5nIGVycm9yIG1lc3NhZ2Ugd2FzIGJlaW5nIHJlcG9y dGVkIHdoZW4gZG9pbmcgYQorICAgICAgICByZWxlYXNlIGJ1aWxkIHdpdGggLURMT0dfRElTQUJM RUQ9MDoKKworICAgICAgICAuLi8uLi9Tb3VyY2UvV2ViQ29yZS9kb20vbWVzc2FnZXBvcnRzL01l c3NhZ2VQb3J0Q2hhbm5lbC5jcHA6IEluIG1lbWJlciBmdW5jdGlvbiDigJh2b2lkIFdlYkNvcmU6 Ok1lc3NhZ2VQb3J0Q2hhbm5lbDo6ZW50YW5nbGVQb3J0V2l0aFByb2Nlc3MoY29uc3QgV2ViQ29y ZTo6TWVzc2FnZVBvcnRJZGVudGlmaWVyJiwgV2ViQ29yZTo6UHJvY2Vzc0lkZW50aWZpZXIp4oCZ OgorLi4vLi4vU291cmNlL1dlYkNvcmUvZG9tL21lc3NhZ2Vwb3J0cy9NZXNzYWdlUG9ydENoYW5u ZWwuY3BwOjg1OjExMTogZXJyb3I6IOKAmGxvZ1N0cmluZ+KAmSB3YXMgbm90IGRlY2xhcmVkIGlu IHRoaXMgc2NvcGUKKyAgICAgTE9HKE1lc3NhZ2VQb3J0cywgIk1lc3NhZ2VQb3J0Q2hhbm5lbCAl cyAoJXApIGVudGFuZ2xpbmcgcG9ydCAlcyAodGhhdCBwb3J0IGhhcyAlenUgbWVzc2FnZXMgYXZh aWxhYmxlKSIsIGxvZ1N0cmluZygpLnV0ZjgoKS5kYXRhKCksIHRoaXMsIHBvcnQubG9nU3RyaW5n KCkudXRmOCgpLmRhdGEoKSwgbV9wZW5kaW5nTWVzc2FnZXNbaV0uc2l6ZSgpKTsKKworICAgICAg ICBPdGhlciB1c2VzIG9mIGxvZ1N0cmluZyBhcmUgZ3VhcmRlZCBieSAhTE9HX0RJU0FCTEVEIHJh dGhlciB0aGFuCisgICAgICAgIE5ERUJVRywgd2hpY2ggd2FzIHRoZSBjYXVzZSBvZiB0aGlzIGlz c3VlLgorCisgICAgICAgICogZG9tL21lc3NhZ2Vwb3J0cy9NZXNzYWdlUG9ydENoYW5uZWwuaDog R3VhcmQgdXNpbmcgIUxPR19ESVNBQkxFRAorICAgICAgICByYXRoZXIgdGhhbiBOREVCVUcuCisK IDIwMTgtMDItMjYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgog CiAgICAgICAgIFtHU3RyZWFtZXJdIFVzZXIgY3VycmVudCBleGVjdXRhYmxlIG5hbWUgaW5zdGVh ZCBvZiBnX2dldF9wcmduYW1lKCkgZm9yIGdzdF9pbml0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9kb20vbWVzc2FnZXBvcnRzL01lc3NhZ2VQb3J0Q2hhbm5lbC5oIGIvU291cmNlL1dlYkNv cmUvZG9tL21lc3NhZ2Vwb3J0cy9NZXNzYWdlUG9ydENoYW5uZWwuaAppbmRleCA5Yzc4MzI1NmI3 YTE5ZDZmMTNjZjQ0OGU0MDNkOGJkY2YzOTU1NDM5Li44ODIyNDM0MDQxNzc1NWFiZWJiZGVkNTdk MDE0MDUwZGJjNTA1M2Y1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vbWVzc2FnZXBv cnRzL01lc3NhZ2VQb3J0Q2hhbm5lbC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9tZXNzYWdl cG9ydHMvTWVzc2FnZVBvcnRDaGFubmVsLmgKQEAgLTYwLDcgKzYwLDcgQEAgcHVibGljOgogCiAg ICAgdWludDY0X3QgYmVpbmdUcmFuc2ZlcnJlZENvdW50KCk7CiAKLSNpZm5kZWYgTkRFQlVHCisj aWYgIUxPR19ESVNBQkxFRAogICAgIFN0cmluZyBsb2dTdHJpbmcoKSBjb25zdCB7IHJldHVybiBt YWtlU3RyaW5nKG1fcG9ydHNbMF0ubG9nU3RyaW5nKCksICI6IiwgbV9wb3J0c1sxXS5sb2dTdHJp bmcoKSk7IH0KICNlbmRpZgogCg== 334611 2018-02-26 04:32:37 -0800 2018-02-26 05:07:46 -0800 Patch for landing bug-183049-20180226123236.patch text/plain 2073 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4OTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTRlODM2MzRiNzFmOGFh YjhjY2Q0YjMzYzBhZDQ5ZTYxNDQyYjVlYi4uYjE4NzQwNjUzNDI4NWQ0YzM2ZThkZjNlMDYxZGM0 ZDgwZWY5OGU4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE4LTAyLTI2ICBDaGFy bGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBGaXggYnVpbGQgZXJy b3Igd2l0aCAhTE9HX0RJU0FCTEVECisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODMwNDkKKworICAgICAgICBSZXZpZXdlZCBieSBQaGlsaXBwZSBOb3Jt YW5kLgorCisgICAgICAgIFRoZSBmb2xsb3dpbmcgZXJyb3IgbWVzc2FnZSB3YXMgYmVpbmcgcmVw b3J0ZWQgd2hlbiBkb2luZyBhCisgICAgICAgIHJlbGVhc2UgYnVpbGQgd2l0aCAtRExPR19ESVNB QkxFRD0wOgorCisgICAgICAgIC4uLy4uL1NvdXJjZS9XZWJDb3JlL2RvbS9tZXNzYWdlcG9ydHMv TWVzc2FnZVBvcnRDaGFubmVsLmNwcDogSW4gbWVtYmVyIGZ1bmN0aW9uIOKAmHZvaWQgV2ViQ29y ZTo6TWVzc2FnZVBvcnRDaGFubmVsOjplbnRhbmdsZVBvcnRXaXRoUHJvY2Vzcyhjb25zdCBXZWJD b3JlOjpNZXNzYWdlUG9ydElkZW50aWZpZXImLCBXZWJDb3JlOjpQcm9jZXNzSWRlbnRpZmllcini gJk6CisuLi8uLi9Tb3VyY2UvV2ViQ29yZS9kb20vbWVzc2FnZXBvcnRzL01lc3NhZ2VQb3J0Q2hh bm5lbC5jcHA6ODU6MTExOiBlcnJvcjog4oCYbG9nU3RyaW5n4oCZIHdhcyBub3QgZGVjbGFyZWQg aW4gdGhpcyBzY29wZQorICAgICBMT0coTWVzc2FnZVBvcnRzLCAiTWVzc2FnZVBvcnRDaGFubmVs ICVzICglcCkgZW50YW5nbGluZyBwb3J0ICVzICh0aGF0IHBvcnQgaGFzICV6dSBtZXNzYWdlcyBh dmFpbGFibGUpIiwgbG9nU3RyaW5nKCkudXRmOCgpLmRhdGEoKSwgdGhpcywgcG9ydC5sb2dTdHJp bmcoKS51dGY4KCkuZGF0YSgpLCBtX3BlbmRpbmdNZXNzYWdlc1tpXS5zaXplKCkpOworCisgICAg ICAgIE90aGVyIHVzZXMgb2YgbG9nU3RyaW5nIGFyZSBndWFyZGVkIGJ5ICFMT0dfRElTQUJMRUQg cmF0aGVyIHRoYW4KKyAgICAgICAgTkRFQlVHLCB3aGljaCB3YXMgdGhlIGNhdXNlIG9mIHRoaXMg aXNzdWUuCisKKyAgICAgICAgKiBkb20vbWVzc2FnZXBvcnRzL01lc3NhZ2VQb3J0Q2hhbm5lbC5o OiBHdWFyZCB1c2luZyAhTE9HX0RJU0FCTEVECisgICAgICAgIHJhdGhlciB0aGFuIE5ERUJVRy4K KwogMjAxOC0wMi0yNiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+ CiAKICAgICAgICAgW0dTdHJlYW1lcl0gVXNlciBjdXJyZW50IGV4ZWN1dGFibGUgbmFtZSBpbnN0 ZWFkIG9mIGdfZ2V0X3ByZ25hbWUoKSBmb3IgZ3N0X2luaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2RvbS9tZXNzYWdlcG9ydHMvTWVzc2FnZVBvcnRDaGFubmVsLmggYi9Tb3VyY2UvV2Vi Q29yZS9kb20vbWVzc2FnZXBvcnRzL01lc3NhZ2VQb3J0Q2hhbm5lbC5oCmluZGV4IDljNzgzMjU2 YjdhMTlkNmYxM2NmNDQ4ZTQwM2Q4YmRjZjM5NTU0MzkuLjg4MjI0MzQwNDE3NzU1YWJlYmJkZWQ1 N2QwMTQwNTBkYmM1MDUzZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9tZXNzYWdl cG9ydHMvTWVzc2FnZVBvcnRDaGFubmVsLmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL21lc3Nh Z2Vwb3J0cy9NZXNzYWdlUG9ydENoYW5uZWwuaApAQCAtNjAsNyArNjAsNyBAQCBwdWJsaWM6CiAK ICAgICB1aW50NjRfdCBiZWluZ1RyYW5zZmVycmVkQ291bnQoKTsKIAotI2lmbmRlZiBOREVCVUcK KyNpZiAhTE9HX0RJU0FCTEVECiAgICAgU3RyaW5nIGxvZ1N0cmluZygpIGNvbnN0IHsgcmV0dXJu IG1ha2VTdHJpbmcobV9wb3J0c1swXS5sb2dTdHJpbmcoKSwgIjoiLCBtX3BvcnRzWzFdLmxvZ1N0 cmluZygpKTsgfQogI2VuZGlmCiAK