183013 2018-02-21 12:47:38 -0800 ServiceWorkerJob::m_lastResponse is unneeded 2018-02-21 13:52:27 -0800 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf cdumez commit-queue webkit-bug-importer oldest_to_newest 1401226 0 youennf 2018-02-21 12:47:38 -0800 ServiceWorkerJob::m_lastResponse is unneeded 1401228 1 334405 youennf 2018-02-21 12:49:27 -0800 Created attachment 334405 Patch 1401233 2 youennf 2018-02-21 13:08:20 -0800 This could fix the following crash since m_lastResponse is the only ResourceResponse: Thread 5 Crashed ↩:: WebCore: Worker 0 com.apple.JavaScriptCore 0x00007fff301cd4c0 WTF::StringImpl::~StringImpl() + 80 1 com.apple.JavaScriptCore 0x00007fff301cd45e WTF::StringImpl::destroy(WTF::StringImpl*) + 14 2 com.apple.WebCore 0x00007fff3a8133c8 WebCore::ResourceResponseBase::~ResourceResponseBase() + 184 3 com.apple.WebCore 0x00007fff3bc2f89b WebCore::ServiceWorkerJob::~ServiceWorkerJob() + 59 4 com.apple.WebCore 0x00007fff3bc2f94e WebCore::ServiceWorkerJob::~ServiceWorkerJob() + 14 5 com.apple.WebCore 0x00007fff3bc2d27c WebCore::ServiceWorkerContainer::jobResolvedWithRegistration(WebCore::ServiceWorkerJob&, WebCore::ServiceWorkerRegistrationData&&, WebCore::ShouldNotifyWhenResolved) + 2444 6 com.apple.WebCore 0x00007fff3bc26c98 WTF::Function<void (WebCore::ScriptExecutionContext&)>::CallableWrapper<WebCore::SWClientConnection::postTaskForJob(WTF::ObjectIdentifier<WebCore::ServiceWorkerJobIdentifierType>, WebCore::SWClientConnection::IsJobComplete, WTF::Function<void (WebCore::ServiceWorkerJob&)>&&)::$_2>::call(WebCore::ScriptExecutionContext&) + 72 7 com.apple.WebCore 0x00007fff3bc1cd10 WebCore::WorkerRunLoop::runInMode(WebCore::WorkerGlobalScope*, WebCore::ModePredicate const&, WebCore::WorkerRunLoop::WaitMode) + 416 8 com.apple.WebCore 0x00007fff3bc1cb10 WebCore::WorkerRunLoop::run(WebCore::WorkerGlobalScope*) + 96 9 com.apple.WebCore 0x00007fff3bc1f0d9 WebCore::WorkerThread::workerThread() + 1033 10 com.apple.JavaScriptCore 0x00007fff30db8f44 WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) + 228 11 com.apple.JavaScriptCore 0x00007fff301cdbd9 WTF::wtfThreadEntryPoint(void*) + 9 12 libsystem_pthread.dylib 0x00007fff5597e661 _pthread_body + 340 13 libsystem_pthread.dylib 0x00007fff5597e50d _pthread_start + 377 14 libsystem_pthread.dylib 0x00007fff5597dbf9 thread_start + 13 That said, m_lastResponse is given by a WorkerThreadableLoaderClient callback so the response should already be isolated. Maybe there is a bigger issue and ServiceWorkerJob is not always deleted in the right thread? 1401237 3 334405 cdumez 2018-02-21 13:10:14 -0800 Comment on attachment 334405 Patch r=me if the bots are happy. 1401256 4 334405 commit-queue 2018-02-21 13:51:38 -0800 Comment on attachment 334405 Patch Clearing flags on attachment: 334405 Committed r228895: <https://trac.webkit.org/changeset/228895> 1401257 5 commit-queue 2018-02-21 13:51:40 -0800 All reviewed patches have been landed. Closing bug. 1401258 6 webkit-bug-importer 2018-02-21 13:52:27 -0800 <rdar://problem/37759608> 334405 2018-02-21 12:49:27 -0800 2018-02-21 13:51:38 -0800 Patch bug-183013-20180221124926.patch text/plain 2175 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4ODU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDkyYjU1ZjE0NTAzNWJh YjE3MjQ2MmYyYjhhZjk4YTM4Mjc0MTE5Ny4uYjg0OTUyNWY2NTBkNzVhODc3YWI5NTUzZWViNzQ5 NWM3MDMwNDNjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTAyLTIxICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBTZXJ2aWNlV29ya2VySm9i OjptX2xhc3RSZXNwb25zZSBpcyB1bm5lZWRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgzMDEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHRoaXMgZmllbGQgc2luY2Ugbm90IHVzZWQgYW55 d2hlcmUuCisKKyAgICAgICAgKiB3b3JrZXJzL3NlcnZpY2UvU2VydmljZVdvcmtlckpvYi5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpTZXJ2aWNlV29ya2VySm9iOjpkaWRSZWNlaXZlUmVzcG9uc2Up OgorICAgICAgICAqIHdvcmtlcnMvc2VydmljZS9TZXJ2aWNlV29ya2VySm9iLmg6CisKIDIwMTgt MDItMjEgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIE1vdmUg QXBwQ2FjaGUgbG9hZGluZyB0byB0aGUgTmV0d29ya1Byb2Nlc3MKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9TZXJ2aWNlV29ya2VySm9iLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3dvcmtlcnMvc2VydmljZS9TZXJ2aWNlV29ya2VySm9iLmNwcAppbmRleCA2MzFjOGMz OGEwODc3M2JjZmQxMjhkNmNkN2YzMjQyMTRkNTA3ZmI1Li43NjA2OTg1ODIzMDgwMTEwZWNjZGQ0 YWU4NWQ1N2YxMjM1ZjFjODgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3Nl cnZpY2UvU2VydmljZVdvcmtlckpvYi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9z ZXJ2aWNlL1NlcnZpY2VXb3JrZXJKb2IuY3BwCkBAIC0xMDcsNyArMTA3LDYgQEAgdm9pZCBTZXJ2 aWNlV29ya2VySm9iOjpkaWRSZWNlaXZlUmVzcG9uc2UodW5zaWduZWQgbG9uZywgY29uc3QgUmVz b3VyY2VSZXNwb25zZSYKICAgICBBU1NFUlQoIW1fY29tcGxldGVkKTsKICAgICBBU1NFUlQobV9z Y3JpcHRMb2FkZXIpOwogCi0gICAgbV9sYXN0UmVzcG9uc2UgPSByZXNwb25zZTsKICAgICAvLyBF eHRyYWN0IGEgTUlNRSB0eXBlIGZyb20gdGhlIHJlc3BvbnNlJ3MgaGVhZGVyIGxpc3QuIElmIHRo aXMgTUlNRSB0eXBlIChpZ25vcmluZyBwYXJhbWV0ZXJzKSBpcyBub3QgYSBKYXZhU2NyaXB0IE1J TUUgdHlwZSwgdGhlbjoKICAgICBpZiAoIU1JTUVUeXBlUmVnaXN0cnk6OmlzU3VwcG9ydGVkSmF2 YVNjcmlwdE1JTUVUeXBlKHJlc3BvbnNlLm1pbWVUeXBlKCkpKSB7CiAgICAgICAgIC8vIEludm9r ZSBSZWplY3QgSm9iIFByb21pc2Ugd2l0aCBqb2IgYW5kICJTZWN1cml0eUVycm9yIiBET01FeGNl cHRpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2UvU2Vydmlj ZVdvcmtlckpvYi5oIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL1NlcnZpY2VXb3Jr ZXJKb2IuaAppbmRleCA4NDcxMTcyODU0OTc0YWU1ODYzMTI2MGM2ZGU0MGIwMWVhODJlMWQ4Li5l ZTVkYWFmZTFhNTZjMTJkYTAwZDIxNDNmNjIyM2UxNzc1ODY5YTQ1IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2UvU2VydmljZVdvcmtlckpvYi5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9TZXJ2aWNlV29ya2VySm9iLmgKQEAgLTg5LDcgKzg5 LDYgQEAgcHJpdmF0ZToKIAogICAgIERvY3VtZW50T3JXb3JrZXJJZGVudGlmaWVyIG1fY29udGV4 dElkZW50aWZpZXI7CiAgICAgUmVmUHRyPFdvcmtlclNjcmlwdExvYWRlcj4gbV9zY3JpcHRMb2Fk ZXI7Ci0gICAgUmVzb3VyY2VSZXNwb25zZSBtX2xhc3RSZXNwb25zZTsKIAogI2lmICFBU1NFUlRf RElTQUJMRUQKICAgICBSZWY8VGhyZWFkPiBtX2NyZWF0aW9uVGhyZWFkIHsgVGhyZWFkOjpjdXJy ZW50KCkgfTsK