183009 2018-02-21 10:59:23 -0800 [RenderTreeBuilder] Move RenderView::willBeRemoved() mutation logic to RenderTreeBuilder 2018-02-21 11:50:30 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1401169 0 zalan 2018-02-21 10:59:23 -0800 the mutation code there is temporary anyway 1401172 1 webkit-bug-importer 2018-02-21 11:05:02 -0800 <rdar://problem/37752804> 1401174 2 334395 zalan 2018-02-21 11:11:49 -0800 Created attachment 334395 Patch 1401194 3 334395 commit-queue 2018-02-21 11:50:28 -0800 Comment on attachment 334395 Patch Clearing flags on attachment: 334395 Committed r228889: <https://trac.webkit.org/changeset/228889> 1401195 4 commit-queue 2018-02-21 11:50:30 -0800 All reviewed patches have been landed. Closing bug. 334395 2018-02-21 11:11:49 -0800 2018-02-21 11:50:28 -0800 Patch bug-183009-20180221111148.patch text/plain 3558 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4ODg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjI5Mzk3MjUwNDNlOTYz MzIyMGE4ZTNhNDM3ZWRhZDBlNTZjZGU3Ni4uOTc3OTc5YTk5NjIwMTIzMmYzOWViZTY2MDNjMWZl YTNlYjc0N2EwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTAyLTIxICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1JlbmRlclRyZWVCdWlsZGVy XSBNb3ZlIFJlbmRlclZpZXc6OndpbGxCZVJlbW92ZWQoKSBtdXRhdGlvbiBsb2dpYyB0byBSZW5k ZXJUcmVlQnVpbGRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTgzMDA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgTm8gY2hhbmdlIGluIGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiBkb20vRG9jdW1l bnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OmRlc3Ryb3lSZW5kZXJUcmVlKToK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJWaWV3Ojp+UmVuZGVyVmlldyk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJWaWV3Ojp3 aWxsQmVEZXN0cm95ZWQpOiBEZWxldGVkLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJWaWV3 Lmg6CisKIDIwMTgtMDItMjEgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAg ICAgICBbUmVuZGVyVHJlZUJ1aWxkZXJdIE1vdmUgUmVuZGVyVGV4dEZyYWdtZW50Ojp3aWxsQmVS ZW1vdmVkKCkgbXV0YXRpb24gbG9naWMgdG8gUmVuZGVyVHJlZUJ1aWxkZXIKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9j dW1lbnQuY3BwCmluZGV4IGY0NGQ0ODBjNDIyM2Q0MmFkODk4ODc3MGZmYmQ0YWM4ZTgyMWMxNDku Ljk0MjMyMzI2ZTBiN2ZiYTI5NjJmODBiNmU0NmZlZDEwNTlkZmIwNGIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0Rv Y3VtZW50LmNwcApAQCAtMjMxNyw2ICsyMzE3LDkgQEAgdm9pZCBEb2N1bWVudDo6ZGVzdHJveVJl bmRlclRyZWUoKQogICAgIC8vIEZJWE1FOiBSZW5kZXJPYmplY3Q6OnZpZXcoKSB1c2VzIG1fcmVu ZGVyVmlldyBhbmQgd2UgY2FuJ3QgbnVsbCBpdCBiZWZvcmUgZGVzdHJ1Y3Rpb24gaXMgY29tcGxl dGVkCiAgICAgewogICAgICAgICBSZW5kZXJUcmVlQnVpbGRlciBidWlsZGVyKCptX3JlbmRlclZp ZXcpOworICAgICAgICAvLyBGSVhNRTogVGhpcyBpcyBhIHdvcmthcm91bmQgZm9yIGxlZnRvdmVy IGNvbnRlbnQgKHNlZSB3ZWJraXQub3JnL2IvMTgyNTQ3KS4KKyAgICAgICAgd2hpbGUgKG1fcmVu ZGVyVmlldy0+Zmlyc3RDaGlsZCgpKQorICAgICAgICAgICAgYnVpbGRlci5yZW1vdmVBbmREZXN0 cm95KCptX3JlbmRlclZpZXctPmZpcnN0Q2hpbGQoKSk7CiAgICAgICAgIG1fcmVuZGVyVmlldy0+ ZGVzdHJveSgpOwogICAgIH0KICAgICBtX3JlbmRlclZpZXcucmVsZWFzZSgpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZXcuY3BwIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclZpZXcuY3BwCmluZGV4IGUxOTgxMzAxZjVlOWJjN2UyZThiYTJm ZGJkODhkY2EwZmZiNDc0MDMuLmM2OTlkNjVhMjZmNjIxYjkxNzIyMDIwOGQ1MWVjZDc0NTQ3Y2Vl ZTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWV3LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5jcHAKQEAgLTEwMyw3ICsx MDMsMTAgQEAgUmVuZGVyVmlldzo6UmVuZGVyVmlldyhEb2N1bWVudCYgZG9jdW1lbnQsIFJlbmRl clN0eWxlJiYgc3R5bGUpCiAgICAgc2V0UG9zaXRpb25TdGF0ZShBYnNvbHV0ZVBvc2l0aW9uKTsg Ly8gdG8gMCwwIDopCiB9CiAKLVJlbmRlclZpZXc6On5SZW5kZXJWaWV3KCkgPSBkZWZhdWx0Owor UmVuZGVyVmlldzo6flJlbmRlclZpZXcoKQoreworICAgIEFTU0VSVF9XSVRIX01FU1NBR0UobV9y ZW5kZXJlckNvdW50ID09IDEsICJBbGwgb3RoZXIgcmVuZGVyZXJzIGluIHRoaXMgcmVuZGVyIHRy ZWUgc2hvdWxkIGhhdmUgYmVlbiBkZXN0cm95ZWQiKTsKK30KIAogdm9pZCBSZW5kZXJWaWV3Ojpz Y2hlZHVsZUxhenlSZXBhaW50KFJlbmRlckJveCYgcmVuZGVyZXIpCiB7CkBAIC02MTEsMTYgKzYx NCw2IEBAIGJvb2wgUmVuZGVyVmlldzo6aXNTY3JvbGxhYmxlT3JSdWJiZXJiYW5kYWJsZUJveCgp IGNvbnN0CiAgICAgcmV0dXJuIGZyYW1lVmlldygpLmlzU2Nyb2xsYWJsZShkZWZpbmVTY3JvbGxh YmxlKTsKIH0KIAotdm9pZCBSZW5kZXJWaWV3Ojp3aWxsQmVEZXN0cm95ZWQoUmVuZGVyVHJlZUJ1 aWxkZXImIGJ1aWxkZXIpCi17Ci0gICAgUmVuZGVyQmxvY2tGbG93Ojp3aWxsQmVEZXN0cm95ZWQo YnVpbGRlcik7Ci0gICAgLy8gRklYTUU6IFRoaXMgaXMgYSB3b3JrYXJvdW5kIGZvciBsZWZ0b3Zl ciBjb250ZW50IChzZWUgd2Via2l0Lm9yZy9iLzE4MjU0NykuCi0gICAgd2hpbGUgKGZpcnN0Q2hp bGQoKSkKLSAgICAgICAgYnVpbGRlci5yZW1vdmVBbmREZXN0cm95KCpmaXJzdENoaWxkKCkpOwot Ci0gICAgQVNTRVJUX1dJVEhfTUVTU0FHRShtX3JlbmRlcmVyQ291bnQgPT0gMSwgIkFsbCBvdGhl ciByZW5kZXJlcnMgaW4gdGhpcyByZW5kZXIgdHJlZSBzaG91bGQgaGF2ZSBiZWVuIGRlc3Ryb3ll ZCIpOwotfQotCiB2b2lkIFJlbmRlclZpZXc6OmFic29sdXRlUmVjdHMoVmVjdG9yPEludFJlY3Q+ JiByZWN0cywgY29uc3QgTGF5b3V0UG9pbnQmIGFjY3VtdWxhdGVkT2Zmc2V0KSBjb25zdAogewog ICAgIHJlY3RzLmFwcGVuZChzbmFwcGVkSW50UmVjdChhY2N1bXVsYXRlZE9mZnNldCwgbGF5ZXIo KS0+c2l6ZSgpKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy Vmlldy5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZXcuaAppbmRleCA2ZDIz ZjBlMjBmZGQzZjE0MjkwYzg1MDZjZDQ0M2UxMzYyZmQwMmI2Li4yOTQ3MzdkYWFkN2M5YzI5YzAw MjQ1OTA3MGJmZjc4MTJhM2FhZGY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyVmlldy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWV3 LmgKQEAgLTIxNCw4ICsyMTQsNiBAQCBwcml2YXRlOgogCiAgICAgYm9vbCBpc1Njcm9sbGFibGVP clJ1YmJlcmJhbmRhYmxlQm94KCkgY29uc3Qgb3ZlcnJpZGU7CiAKLSAgICB2b2lkIHdpbGxCZURl c3Ryb3llZChSZW5kZXJUcmVlQnVpbGRlciYpIG92ZXJyaWRlOwotCiBwcml2YXRlOgogICAgIEZy YW1lVmlldyYgbV9mcmFtZVZpZXc7CiAK