183002 2018-02-21 07:31:01 -0800 [GStreamer] HTTP totalBytes query returns 0 after seeking (sometimes) 2018-02-23 02:07:20 -0800 1 1 1 Unclassified WebKit Platform Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pnormand pnormand calvaris eocanha webkit-bug-importer oldest_to_newest 1401102 0 pnormand 2018-02-21 07:31:01 -0800 The size attribute is reset when the element performs seeks, I don't see why that would make sense. Also it's useless to handle the DURATION query if the appsrc size is correctly set (once) in the first place. 1401104 1 334375 pnormand 2018-02-21 07:35:47 -0800 Created attachment 334375 Patch 1401387 2 334375 eocanha 2018-02-22 01:11:54 -0800 Comment on attachment 334375 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334375&action=review Apart from the nitpick below, I don't see anything wrong with the patch. > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:86 > + gboolean haveSize; This attribute is only for internal usage and doesn't interact with Glib. Why not using a C++ bool type, like for "paused" or "isSeeking"? 1401388 3 334375 calvaris 2018-02-22 01:14:09 -0800 Comment on attachment 334375 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334375&action=review >> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:86 >> + gboolean haveSize; > > This attribute is only for internal usage and doesn't interact with Glib. Why not using a C++ bool type, like for "paused" or "isSeeking"? I was going to mention exactly the same thing :) 1401676 4 pnormand 2018-02-23 02:07:00 -0800 Committed r228945: <https://trac.webkit.org/changeset/228945> 1401677 5 webkit-bug-importer 2018-02-23 02:07:20 -0800 <rdar://problem/37820322> 334375 2018-02-21 07:35:47 -0800 2018-02-22 01:14:09 -0800 Patch bug-183002-20180221153545.patch text/plain 4901 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4ODcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTZmYzZhZTg5ZmQ3MDE0 OGIzNzQ4ODRkZDNmMzNkNTA0ZjU1ZjhjOS4uZmIwODI0NTJlYWM1OWE3YmI5OTdkMzNmOWQ5OGRk MzUwMWMxYjIxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE4LTAyLTIxICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBIVFRQIHRvdGFsQnl0ZXMgcXVlcnkgcmV0dXJucyAwIGFmdGVyIHNlZWtpbmcgKHNvbWV0aW1l cykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MzAw MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5jcHA6Cisg ICAgICAgICh3ZWJraXRfd2ViX3NyY19pbml0KTogSW5pdGlhbGl6ZSBtZW1iZXIgdmFyaWFibGVz LiBBbHNvIG5vIG5lZWQKKyAgICAgICAgdG8gc2V0IHRoZSBhcHBzcmMgc2l6ZSBhdCB0aGF0IHBv aW50LgorICAgICAgICAod2ViS2l0V2ViU3JjU3RvcCk6IERvbid0IHJlc2V0IHNpemUgd2hlbiBz ZWVraW5nLiBTaXplIHNob3VsZCBpbgorICAgICAgICBtb3N0IGNhc2VzIHJlcHJlc2VudCB0aGUg Q29udGVudC1MZW5ndGggcmVzcG9uc2UgYXR0cmlidXRlLCBldmVuCisgICAgICAgIHdoZW4gc2Vl a2luZy4KKyAgICAgICAgKHdlYktpdFdlYlNyY1N0YXJ0KTogTm8gbmVlZCB0byByZXNldCB0aGUg c2l6ZSBhdHRyaWJ1dGUuCisgICAgICAgICh3ZWJLaXRXZWJTcmNRdWVyeVdpdGhQYXJlbnQpOiBM ZXQgYXBwc3JjIGhhbmRsZSBEVVJBVElPTiBxdWVyaWVzLgorICAgICAgICAoQ2FjaGVkUmVzb3Vy Y2VTdHJlYW1pbmdDbGllbnQ6OnJlc3BvbnNlUmVjZWl2ZWQpOiBFbWl0IGR1cmF0aW9uIG5vdGlm aWNhdGlvbiBvbmUgdGltZSBvbmx5LgorCiAyMDE4LTAyLTIxICBQaGlsaXBwZSBOb3JtYW5kICA8 cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1N0cmVhbWVyXSBDcmFzaCBpbiBEZWJ1 ZyBidWlsZCB3aGVuIHB1cmdpbmcgaW52YWxpZCB0cmFja3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFt ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktp dFdlYlNvdXJjZUdTdHJlYW1lci5jcHAKaW5kZXggYzg2NzExNWVjZWNlNjM4NmE0OTc2NjRlNDU4 NDIwZTc3YWUyMDA5Ni4uNzQyMjAwNjZiZDllZjNkNzljZmYzNzM4MzM1MmRkY2IzMzVlNTc2MSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dl YktpdFdlYlNvdXJjZUdTdHJlYW1lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5jcHAKQEAgLTgzLDYg KzgzLDcgQEAgc3RydWN0IF9XZWJLaXRXZWJTcmNQcml2YXRlIHsKICAgICBib29sIGRpZFBhc3NB Y2Nlc3NDb250cm9sQ2hlY2s7CiAKICAgICBndWludDY0IG9mZnNldDsKKyAgICBnYm9vbGVhbiBo YXZlU2l6ZTsKICAgICBndWludDY0IHNpemU7CiAgICAgZ2Jvb2xlYW4gc2Vla2FibGU7CiAgICAg Ym9vbCBwYXVzZWQ7CkBAIC0yMDQsNiArMjA1LDkgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl9z cmNfaW5pdChXZWJLaXRXZWJTcmMqIHNyYykKIAogICAgIHByaXYtPm5vdGlmaWVyID0gTWFpblRo cmVhZE5vdGlmaWVyPE1haW5UaHJlYWRTb3VyY2VOb3RpZmljYXRpb24+OjpjcmVhdGUoKTsKIAor ICAgIHByaXYtPmhhdmVTaXplID0gRkFMU0U7CisgICAgcHJpdi0+c2l6ZSA9IDA7CisKICAgICBw cml2LT5hcHBzcmMgPSBHU1RfQVBQX1NSQyhnc3RfZWxlbWVudF9mYWN0b3J5X21ha2UoImFwcHNy YyIsIG51bGxwdHIpKTsKICAgICBpZiAoIXByaXYtPmFwcHNyYykgewogICAgICAgICBHU1RfRVJS T1JfT0JKRUNUKHNyYywgIkZhaWxlZCB0byBjcmVhdGUgYXBwc3JjIik7CkBAIC0yNDYsNyArMjUw LDYgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl9zcmNfaW5pdChXZWJLaXRXZWJTcmMqIHNyYykK ICAgICBnc3RfYmFzZV9zcmNfc2V0X2F1dG9tYXRpY19lb3MoR1NUX0JBU0VfU1JDKHByaXYtPmFw cHNyYyksIEZBTFNFKTsKIAogICAgIGdzdF9hcHBfc3JjX3NldF9jYXBzKHByaXYtPmFwcHNyYywg bnVsbHB0cik7Ci0gICAgZ3N0X2FwcF9zcmNfc2V0X3NpemUocHJpdi0+YXBwc3JjLCAtMSk7CiB9 CiAKIHN0YXRpYyB2b2lkIHdlYktpdFdlYlNyY0Rpc3Bvc2UoR09iamVjdCogb2JqZWN0KQpAQCAt MzYwLDcgKzM2Myw2IEBAIHN0YXRpYyB2b2lkIHdlYktpdFdlYlNyY1N0b3AoV2ViS2l0V2ViU3Jj KiBzcmMpCiAgICAgcHJpdi0+b2Zmc2V0ID0gMDsKIAogICAgIGlmICghd2FzU2Vla2luZykgewot ICAgICAgICBwcml2LT5zaXplID0gMDsKICAgICAgICAgcHJpdi0+cmVxdWVzdGVkT2Zmc2V0ID0g MDsKICAgICAgICAgcHJpdi0+cGxheWVyID0gbnVsbHB0cjsKICAgICAgICAgcHJpdi0+c2Vla2Fi bGUgPSBGQUxTRTsKQEAgLTQ0Niw4ICs0NDgsNiBAQCBzdGF0aWMgdm9pZCB3ZWJLaXRXZWJTcmNT dGFydChXZWJLaXRXZWJTcmMqIHNyYykKICAgICByZXF1ZXN0LnNldEFsbG93Q29va2llcyh0cnVl KTsKICAgICByZXF1ZXN0LnNldEZpcnN0UGFydHlGb3JDb29raWVzKHVybCk7CiAKLSAgICBwcml2 LT5zaXplID0gMDsKLQogICAgIHJlcXVlc3Quc2V0SFRUUFJlZmVycmVyKHByaXYtPnBsYXllci0+ cmVmZXJyZXIoKSk7CiAKICAgICBpZiAocHJpdi0+aHR0cE1ldGhvZC5nZXQoKSkKQEAgLTU2Mywx OCArNTYzLDYgQEAgc3RhdGljIGdib29sZWFuIHdlYktpdFdlYlNyY1F1ZXJ5V2l0aFBhcmVudChH c3RQYWQqIHBhZCwgR3N0T2JqZWN0KiBwYXJlbnQsIEdzdFEKICAgICBnYm9vbGVhbiByZXN1bHQg PSBGQUxTRTsKIAogICAgIHN3aXRjaCAoR1NUX1FVRVJZX1RZUEUocXVlcnkpKSB7Ci0gICAgY2Fz ZSBHU1RfUVVFUllfRFVSQVRJT046IHsKLSAgICAgICAgR3N0Rm9ybWF0IGZvcm1hdDsKLQotICAg ICAgICBnc3RfcXVlcnlfcGFyc2VfZHVyYXRpb24ocXVlcnksICZmb3JtYXQsIG51bGxwdHIpOwot Ci0gICAgICAgIEdTVF9MT0dfT0JKRUNUKHNyYywgImR1cmF0aW9uIHF1ZXJ5IGluIGZvcm1hdCAl cywgY3VycmVudCBzaXplOiAlbHUiLCBnc3RfZm9ybWF0X2dldF9uYW1lKGZvcm1hdCksIHByaXYt PnNpemUpOwotICAgICAgICBpZiAoZm9ybWF0ID09IEdTVF9GT1JNQVRfQllURVMgJiYgcHJpdi0+ c2l6ZSA+IDApIHsKLSAgICAgICAgICAgIGdzdF9xdWVyeV9zZXRfZHVyYXRpb24ocXVlcnksIGZv cm1hdCwgcHJpdi0+c2l6ZSk7Ci0gICAgICAgICAgICByZXN1bHQgPSBUUlVFOwotICAgICAgICB9 Ci0gICAgICAgIGJyZWFrOwotICAgIH0KICAgICBjYXNlIEdTVF9RVUVSWV9VUkk6IHsKICAgICAg ICAgZ3N0X3F1ZXJ5X3NldF91cmkocXVlcnksIHByaXYtPm9yaWdpbmFsVVJJLmRhdGEoKSk7CiAg ICAgICAgIGlmICghcHJpdi0+cmVkaXJlY3RlZFVSSS5pc051bGwoKSkKQEAgLTc5MiwxNCArNzgw LDE3IEBAIHZvaWQgQ2FjaGVkUmVzb3VyY2VTdHJlYW1pbmdDbGllbnQ6OnJlc3BvbnNlUmVjZWl2 ZWQoUGxhdGZvcm1NZWRpYVJlc291cmNlJiwgY29uCiAgICAgaWYgKGxlbmd0aCA+IDAgJiYgcHJp di0+cmVxdWVzdGVkT2Zmc2V0ICYmIHJlc3BvbnNlLmh0dHBTdGF0dXNDb2RlKCkgPT0gMjA2KQog ICAgICAgICBsZW5ndGggKz0gcHJpdi0+cmVxdWVzdGVkT2Zmc2V0OwogCi0gICAgcHJpdi0+c2l6 ZSA9IGxlbmd0aCA+PSAwID8gbGVuZ3RoIDogMDsKICAgICBwcml2LT5zZWVrYWJsZSA9IGxlbmd0 aCA+IDAgJiYgZ19hc2NpaV9zdHJjYXNlY21wKCJub25lIiwgcmVzcG9uc2UuaHR0cEhlYWRlckZp ZWxkKEhUVFBIZWFkZXJOYW1lOjpBY2NlcHRSYW5nZXMpLnV0ZjgoKS5kYXRhKCkpOwogCi0gICAg R1NUX0RFQlVHX09CSkVDVChzcmMsICJTaXplOiAlIiBHX0dJTlQ2NF9GT1JNQVQgIiwgc2Vla2Fi bGU6ICVzIiwgcHJpdi0+c2l6ZSwgcHJpdi0+c2Vla2FibGUgPyAieWVzIiA6ICJubyIpOworICAg IEdTVF9ERUJVR19PQkpFQ1Qoc3JjLCAiU2l6ZTogJWxsZCwgc2Vla2FibGU6ICVzIiwgbGVuZ3Ro LCBwcml2LT5zZWVrYWJsZSA/ICJ5ZXMiIDogIm5vIik7CiAgICAgLy8gbm90aWZ5IHNpemUvZHVy YXRpb24KLSAgICBpZiAobGVuZ3RoID4gMCkKLSAgICAgICAgZ3N0X2FwcF9zcmNfc2V0X3NpemUo cHJpdi0+YXBwc3JjLCBsZW5ndGgpOwotICAgIGVsc2UgeworICAgIGlmIChsZW5ndGggPiAwKSB7 CisgICAgICAgIGlmICghcHJpdi0+aGF2ZVNpemUgfHwgKHN0YXRpY19jYXN0PGxvbmcgbG9uZz4o cHJpdi0+c2l6ZSkgIT0gbGVuZ3RoKSkgeworICAgICAgICAgICAgcHJpdi0+aGF2ZVNpemUgPSBU UlVFOworICAgICAgICAgICAgcHJpdi0+c2l6ZSA9IGxlbmd0aDsKKyAgICAgICAgICAgIGdzdF9h cHBfc3JjX3NldF9zaXplKHByaXYtPmFwcHNyYywgbGVuZ3RoKTsKKyAgICAgICAgfQorICAgIH0g ZWxzZSB7CiAgICAgICAgIGdzdF9hcHBfc3JjX3NldF9zaXplKHByaXYtPmFwcHNyYywgLTEpOwog ICAgICAgICBpZiAoIXByaXYtPnNlZWthYmxlKQogICAgICAgICAgICAgZ3N0X2FwcF9zcmNfc2V0 X3N0cmVhbV90eXBlKHByaXYtPmFwcHNyYywgR1NUX0FQUF9TVFJFQU1fVFlQRV9TVFJFQU0pOwo=