182996 2018-02-21 01:31:25 -0800 [GStreamer] We need to adopt GstGlDisplays after GStreamer 1.13.1 2018-02-21 05:26:29 -0800 1 1 1 Unclassified WebKit WebCore Misc. Other Unspecified Unspecified RESOLVED FIXED https://bugzilla.gnome.org/show_bug.cgi?id=743062 InRadar P2 Normal --- 182968 1 calvaris pnormand calvaris magomez pnormand webkit-bug-importer oldest_to_newest 1401043 0 calvaris 2018-02-21 01:31:25 -0800 If you check https://bugzilla.gnome.org/show_bug.cgi?id=743062 you'll see like after 1.13.1, references are sinked and the GstGLDisplay object are really [transfer full] (before the docs say they were but they were [transfer floating]). We need to address this in runtime or we can crash or leak depending on the version. 1401065 1 334358 pnormand 2018-02-21 03:17:18 -0800 Created attachment 334358 Patch 1401084 2 pnormand 2018-02-21 05:25:52 -0800 Committed r228869: <https://trac.webkit.org/changeset/228869> 1401085 3 webkit-bug-importer 2018-02-21 05:26:29 -0800 <rdar://problem/37742438> 334358 2018-02-21 03:17:18 -0800 2018-02-21 05:12:10 -0800 Patch bug-182996-20180221111717.patch text/plain 4902 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4ODY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzViNTIyOGY0MGRjMDg5 MDQxOTEwOGEyZmRmZDJhMzQwOTNlNjliYi4uYzhlYjVjMmQ1ZGFkZjY1MWI4MmU1YTFiODgwZWJj ZWUyZjZhNGYwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTAyLTIxICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBXZSBuZWVkIHRvIGFkb3B0IEdzdEdsRGlzcGxheXMgYWZ0ZXIgR1N0cmVhbWVyIDEuMTMuMQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyOTk2CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlOjplbnN1 cmVHc3RHTENvbnRleHQpOgorICAgICAgICBBZG9wdCByZWZlcmVuY2VzIHdoZW4gcnVubmluZyB3 aXRoIEdTdHJlYW1lciAxLjEzLjEgdG8gYXZvaWQKKyAgICAgICAgbWVtb3J5IGxlYWtzLgorCiAy MDE4LTAyLTIxICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAg ICAgICBbR1N0cmVhbWVyXSBDcmVhdGUgYSBXYXlsYW5kIEdMIGRpc3BsYXkgaW5zdGVhZCBvZiBF R0wKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1l ci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNl LmNwcAppbmRleCBjYTFmYTk0NTRkMWQ0ZDEyMDA4YjAzZmE3ODU4OTQ4ZjYyMzIyYjFhLi42Y2M3 M2RlNjA5OTQ0MmVmNjZkYmY2MDAzNjM0OGY3YTE3MjFhMTU1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0 cmVhbWVyQmFzZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0 cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwCkBAIC00MzgsMTcgKzQz OCwyNSBAQCBib29sIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2U6OmVuc3VyZUdzdEdM Q29udGV4dCgpCiAKICAgICBhdXRvJiBzaGFyZWREaXNwbGF5ID0gUGxhdGZvcm1EaXNwbGF5Ojpz aGFyZWREaXNwbGF5Rm9yQ29tcG9zaXRpbmcoKTsKIAorICAgIC8vIFRoZSBmbG9hdGluZyByZWYg cmVtb3ZhbCBzdXBwb3J0IHdhcyBhZGRlZCBpbiBodHRwczovL2J1Z3ppbGxhLmdub21lLm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NzQzMDYyLgorICAgIGJvb2wgc2hvdWxkQWRvcHRSZWYgPSB3ZWJraXRH c3RDaGVja1ZlcnNpb24oMSwgMTMsIDEpOwogICAgIGlmICghbV9nbERpc3BsYXkpIHsKICNpZiBQ TEFURk9STShYMTEpCiAjaWYgVVNFKEdMWCkKICAgICAgICAgaWYgKGlzPFBsYXRmb3JtRGlzcGxh eVgxMT4oc2hhcmVkRGlzcGxheSkpIHsKICAgICAgICAgICAgIEdTVF9ERUJVRygiQ3JlYXRpbmcg WDExIHNoYXJlZCBHTCBkaXNwbGF5Iik7Ci0gICAgICAgICAgICBtX2dsRGlzcGxheSA9IEdTVF9H TF9ESVNQTEFZKGdzdF9nbF9kaXNwbGF5X3gxMV9uZXdfd2l0aF9kaXNwbGF5KGRvd25jYXN0PFBs YXRmb3JtRGlzcGxheVgxMT4oc2hhcmVkRGlzcGxheSkubmF0aXZlKCkpKTsKKyAgICAgICAgICAg IGlmIChzaG91bGRBZG9wdFJlZikKKyAgICAgICAgICAgICAgICBtX2dsRGlzcGxheSA9IGFkb3B0 R1JlZihHU1RfR0xfRElTUExBWShnc3RfZ2xfZGlzcGxheV94MTFfbmV3X3dpdGhfZGlzcGxheShk b3duY2FzdDxQbGF0Zm9ybURpc3BsYXlYMTE+KHNoYXJlZERpc3BsYXkpLm5hdGl2ZSgpKSkpOwor ICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgIG1fZ2xEaXNwbGF5ID0gR1NUX0dMX0RJ U1BMQVkoZ3N0X2dsX2Rpc3BsYXlfeDExX25ld193aXRoX2Rpc3BsYXkoZG93bmNhc3Q8UGxhdGZv cm1EaXNwbGF5WDExPihzaGFyZWREaXNwbGF5KS5uYXRpdmUoKSkpOwogICAgICAgICB9CiAjZWxp ZiBVU0UoRUdMKQogICAgICAgICBpZiAoaXM8UGxhdGZvcm1EaXNwbGF5WDExPihzaGFyZWREaXNw bGF5KSkgewogICAgICAgICAgICAgR1NUX0RFQlVHKCJDcmVhdGluZyBYMTEgc2hhcmVkIEVHTCBk aXNwbGF5Iik7Ci0gICAgICAgICAgICBtX2dsRGlzcGxheSA9IEdTVF9HTF9ESVNQTEFZKGdzdF9n bF9kaXNwbGF5X2VnbF9uZXdfd2l0aF9lZ2xfZGlzcGxheShkb3duY2FzdDxQbGF0Zm9ybURpc3Bs YXlYMTE+KHNoYXJlZERpc3BsYXkpLmVnbERpc3BsYXkoKSkpOworICAgICAgICAgICAgaWYgKHNo b3VsZEFkb3B0UmVmKQorICAgICAgICAgICAgICAgIG1fZ2xEaXNwbGF5ID0gYWRvcHRHUmVmKEdT VF9HTF9ESVNQTEFZKGdzdF9nbF9kaXNwbGF5X2VnbF9uZXdfd2l0aF9lZ2xfZGlzcGxheShkb3du Y2FzdDxQbGF0Zm9ybURpc3BsYXlYMTE+KHNoYXJlZERpc3BsYXkpLmVnbERpc3BsYXkoKSkpKTsK KyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICBtX2dsRGlzcGxheSA9IEdTVF9HTF9E SVNQTEFZKGdzdF9nbF9kaXNwbGF5X2VnbF9uZXdfd2l0aF9lZ2xfZGlzcGxheShkb3duY2FzdDxQ bGF0Zm9ybURpc3BsYXlYMTE+KHNoYXJlZERpc3BsYXkpLmVnbERpc3BsYXkoKSkpOwogICAgICAg ICB9CiAjZW5kaWYKICNlbmRpZgpAQCAtNDU2LDE0ICs0NjQsMjAgQEAgYm9vbCBNZWRpYVBsYXll clByaXZhdGVHU3RyZWFtZXJCYXNlOjplbnN1cmVHc3RHTENvbnRleHQoKQogI2lmIFBMQVRGT1JN KFdBWUxBTkQpCiAgICAgICAgIGlmIChpczxQbGF0Zm9ybURpc3BsYXlXYXlsYW5kPihzaGFyZWRE aXNwbGF5KSkgewogICAgICAgICAgICAgR1NUX0RFQlVHKCJDcmVhdGluZyBXYXlsYW5kIHNoYXJl ZCBkaXNwbGF5Iik7Ci0gICAgICAgICAgICBtX2dsRGlzcGxheSA9IEdTVF9HTF9ESVNQTEFZKGdz dF9nbF9kaXNwbGF5X3dheWxhbmRfbmV3X3dpdGhfZGlzcGxheShkb3duY2FzdDxQbGF0Zm9ybURp c3BsYXlXYXlsYW5kPihzaGFyZWREaXNwbGF5KS5uYXRpdmUoKSkpOworICAgICAgICAgICAgaWYg KHNob3VsZEFkb3B0UmVmKQorICAgICAgICAgICAgICAgIG1fZ2xEaXNwbGF5ID0gYWRvcHRHUmVm KEdTVF9HTF9ESVNQTEFZKGdzdF9nbF9kaXNwbGF5X3dheWxhbmRfbmV3X3dpdGhfZGlzcGxheShk b3duY2FzdDxQbGF0Zm9ybURpc3BsYXlXYXlsYW5kPihzaGFyZWREaXNwbGF5KS5uYXRpdmUoKSkp KTsKKyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICBtX2dsRGlzcGxheSA9IEdTVF9H TF9ESVNQTEFZKGdzdF9nbF9kaXNwbGF5X3dheWxhbmRfbmV3X3dpdGhfZGlzcGxheShkb3duY2Fz dDxQbGF0Zm9ybURpc3BsYXlXYXlsYW5kPihzaGFyZWREaXNwbGF5KS5uYXRpdmUoKSkpOwogICAg ICAgICB9CiAjZW5kaWYKIAogI2lmIFBMQVRGT1JNKFdQRSkKICAgICAgICAgQVNTRVJUKGlzPFBs YXRmb3JtRGlzcGxheVdQRT4oc2hhcmVkRGlzcGxheSkpOwogICAgICAgICBHU1RfREVCVUcoIkNy ZWF0aW5nIFdQRSBzaGFyZWQgRUdMIGRpc3BsYXkiKTsKLSAgICAgICAgbV9nbERpc3BsYXkgPSBH U1RfR0xfRElTUExBWShnc3RfZ2xfZGlzcGxheV9lZ2xfbmV3X3dpdGhfZWdsX2Rpc3BsYXkoZG93 bmNhc3Q8UGxhdGZvcm1EaXNwbGF5V1BFPihzaGFyZWREaXNwbGF5KS5lZ2xEaXNwbGF5KCkpKTsK KyAgICAgICAgaWYgKHNob3VsZEFkb3B0UmVmKQorICAgICAgICAgICAgbV9nbERpc3BsYXkgPSBh ZG9wdEdSZWYoR1NUX0dMX0RJU1BMQVkoZ3N0X2dsX2Rpc3BsYXlfZWdsX25ld193aXRoX2VnbF9k aXNwbGF5KGRvd25jYXN0PFBsYXRmb3JtRGlzcGxheVdQRT4oc2hhcmVkRGlzcGxheSkuZWdsRGlz cGxheSgpKSkpOworICAgICAgICBlbHNlCisgICAgICAgICAgICBtX2dsRGlzcGxheSA9IEdTVF9H TF9ESVNQTEFZKGdzdF9nbF9kaXNwbGF5X2VnbF9uZXdfd2l0aF9lZ2xfZGlzcGxheShkb3duY2Fz dDxQbGF0Zm9ybURpc3BsYXlXUEU+KHNoYXJlZERpc3BsYXkpLmVnbERpc3BsYXkoKSkpOwogI2Vu ZGlmCiAKICAgICAgICAgQVNTRVJUKG1fZ2xEaXNwbGF5KTsKQEAgLTQ4NSw3ICs0OTksMTAgQEAg Ym9vbCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlOjplbnN1cmVHc3RHTENvbnRleHQo KQogICAgIGlmICghY29udGV4dEhhbmRsZSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAg bV9nbENvbnRleHQgPSBnc3RfZ2xfY29udGV4dF9uZXdfd3JhcHBlZChtX2dsRGlzcGxheS5nZXQo KSwgcmVpbnRlcnByZXRfY2FzdDxndWludHB0cj4oY29udGV4dEhhbmRsZSksIGdsUGxhdGZvcm0s IGdsQVBJKTsKKyAgICBpZiAoc2hvdWxkQWRvcHRSZWYpCisgICAgICAgIG1fZ2xDb250ZXh0ID0g YWRvcHRHUmVmKGdzdF9nbF9jb250ZXh0X25ld193cmFwcGVkKG1fZ2xEaXNwbGF5LmdldCgpLCBy ZWludGVycHJldF9jYXN0PGd1aW50cHRyPihjb250ZXh0SGFuZGxlKSwgZ2xQbGF0Zm9ybSwgZ2xB UEkpKTsKKyAgICBlbHNlCisgICAgICAgIG1fZ2xDb250ZXh0ID0gZ3N0X2dsX2NvbnRleHRfbmV3 X3dyYXBwZWQobV9nbERpc3BsYXkuZ2V0KCksIHJlaW50ZXJwcmV0X2Nhc3Q8Z3VpbnRwdHI+KGNv bnRleHRIYW5kbGUpLCBnbFBsYXRmb3JtLCBnbEFQSSk7CiAKICAgICByZXR1cm4gdHJ1ZTsKIH0K