182991 2018-02-20 17:13:24 -0800 ASSERT under WebAutomationSession::setProcessPool() when running W3C test suite a second time 2018-02-20 18:18:03 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg aestes bburg cgarcia commit-queue ews-watchlist joepeck mkwst timothy webkit-bug-importer oldest_to_newest 1400966 0 bburg 2018-02-20 17:13:24 -0800 It appears that the WebProcessPool's WebAutomationSession did not get cleared properly before we set the next one. Thus, we hit this assertion: #1 0x000000010f8cf13e in IPC::MessageReceiverMap::addMessageReceiver(IPC::StringReference, IPC::MessageReceiver&) at /Users/bburg/repos/webkit/OpenSource/Source/WebKit/Platform/IPC/MessageReceiverMap.cpp:44 ASSERT(!m_globalMessageReceivers.contains(messageReceiverName)); Because the old session has still registered for the name "WebAutomationSession". I looked into the receiver map and saw some unrecognized pointer still registered for that name. So, my hunch is that it's an old session that wasn't cleared properly. In general, the existing pattern of relying on the destructor to run at a certain time and clean up message receivers seems bad. If the client accidentally retained the WebAutomationSession somehow, then this would behave poorly. 1400967 1 bburg 2018-02-20 17:13:45 -0800 <rdar://problem/37620578> 1400972 2 334324 bburg 2018-02-20 17:20:39 -0800 Created attachment 334324 Proposed Fix 1400973 3 334324 timothy 2018-02-20 17:23:08 -0800 Comment on attachment 334324 Proposed Fix Good call. I blame me. 1400985 4 334324 commit-queue 2018-02-20 18:18:02 -0800 Comment on attachment 334324 Proposed Fix Clearing flags on attachment: 334324 Committed r228854: <https://trac.webkit.org/changeset/228854> 1400986 5 commit-queue 2018-02-20 18:18:03 -0800 All reviewed patches have been landed. Closing bug. 334324 2018-02-20 17:20:39 -0800 2018-02-20 18:18:02 -0800 Proposed Fix bug-182991-20180220172038.patch text/plain 3084 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4NzEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY5YThmZjRlYTE0N2RhZjc3 OTM0OTliZWIzYzMxMTAzMzA3NzM4MGUuLjU0MGQzZDhkYWRkOWRhZjUwZDBlZTlkYzIzNTI3ZmRj MTA3OGUyZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTgtMDItMjAgIEJyaWFuIEJ1 cmcgIDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQVNTRVJUIHVuZGVyIFdlYkF1dG9tYXRp b25TZXNzaW9uOjpzZXRQcm9jZXNzUG9vbCgpIHdoZW4gcnVubmluZyBXM0MgdGVzdCBzdWl0ZSBh IHNlY29uZCB0aW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xODI5OTEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM3NjIwNTc4PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNvbWV0aW1lcyB3aGVuIHJ1 bm5pbmcgbW9yZSB0aGFuIG9uZSBzZXNzaW9uIGVuZC10by1lbmQgd2l0aCB0aGUgc2FtZSBicm93 c2VyIGluc3RhbmNlLAorICAgICAgICBVSVByb2Nlc3Mgd291bGQgY3Jhc2ggdW5kZXIgYWRkTWVz c2FnZVJlY2VpdmVyIGJlY2F1c2UgYW5vdGhlciBXZWJBdXRvbWF0aW9uU2Vzc2lvbiB3YXMgc3Rp bGwKKyAgICAgICAgcmVnaXN0ZXJlZC4gVGhpcyBpcyBoYXJkIHRvIHJlcHJvZHVjZSwgYnV0IHVw b24gY29kZSBpbnNwZWN0aW9uLCB0aGUgcmVjZWl2ZXIgbWFuYWdlbWVudCBjb2RlCisgICAgICAg IGlzIHNvbWV3aGF0IHByb2JsZW1hdGljIGJlY2F1c2UgaXQgb25seSBydW5zIHdoZW4gdGhlIFdl YkF1dG9tYXRpb25TZXNzaW9uIGRlc3RydWN0b3IgcnVucy4KKyAgICAgICAgSW4gc29tZSBjYXNl cyB0aGUgY2xpZW50IGNvdWxkIHJldGFpbiB0d28gc2Vzc2lvbnMgYW5kIGNhdXNlIHRoZSBmaXJz dCBvbmUgdG8gbmV2ZXIgcmVtb3ZlIGl0c2VsZgorICAgICAgICBhcyB0aGUgbWVzc2FnZSByZWNl aXZlci4KKworICAgICAgICBJbnN0ZWFkIG9mIHVucmVnaXN0ZXJpbmcgdGhlIHNlc3Npb24gYXMg YSBtZXNzYWdlIHJlY2VpdmVyIHVuZGVybmVhdGggdGhlIHNlc3Npb24ncyBkZXN0cnVjdG9yLAor ICAgICAgICBkbyB0aGlzIHdoZW5ldmVyIGEgbmV3IHNlc3Npb24gc3VwcGxhbnRzIGFuIG9sZCBz ZXNzaW9uIHNpbmNlIHRoZXJlIGlzIG9ubHkgb25lIGFjdGl2ZSBzZXNzaW9uIGF0IGEgdGltZS4K KworICAgICAgICAqIFVJUHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9tYXRpb25TZXNzaW9uLmNw cDoKKyAgICAgICAgKFdlYktpdDo6V2ViQXV0b21hdGlvblNlc3Npb246On5XZWJBdXRvbWF0aW9u U2Vzc2lvbik6CisgICAgICAgICogVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29sLmNwcDoKKyAgICAg ICAgKFdlYktpdDo6V2ViUHJvY2Vzc1Bvb2w6OnNldEF1dG9tYXRpb25TZXNzaW9uKToKKwogMjAx OC0wMi0xNCAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgQXV0 b21hdGlvbjogY29tYmluZSBzZXNzaW9uIGNvbW1hbmRzIHRvIHJlc2l6ZSBhbmQgbW92ZSB0b3At bGV2ZWwgYnJvd3NpbmcgY29udGV4dHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0F1dG9tYXRpb24vV2ViQXV0b21hdGlvblNlc3Npb24uY3BwIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvbi5jcHAKaW5kZXggOTI0NjY4 N2RmNzVhZThlNzY3N2FkOTdlOTEwNzY4NTNmNjA4MzExOS4uMjk2ODViZmNkZDg4ZjdlYTc5NDQx N2I1NGZjZDVjZGIxZmNiN2ZjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv QXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvbi5jcHAKKysrIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvbi5jcHAKQEAgLTcxLDkgKzcx LDcgQEAgV2ViQXV0b21hdGlvblNlc3Npb246OldlYkF1dG9tYXRpb25TZXNzaW9uKCkKIFdlYkF1 dG9tYXRpb25TZXNzaW9uOjp+V2ViQXV0b21hdGlvblNlc3Npb24oKQogewogICAgIEFTU0VSVCgh bV9jbGllbnQpOwotCi0gICAgaWYgKG1fcHJvY2Vzc1Bvb2wpCi0gICAgICAgIG1fcHJvY2Vzc1Bv b2wtPnJlbW92ZU1lc3NhZ2VSZWNlaXZlcihNZXNzYWdlczo6V2ViQXV0b21hdGlvblNlc3Npb246 Om1lc3NhZ2VSZWNlaXZlck5hbWUoKSk7CisgICAgQVNTRVJUKCFtX3Byb2Nlc3NQb29sKTsKIH0K IAogdm9pZCBXZWJBdXRvbWF0aW9uU2Vzc2lvbjo6c2V0Q2xpZW50KHN0ZDo6dW5pcXVlX3B0cjxB UEk6OkF1dG9tYXRpb25TZXNzaW9uQ2xpZW50PiYmIGNsaWVudCkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29sLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL1dlYlByb2Nlc3NQb29sLmNwcAppbmRleCBmYWExZGViZDJiODhiNWFjZjNlZmRhODJm ZjViNDk5MjRkMTg4MTBiLi44YTU3MzMyNDJmN2IwY2JkOGU3MTU1ODU2NWM3NGZkM2Y0MDhlY2Q2 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHAK KysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3BwCkBAIC0xNTAy LDYgKzE1MDIsOSBAQCB2b2lkIFdlYlByb2Nlc3NQb29sOjp1cGRhdGVBdXRvbWF0aW9uQ2FwYWJp bGl0aWVzKCkgY29uc3QKIAogdm9pZCBXZWJQcm9jZXNzUG9vbDo6c2V0QXV0b21hdGlvblNlc3Np b24oUmVmUHRyPFdlYkF1dG9tYXRpb25TZXNzaW9uPiYmIGF1dG9tYXRpb25TZXNzaW9uKQogewor ICAgIGlmIChtX2F1dG9tYXRpb25TZXNzaW9uKQorICAgICAgICBtX2F1dG9tYXRpb25TZXNzaW9u LT5zZXRQcm9jZXNzUG9vbChudWxscHRyKTsKKyAgICAKICAgICBtX2F1dG9tYXRpb25TZXNzaW9u ID0gV1RGTW92ZShhdXRvbWF0aW9uU2Vzc2lvbik7CiAKICNpZiBFTkFCTEUoUkVNT1RFX0lOU1BF Q1RPUikK