182978 2018-02-20 09:59:18 -0800 [GTK] Unsafe g_setenv use in MiniBrowser main 2018-02-21 11:55:46 -0800 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply cgarcia commit-queue mcatanzaro oldest_to_newest 1400803 0 mcatanzaro 2018-02-20 09:59:18 -0800 There is unsafe g_setenv use in MiniBrowser main. See https://bugs.webkit.org/show_bug.cgi?id=173655#c14 for background on this. 1400804 1 334279 mcatanzaro 2018-02-20 10:01:31 -0800 Created attachment 334279 Patch 1401199 2 334279 commit-queue 2018-02-21 11:55:44 -0800 Comment on attachment 334279 Patch Clearing flags on attachment: 334279 Committed r228890: <https://trac.webkit.org/changeset/228890> 1401200 3 commit-queue 2018-02-21 11:55:46 -0800 All reviewed patches have been landed. Closing bug. 334279 2018-02-20 10:01:31 -0800 2018-02-21 11:55:44 -0800 Patch bug-182978-20180220120130.patch text/plain 1784 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4ODIyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDYyMzFhY2E0YTg5ZWY0YzRmODAyN2I5NDViMjYwYmEx OTYwMGUwOC4uNjJlMWQ1MmNkZTU4ZDI1ZGJhZjkzMDVjYzJjMmIyZTRlYTg4OTE2MiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE4LTAyLTIwICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KKworICAgICAgICBbR1RLXSBVbnNhZmUgZ19zZXRlbnYgdXNlIGluIE1pbmlCcm93c2VyIG1h aW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4Mjk3 OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHNldGVu diAoYW5kIGdfc2V0ZW52KSB3aWxsIHJhbmRvbWx5IGNyYXNoIGlmIGNhbGxlZCB0b28gbGF0ZS4K KworICAgICAgICAqIE1pbmlCcm93c2VyL2d0ay9tYWluLmM6CisgICAgICAgIChtYWluKToKKwog MjAxOC0wMi0yMCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAg ICAgICAgW0dTdHJlYW1lcl1bTWluaUJyb3dzZXJdIEhvbm9yIEdTdHJlYW1lciBjb21tYW5kIGxp bmUgcGFyYW1ldGVycyBpbiBNaW5pQnJvd3NlcgpAQCAtMTIsNiArMjQsNyBAQAogCiAgICAgICAg ICogTWluaUJyb3dzZXIvZ3RrL21haW4uYzoKICAgICAgICAgKG1haW4pOiBBZGQgdGhlIGdyb3Vw IGNvbnRhaW5pbmcgdGhlIEdzdHJlYW1lciBvcHRpb25zIHRoYXQgdGhlIGNvbnNvbGUgZGlzcGxh eXMuCisKIDIwMTgtMDItMTkgIEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5j b20+CiAKICAgICAgICAgW1dUUl1bR1RLXSBjcmFzaCBsb2cgYmFja3RyYWNlIGRvZXNuJ3Qgc2hv dyBzeW1ib2wgbmFtZXMgZm9yIERhdGFiYXNlUHJvY2VzcyBhbmQgTmV0d29ya1Byb2Nlc3MKZGlm ZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9tYWluLmMgYi9Ub29scy9NaW5pQnJvd3Nl ci9ndGsvbWFpbi5jCmluZGV4IGY1ZGE2ZWRlZGNjZDQxZTM2MjYzNmZhODBlZjdhYWViNjRhZmZi MTEuLjE5ZTgwNmYwZjUwNjA1NjhhMmQyZWRhMzNmNzZiZmZjNDFjM2FhYjIgMTAwNjQ0Ci0tLSBh L1Rvb2xzL01pbmlCcm93c2VyL2d0ay9tYWluLmMKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3Rr L21haW4uYwpAQCAtNDc3LDExICs0NzcsMTIgQEAgc3RhdGljIHZvaWQgYXV0b21hdGlvblN0YXJ0 ZWRDYWxsYmFjayhXZWJLaXRXZWJDb250ZXh0ICp3ZWJDb250ZXh0LCBXZWJLaXRBdXRvbWEKIAog aW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKIHsKLSAgICBndGtfaW5pdCgmYXJnYywg JmFyZ3YpOwogI2lmIEVOQUJMRV9ERVZFTE9QRVJfTU9ERQogICAgIGdfc2V0ZW52KCJXRUJLSVRf SU5KRUNURURfQlVORExFX1BBVEgiLCBXRUJLSVRfSU5KRUNURURfQlVORExFX1BBVEgsIEZBTFNF KTsKICNlbmRpZgogCisgICAgZ3RrX2luaXQoJmFyZ2MsICZhcmd2KTsKKwogICAgIEdPcHRpb25D b250ZXh0ICpjb250ZXh0ID0gZ19vcHRpb25fY29udGV4dF9uZXcoTlVMTCk7CiAgICAgZ19vcHRp b25fY29udGV4dF9hZGRfbWFpbl9lbnRyaWVzKGNvbnRleHQsIGNvbW1hbmRMaW5lT3B0aW9ucywg MCk7CiAgICAgZ19vcHRpb25fY29udGV4dF9hZGRfZ3JvdXAoY29udGV4dCwgZ3RrX2dldF9vcHRp b25fZ3JvdXAoVFJVRSkpOwo=