182972 2018-02-20 07:16:08 -0800 WebCrypto keys break autoincrementing primary keys of IndexedDB 2019-10-25 03:21:16 -0700 1 1 1 Unclassified WebKit WebCore Misc. Safari Technology Preview Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=177350 https://bugs.webkit.org/show_bug.cgi?id=160306 https://bugs.webkit.org/show_bug.cgi?id=133122 https://gist.github.com/sechel/415c34b9bf80f3adeba52856d2377393 InRadar P2 Normal --- 133122 160306 1 stefan webkit-unassigned beidson jiewen_tan mcatanzaro webkit-bug-importer zan oldest_to_newest 1400756 0 stefan 2018-02-20 07:16:08 -0800 When storing an object that contains a WebCrypto CryptoKey to an IDB object store with auto incrementing primary key we get the following error: Error: Unable to inject record key into record value See also https://gist.github.com/sechel/415c34b9bf80f3adeba52856d2377393 1400859 1 jiewen_tan 2018-02-20 11:53:42 -0800 I tried the test case in Safari. It doesn't reproduce the bug. A very primitive suggestion here is to see if SerializedCryptoKeyWrap.h has caused some troubles for GTK+. 1400862 2 jiewen_tan 2018-02-20 12:00:42 -0800 I remember I told Zan not to wrap/unwrap Crypto Keys for GTK+, so it shouldn't cause any troubles for you. Wrapping crypto keys when storing them into IndexedDB is a legacy behavior to protect them in order to address early limitations of the spec. However, since we have existing clients that have already stored wrapped keys in IndexedDb, Apple ports couldn't get rid of it at this moment. 1400880 3 zan 2018-02-20 13:07:04 -0800 (In reply to Jiewen Tan from comment #2) > I remember I told Zan not to wrap/unwrap Crypto Keys for GTK+, so it > shouldn't cause any troubles for you. > > Wrapping crypto keys when storing them into IndexedDB is a legacy behavior > to protect them in order to address early limitations of the spec. However, > since we have existing clients that have already stored wrapped keys in > IndexedDb, Apple ports couldn't get rid of it at this moment. Keys are still not wrapped for the GTK+ port, as recommended. At least per this bug report, issue is observed with the Safari Tech Preview. OTOH the test case passes on GTK+/WPE as well, meaning that the issue appears to be present (as otherwise the test case would fail). 1400891 4 zan 2018-02-20 13:33:13 -0800 Failure occurs during deserialization because UniqueIDBDatabase provides an ExecState from which a usable ScriptExecutionContext cannot be retrieved. That's currently necessary in order to pipe the serialization and deserialization operations all the way up to the WebChromeClient in UIProcess. https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp#L477 https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/bindings/js/ScriptState.cpp#L65 1400900 5 stefan 2018-02-20 14:02:57 -0800 > OTOH the test case passes on GTK+/WPE as well, meaning that the issue appears to be present (as otherwise the test case would fail). Thats right, sorry for causing confusion. The test case is written canary style meaning it will fail if the issue has been resolved. BTW, this bug seems to be related as it also involves creating indices with WebCrypto keys present: https://bugs.webkit.org/show_bug.cgi?id=177350 1459723 6 stefan 2018-09-14 05:24:28 -0700 Anything new in the meantime? I will now perform another attempt to port out web application to Safari. Its pretty frustrating that I need so many Workarounds just due to WebCrypto. 1583746 7 stefan 2019-10-25 03:20:35 -0700 This has been fixed in Safari 13.x.x. 1583747 8 webkit-bug-importer 2019-10-25 03:21:16 -0700 <rdar://problem/56613473>