182968 2018-02-20 06:17:22 -0800 [GStreamer] Create a Wayland GL display instead of EGL 2018-05-02 10:52:17 -0700 1 1 1 Unclassified WebKit Platform Other Unspecified Unspecified RESOLVED INVALID InRadar P2 Normal --- 185207 182996 1 pnormand pnormand calvaris cgarcia magomez webkit-bug-importer oldest_to_newest 1400744 0 pnormand 2018-02-20 06:17:22 -0800 This looks like an old copy/paste error. 1400745 1 334264 pnormand 2018-02-20 06:20:21 -0800 Created attachment 334264 Patch 1401037 2 334264 calvaris 2018-02-21 00:44:52 -0800 Comment on attachment 334264 Patch Wait, I think we have a leak here. All these gst_gl_display_*_new_with_egl_display are [transfer full] and we are not adopting them. 1401042 3 334264 calvaris 2018-02-21 01:27:41 -0800 Comment on attachment 334264 Patch Before the patch landed on https://bugzilla.gnome.org/show_bug.cgi?id=743062 these references were still floating, thus we can't adopt or we would get crashes in debug mode. After that patch, we need to adopt or we would be leaking. I think we can land as it is but we need a new bug to fix this. 1401044 4 pnormand 2018-02-21 01:35:00 -0800 Committed r228866: <https://trac.webkit.org/changeset/228866> 1401045 5 webkit-bug-importer 2018-02-21 01:35:24 -0800 <rdar://problem/37738006> 1402038 6 cgarcia 2018-02-26 06:21:55 -0800 This is wrong, the display we want to use for rendering is the EGL display created and initialized by the PlatformDisplay. This patch causes runtime errors like: 0:00:46.130136714 13362 0x5609ff9524a0 ERROR webkitmediaplayer MediaPlayerPrivateGStreamer.cpp:956:handleMessage: Error 3: Failed to create a OpenGL context: EGL_BAD_CONTEXT (url=webkit+https://video.twimg.com/ext_tw_video/968118107192602624/pu/vid/640x360/dFLZDeagge7DOJd6.mp4) And then the web process hangs. 1402039 7 cgarcia 2018-02-26 06:23:51 -0800 Reopening, not rolling out yet, just in case you have a quick fix. Otherwise, please roll it out. 1402041 8 pnormand 2018-02-26 06:35:13 -0800 Rolled out in r229022 334264 2018-02-20 06:20:21 -0800 2018-02-21 01:27:41 -0800 Patch bug-182968-20180220142020.patch text/plain 3235 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4ODE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjA0OGUwZWY2ODZjZDg2 YWUzYmJiZmFhZmFjZTE0MWVlZWRiNDUzMC4uMjUzOTBkZjg4OTkwZDQ3OWZkNjJkZjA0MzdkZGIx ZDcyMzE5OGNhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTAyLTIwICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBDcmVhdGUgYSBXYXlsYW5kIEdMIGRpc3BsYXkgaW5zdGVhZCBvZiBFR0wKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4Mjk2OAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv Z3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwOgorICAgICAgICAo V2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZTo6ZW5zdXJlR3N0R0xDb250 ZXh0KToKKyAgICAgICAgQWRkIGxvZ2dpbmcgYW5kIGluc3RhbnRpYXRlIGEgR3N0RGlzcGxheVdh eWxhbmQgZGlzcGxheSBpbnN0ZWFkIG9mCisgICAgICAgIGFuIEVHTCBkaXNwbGF5IHdoZW4gcnVu bmluZyB1bmRlciBhIFdheWxhbmQgY29tcG9zaXRvci4KKwogMjAxOC0wMi0yMCAgUGhpbGlwcGUg Tm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dTdHJlYW1lcl1bTWlu aUJyb3dzZXJdIEhvbm9yIEdTdHJlYW1lciBjb21tYW5kIGxpbmUgcGFyYW1ldGVycyBpbiBNaW5p QnJvd3NlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0 cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l ckJhc2UuY3BwCmluZGV4IDA0YmIwMGQxNTQxZWU3YzhhZjNiMGRhYzczMDVjNGFjNzgzYzU1MGUu LmNhMWZhOTQ1NGQxZDRkMTIwMDhiMDNmYTc4NTg5NDhmNjIzMjJiMWEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZh dGVHU3RyZWFtZXJCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHAKQEAgLTkzLDYg KzkzLDcgQEAKIAogI2lmIFBMQVRGT1JNKFdBWUxBTkQpCiAjaW5jbHVkZSAiUGxhdGZvcm1EaXNw bGF5V2F5bGFuZC5oIgorI2luY2x1ZGUgPGdzdC9nbC93YXlsYW5kL2dzdGdsZGlzcGxheV93YXls YW5kLmg+CiAjZWxpZiBQTEFURk9STShXUEUpCiAjaW5jbHVkZSAiUGxhdGZvcm1EaXNwbGF5V1BF LmgiCiAjZW5kaWYKQEAgLTQzNiwyNCArNDM3LDMyIEBAIGJvb2wgTWVkaWFQbGF5ZXJQcml2YXRl R1N0cmVhbWVyQmFzZTo6ZW5zdXJlR3N0R0xDb250ZXh0KCkKICAgICAgICAgcmV0dXJuIHRydWU7 CiAKICAgICBhdXRvJiBzaGFyZWREaXNwbGF5ID0gUGxhdGZvcm1EaXNwbGF5OjpzaGFyZWREaXNw bGF5Rm9yQ29tcG9zaXRpbmcoKTsKKwogICAgIGlmICghbV9nbERpc3BsYXkpIHsKICNpZiBQTEFU Rk9STShYMTEpCiAjaWYgVVNFKEdMWCkKLSAgICAgICAgaWYgKGlzPFBsYXRmb3JtRGlzcGxheVgx MT4oc2hhcmVkRGlzcGxheSkpCisgICAgICAgIGlmIChpczxQbGF0Zm9ybURpc3BsYXlYMTE+KHNo YXJlZERpc3BsYXkpKSB7CisgICAgICAgICAgICBHU1RfREVCVUcoIkNyZWF0aW5nIFgxMSBzaGFy ZWQgR0wgZGlzcGxheSIpOwogICAgICAgICAgICAgbV9nbERpc3BsYXkgPSBHU1RfR0xfRElTUExB WShnc3RfZ2xfZGlzcGxheV94MTFfbmV3X3dpdGhfZGlzcGxheShkb3duY2FzdDxQbGF0Zm9ybURp c3BsYXlYMTE+KHNoYXJlZERpc3BsYXkpLm5hdGl2ZSgpKSk7CisgICAgICAgIH0KICNlbGlmIFVT RShFR0wpCi0gICAgICAgIGlmIChpczxQbGF0Zm9ybURpc3BsYXlYMTE+KHNoYXJlZERpc3BsYXkp KQorICAgICAgICBpZiAoaXM8UGxhdGZvcm1EaXNwbGF5WDExPihzaGFyZWREaXNwbGF5KSkgewor ICAgICAgICAgICAgR1NUX0RFQlVHKCJDcmVhdGluZyBYMTEgc2hhcmVkIEVHTCBkaXNwbGF5Iik7 CiAgICAgICAgICAgICBtX2dsRGlzcGxheSA9IEdTVF9HTF9ESVNQTEFZKGdzdF9nbF9kaXNwbGF5 X2VnbF9uZXdfd2l0aF9lZ2xfZGlzcGxheShkb3duY2FzdDxQbGF0Zm9ybURpc3BsYXlYMTE+KHNo YXJlZERpc3BsYXkpLmVnbERpc3BsYXkoKSkpOworICAgICAgICB9CiAjZW5kaWYKICNlbmRpZgog CiAjaWYgUExBVEZPUk0oV0FZTEFORCkKLSAgICAgICAgaWYgKGlzPFBsYXRmb3JtRGlzcGxheVdh eWxhbmQ+KHNoYXJlZERpc3BsYXkpKQotICAgICAgICAgICAgbV9nbERpc3BsYXkgPSBHU1RfR0xf RElTUExBWShnc3RfZ2xfZGlzcGxheV9lZ2xfbmV3X3dpdGhfZWdsX2Rpc3BsYXkoZG93bmNhc3Q8 UGxhdGZvcm1EaXNwbGF5V2F5bGFuZD4oc2hhcmVkRGlzcGxheSkuZWdsRGlzcGxheSgpKSk7Cisg ICAgICAgIGlmIChpczxQbGF0Zm9ybURpc3BsYXlXYXlsYW5kPihzaGFyZWREaXNwbGF5KSkgewor ICAgICAgICAgICAgR1NUX0RFQlVHKCJDcmVhdGluZyBXYXlsYW5kIHNoYXJlZCBkaXNwbGF5Iik7 CisgICAgICAgICAgICBtX2dsRGlzcGxheSA9IEdTVF9HTF9ESVNQTEFZKGdzdF9nbF9kaXNwbGF5 X3dheWxhbmRfbmV3X3dpdGhfZGlzcGxheShkb3duY2FzdDxQbGF0Zm9ybURpc3BsYXlXYXlsYW5k PihzaGFyZWREaXNwbGF5KS5uYXRpdmUoKSkpOworICAgICAgICB9CiAjZW5kaWYKIAogI2lmIFBM QVRGT1JNKFdQRSkKICAgICAgICAgQVNTRVJUKGlzPFBsYXRmb3JtRGlzcGxheVdQRT4oc2hhcmVk RGlzcGxheSkpOworICAgICAgICBHU1RfREVCVUcoIkNyZWF0aW5nIFdQRSBzaGFyZWQgRUdMIGRp c3BsYXkiKTsKICAgICAgICAgbV9nbERpc3BsYXkgPSBHU1RfR0xfRElTUExBWShnc3RfZ2xfZGlz cGxheV9lZ2xfbmV3X3dpdGhfZWdsX2Rpc3BsYXkoZG93bmNhc3Q8UGxhdGZvcm1EaXNwbGF5V1BF PihzaGFyZWREaXNwbGF5KS5lZ2xEaXNwbGF5KCkpKTsKICNlbmRpZgogCg==