182956 2018-02-19 23:29:42 -0800 [GTK] jhbuild: Remove gtk-doc 2018-02-20 19:27:15 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 fujii fujii agomez bugs-noreply clopez commit-queue ews-watchlist ltilve mcatanzaro oldest_to_newest 1400681 0 fujii 2018-02-19 23:29:42 -0800 [GTK] jhbuild: Remove gtk-doc According to Bug 163102, WebKitGTK+ needs gtk-doc 1.25 or newer. gtk-doc is a development dependency. and major LTS Linux distro has gtk-doc 1.25. Debian 9: 1.25 https://packages.debian.org/stretch/gtk-doc-tools Ubuntu 16.04: 1.25 https://packages.ubuntu.com/xenial/gtk-doc-tools CentOS 7: 1.25 http://mirror.centos.org/centos/7/os/x86_64/Packages/ Tools/gtk/install-dependencies already installs gtk-doc. 1400690 1 fujii 2018-02-20 00:01:30 -0800 If following warnings are annoying, you can modify your system gtk-doc. > Negative repeat count does nothing at /usr/bin/gtkdoc-mkdb line 3812, <INPUT> line 424. > Negative repeat count does nothing at /usr/bin/gtkdoc-mkdb line 3812, <INPUT> line 424. > Negative repeat count does nothing at /usr/bin/gtkdoc-mkdb line 3812, <INPUT> line 424. > Negative repeat count does nothing at /usr/bin/gtkdoc-mkdb line 3812, <INPUT> line 424. > Negative repeat count does nothing at /usr/bin/gtkdoc-mkdb line 3812, <INPUT> line 917. > Negative repeat count does nothing at /usr/bin/gtkdoc-mkdb line 3812, <INPUT> line 987. > Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.30), passed through in regex; marked by <-- HERE in m/(.*?){ <-- HERE / at /usr/bin/gtkdoc-scan line 735. I created a patch https://gist.github.com/fujii/9aa8ebc99ab4662adaef567424ea3453 based on https://github.com/GNOME/gtk-doc/commit/2f968fede39732677efaac205fb8f1e9ae46d90e 1400692 2 334249 fujii 2018-02-20 00:14:22 -0800 Created attachment 334249 Patch 1400786 3 334249 mcatanzaro 2018-02-20 09:23:46 -0800 Comment on attachment 334249 Patch OK, this seems like a good idea. If it causes trouble, we can always put it back. 1400794 4 334249 commit-queue 2018-02-20 09:48:15 -0800 Comment on attachment 334249 Patch Rejecting attachment 334249 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 334249, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: rdparty/autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain result = func(*args) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 60] Operation timed out> Full output: http://webkit-queues.webkit.org/results/6592288 1400995 5 334249 mcatanzaro 2018-02-20 19:03:00 -0800 Comment on attachment 334249 Patch I might need to land it manually. Let's see if commit-queue is fixed yet.... 1401000 6 334249 commit-queue 2018-02-20 19:27:13 -0800 Comment on attachment 334249 Patch Clearing flags on attachment: 334249 Committed r228855: <https://trac.webkit.org/changeset/228855> 1401001 7 commit-queue 2018-02-20 19:27:15 -0800 All reviewed patches have been landed. Closing bug. 334249 2018-02-20 00:14:22 -0800 2018-02-20 19:27:13 -0800 Patch bug-182956-20180220001132.patch text/plain 2022 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4NjE4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2M4ZTg1MzMzYzdmYWNlNTBhYjgzZDkxOWFkZjYzZGJh ODNiZTVlMS4uN2Y4MzE0YjI5MTJhYTY4YzZhYzY3OGQ2OGU5OTE5YzQzM2Q5NWE0NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE4LTAyLTIwICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIFtHVEtdIGpoYnVpbGQ6IFJlbW92ZSBndGstZG9jCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODI5NTYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBqaGJ1aWxkIGRvZXNuJ3QgbmVlZCB0 byBidWlsZCBndGstZG9jIGJlY2F1c2UgbWFqb3IgTFRTIExpbnV4CisgICAgICAgIGRpc3RyaWJ1 dGlvbnMgaGF2ZSBndGstZG9jIHYxLjI1LCBhbmQKKyAgICAgICAgVG9vbHMvZ3RrL2luc3RhbGwt ZGVwZW5kZW5jaWVzIGluc3RhbGxzIGd0ay1kb2MuCisKKyAgICAgICAgKiBndGsvamhidWlsZC5t b2R1bGVzOiBSZW1vdmVkIGd0ay1kb2MuCisKIDIwMTgtMDItMTYgIFJ5b3N1a2UgTml3YSAgPHJu aXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkIGFuIGVudGl0bGVtZW50IGNoZWNrIGZvciBz ZXJ2aWNlIHdvcmtlciBvbiBpT1MKZGlmZiAtLWdpdCBhL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVs ZXMgYi9Ub29scy9ndGsvamhidWlsZC5tb2R1bGVzCmluZGV4IDRjM2Y3OWYzMmEyMjg4NWJmMGZk MWY2NmMxYTZmNjgyMmUxNWRlNzEuLjljMzI5NDI3MjBmNjgzOTMzODBjZWU2ZDA2OWEwMjNiZWZj OGE2ODkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMKKysrIGIvVG9vbHMv Z3RrL2poYnVpbGQubW9kdWxlcwpAQCAtMjEsNyArMjEsNiBAQAogICAgICAgPGRlcCBwYWNrYWdl PSJnbGliIi8+CiAgICAgICA8ZGVwIHBhY2thZ2U9ImdsaWItbmV0d29ya2luZyIvPgogICAgICAg PGRlcCBwYWNrYWdlPSJhZHdhaXRhLWljb24tdGhlbWUiLz4KLSAgICAgIDxkZXAgcGFja2FnZT0i Z3RrLWRvYyIvPgogICAgICAgPGRlcCBwYWNrYWdlPSJpY3UiLz4KICAgICAgIDxkZXAgcGFja2Fn ZT0ibGlic291cCIvPgogICAgICAgPGRlcCBwYWNrYWdlPSJhdGsiLz4KQEAgLTM2NywxOCArMzY2 LDYgQEAKICAgICAgICAgICAgIGhhc2g9InNoYTI1NjpjZGUxZDU1ZThkZDcwYzNjYmIzZDFlYzcy ZjYwZTYwMDAwMDQxNTc5Y2FhMWQ2YTI2MmJkOWMzNWU5MzcyM2E1Ii8+CiAgIDwvYXV0b3Rvb2xz PgogCi0gIDxhdXRvdG9vbHMgaWQ9Imd0ay1kb2MiIGF1dG9nZW4tc2g9ImNvbmZpZ3VyZSI+Ci0g ICAgPGlmIGNvbmRpdGlvbi1zZXQ9Im1hY29zIj4KLSAgICAgIDxhdXRvZ2VuYXJncyB2YWx1ZT0i LS13aXRoLXhtbC1jYXRhbG9nPS91c3IvbG9jYWwvZXRjL3htbC9jYXRhbG9nIi8+Ci0gICAgPC9p Zj4KLSAgICA8ZGVwZW5kZW5jaWVzPgotICAgICAgPGRlcCBwYWNrYWdlPSJnbGliIi8+Ci0gICAg PC9kZXBlbmRlbmNpZXM+Ci0gICAgPGJyYW5jaCBtb2R1bGU9Ii9wdWIvR05PTUUvc291cmNlcy9n dGstZG9jLyR7dmVyc2lvbn0vZ3RrLWRvYy0ke3ZlcnNpb259LnRhci54eiIgdmVyc2lvbj0iMS4y NSIKLSAgICAgICAgICAgIHJlcG89ImZ0cC5nbm9tZS5vcmciCi0gICAgICAgICAgICBoYXNoPSJz aGEyNTY6MWVhNDZlZDQwMGU2NTAxZjk3NWFjYWFmZWEzMTQ3OWNlYThmMzJmOTExZGNhNGRmZjAz NmY1OWU2NDY0ZmQ0MiIvPgotICA8L2F1dG90b29scz4KLQogICA8YXV0b3Rvb2xzIGlkPSJsaWJk cm0iIGF1dG9nZW4tc2g9ImNvbmZpZ3VyZSI+CiAgICAgPHBrZy1jb25maWc+bGliZHJtLnBjPC9w a2ctY29uZmlnPgogICAgIDxicmFuY2ggbW9kdWxlPSIvbGliZHJtL2xpYmRybS0ke3ZlcnNpb259 LnRhci5iejIiIHZlcnNpb249IjIuNC44OSIK