182938 2018-02-19 13:23:37 -0800 Copying a list from Microsoft Word to TinyMCE fails when mso-list is the first property 2018-04-03 00:48:52 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 182564 1 rniwa rniwa commit-queue thespyder webkit-bug-importer wenson_hsieh oldest_to_newest 1400472 0 rniwa 2018-02-19 13:23:37 -0800 See https://bugs.webkit.org/show_bug.cgi?id=182564#c51 When mso-list is the first CSS property, our workaround doesn't kick in. 1400476 1 webkit-bug-importer 2018-02-19 13:29:41 -0800 <rdar://problem/37683007> 1400529 2 thespyder 2018-02-19 15:43:12 -0800 As we finished capturing the Safari clipboard data for our test documents, another failing case popped up - Word can also put newlines in the style attribute :) <p class=MsoNormal style='margin-left:0cm;text-indent:0cm;mso-pagination:none; mso-list:l0 level1 lfo1;mso-layout-grid-align:none;text-autospace:none'> 1410561 3 336844 rniwa 2018-03-30 00:00:29 -0700 Created attachment 336844 Fixes the bug 1410699 4 336844 wenson_hsieh 2018-03-30 12:28:18 -0700 Comment on attachment 336844 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=336844&action=review r=me > Source/WebCore/editing/markup.cpp:432 > + return style.startsWith("mso-list:") || style.contains(";mso-list:") || style.contains("\nmso-list:"); I wonder if we should just regex this at some point :P 1410760 5 rniwa 2018-03-30 16:31:47 -0700 (In reply to Wenson Hsieh from comment #4) > Comment on attachment 336844 [details] > Fixes the bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=336844&action=review > > r=me > > > Source/WebCore/editing/markup.cpp:432 > > + return style.startsWith("mso-list:") || style.contains(";mso-list:") || style.contains("\nmso-list:"); > > I wonder if we should just regex this at some point :P Haha, I did think about that. 1410761 6 336844 rniwa 2018-03-30 16:32:04 -0700 Comment on attachment 336844 Fixes the bug Thanks for the review. We'd consider using a regular expression if we find more bugs. 1410769 7 336844 commit-queue 2018-03-30 16:57:55 -0700 Comment on attachment 336844 Fixes the bug Clearing flags on attachment: 336844 Committed r230120: <https://trac.webkit.org/changeset/230120> 1410770 8 commit-queue 2018-03-30 16:57:57 -0700 All reviewed patches have been landed. Closing bug. 1411371 9 thespyder 2018-04-03 00:48:52 -0700 I have just downloaded r230195 and confirmed that this seems to fix pasting for the relevant documents in our test suite. Thanks :D 336844 2018-03-30 00:00:29 -0700 2018-03-30 16:57:55 -0700 Fixes the bug bug-182938-20180330000028.patch text/plain 6767 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzMDA5OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE4LTAzLTI5ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIENvcHlpbmcgYSBsaXN0IGZyb20g TWljcm9zb2Z0IFdvcmQgdG8gVGlueU1DRSBmYWlscyB3aGVuIG1zby1saXN0IGlzIHRoZSBmaXJz dCBwcm9wZXJ0eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTgyOTM4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNzY4MzAwNz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWRlIHRoZSBsb2dpYyB0byBk ZXRlY3QgTWljcm9zb2Z0IFdvcmQncyBtc28tbGlzdCBDU1MgcHJvcGVydHkgbW9yZSBnZW5lcmlj IGJ5IGRldGVjdGluZworICAgICAgICBpbmxpbmUgc3R5bGVzIHdoaWNoIHN0YXJ0IHdpdGggIm1z by1saXN0OiIgYW5kIG9uZSB3aGljaCBsaW5lLWJyZWFrIHJpZ2h0IGJlZm9yZSBpdDogIlxubXNv LWxpc3Q6IgorCisgICAgICAgIFRlc3RzOiBQYXN0ZUhUTUwuUHJlc2VydmVzTVNPTGlzdAorCisg ICAgICAgICogZWRpdGluZy9tYXJrdXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U3R5bGVkTWFy a3VwQWNjdW11bGF0b3I6OnNob3VsZFByZXNlcnZlTVNPTGlzdFN0eWxlRm9yRWxlbWVudCk6CisK IDIwMTgtMDMtMjkgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAg Q29weWluZyBhIGxpc3QgZnJvbSBNaWNyb3NvZnQgV29yZCB0byBUaW55TUNFIGZhaWxzIHdoZW4g bXNvLWxpc3QgaXMgb24gdGFncyBvdGhlciB0aGFuIFAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Vk aXRpbmcvbWFya3VwLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL21h cmt1cC5jcHAJKHJldmlzaW9uIDIzMDA5OSkKKysrIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvbWFy a3VwLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDI1LDcgKzQyNSwxMyBAQCB2b2lkIFN0eWxlZE1h cmt1cEFjY3VtdWxhdG9yOjphcHBlbmRDdXN0CiAKIGJvb2wgU3R5bGVkTWFya3VwQWNjdW11bGF0 b3I6OnNob3VsZFByZXNlcnZlTVNPTGlzdFN0eWxlRm9yRWxlbWVudChjb25zdCBFbGVtZW50JiBl bGVtZW50KQogewotICAgIHJldHVybiBtX2luTVNPTGlzdCB8fCAobV9zaG91bGRQcmVzZXJ2ZU1T T0xpc3QgJiYgZWxlbWVudC5nZXRBdHRyaWJ1dGUoc3R5bGVBdHRyKS5jb250YWlucygiO21zby1s aXN0OiIpKTsKKyAgICBpZiAobV9pbk1TT0xpc3QpCisgICAgICAgIHJldHVybiB0cnVlOworICAg IGlmIChtX3Nob3VsZFByZXNlcnZlTVNPTGlzdCkgeworICAgICAgICBhdXRvIHN0eWxlID0gZWxl bWVudC5nZXRBdHRyaWJ1dGUoc3R5bGVBdHRyKTsKKyAgICAgICAgcmV0dXJuIHN0eWxlLnN0YXJ0 c1dpdGgoIm1zby1saXN0OiIpIHx8IHN0eWxlLmNvbnRhaW5zKCI7bXNvLWxpc3Q6IikgfHwgc3R5 bGUuY29udGFpbnMoIlxubXNvLWxpc3Q6Iik7CisgICAgfQorICAgIHJldHVybiBmYWxzZTsKIH0K IAogdm9pZCBTdHlsZWRNYXJrdXBBY2N1bXVsYXRvcjo6YXBwZW5kRWxlbWVudChTdHJpbmdCdWls ZGVyJiBvdXQsIGNvbnN0IEVsZW1lbnQmIGVsZW1lbnQsIGJvb2wgYWRkRGlzcGxheUlubGluZSwg UmFuZ2VGdWxseVNlbGVjdHNOb2RlIHJhbmdlRnVsbHlTZWxlY3RzTm9kZSkKSW5kZXg6IFRvb2xz L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzMDEw MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisy MDE4LTAzLTI5ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIENv cHlpbmcgYSBsaXN0IGZyb20gTWljcm9zb2Z0IFdvcmQgdG8gVGlueU1DRSBmYWlscyB3aGVuIG1z by1saXN0IGlzIHRoZSBmaXJzdCBwcm9wZXJ0eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyOTM4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNzY4 MzAwNz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGRlZCBtb3JlIGFzc2VydGlvbnMgdG8gUGFzdGVIVE1MLlByZXNlcnZlc01TT0xpc3QgZm9yIHBy ZXNlcnZpbmcgYW4gaW5saW5lIHN0eWxlIHdoaWNoIHN0YXJ0cyB3aXRoIG1zby1saXN0CisgICAg ICAgIG9yIHRoZSBvbmUgd2hpY2ggbGluZS1icmVha3MgcmlnaHQgYmVmb3JlIGl0LgorCisgICAg ICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9QYXN0ZUhUTUwubW06CisgICAg ICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9tc28tbGlzdC5odG1sOgorCiAy MDE4LTAzLTI5ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIENv cHlpbmcgYSBsaXN0IGZyb20gTWljcm9zb2Z0IFdvcmQgdG8gVGlueU1DRSBmYWlscyB3aGVuIG1z by1saXN0IGlzIG9uIHRhZ3Mgb3RoZXIgdGhhbiBQCkluZGV4OiBUb29scy9UZXN0V2ViS2l0QVBJ L1Rlc3RzL1dlYktpdENvY29hL1Bhc3RlSFRNTC5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9UZXN0 V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1Bhc3RlSFRNTC5tbQkocmV2aXNpb24gMjMwMDk5 KQorKysgVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9QYXN0ZUhUTUwubW0J KHdvcmtpbmcgY29weSkKQEAgLTE3OCw2ICsxNzgsOSBAQCBURVNUKFBhc3RlSFRNTCwgUHJlc2Vy dmVzTVNPTGlzdCkKICAgICBFWFBFQ1RfVFJVRShbd2ViVmlldyBzdHJpbmdCeUV2YWx1YXRpbmdK YXZhU2NyaXB0OkAicGFzdGVkSFRNTC5pbmNsdWRlcygnW2lmICFzdXBwb3J0TGlzdHNdJykiXS5i b29sVmFsdWUpOwogICAgIEVYUEVDVF9UUlVFKFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGluZ0ph dmFTY3JpcHQ6QCJwYXN0ZWRIVE1MLmluY2x1ZGVzKCdbZW5kaWZdJykiXS5ib29sVmFsdWUpOwog ICAgIEVYUEVDVF9UUlVFKFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGluZ0phdmFTY3JpcHQ6QCJw YXN0ZWRIVE1MLmluY2x1ZGVzKCcgc3R5bGU9XCJ0ZXh0LWluZGVudDotLjI1aW47bXNvLWxpc3Q6 bDAgbGV2ZWwxIGxmbzFcIj4nKSJdLmJvb2xWYWx1ZSk7CisgICAgRVhQRUNUX1RSVUUoW3dlYlZp ZXcgc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpAInBhc3RlZEhUTUwuaW5jbHVkZXMoJzxw IGNsYXNzPVwiTXNvTm9ybWFsXCIgc3R5bGU9XCJtYXJnaW4tbGVmdDowY207dGV4dC1pbmRlbnQ6 MGNtO21zby1wYWdpbmF0aW9uOm5vbmU7XFxuIgorICAgICAgICAibXNvLWxpc3Q6bDEgbGV2ZWwx IGxmbzE7bXNvLWxheW91dC1ncmlkLWFsaWduOm5vbmU7dGV4dC1hdXRvc3BhY2U6bm9uZVwiPicp Il0uYm9vbFZhbHVlKTsKKyAgICBFWFBFQ1RfVFJVRShbd2ViVmlldyBzdHJpbmdCeUV2YWx1YXRp bmdKYXZhU2NyaXB0OkAicGFzdGVkSFRNTC5pbmNsdWRlcygnPHAgY2xhc3M9XCJNc29Ob3JtYWxc IiBzdHlsZT1cIm1zby1saXN0OmwxIGxldmVsMSBsZm8xO21hcmdpbi1sZWZ0OjBjbVwiPicpIl0u Ym9vbFZhbHVlKTsKICAgICBFWFBFQ1RfRkFMU0UoW3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0aW5n SmF2YVNjcmlwdDpAInBhc3RlZEhUTUwuaW5jbHVkZXMoJy9Vc2Vycy93ZWJraXR0ZW4vTGlicmFy eS8nKSJdLmJvb2xWYWx1ZSk7CiAKICAgICBbd2ViVmlldyBzdHJpbmdCeUV2YWx1YXRpbmdKYXZh U2NyaXB0OkAiZ2V0U2VsZWN0aW9uKCkuc2V0UG9zaXRpb24oZG9jdW1lbnQucXVlcnlTZWxlY3Rv cignLk1zb0xpc3RQYXJhZ3JhcGhDeFNwTGFzdCcpKTsiXTsKQEAgLTE5Myw2ICsxOTYsOSBAQCBU RVNUKFBhc3RlSFRNTCwgUHJlc2VydmVzTVNPTGlzdCkKICAgICBFWFBFQ1RfVFJVRShbd2ViVmll dyBzdHJpbmdCeUV2YWx1YXRpbmdKYXZhU2NyaXB0OkAiaHRtbEluRGF0YVRyYW5zZmVyLmluY2x1 ZGVzKCdbaWYgIXN1cHBvcnRMaXN0c10nKSJdLmJvb2xWYWx1ZSk7CiAgICAgRVhQRUNUX1RSVUUo W3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpAImh0bWxJbkRhdGFUcmFuc2Zl ci5pbmNsdWRlcygnW2VuZGlmXScpIl0uYm9vbFZhbHVlKTsKICAgICBFWFBFQ1RfVFJVRShbd2Vi VmlldyBzdHJpbmdCeUV2YWx1YXRpbmdKYXZhU2NyaXB0OkAiaHRtbEluRGF0YVRyYW5zZmVyLmlu Y2x1ZGVzKCcgc3R5bGU9XCJ0ZXh0LWluZGVudDotLjI1aW47bXNvLWxpc3Q6bDAgbGV2ZWwxIGxm bzFcIj4nKSJdLmJvb2xWYWx1ZSk7CisgICAgRVhQRUNUX1RSVUUoW3dlYlZpZXcgc3RyaW5nQnlF dmFsdWF0aW5nSmF2YVNjcmlwdDpAImh0bWxJbkRhdGFUcmFuc2Zlci5pbmNsdWRlcygnPHAgY2xh c3M9XCJNc29Ob3JtYWxcIiBzdHlsZT1cIm1hcmdpbi1sZWZ0OjBjbTt0ZXh0LWluZGVudDowY207 bXNvLXBhZ2luYXRpb246bm9uZTtcXG4iCisgICAgICAgICJtc28tbGlzdDpsMSBsZXZlbDEgbGZv MTttc28tbGF5b3V0LWdyaWQtYWxpZ246bm9uZTt0ZXh0LWF1dG9zcGFjZTpub25lXCI+JykiXS5i b29sVmFsdWUpOworICAgIEVYUEVDVF9UUlVFKFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGluZ0ph dmFTY3JpcHQ6QCJodG1sSW5EYXRhVHJhbnNmZXIuaW5jbHVkZXMoJzxwIGNsYXNzPVwiTXNvTm9y bWFsXCIgc3R5bGU9XCJtc28tbGlzdDpsMSBsZXZlbDEgbGZvMTttYXJnaW4tbGVmdDowY21cIj4n KSJdLmJvb2xWYWx1ZSk7CiAgICAgRVhQRUNUX0ZBTFNFKFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVh dGluZ0phdmFTY3JpcHQ6QCJodG1sSW5EYXRhVHJhbnNmZXIuaW5jbHVkZXMoJy9Vc2Vycy93ZWJr aXR0ZW4vTGlicmFyeS8nKSJdLmJvb2xWYWx1ZSk7CiAKICAgICBbd2ViVmlldyBzdHJpbmdCeUV2 YWx1YXRpbmdKYXZhU2NyaXB0OkAiZWRpdG9yLmlubmVySFRNTCA9ICcnOyBlZGl0b3IuZm9jdXMo KTsiXTsKSW5kZXg6IFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvbXNvLWxp c3QuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENv Y29hL21zby1saXN0Lmh0bWwJKHJldmlzaW9uIDIzMDA5OSkKKysrIFRvb2xzL1Rlc3RXZWJLaXRB UEkvVGVzdHMvV2ViS2l0Q29jb2EvbXNvLWxpc3QuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtOTMy LDYgKzkzMiwxNyBAQCBzdHlsZT0nbXNvLWJvb2ttYXJrOk9MRV9MSU5LMic+PCFbaWYgIXN1CiBz dHlsZT0nbXNvLWxpc3Q6SWdub3JlJz59PHNwYW4gc3R5bGU9J2ZvbnQ6Ny4wcHQgIlRpbWVzIE5l dyBSb21hbiInPiZuYnNwOyZuYnNwOwogPC9zcGFuPjwvc3Bhbj48L3NwYW4+PCFbZW5kaWZdPjxz cGFuIHN0eWxlPSdjb2xvcjpyZWQnPldlYktpdDwvc3Bhbj48bzpwPjwvbzpwPjwvc3Bhbj48L3Nw YW4+PC9wPgogCis8cCBjbGFzcz1Nc29Ob3JtYWwgc3R5bGU9J21hcmdpbi1sZWZ0OjBjbTt0ZXh0 LWluZGVudDowY207bXNvLXBhZ2luYXRpb246bm9uZTsKK21zby1saXN0OmwxIGxldmVsMSBsZm8x O21zby1sYXlvdXQtZ3JpZC1hbGlnbjpub25lO3RleHQtYXV0b3NwYWNlOm5vbmUnPjwhW2lmICFz dXBwb3J0TGlzdHNdPjxzcGFuIHN0eWxlPSdmb250LWZhbWlseToKKyJDb3VyaWVyIE5ldyIsc2Vy aWY7bXNvLWZhcmVhc3QtZm9udC1mYW1pbHk6IkNvdXJpZXIgTmV3Iic+PHNwYW4KK3N0eWxlPSdt c28tbGlzdDpJZ25vcmUnPi08c3BhbiBzdHlsZT0nZm9udDo3LjBwdCAiVGltZXMgTmV3IFJvbWFu Iic+Jm5ic3A7Jm5ic3A7Cis8L3NwYW4+PC9zcGFuPjwvc3Bhbj48IVtlbmRpZl0+PHNwYW4gc3R5 bGU9J2NvbG9yOnJlZCc+cm9ja3M8L3NwYW4+PG86cD48L286cD48L3NwYW4+PC9zcGFuPjwvcD4K KworPHAgY2xhc3M9TXNvTm9ybWFsIHN0eWxlPSdtc28tbGlzdDpsMSBsZXZlbDEgbGZvMTttYXJn aW4tbGVmdDowY20nPjwhW2lmICFzdXBwb3J0TGlzdHNdPjxzcGFuIHN0eWxlPSdmb250LWZhbWls eToKKyJDb3VyaWVyIE5ldyIsc2VyaWY7bXNvLWZhcmVhc3QtZm9udC1mYW1pbHk6IkNvdXJpZXIg TmV3Iic+PHNwYW4KK3N0eWxlPSdtc28tbGlzdDpJZ25vcmUnPi08c3BhbiBzdHlsZT0nZm9udDo3 LjBwdCAiVGltZXMgTmV3IFJvbWFuIic+Jm5ic3A7Jm5ic3A7Cis8L3NwYW4+PC9zcGFuPjwvc3Bh bj48IVtlbmRpZl0+PHNwYW4gc3R5bGU9J2NvbG9yOnJlZCc+Zm9vPC9zcGFuPjxvOnA+PC9vOnA+ PC9zcGFuPjwvc3Bhbj48L3A+CisKIDxwIGNsYXNzPU1zb05vcm1hbD48c3BhbiBzdHlsZT0nbXNv LWJvb2ttYXJrOk9MRV9MSU5LMSc+PHNwYW4gc3R5bGU9J21zby1ib29rbWFyazoKIE9MRV9MSU5L Mic+PG86cD4mbmJzcDs8L286cD48L3NwYW4+PC9zcGFuPjwvcD4KIAo=