<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>182933</bug_id>
          
          <creation_ts>2018-02-19 11:07:24 -0800</creation_ts>
          <short_desc>[GTK][CMake] Support building with Enchant 2.x</short_desc>
          <delta_ts>2018-02-20 10:47:22 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Adrian Perez">aperez</reporter>
          <assigned_to name="Adrian Perez">aperez</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>dbates</cc>
    
    <cc>jamesr</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>mrobinson</cc>
    
    <cc>senorblanco</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1400430</commentid>
    <comment_count>0</comment_count>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2018-02-19 11:07:24 -0800</bug_when>
    <thetext>Today I noticed that Arch Linux has stopped shipping Enchant 1.x a
while ago, and that for building WebKitGTK+ the following patch is
applied:

  https://git.archlinux.org/svntogit/packages.git/tree/trunk/enchant-2.diff?h=packages/webkit2gtk

The patch is very simple, and it merely changes “FindEnchant.cmake”
so it checks for “enchant-2” instead of “enchant” using pkg-config.
The usage that WebKitGTK+ makes of Enchant does not seem to rely on
any API changed between the Enchant 1.x series and the 2.x ones, so
it should be safe to check whether any of them is available.

On a chat with Michael Catanzaro he pointed out that Enchant 2.x
will still take time to be adopted by all GNU/Linux distributions,
and in the meanwhile we should try to keep the build working fine
with both 1.x and 2.x — and making WebKitGTK+ buildable out of the
box with the newer releases is the first step.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1400442</commentid>
    <comment_count>1</comment_count>
      <attachid>334171</attachid>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2018-02-19 11:40:22 -0800</bug_when>
    <thetext>Created attachment 334171
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1400443</commentid>
    <comment_count>2</comment_count>
      <attachid>334171</attachid>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2018-02-19 11:42:48 -0800</bug_when>
    <thetext>Comment on attachment 334171
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334171&amp;action=review

There&apos;s a small typo in the comment, I&apos;ll fix it before landing.

&gt; Source/cmake/FindEnchant.cmake:48
&gt; +    # cases in which e.g. both versions of the library are installed, but on

The “on” needs to be deleted in this phrase, it should read “but the
headers are usable/present only for one of them”.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1400445</commentid>
    <comment_count>3</comment_count>
      <attachid>334172</attachid>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2018-02-19 11:45:37 -0800</bug_when>
    <thetext>Created attachment 334172
Patch

Rebased patch with typo in comment fixed</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1400790</commentid>
    <comment_count>4</comment_count>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2018-02-20 09:32:18 -0800</bug_when>
    <thetext>On a chat with Michael Catanzaro we have agreed that it&apos;s probably
better to check for Enchant 2.x first, so I&apos;ll re-upload the patch
with that change done.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1400791</commentid>
    <comment_count>5</comment_count>
      <attachid>334172</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-02-20 09:32:34 -0800</bug_when>
    <thetext>Comment on attachment 334172
Patch

This looks good, just swap the order so enchant-2 is checked first, and please add a FIXME to remove the check for old enchant after a couple of years.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1400792</commentid>
    <comment_count>6</comment_count>
      <attachid>334275</attachid>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2018-02-20 09:34:06 -0800</bug_when>
    <thetext>Created attachment 334275
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1400800</commentid>
    <comment_count>7</comment_count>
      <attachid>334277</attachid>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2018-02-20 09:58:13 -0800</bug_when>
    <thetext>Created attachment 334277
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1400832</commentid>
    <comment_count>8</comment_count>
      <attachid>334277</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-02-20 10:46:14 -0800</bug_when>
    <thetext>Comment on attachment 334277
Patch for landing

Clearing flags on attachment: 334277

Committed r228826: &lt;https://trac.webkit.org/changeset/228826&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1400833</commentid>
    <comment_count>9</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-02-20 10:46:16 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1400834</commentid>
    <comment_count>10</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-02-20 10:47:22 -0800</bug_when>
    <thetext>&lt;rdar://problem/37712970&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>334171</attachid>
            <date>2018-02-19 11:40:22 -0800</date>
            <delta_ts>2018-02-19 11:45:33 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-182933-20180219214015.patch</filename>
            <type>text/plain</type>
            <size>2151</size>
            <attacher name="Adrian Perez">aperez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4NzAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu
ZEVuY2hhbnQuY21ha2UgYi9Tb3VyY2UvY21ha2UvRmluZEVuY2hhbnQuY21ha2UKaW5kZXggOGRk
MGI1YmEyZmIwMTRjZGZlYjQwNzYxMzBhYTA0YjBmNjRmNmEwNC4uZTBhNDJmNTY5YTQ2NzBkMzJm
Yzk1YWNiMjRlOWQ2MTBmMmUwYThmMiAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL0ZpbmRFbmNo
YW50LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kRW5jaGFudC5jbWFrZQpAQCAtMjgsMTkg
KzI4LDI5IEBACiAjIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgog
CiBmaW5kX3BhY2thZ2UoUGtnQ29uZmlnKQotcGtnX2NoZWNrX21vZHVsZXMoUENfRU5DSEFOVCBl
bmNoYW50KQotCi1maW5kX3BhdGgoRU5DSEFOVF9JTkNMVURFX0RJUlMKLSAgICBOQU1FUyBlbmNo
YW50LmgKLSAgICBQQVRIUyAke1BDX0VOQ0hBTlRfSU5DTFVERURJUn0KLSAgICAgICAgICAke1BD
X0VOQ0hBTlRfSU5DTFVERV9ESVJTfQotKQotCi1maW5kX2xpYnJhcnkoRU5DSEFOVF9MSUJSQVJJ
RVMKLSAgICBOQU1FUyBlbmNoYW50Ci0gICAgUEFUSFMgJHtQQ19FTkNIQU5UX0xJQkRJUn0KLSAg
ICAgICAgICAke1BDX0VOQ0hBTlRfTElCUkFSWV9ESVJTfQotKQorCitmb3JlYWNoIChFTkNIQU5U
X05BTUUgZW5jaGFudCBlbmNoYW50LTIpCisgICAgcGtnX2NoZWNrX21vZHVsZXMoUENfRU5DSEFO
VCAke0VOQ0hBTlRfTkFNRX0pCisKKyAgICBmaW5kX3BhdGgoRU5DSEFOVF9JTkNMVURFX0RJUlMK
KyAgICAgICAgTkFNRVMgZW5jaGFudC5oCisgICAgICAgIFBBVEhTICR7UENfRU5DSEFOVF9JTkNM
VURFRElSfQorICAgICAgICAgICAgICAke1BDX0VOQ0hBTlRfSU5DTFVERV9ESVJTfQorICAgICkK
KworICAgIGZpbmRfbGlicmFyeShFTkNIQU5UX0xJQlJBUklFUworICAgICAgICBOQU1FUyAke0VO
Q0hBTlRfTkFNRX0KKyAgICAgICAgUEFUSFMgJHtQQ19FTkNIQU5UX0xJQkRJUn0KKyAgICAgICAg
ICAgICAgJHtQQ19FTkNIQU5UX0xJQlJBUllfRElSU30KKyAgICApCisKKyAgICAjIE9ubHkgc3Rv
cCBzZWFyY2hpbmcgaWYgdGhlIHRocmVlIGhhdmUgYmVlbiBmb3VuZC4gVGhpcyBjb3ZlcnMgZm9y
IGNvcm5lcgorICAgICMgY2FzZXMgaW4gd2hpY2ggZS5nLiBib3RoIHZlcnNpb25zIG9mIHRoZSBs
aWJyYXJ5IGFyZSBpbnN0YWxsZWQsIGJ1dCBvbgorICAgICMgdGhlIGhlYWRlcnMgYXJlIHVzYWJs
ZS9wcmVzZW50IGZvciBvbmUgb2YgdGhlbS4KKyAgICBpZiAoUENfRU5DSEFOVF9GT1VORCBBTkQg
RU5DSEFOVF9JTkNMVURFX0RJUlMgQU5EIEVOQ0hBTlRfTElCUkFSSUVTKQorICAgICAgICBicmVh
ayAoKQorICAgIGVuZGlmICgpCitlbmRmb3JlYWNoIChFTkNIQU5UX05BTUUpCiAKIG1hcmtfYXNf
YWR2YW5jZWQoCiAgICAgRU5DSEFOVF9JTkNMVURFX0RJUlMKZGlmZiAtLWdpdCBhL0NoYW5nZUxv
ZyBiL0NoYW5nZUxvZwppbmRleCA1NmY5YjZkMTQzNThhMTExZmQ5ZGQwYjE5ZDQ2NzY2YjJmNjQ3
Njc3Li42MGJkOWMyOGQ3YTA0MDJmMmM0YTFhNzlmOGE2ZDZiMmY5NzMyNWI0IDEwMDY0NAotLS0g
YS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMDItMTkg
IEFkcmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBb
R1RLXVtDTWFrZV0gU3VwcG9ydCBidWlsZGluZyB3aXRoIEVuY2hhbnQgMi54CisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODI5MzMKKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9GaW5k
RW5jaGFudC5jbWFrZTogQ2hlY2sgZm9yIGJvdGggdGhlICJlbmNoYW50IiBhbmQgImVuY2hhbnQt
MiIKKyAgICAgICAgcGtnLWNvbmZpZyBjb21wb25lbnRzLCBwaWNraW5nIHRoZSBmaXJzdCBhdmFp
bGFibGUgZm9yIHdoaWNoIHRoZSBoZWFkZXJzIGFuZAorICAgICAgICBsaWJyYXJ5IGFyZSB1c2Fi
bGUuCisKIDIwMTgtMDItMTkgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29t
PgogCiAgICAgICAgIFtHU3RyZWFtZXJdIFBsYXliaW4zIHN1cHBvcnQK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>334172</attachid>
            <date>2018-02-19 11:45:37 -0800</date>
            <delta_ts>2018-02-20 09:34:03 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-182933-20180219214530.patch</filename>
            <type>text/plain</type>
            <size>2148</size>
            <attacher name="Adrian Perez">aperez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4NzAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu
ZEVuY2hhbnQuY21ha2UgYi9Tb3VyY2UvY21ha2UvRmluZEVuY2hhbnQuY21ha2UKaW5kZXggOGRk
MGI1YmEyZmIwMTRjZGZlYjQwNzYxMzBhYTA0YjBmNjRmNmEwNC4uMDk5NWE1MTI3ZDM0ZTAxNWZl
YTYwMWQzOTc3ZDdkYmMxOGJlY2MwNCAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL0ZpbmRFbmNo
YW50LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kRW5jaGFudC5jbWFrZQpAQCAtMjgsMTkg
KzI4LDI5IEBACiAjIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgog
CiBmaW5kX3BhY2thZ2UoUGtnQ29uZmlnKQotcGtnX2NoZWNrX21vZHVsZXMoUENfRU5DSEFOVCBl
bmNoYW50KQotCi1maW5kX3BhdGgoRU5DSEFOVF9JTkNMVURFX0RJUlMKLSAgICBOQU1FUyBlbmNo
YW50LmgKLSAgICBQQVRIUyAke1BDX0VOQ0hBTlRfSU5DTFVERURJUn0KLSAgICAgICAgICAke1BD
X0VOQ0hBTlRfSU5DTFVERV9ESVJTfQotKQotCi1maW5kX2xpYnJhcnkoRU5DSEFOVF9MSUJSQVJJ
RVMKLSAgICBOQU1FUyBlbmNoYW50Ci0gICAgUEFUSFMgJHtQQ19FTkNIQU5UX0xJQkRJUn0KLSAg
ICAgICAgICAke1BDX0VOQ0hBTlRfTElCUkFSWV9ESVJTfQotKQorCitmb3JlYWNoIChFTkNIQU5U
X05BTUUgZW5jaGFudCBlbmNoYW50LTIpCisgICAgcGtnX2NoZWNrX21vZHVsZXMoUENfRU5DSEFO
VCAke0VOQ0hBTlRfTkFNRX0pCisKKyAgICBmaW5kX3BhdGgoRU5DSEFOVF9JTkNMVURFX0RJUlMK
KyAgICAgICAgTkFNRVMgZW5jaGFudC5oCisgICAgICAgIFBBVEhTICR7UENfRU5DSEFOVF9JTkNM
VURFRElSfQorICAgICAgICAgICAgICAke1BDX0VOQ0hBTlRfSU5DTFVERV9ESVJTfQorICAgICkK
KworICAgIGZpbmRfbGlicmFyeShFTkNIQU5UX0xJQlJBUklFUworICAgICAgICBOQU1FUyAke0VO
Q0hBTlRfTkFNRX0KKyAgICAgICAgUEFUSFMgJHtQQ19FTkNIQU5UX0xJQkRJUn0KKyAgICAgICAg
ICAgICAgJHtQQ19FTkNIQU5UX0xJQlJBUllfRElSU30KKyAgICApCisKKyAgICAjIE9ubHkgc3Rv
cCBzZWFyY2hpbmcgaWYgdGhlIHRocmVlIGhhdmUgYmVlbiBmb3VuZC4gVGhpcyBjb3ZlcnMgZm9y
IGNvcm5lcgorICAgICMgY2FzZXMgaW4gd2hpY2ggZS5nLiBib3RoIHZlcnNpb25zIG9mIHRoZSBs
aWJyYXJ5IGFyZSBpbnN0YWxsZWQsIGJ1dCB0aGUKKyAgICAjIGhlYWRlcnMgYXJlIHVzYWJsZS9w
cmVzZW50IGZvciBvbmUgb2YgdGhlbS4KKyAgICBpZiAoUENfRU5DSEFOVF9GT1VORCBBTkQgRU5D
SEFOVF9JTkNMVURFX0RJUlMgQU5EIEVOQ0hBTlRfTElCUkFSSUVTKQorICAgICAgICBicmVhayAo
KQorICAgIGVuZGlmICgpCitlbmRmb3JlYWNoIChFTkNIQU5UX05BTUUpCiAKIG1hcmtfYXNfYWR2
YW5jZWQoCiAgICAgRU5DSEFOVF9JTkNMVURFX0RJUlMKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBi
L0NoYW5nZUxvZwppbmRleCA1NmY5YjZkMTQzNThhMTExZmQ5ZGQwYjE5ZDQ2NzY2YjJmNjQ3Njc3
Li42MGJkOWMyOGQ3YTA0MDJmMmM0YTFhNzlmOGE2ZDZiMmY5NzMyNWI0IDEwMDY0NAotLS0gYS9D
aGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMDItMTkgIEFk
cmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RL
XVtDTWFrZV0gU3VwcG9ydCBidWlsZGluZyB3aXRoIEVuY2hhbnQgMi54CisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODI5MzMKKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9GaW5kRW5j
aGFudC5jbWFrZTogQ2hlY2sgZm9yIGJvdGggdGhlICJlbmNoYW50IiBhbmQgImVuY2hhbnQtMiIK
KyAgICAgICAgcGtnLWNvbmZpZyBjb21wb25lbnRzLCBwaWNraW5nIHRoZSBmaXJzdCBhdmFpbGFi
bGUgZm9yIHdoaWNoIHRoZSBoZWFkZXJzIGFuZAorICAgICAgICBsaWJyYXJ5IGFyZSB1c2FibGUu
CisKIDIwMTgtMDItMTkgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgog
CiAgICAgICAgIFtHU3RyZWFtZXJdIFBsYXliaW4zIHN1cHBvcnQK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>334275</attachid>
            <date>2018-02-20 09:34:06 -0800</date>
            <delta_ts>2018-02-20 09:58:10 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-182933-20180220173405.patch</filename>
            <type>text/plain</type>
            <size>2148</size>
            <attacher name="Adrian Perez">aperez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4ODIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu
ZEVuY2hhbnQuY21ha2UgYi9Tb3VyY2UvY21ha2UvRmluZEVuY2hhbnQuY21ha2UKaW5kZXggOGRk
MGI1YmEyZmIwMTRjZGZlYjQwNzYxMzBhYTA0YjBmNjRmNmEwNC4uM2NkYzQ0M2FiMzJjNzYwMjEz
NGVjNjA4ZTg4Y2QxYWZmNGQ3ZTVhYSAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL0ZpbmRFbmNo
YW50LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kRW5jaGFudC5jbWFrZQpAQCAtMjgsMTkg
KzI4LDI5IEBACiAjIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgog
CiBmaW5kX3BhY2thZ2UoUGtnQ29uZmlnKQotcGtnX2NoZWNrX21vZHVsZXMoUENfRU5DSEFOVCBl
bmNoYW50KQotCi1maW5kX3BhdGgoRU5DSEFOVF9JTkNMVURFX0RJUlMKLSAgICBOQU1FUyBlbmNo
YW50LmgKLSAgICBQQVRIUyAke1BDX0VOQ0hBTlRfSU5DTFVERURJUn0KLSAgICAgICAgICAke1BD
X0VOQ0hBTlRfSU5DTFVERV9ESVJTfQotKQotCi1maW5kX2xpYnJhcnkoRU5DSEFOVF9MSUJSQVJJ
RVMKLSAgICBOQU1FUyBlbmNoYW50Ci0gICAgUEFUSFMgJHtQQ19FTkNIQU5UX0xJQkRJUn0KLSAg
ICAgICAgICAke1BDX0VOQ0hBTlRfTElCUkFSWV9ESVJTfQotKQorCitmb3JlYWNoIChFTkNIQU5U
X05BTUUgZW5jaGFudC0yIGVuY2hhbnQpCisgICAgcGtnX2NoZWNrX21vZHVsZXMoUENfRU5DSEFO
VCAke0VOQ0hBTlRfTkFNRX0pCisKKyAgICBmaW5kX3BhdGgoRU5DSEFOVF9JTkNMVURFX0RJUlMK
KyAgICAgICAgTkFNRVMgZW5jaGFudC5oCisgICAgICAgIFBBVEhTICR7UENfRU5DSEFOVF9JTkNM
VURFRElSfQorICAgICAgICAgICAgICAke1BDX0VOQ0hBTlRfSU5DTFVERV9ESVJTfQorICAgICkK
KworICAgIGZpbmRfbGlicmFyeShFTkNIQU5UX0xJQlJBUklFUworICAgICAgICBOQU1FUyAke0VO
Q0hBTlRfTkFNRX0KKyAgICAgICAgUEFUSFMgJHtQQ19FTkNIQU5UX0xJQkRJUn0KKyAgICAgICAg
ICAgICAgJHtQQ19FTkNIQU5UX0xJQlJBUllfRElSU30KKyAgICApCisKKyAgICAjIE9ubHkgc3Rv
cCBzZWFyY2hpbmcgaWYgdGhlIHRocmVlIGhhdmUgYmVlbiBmb3VuZC4gVGhpcyBjb3ZlcnMgZm9y
IGNvcm5lcgorICAgICMgY2FzZXMgaW4gd2hpY2ggZS5nLiBib3RoIHZlcnNpb25zIG9mIHRoZSBs
aWJyYXJ5IGFyZSBpbnN0YWxsZWQsIGJ1dCB0aGUKKyAgICAjIGhlYWRlcnMgYXJlIHVzYWJsZS9w
cmVzZW50IGZvciBvbmUgb2YgdGhlbS4KKyAgICBpZiAoUENfRU5DSEFOVF9GT1VORCBBTkQgRU5D
SEFOVF9JTkNMVURFX0RJUlMgQU5EIEVOQ0hBTlRfTElCUkFSSUVTKQorICAgICAgICBicmVhayAo
KQorICAgIGVuZGlmICgpCitlbmRmb3JlYWNoIChFTkNIQU5UX05BTUUpCiAKIG1hcmtfYXNfYWR2
YW5jZWQoCiAgICAgRU5DSEFOVF9JTkNMVURFX0RJUlMKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBi
L0NoYW5nZUxvZwppbmRleCA1NmY5YjZkMTQzNThhMTExZmQ5ZGQwYjE5ZDQ2NzY2YjJmNjQ3Njc3
Li5iZTVkZDY1ZjA1ZWFhMzBkNTFiYjU3ZjFlNDg2NjlmODRkNDhmZWJiIDEwMDY0NAotLS0gYS9D
aGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMDItMjAgIEFk
cmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RL
XVtDTWFrZV0gU3VwcG9ydCBidWlsZGluZyB3aXRoIEVuY2hhbnQgMi54CisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODI5MzMKKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9GaW5kRW5j
aGFudC5jbWFrZTogQ2hlY2sgZm9yIGJvdGggdGhlICJlbmNoYW50IiBhbmQgImVuY2hhbnQtMiIK
KyAgICAgICAgcGtnLWNvbmZpZyBjb21wb25lbnRzLCBwaWNraW5nIHRoZSBmaXJzdCBhdmFpbGFi
bGUgZm9yIHdoaWNoIHRoZSBoZWFkZXJzIGFuZAorICAgICAgICBsaWJyYXJ5IGFyZSB1c2FibGUu
CisKIDIwMTgtMDItMTkgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgog
CiAgICAgICAgIFtHU3RyZWFtZXJdIFBsYXliaW4zIHN1cHBvcnQK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>334277</attachid>
            <date>2018-02-20 09:58:13 -0800</date>
            <delta_ts>2018-02-20 10:46:14 -0800</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-182933-20180220175812.patch</filename>
            <type>text/plain</type>
            <size>2293</size>
            <attacher name="Adrian Perez">aperez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4ODIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu
ZEVuY2hhbnQuY21ha2UgYi9Tb3VyY2UvY21ha2UvRmluZEVuY2hhbnQuY21ha2UKaW5kZXggOGRk
MGI1YmEyZmIwMTRjZGZlYjQwNzYxMzBhYTA0YjBmNjRmNmEwNC4uNTNiOWEwZWQzZmFjMWRhZDY1
MjcyM2IyNmEzNjgwMzEyZTBmNDljNiAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL0ZpbmRFbmNo
YW50LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kRW5jaGFudC5jbWFrZQpAQCAtMjgsMTkg
KzI4LDMyIEBACiAjIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgog
CiBmaW5kX3BhY2thZ2UoUGtnQ29uZmlnKQotcGtnX2NoZWNrX21vZHVsZXMoUENfRU5DSEFOVCBl
bmNoYW50KQotCi1maW5kX3BhdGgoRU5DSEFOVF9JTkNMVURFX0RJUlMKLSAgICBOQU1FUyBlbmNo
YW50LmgKLSAgICBQQVRIUyAke1BDX0VOQ0hBTlRfSU5DTFVERURJUn0KLSAgICAgICAgICAke1BD
X0VOQ0hBTlRfSU5DTFVERV9ESVJTfQotKQotCi1maW5kX2xpYnJhcnkoRU5DSEFOVF9MSUJSQVJJ
RVMKLSAgICBOQU1FUyBlbmNoYW50Ci0gICAgUEFUSFMgJHtQQ19FTkNIQU5UX0xJQkRJUn0KLSAg
ICAgICAgICAke1BDX0VOQ0hBTlRfTElCUkFSWV9ESVJTfQotKQorCisjIFRPRE8gUmVtb3ZlIHRo
ZSBjaGVjayBmb3IgRW5jaGFudCAxLnggb25jZSBhbGwgbWFqb3IgTFRTIEdOVS9MaW51eAorIyAg
ICAgIGRpc3RyaWJ1dGlvbnMgc2hpcCB0aGUgMi54IHNlcmllcyAocHJvYmFibHkgYXJvdW5kIG1p
ZC0yMDIwKS4KKworZm9yZWFjaCAoRU5DSEFOVF9OQU1FIGVuY2hhbnQtMiBlbmNoYW50KQorICAg
IHBrZ19jaGVja19tb2R1bGVzKFBDX0VOQ0hBTlQgJHtFTkNIQU5UX05BTUV9KQorCisgICAgZmlu
ZF9wYXRoKEVOQ0hBTlRfSU5DTFVERV9ESVJTCisgICAgICAgIE5BTUVTIGVuY2hhbnQuaAorICAg
ICAgICBQQVRIUyAke1BDX0VOQ0hBTlRfSU5DTFVERURJUn0KKyAgICAgICAgICAgICAgJHtQQ19F
TkNIQU5UX0lOQ0xVREVfRElSU30KKyAgICApCisKKyAgICBmaW5kX2xpYnJhcnkoRU5DSEFOVF9M
SUJSQVJJRVMKKyAgICAgICAgTkFNRVMgJHtFTkNIQU5UX05BTUV9CisgICAgICAgIFBBVEhTICR7
UENfRU5DSEFOVF9MSUJESVJ9CisgICAgICAgICAgICAgICR7UENfRU5DSEFOVF9MSUJSQVJZX0RJ
UlN9CisgICAgKQorCisgICAgIyBPbmx5IHN0b3Agc2VhcmNoaW5nIGlmIHRoZSB0aHJlZSBoYXZl
IGJlZW4gZm91bmQuIFRoaXMgY292ZXJzIGZvciBjb3JuZXIKKyAgICAjIGNhc2VzIGluIHdoaWNo
IGUuZy4gYm90aCB2ZXJzaW9ucyBvZiB0aGUgbGlicmFyeSBhcmUgaW5zdGFsbGVkLCBidXQgdGhl
CisgICAgIyBoZWFkZXJzIGFyZSB1c2FibGUvcHJlc2VudCBmb3Igb25lIG9mIHRoZW0uCisgICAg
aWYgKFBDX0VOQ0hBTlRfRk9VTkQgQU5EIEVOQ0hBTlRfSU5DTFVERV9ESVJTIEFORCBFTkNIQU5U
X0xJQlJBUklFUykKKyAgICAgICAgYnJlYWsgKCkKKyAgICBlbmRpZiAoKQorZW5kZm9yZWFjaCAo
RU5DSEFOVF9OQU1FKQogCiBtYXJrX2FzX2FkdmFuY2VkKAogICAgIEVOQ0hBTlRfSU5DTFVERV9E
SVJTCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggNTZmOWI2ZDE0MzU4
YTExMWZkOWRkMGIxOWQ0Njc2NmIyZjY0NzY3Ny4uMTY1Nzk0NTNmODZjOGJiMWJlOGNjN2ZlZmVm
ZmEzZjE5MzcyNjM4ZSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAt
MSwzICsxLDE0IEBACisyMDE4LTAyLTIwICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6
QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bQ01ha2VdIFN1cHBvcnQgYnVpbGRpbmcgd2l0
aCBFbmNoYW50IDIueAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MTgyOTMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTWljaGFlbCBDYXRhbnphcm8uCisK
KyAgICAgICAgKiBTb3VyY2UvY21ha2UvRmluZEVuY2hhbnQuY21ha2U6IENoZWNrIGZvciBib3Ro
IHRoZSAiZW5jaGFudCIgYW5kICJlbmNoYW50LTIiCisgICAgICAgIHBrZy1jb25maWcgY29tcG9u
ZW50cywgcGlja2luZyB0aGUgZmlyc3QgYXZhaWxhYmxlIGZvciB3aGljaCB0aGUgaGVhZGVycyBh
bmQKKyAgICAgICAgbGlicmFyeSBhcmUgdXNhYmxlLgorCiAyMDE4LTAyLTE5ICBQaGlsaXBwZSBO
b3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1N0cmVhbWVyXSBQbGF5
YmluMyBzdXBwb3J0Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>