182890 2018-02-16 15:12:34 -0800 Offlineasm/MIPS: immediates need to be within 16-bit signed values 2018-02-18 09:13:42 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Other Linux RESOLVED FIXED InRadar P2 Normal --- 1 guijemont webkit-unassigned commit-queue dominik.infuehr ews-watchlist guijemont keith_miller mark.lam mcatanzaro msaboff saam webkit-bug-importer oldest_to_newest 1400055 0 guijemont 2018-02-16 15:12:34 -0800 in Sequence.getModifiedListMIPS(), we allow immediate values within the range -0xffff..0xffff for immediates (addresses and other immediates), but then in Immediate.mipsOperand() and Address.mipsOperand() we raise if immediate values are not within -0x7fff..0x7fff. This is inconsistent, and broke compilation on mips since r228552 made the VM structure bigger meaning we address values with bigger offsets in llint. 1400067 1 334078 guijemont 2018-02-16 15:23:53 -0800 Created attachment 334078 Patch Patch by Dominik Inführ for the immediate part, with addition of the immediate part by me. 1400108 2 guijemont 2018-02-16 17:04:23 -0800 (In reply to Guillaume Emont from comment #1) > Created attachment 334078 [details] > Patch > > Patch by Dominik Inführ for the immediate part, with addition of the > immediate part by me. I meant that Dominik did the patch for the immediate *address* part, I modified the parameters passed to riscLowerMalformedImmediates(). 1400117 3 334078 commit-queue 2018-02-16 18:24:59 -0800 Comment on attachment 334078 Patch Rejecting attachment 334078 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 334078, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: rdparty/autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain result = func(*args) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 60] Operation timed out> Full output: http://webkit-queues.webkit.org/results/6546131 1400169 4 334078 commit-queue 2018-02-17 11:09:15 -0800 Comment on attachment 334078 Patch Rejecting attachment 334078 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 334078, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: rdparty/autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain result = func(*args) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 60] Operation timed out> Full output: http://webkit-queues.webkit.org/results/6553415 1400228 5 334078 commit-queue 2018-02-18 09:13:00 -0800 Comment on attachment 334078 Patch Clearing flags on attachment: 334078 Committed r228604: <https://trac.webkit.org/changeset/228604> 1400229 6 commit-queue 2018-02-18 09:13:02 -0800 All reviewed patches have been landed. Closing bug. 1400230 7 webkit-bug-importer 2018-02-18 09:13:42 -0800 <rdar://problem/37652360> 334078 2018-02-16 15:23:53 -0800 2018-02-18 09:13:00 -0800 Patch bug-182890-20180216172352.patch text/plain 2507 guijemont U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4NTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy MTJiOTljYTk4N2E0Njg2YTgyODFjOWNlYjQxMDNhNmY4ODFjNTAwLi5jOWIwOGY3NzM5ZjczOGI3 N2I1MDMwMzFlMzk2NmY4MDBjNmJlZTQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxOC0wMi0xNiAgRG9taW5payBJbmbDvGhyICA8ZG9taW5pay5pbmZ1ZWhy QGdtYWlsLmNvbT4KKworICAgICAgICBPZmZsaW5lYXNtL01JUFM6IGltbWVkaWF0ZXMgbmVlZCB0 byBiZSB3aXRoaW4gMTYtYml0IHNpZ25lZCB2YWx1ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4Mjg5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIFNlcXVlbmNlLmdldE1vZGlmaWVkTGlzdE1JUFMo KSwgd2UgYWxsb3cgaW1tZWRpYXRlIHZhbHVlcyB3aXRoaW4KKyAgICAgICAgdGhlIHJhbmdlIC0w eGZmZmYuLjB4ZmZmZiBmb3IgaW1tZWRpYXRlcyAoYWRkcmVzc2VzIGFuZCBvdGhlcgorICAgICAg ICBpbW1lZGlhdGVzKSwgYnV0IHRoZW4gaW4gSW1tZWRpYXRlLm1pcHNPcGVyYW5kKCkgYW5kCisg ICAgICAgIEFkZHJlc3MubWlwc09wZXJhbmQoKSB3ZSByYWlzZSBpZiBpbW1lZGlhdGUgdmFsdWVz IGFyZSBub3Qgd2l0aGluCisgICAgICAgIC0weDdmZmYuLjB4N2ZmZi4gVGhpcyBpcyBpbmNvbnNp c3RlbnQsIGFuZCBicm9rZSBjb21waWxhdGlvbiBvbiBtaXBzCisgICAgICAgIHNpbmNlIHIyMjg1 NTIgbWFkZSB0aGUgVk0gc3RydWN0dXJlIGJpZ2dlciBtZWFuaW5nIHdlIGFkZHJlc3MgdmFsdWVz CisgICAgICAgIHdpdGggYmlnZ2VyIG9mZnNldHMgaW4gbGxpbnQuIFRoaXMgY2hhbmdlIHJlc3Ry aWN0cyB0aGUgYWxsb3dlZCByYW5nZSwKKyAgICAgICAgc28gdGhhdCBhIHNlcGFyYXRlIGxvYWQg b2YgdGhlIHZhbHVlIGlzIGRvbmUgZm9yIHZhbHVlcyBvdXRzaWRlIG9mCisgICAgICAgIHRoYXQg cmFuZ2UuCisKKyAgICAgICAgKiBvZmZsaW5lYXNtL21pcHMucmI6CisKIDIwMTgtMDItMTUgIEZp bGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBPYmplY3RzIHRoYXQgY29u dGFpbiBkYW5nZXJvdXMgdGhpbmdzIHNob3VsZCBiZSBhbGxvY2F0ZWQgZmFyIGF3YXkgZnJvbSBv YmplY3RzIHRoYXQgY2FuIGRvIE9PQgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L29mZmxpbmVhc20vbWlwcy5yYiBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL21p cHMucmIKaW5kZXggN2U1ZDRkOTFjZjMwYmZlOWRhOGQyYzA3Yzk1NDE5MmJkZWQ5YjgxOC4uMWNk MzY4ODUzZDY1NTcxZGM3NzZjZmNjNzlkMDU4ZmMwMTA0ZTc0MSAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vbWlwcy5yYgorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvb2ZmbGluZWFzbS9taXBzLnJiCkBAIC03MTMsNyArNzEzLDcgQEAgY2xhc3MgU2VxdWVu Y2UKICAgICAgICAgcmVzdWx0ID0gcmlzY0xvd2VyTWFsZm9ybWVkQWRkcmVzc2VzKHJlc3VsdCkg ewogICAgICAgICAgICAgfCBub2RlLCBhZGRyZXNzIHwKICAgICAgICAgICAgIGlmIGFkZHJlc3Mu aXNfYT8gQWRkcmVzcwotICAgICAgICAgICAgICAgICgtMHhmZmZmLi4weGZmZmYpLmluY2x1ZGU/ IGFkZHJlc3Mub2Zmc2V0LnZhbHVlCisgICAgICAgICAgICAgICAgKC0weDdmZmYuLjB4N2ZmZiku aW5jbHVkZT8gYWRkcmVzcy5vZmZzZXQudmFsdWUKICAgICAgICAgICAgIGVsc2UKICAgICAgICAg ICAgICAgICBmYWxzZQogICAgICAgICAgICAgZW5kCkBAIC03MjEsNyArNzIxLDcgQEAgY2xhc3Mg U2VxdWVuY2UKICAgICAgICAgcmVzdWx0ID0gcmlzY0xvd2VyTWFsZm9ybWVkQWRkcmVzc2VzRG91 YmxlKHJlc3VsdCkKICAgICAgICAgcmVzdWx0ID0gcmlzY0xvd2VyTWlzcGxhY2VkSW1tZWRpYXRl cyhyZXN1bHQsIFsic3RvcmViIiwgInN0b3JlaSIsICJzdG9yZXAiXSkKICAgICAgICAgcmVzdWx0 ID0gbWlwc0xvd2VyTWlzcGxhY2VkSW1tZWRpYXRlcyhyZXN1bHQpCi0gICAgICAgIHJlc3VsdCA9 IHJpc2NMb3dlck1hbGZvcm1lZEltbWVkaWF0ZXMocmVzdWx0LCAtMHhmZmZmLi4weGZmZmYpCisg ICAgICAgIHJlc3VsdCA9IHJpc2NMb3dlck1hbGZvcm1lZEltbWVkaWF0ZXMocmVzdWx0LCAtMHg3 ZmZmLi4weDdmZmYpCiAgICAgICAgIHJlc3VsdCA9IG1pcHNMb3dlck1pc3BsYWNlZEFkZHJlc3Nl cyhyZXN1bHQpCiAgICAgICAgIHJlc3VsdCA9IHJpc2NMb3dlck1pc3BsYWNlZEFkZHJlc3Nlcyhy ZXN1bHQpCiAgICAgICAgIHJlc3VsdCA9IHJpc2NMb3dlclJlZ2lzdGVyUmV1c2UocmVzdWx0KQo=