182882 2018-02-16 13:28:45 -0800 [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views 2018-02-16 13:57:16 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham aestes bfulgham darin mitz thorton oldest_to_newest 1399997 0 bfulgham 2018-02-16 13:28:45 -0800 The refactoring in Bug 176280 caused WebKit to attempt to message destroyed objects in WebKitLegacy applications. A loop was moved (and rewritten) in the new implementation of (void)_web_makePluginSubviewsPerformSelector:(SEL)selector withObject:(id)object The new code access subviews, copied them, placed them in a smart pointer, then retrieved the bare pointer for use in the Objective C iteration: for (NSView *view in adoptNS([[self subviews] copy]).get()) { ... } This caused the collection being iterated over to be cleaned up during the loop, resulting in a crash. 1399999 1 bfulgham 2018-02-16 13:28:56 -0800 <rdar://problem/35672661> 1400002 2 334064 bfulgham 2018-02-16 13:32:28 -0800 Created attachment 334064 Patch 1400015 3 334064 mitz 2018-02-16 13:52:46 -0800 Comment on attachment 334064 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334064&action=review > Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:1430 > + auto subViewsCopy = adoptNS([self.subviews copy]); Lowercase v. 1400020 4 bfulgham 2018-02-16 13:56:18 -0800 Committed r228580: <https://trac.webkit.org/changeset/228580> 1400022 5 334064 bfulgham 2018-02-16 13:57:16 -0800 Comment on attachment 334064 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334064&action=review >> Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:1430 >> + auto subViewsCopy = adoptNS([self.subviews copy]); > > Lowercase v. Will do! Thanks! 334064 2018-02-16 13:32:28 -0800 2018-02-16 13:52:46 -0800 Patch bug-182882-20180216133227.patch text/plain 1657 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyODU3NCkKKysrIFNv dXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDE3IEBACisyMDE4LTAyLTE2ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgor CisgICAgICAgIFtDb2NvYV1bV2ViS2l0TGVnYWN5XSBSRUdSRVNTSU9OKHIyMjE1NTkpOiBDb2Rh IDIgY3Jhc2hlcyB3aGVuIHN3aXRjaGluZyB2aWV3cworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyODgyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8z NTY3MjY2MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBNYWtlIHN1cmUgdGhlIHNtYXJ0IHBvaW50ZXIgaG9sZCB0aGUgY29sbGVjdGlvbiBvZiBzdWJ2 aWV3cyBsaXZlcyBhdCBsZWFzdCBhcworICAgICAgICBsb25nIGFzIHRoZSBsb29wIHVzaW5nIGl0 LgorCisgICAgICAgICogV2ViVmlldy9XZWJIVE1MVmlldy5tbToKKyAgICAgICAgKC1bV2ViSFRN TFZpZXcgX3dlYl9tYWtlUGx1Z2luU3Vidmlld3NQZXJmb3JtU2VsZWN0b3I6d2l0aE9iamVjdDpd KToKKwogMjAxOC0wMi0xNCAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAg ICAgICAgRGlzYWxsb3cgY3Jvc3Mtb3JpZ2luIHN1YnJlc291cmNlcyBmcm9tIGFza2luZyBmb3Ig Y3JlZGVudGlhbHMKSW5kZXg6IFNvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViSFRN TFZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmlldy9X ZWJIVE1MVmlldy5tbQkocmV2aXNpb24gMjI4NTU5KQorKysgU291cmNlL1dlYktpdExlZ2FjeS9t YWMvV2ViVmlldy9XZWJIVE1MVmlldy5tbQkod29ya2luZyBjb3B5KQpAQCAtMTQyNyw3ICsxNDI3 LDggQEAgLSAodm9pZClfd2ViX21ha2VQbHVnaW5TdWJ2aWV3c1BlcmZvcm1TZQogewogICAgIC8v IENvcHkgc3Vidmlld3MgYmVjYXVzZSBbc2VsZiBzdWJ2aWV3c10gcmV0dXJucyB0aGUgdmlldydz IG11dGFibGUgaW50ZXJuYWwgYXJyYXksCiAgICAgLy8gYW5kIHdlIG11c3QgYXZvaWQgbXV0YXRp bmcgdGhlIGFycmF5IHdoaWxlIGVudW1lcmF0aW5nIGl0LgotICAgIGZvciAoTlNWaWV3ICp2aWV3 IGluIGFkb3B0TlMoW1tzZWxmIHN1YnZpZXdzXSBjb3B5XSkuZ2V0KCkpIHsKKyAgICBhdXRvIHN1 YlZpZXdzQ29weSA9IGFkb3B0TlMoW3NlbGYuc3Vidmlld3MgY29weV0pOworICAgIGZvciAoTlNW aWV3ICp2aWV3IGluIHN1YlZpZXdzQ29weS5nZXQoKSkgewogICAgICAgICBpZiAoW3ZpZXcgaXNL aW5kT2ZDbGFzczpbV2ViQmFzZU5ldHNjYXBlUGx1Z2luVmlldyBjbGFzc11dKQogICAgICAgICAg ICAgW3ZpZXcgcGVyZm9ybVNlbGVjdG9yOnNlbGVjdG9yIHdpdGhPYmplY3Q6b2JqZWN0XTsKICAg ICB9Cg==