182841 2018-02-15 14:31:09 -0800 Speed up dSYM generation on build.webkit.org with -gline-tables-only 2018-02-15 16:07:29 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap aakash_jain commit-queue fpizlo jlewis3 lforschler mitz ryanhaddad oldest_to_newest 1399620 0 ap 2018-02-15 14:31:09 -0800 We need to produce dSYM files on CI builders to have line numbers in crash logs on testers. On my machine, a full release build of WebKit with dSYM generation takes ~6 minutes longer than without (the time is split between slower compilation and slower dsymutil invocations). With -gline-tables-only AKA -gmlt, the cost is only 30 seconds, and the resulting dSYMs are also dramatically smaller (962 MB to 139 MB for WebCore). I believe that we would be getting proper crash logs with -gline-tables-only too. 1399631 1 ap 2018-02-15 14:42:47 -0800 rdar://problem/34579649 1399632 2 333951 ap 2018-02-15 14:43:05 -0800 Created attachment 333951 proposed patch 1399653 3 333951 aakash_jain 2018-02-15 15:48:32 -0800 Comment on attachment 333951 proposed patch Seems fine to me. 1399664 4 333951 commit-queue 2018-02-15 16:07:28 -0800 Comment on attachment 333951 proposed patch Clearing flags on attachment: 333951 Committed r228539: <https://trac.webkit.org/changeset/228539> 1399665 5 commit-queue 2018-02-15 16:07:29 -0800 All reviewed patches have been landed. Closing bug. 333951 2018-02-15 14:43:05 -0800 2018-02-15 16:07:28 -0800 proposed patch gmlt.txt text/plain 2410 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyODUzMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE4LTAyLTE1ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFNwZWVkIHVwIGRTWU0gZ2VuZXJhdGlvbiBvbiBidWlsZC53ZWJraXQub3Jn IHdpdGggLWdsaW5lLXRhYmxlcy1vbmx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xODI4NDEKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMzQ1Nzk2NDkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCdWlsZCBz cGVlZCBhbmQgYmluYXJ5IHNpemUgaW1wcm92ZW1lbnRzIGFyZSBzbyBzdWJzdGFudGlhbCB0aGF0 IEknbSB3aWxsaW5nIHRvIG1ha2UKKyAgICAgICAgQ0kgYnVpbGRzIGxlc3Mgc3VpdGFibGUgZm9y IGRlYnVnZ2luZywgd2hpY2ggaXMgbm90IGEgY29tbW9uIHNjZW5hcmlvIGFueXdheS4KKyAgICAg ICAgQ3Jhc2ggbG9ncyB3aWxsIHN0aWxsIGhhdmUgbGluZSBudW1iZXJzIGluIHRoZW0uCisKKyAg ICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9zdGVwcy5w eTogKENvbXBpbGVXZWJLaXQuc3RhcnQpOgorCiAyMDE4LTAyLTE1ICBEb24gT2xtc3RlYWQgIDxk b24ub2xtc3RlYWRAc29ueS5jb20+CiAKICAgICAgICAgV2ViQ29yZSBoZWFkZXJzIHNob3VsZCBu b3QgYmUgaW5jbHVkZWQgcmVsYXRpdmVseSB3aXRoaW4gZGVwZW5kZW50IHByb2plY3RzCkluZGV4 OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9zdGVwcy5w eQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9zdGVwcy5weQkocmV2aXNpb24gMjI4MTg1KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1 cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvc3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAg LTIwNiwxMCArMjA2LDEyIEBAIGNsYXNzIENvbXBpbGVXZWJLaXQoc2hlbGwuQ29tcGlsZSk6CiAg ICAgICAgICAgICBzZWxmLnNldENvbW1hbmQoc2VsZi5jb21tYW5kICsgWydBUkNIUz0nICsgYXJj aGl0ZWN0dXJlXSkKICAgICAgICAgICAgIGlmIHBsYXRmb3JtID09ICdpb3MnOgogICAgICAgICAg ICAgICAgIHNlbGYuc2V0Q29tbWFuZChzZWxmLmNvbW1hbmQgKyBbJ09OTFlfQUNUSVZFX0FSQ0g9 Tk8nXSkKLSAgICAgICAgIyBHZW5lcmF0aW5nIGRTWU0gZmlsZXMgaXMgc2xvdywgYnV0IHRoZXNl IGFyZSBuZWVkZWQgdG8gaGF2ZSBsaW5lIG51bWJlcnMgaW4gY3Jhc2ggcmVwb3J0cyBvbiB0ZXN0 ZXJzLgotICAgICAgICAjIERlYnVnIGJ1aWxkcyBvbiBZb3NlbWl0ZSBjYW4ndCB1c2UgZFNZTXMs IGJlY2F1c2UgY3Jhc2ggbG9ncyBlbmQgdXAgdW5zeW1ib2xpY2F0ZWQuCi0gICAgICAgIGlmIHBs YXRmb3JtIGluICgnbWFjJywgJ2lvcycpIGFuZCBidWlsZE9ubHkgYW5kIChzZWxmLmdldFByb3Bl cnR5KCdmdWxsUGxhdGZvcm0nKSAhPSAibWFjLXlvc2VtaXRlIiBvciBzZWxmLmdldFByb3BlcnR5 KCdjb25maWd1cmF0aW9uJykgIT0gImRlYnVnIik6CisgICAgICAgIGlmIHBsYXRmb3JtIGluICgn bWFjJywgJ2lvcycpIGFuZCBidWlsZE9ubHk6CisgICAgICAgICAgICAjIEZvciBidWlsZC1vbmx5 IGJvdHMsIHRoZSBleHBlY3RhdGlvbiBpcyB0aGF0IHRlc3RzIHdpbGwgYmUgcnVuIG9uIHNlcGFy YXRlIG1hY2hpbmVzLAorICAgICAgICAgICAgIyBzbyB3ZSBuZWVkIHRvIHBhY2thZ2UgZGVidWcg aW5mbyBhcyBkU1lNcy4gT25seSBnZW5lcmF0aW5nIGxpbmUgdGFibGVzIG1ha2VzCisgICAgICAg ICAgICAjIHRoaXMgbXVjaCBmYXN0ZXIgdGhhbiBmdWxsIGRlYnVnIGluZm8sIGFuZCBjcmFzaCBs b2dzIHN0aWxsIGhhdmUgbGluZSBudW1iZXJzLgogICAgICAgICAgICAgc2VsZi5zZXRDb21tYW5k KHNlbGYuY29tbWFuZCArIFsnREVCVUdfSU5GT1JNQVRJT05fRk9STUFUPWR3YXJmLXdpdGgtZHN5 bSddKQorICAgICAgICAgICAgc2VsZi5zZXRDb21tYW5kKHNlbGYuY29tbWFuZCArIFsnQ0xBTkdf REVCVUdfSU5GT1JNQVRJT05fTEVWRUw9bGluZS10YWJsZXMtb25seSddKQogCiAgICAgICAgIGFw cGVuZEN1c3RvbUJ1aWxkRmxhZ3Moc2VsZiwgcGxhdGZvcm0sIHNlbGYuZ2V0UHJvcGVydHkoJ2Z1 bGxQbGF0Zm9ybScpKQogCg==