182825 2018-02-15 03:17:12 -0800 FontPlatformData::harfBuzzFace() should return a reference 2018-02-15 11:05:32 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zan zan bugs-noreply cgarcia ews-watchlist mmaxfield webkit-bug-importer oldest_to_newest 1399425 0 zan 2018-02-15 03:17:12 -0800 FontPlatformData::harfBuzzFace() should return a reference 1399426 1 333889 zan 2018-02-15 03:21:18 -0800 Created attachment 333889 Patch 1399527 2 333889 zan 2018-02-15 11:04:03 -0800 Comment on attachment 333889 Patch Clearing flags on attachment: 333889 Committed r228524: <https://trac.webkit.org/changeset/228524> 1399528 3 zan 2018-02-15 11:04:07 -0800 All reviewed patches have been landed. Closing bug. 1399530 4 webkit-bug-importer 2018-02-15 11:05:32 -0800 <rdar://problem/37576292> 333889 2018-02-15 03:21:18 -0800 2018-02-15 11:04:03 -0800 Patch bug-182825-20180215122117.patch text/plain 5633 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4NTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2RjMDBhZTFlYWE4MzQw NGJiOTYxOTI1ZjM2Y2Q4MjMwYjUyYzExYi4uN2IzZGI5NTUzMjYxOGZlZDRlMjFkOTJhNzgxMjFh ZGY5Zjk2ZDEwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3IEBACiAyMDE4LTAyLTE1ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAorICAgICAgICBGb250UGxhdGZvcm1E YXRhOjpoYXJmQnV6ekZhY2UoKSBzaG91bGQgcmV0dXJuIGEgcmVmZXJlbmNlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODI4MjUKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBIYXZlIEZvbnRQbGF0Zm9ybURh dGE6OmhhcmZCdXp6RmFjZSgpIHJldHVybiBhIHJlZmVyZW5jZSBpbnN0ZWFkIG9mIGEKKyAgICAg ICAgcG9pbnRlciwgZ2l2ZW4gdGhhdCB0aGUgcmV0dXJuZWQgSGFyZkJ1enpGYWNlIG9iamVjdCBj YW5ub3QgYmUgbnVsbC4KKworICAgICAgICBDYWxsLXNpdGVzIG9mIEZvbnRQbGF0Zm9ybURhdGE6 OmhhcmZCdXp6RmFjZSgpIGFyZSBhZGp1c3RlZC4KKyAgICAgICAgT3BlblR5cGVNYXRoRGF0YSBj b25zdHJ1Y3RvcnMgYXJlIGFsc28gY2hhbmdlZCB0byBub3QgcmVseSBvbgorICAgICAgICBwcmVw cm9jZXNzb3IgdG8gY29ycmVjdGx5IHBvc2l0aW9uIHRoZSBjbG9zaW5nIGJyYWNlLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvRm9udFBsYXRmb3JtRGF0YS5oOgorICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL2ZyZWV0eXBlL0ZvbnRQbGF0Zm9ybURhdGFGcmVlVHlwZS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpGb250UGxhdGZvcm1EYXRhOjpoYXJmQnV6ekZhY2UgY29uc3QpOgor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2hhcmZidXp6L0NvbXBsZXhUZXh0Q29udHJvbGxl ckhhcmZCdXp6LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNvbXBsZXhUZXh0Q29udHJvbGxlcjo6 Y29sbGVjdENvbXBsZXhUZXh0UnVuc0ZvckNoYXJhY3RlcnMpOgorICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL29wZW50eXBlL09wZW5UeXBlTWF0aERhdGEuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6T3BlblR5cGVNYXRoRGF0YTo6T3BlblR5cGVNYXRoRGF0YSk6CisKKzIwMTgtMDItMTUgIFph biBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgorCiAgICAgICAgIENsZWFuIHVwIEhh cmZCdXp6RmFjZUNhaXJvCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xODI4MjQKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvRm9udFBsYXRmb3JtRGF0YS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvRm9udFBsYXRmb3JtRGF0YS5oCmluZGV4IDVhNzlkNTk2YTMyYjQ4MjkyOWJhYzE0YTdmNWJk ZTM1ZTM2YjdmMDYuLmJkNDZmYzViMWMxNzY2NjU4MTk3YmYzZDVjNjViODRmYzJjYTA2MTAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnRQbGF0Zm9ybURh dGEuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250UGxhdGZvcm1E YXRhLmgKQEAgLTE2Miw3ICsxNjIsNyBAQCBwdWJsaWM6CiAjZW5kaWYKIAogI2lmIFVTRShGUkVF VFlQRSkKLSAgICBIYXJmQnV6ekZhY2UqIGhhcmZCdXp6RmFjZSgpIGNvbnN0OworICAgIEhhcmZC dXp6RmFjZSYgaGFyZkJ1enpGYWNlKCkgY29uc3Q7CiAgICAgYm9vbCBoYXNDb21wYXRpYmxlQ2hh cm1hcCgpIGNvbnN0OwogICAgIEZjRm9udFNldCogZmFsbGJhY2tzKCkgY29uc3Q7CiAjZW5kaWYK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZyZWV0eXBlL0Zv bnRQbGF0Zm9ybURhdGFGcmVlVHlwZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9mcmVldHlwZS9Gb250UGxhdGZvcm1EYXRhRnJlZVR5cGUuY3BwCmluZGV4IDNjM2NhODE5 MDJjNWFlYzIzODJlYWYzNTllYzA3Y2VhMjcxOTIyYTYuLjZjNGFiZmE4MjJhMjcxMzdiZmQ5ZWE5 MzYwZGIzNjBhYzU2MDNmMTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2ZyZWV0eXBlL0ZvbnRQbGF0Zm9ybURhdGFGcmVlVHlwZS5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZnJlZXR5cGUvRm9udFBsYXRmb3JtRGF0YUZyZWVU eXBlLmNwcApAQCAtMjM4LDExICsyMzgsMTEgQEAgRm9udFBsYXRmb3JtRGF0YSBGb250UGxhdGZv cm1EYXRhOjpjbG9uZVdpdGhTaXplKGNvbnN0IEZvbnRQbGF0Zm9ybURhdGEmIHNvdXJjZSwKICAg ICByZXR1cm4gY29weTsKIH0KIAotSGFyZkJ1enpGYWNlKiBGb250UGxhdGZvcm1EYXRhOjpoYXJm QnV6ekZhY2UoKSBjb25zdAorSGFyZkJ1enpGYWNlJiBGb250UGxhdGZvcm1EYXRhOjpoYXJmQnV6 ekZhY2UoKSBjb25zdAogewogICAgIGlmICghbV9oYXJmQnV6ekZhY2UpCiAgICAgICAgIG1faGFy ZkJ1enpGYWNlID0gc3RkOjptYWtlX3VuaXF1ZTxIYXJmQnV6ekZhY2U+KGNvbnN0X2Nhc3Q8Rm9u dFBsYXRmb3JtRGF0YSo+KHRoaXMpLCBoYXNoKCkpOwotICAgIHJldHVybiBtX2hhcmZCdXp6RmFj ZS5nZXQoKTsKKyAgICByZXR1cm4gKm1faGFyZkJ1enpGYWNlOwogfQogCiBGY0ZvbnRTZXQqIEZv bnRQbGF0Zm9ybURhdGE6OmZhbGxiYWNrcygpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9Db21wbGV4VGV4dENvbnRyb2xsZXJIYXJm QnV6ei5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9Db21w bGV4VGV4dENvbnRyb2xsZXJIYXJmQnV6ei5jcHAKaW5kZXggNGU2YTUzYjY0ZTBhOGZlZWIxOGFi NTkxNThlODFiY2VkNmRlNmMxNC4uMzdmNjZiNmVjNjM3NTJjN2NmMWI2ZWE5MDBmZjliMTI5YTRk Mzg3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1 enovQ29tcGxleFRleHRDb250cm9sbGVySGFyZkJ1enouY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2hhcmZidXp6L0NvbXBsZXhUZXh0Q29udHJvbGxlckhhcmZCdXp6 LmNwcApAQCAtMjA3LDEyICsyMDcsMTEgQEAgdm9pZCBDb21wbGV4VGV4dENvbnRyb2xsZXI6OmNv bGxlY3RDb21wbGV4VGV4dFJ1bnNGb3JDaGFyYWN0ZXJzKGNvbnN0IFVDaGFyKiBjaGEKICAgICAg ICAgfQogICAgICAgICBoYl9idWZmZXJfYWRkX3V0ZjE2KGJ1ZmZlci5nZXQoKSwgcmVpbnRlcnBy ZXRfY2FzdDxjb25zdCB1aW50MTZfdCo+KGNoYXJhY3RlcnMpLCBsZW5ndGgsIHJ1bi5zdGFydElu ZGV4LCBydW4uZW5kSW5kZXggLSBydW4uc3RhcnRJbmRleCk7CiAKLSAgICAgICAgSGFyZkJ1enpG YWNlKiBmYWNlID0gZm9udFBsYXRmb3JtRGF0YS5oYXJmQnV6ekZhY2UoKTsKLSAgICAgICAgQVNT RVJUKGZhY2UpOworICAgICAgICBhdXRvJiBmYWNlID0gZm9udFBsYXRmb3JtRGF0YS5oYXJmQnV6 ekZhY2UoKTsKICAgICAgICAgaWYgKGZvbnRQbGF0Zm9ybURhdGEub3JpZW50YXRpb24oKSA9PSBW ZXJ0aWNhbCkKLSAgICAgICAgICAgIGZhY2UtPnNldFNjcmlwdEZvclZlcnRpY2FsR2x5cGhTdWJz dGl0dXRpb24oYnVmZmVyLmdldCgpKTsKKyAgICAgICAgICAgIGZhY2Uuc2V0U2NyaXB0Rm9yVmVy dGljYWxHbHlwaFN1YnN0aXR1dGlvbihidWZmZXIuZ2V0KCkpOwogCi0gICAgICAgIEhiVW5pcXVl UHRyPGhiX2ZvbnRfdD4gaGFyZkJ1enpGb250KGZhY2UtPmNyZWF0ZUZvbnQoKSk7CisgICAgICAg IEhiVW5pcXVlUHRyPGhiX2ZvbnRfdD4gaGFyZkJ1enpGb250KGZhY2UuY3JlYXRlRm9udCgpKTsK ICAgICAgICAgaGJfc2hhcGUoaGFyZkJ1enpGb250LmdldCgpLCBidWZmZXIuZ2V0KCksIGZlYXR1 cmVzLmlzRW1wdHkoKSA/IG51bGxwdHIgOiBmZWF0dXJlcy5kYXRhKCksIGZlYXR1cmVzLnNpemUo KSk7CiAgICAgICAgIG1fY29tcGxleFRleHRSdW5zLmFwcGVuZChDb21wbGV4VGV4dFJ1bjo6Y3Jl YXRlKGJ1ZmZlci5nZXQoKSwgKmZvbnQsIGNoYXJhY3RlcnMsIHN0cmluZ0xvY2F0aW9uLCBsZW5n dGgsIHJ1bi5zdGFydEluZGV4LCBydW4uZW5kSW5kZXgpKTsKICAgICAgICAgaGJfYnVmZmVyX3Jl c2V0KGJ1ZmZlci5nZXQoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9vcGVudHlwZS9PcGVuVHlwZU1hdGhEYXRhLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL29wZW50eXBlL09wZW5UeXBlTWF0aERhdGEuY3BwCmluZGV4IGYxMGU0 MDA5OTVkN2E3YTI1YjAxMzMxOTMzNjg5ZTRjYWNiODY3YzMuLjg0MTgxZmEyODk1MTAyMjdkZmE2 ZTM4MzI0M2IyMDBjNGY0YmQzZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL29wZW50eXBlL09wZW5UeXBlTWF0aERhdGEuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW50eXBlL09wZW5UeXBlTWF0aERhdGEuY3BwCkBAIC0y NTQsMjAgKzI1NCwxNyBAQCBPcGVuVHlwZU1hdGhEYXRhOjpPcGVuVHlwZU1hdGhEYXRhKGNvbnN0 IEZvbnRQbGF0Zm9ybURhdGEmIGZvbnQpCiAgICAgY29uc3QgT3BlblR5cGU6Ok1hdGhWYXJpYW50 cyogbWF0aFZhcmlhbnRzID0gbWF0aC0+bWF0aFZhcmlhbnRzKCptX21hdGhCdWZmZXIpOwogICAg IGlmICghbWF0aFZhcmlhbnRzKQogICAgICAgICBtX21hdGhCdWZmZXIgPSBudWxscHRyOworfQog I2VsaWYgVVNFKEhBUkZCVVpaKQogT3BlblR5cGVNYXRoRGF0YTo6T3BlblR5cGVNYXRoRGF0YShj b25zdCBGb250UGxhdGZvcm1EYXRhJiBmb250KQorICAgIDogbV9tYXRoRm9udChmb250LmhhcmZC dXp6RmFjZSgpLmNyZWF0ZUZvbnQoKSkKIHsKLSAgICBIYXJmQnV6ekZhY2UqIGZhY2UgPSBmb250 LmhhcmZCdXp6RmFjZSgpOwotICAgIGlmIChmYWNlKSB7Ci0gICAgICAgIG1fbWF0aEZvbnQucmVz ZXQoZmFjZS0+Y3JlYXRlRm9udCgpKTsKLSAgICAgICAgaWYgKCFoYl9vdF9tYXRoX2hhc19kYXRh KGhiX2ZvbnRfZ2V0X2ZhY2UobV9tYXRoRm9udC5nZXQoKSkpKQotICAgICAgICAgICAgbV9tYXRo Rm9udC5yZWxlYXNlKCk7Ci0gICAgfQorICAgIGlmICghaGJfb3RfbWF0aF9oYXNfZGF0YShoYl9m b250X2dldF9mYWNlKG1fbWF0aEZvbnQuZ2V0KCkpKSkKKyAgICAgICAgbV9tYXRoRm9udCA9IG51 bGxwdHI7Cit9CiAjZWxzZQotT3BlblR5cGVNYXRoRGF0YTo6T3BlblR5cGVNYXRoRGF0YShjb25z dCBGb250UGxhdGZvcm1EYXRhJikKLXsKK09wZW5UeXBlTWF0aERhdGE6Ok9wZW5UeXBlTWF0aERh dGEoY29uc3QgRm9udFBsYXRmb3JtRGF0YSYpID0gZGVmYXVsdDsKICNlbmRpZgotfQogCiBPcGVu VHlwZU1hdGhEYXRhOjp+T3BlblR5cGVNYXRoRGF0YSgpID0gZGVmYXVsdDsKIAo=