182795 2018-02-14 09:27:27 -0800 Log the error message when failing to open the database 2018-02-16 11:36:14 -0800 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf beidson cdumez commit-queue fred.wang ryanhaddad webkit-bug-importer oldest_to_newest 1399086 0 youennf 2018-02-14 09:27:27 -0800 Log the error message when failing to open the database 1399087 1 333806 youennf 2018-02-14 09:30:12 -0800 Created attachment 333806 Patch 1399088 2 youennf 2018-02-14 09:31:36 -0800 Looking at the code, it is the first time we would expose SQLiteDatabase::lastErrorMsg() in release log. AIUI, it does not contain any privacy sensitive information. 1399696 3 333806 commit-queue 2018-02-15 17:30:41 -0800 Comment on attachment 333806 Patch Rejecting attachment 333806 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 333806, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: rdparty/autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain result = func(*args) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 60] Operation timed out> Full output: http://webkit-queues.webkit.org/results/6526217 1399723 4 333806 commit-queue 2018-02-15 18:27:19 -0800 Comment on attachment 333806 Patch Rejecting attachment 333806 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 333806, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: rdparty/autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain result = func(*args) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 60] Operation timed out> Full output: http://webkit-queues.webkit.org/results/6527099 1399734 5 333806 commit-queue 2018-02-15 18:45:13 -0800 Comment on attachment 333806 Patch Clearing flags on attachment: 333806 Committed r228548: <https://trac.webkit.org/changeset/228548> 1399735 6 commit-queue 2018-02-15 18:45:15 -0800 All reviewed patches have been landed. Closing bug. 1399736 7 webkit-bug-importer 2018-02-15 18:46:19 -0800 <rdar://problem/37592399> 1399854 8 fred.wang 2018-02-16 03:35:52 -0800 @Youenn: It looks like this patch breaks the iOS simulator debug bot: In file included from /Volumes/Data/slave/ios-simulator-11-debug/build/WebKitBuild/Debug-iphonesimulator/DerivedSources/WebCore/unified-sources/UnifiedSource470.cpp:1: ./workers/service/server/RegistrationDatabase.cpp:111:98: error: using 'public' format specifier annotation outside of os_log()/os_trace() [-Werror,-Wformat] RELEASE_LOG_ERROR(ServiceWorker, "Failed to open Service Worker registration database: %{public}s", errorMessage->utf8().data()); ~~^~~~~~~~ In file included from /Volumes/Data/slave/ios-simulator-11-debug/build/WebKitBuild/Debug-iphonesimulator/DerivedSources/WebCore/unified-sources/UnifiedSource470.cpp:1: In file included from /Volumes/Data/slave/ios-simulator-11-debug/build/Source/WebCore/WebCorePrefix.h:171: In file included from /Volumes/Data/slave/ios-simulator-11-debug/build/WebKitBuild/Debug-iphonesimulator/usr/local/include/wtf/FastMalloc.h:26: In file included from /Volumes/Data/slave/ios-simulator-11-debug/build/WebKitBuild/Debug-iphonesimulator/usr/local/include/wtf/StdLibExtras.h:34: /Volumes/Data/slave/ios-simulator-11-debug/build/WebKitBuild/Debug-iphonesimulator/usr/local/include/wtf/Assertions.h:449:59: note: expanded from macro 'RELEASE_LOG_ERROR' #define RELEASE_LOG_ERROR(channel, format, ...) LOG_ERROR(format, ##__VA_ARGS__) ^ /Volumes/Data/slave/ios-simulator-11-debug/build/WebKitBuild/Debug-iphonesimulator/usr/local/include/wtf/Assertions.h:418:80: note: expanded from macro 'LOG_ERROR' #define LOG_ERROR(...) WTFReportError(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, __VA_ARGS__) ^ 1 error generated. 1399894 9 youennf 2018-02-16 08:57:13 -0800 Thanks Fred, will look at it. 1399915 10 youennf 2018-02-16 09:51:33 -0800 Reopening to attach new patch. 1399916 11 334047 youennf 2018-02-16 09:51:34 -0800 Created attachment 334047 Patch 1399933 12 334047 commit-queue 2018-02-16 10:48:36 -0800 Comment on attachment 334047 Patch Clearing flags on attachment: 334047 Committed r228562: <https://trac.webkit.org/changeset/228562> 1399934 13 commit-queue 2018-02-16 10:48:37 -0800 All reviewed patches have been landed. Closing bug. 1399954 14 ryanhaddad 2018-02-16 11:28:10 -0800 (In reply to WebKit Commit Bot from comment #12) > Comment on attachment 334047 [details] > Patch > > Clearing flags on attachment: 334047 > > Committed r228562: <https://trac.webkit.org/changeset/228562> The failure is different now: ./workers/service/server/RegistrationDatabase.cpp:113:19: error: use of undeclared identifier 'ServiceWorker' LOG_ERROR(ServiceWorker, "Failed to open Service Worker registration database: %s", errorMessage->utf8().data()); ^ 1 error generated. https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Debug%20%28Build%29/builds/3907 1399961 15 cdumez 2018-02-16 11:36:14 -0800 (In reply to Ryan Haddad from comment #14) > (In reply to WebKit Commit Bot from comment #12) > > Comment on attachment 334047 [details] > > Patch > > > > Clearing flags on attachment: 334047 > > > > Committed r228562: <https://trac.webkit.org/changeset/228562> > > The failure is different now: > ./workers/service/server/RegistrationDatabase.cpp:113:19: error: use of > undeclared identifier 'ServiceWorker' > LOG_ERROR(ServiceWorker, "Failed to open Service Worker registration > database: %s", errorMessage->utf8().data()); > ^ > 1 error generated. > > https://build.webkit.org/builders/ > Apple%20iOS%2011%20Simulator%20Debug%20%28Build%29/builds/3907 Should be fixed by <https://trac.webkit.org/changeset/228568>. 333806 2018-02-14 09:30:12 -0800 2018-02-16 09:51:31 -0800 Patch bug-182795-20180214093011.patch text/plain 1866 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4MzExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjUwYzEwY2EzMDBmNjc1 NzAwOWJmYzQxMWEwM2MxNmE5MjJjNjg4Ni4uYTg5YzVlZDIxNzRiMTIzZGQ1NjQ3YTFjMGRjYjU1 NDNhYzgyNGUzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTAyLTE0ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBMb2cgdGhlIGVycm9yIG1l c3NhZ2Ugd2hlbiBmYWlsaW5nIHRvIG9wZW4gdGhlIGRhdGFiYXNlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODI3OTUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBjaGFuZ2Ugb2YgYmVoYXZpb3IuCisg ICAgICAgIFByaW50IHRoZSBlcnJvciBtZXNzYWdlIGFzIGl0IGRvZXMgbm90IGNvbnRhaW4gYW55 IHVzZXIgcHJpdmF0ZSBpbmZvcm1hdGlvbi4KKworICAgICAgICAqIHdvcmtlcnMvc2VydmljZS9z ZXJ2ZXIvUmVnaXN0cmF0aW9uRGF0YWJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVnaXN0 cmF0aW9uRGF0YWJhc2U6Om9wZW5TUUxpdGVEYXRhYmFzZSk6CisKIDIwMTgtMDItMTMgIFlvdWVu biBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEFsbG93IHNwZWNpZnlpbmcg d2hpY2ggcGx1Zy1pbnMgYXJlIHN1cHBvcnRlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv d29ya2Vycy9zZXJ2aWNlL3NlcnZlci9SZWdpc3RyYXRpb25EYXRhYmFzZS5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS93b3JrZXJzL3NlcnZpY2Uvc2VydmVyL1JlZ2lzdHJhdGlvbkRhdGFiYXNlLmNwcApp bmRleCBkNTdjZGFmZDcxNDA2NDM0OWVkOGEzYmVkZGI3NDI3OTMwMTgyZDU2Li4wMzIwZGRkM2E2 ZWUyNzVmZmMzNWI2OTFiYWFiMmIzMmM1ODRjOWYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS93b3JrZXJzL3NlcnZpY2Uvc2VydmVyL1JlZ2lzdHJhdGlvbkRhdGFiYXNlLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2Uvc2VydmVyL1JlZ2lzdHJhdGlvbkRhdGFiYXNl LmNwcApAQCAtMTA4LDcgKzEwOCw3IEBAIHZvaWQgUmVnaXN0cmF0aW9uRGF0YWJhc2U6Om9wZW5T UUxpdGVEYXRhYmFzZShjb25zdCBTdHJpbmcmIGZ1bGxGaWxlbmFtZSkKICAgICBTdHJpbmcgZXJy b3JNZXNzYWdlOwogICAgIGF1dG8gc2NvcGVFeGl0ID0gbWFrZVNjb3BlRXhpdChbJiwgZXJyb3JN ZXNzYWdlID0gJmVycm9yTWVzc2FnZV0gewogICAgICAgICBBU1NFUlRfVU5VU0VEKGVycm9yTWVz c2FnZSwgIWVycm9yTWVzc2FnZS0+aXNOdWxsKCkpOwotICAgICAgICBSRUxFQVNFX0xPR19FUlJP UihTZXJ2aWNlV29ya2VyLCAiRmFpbGVkIHRvIG9wZW4gU2VydmljZSBXb3JrZXIgcmVnaXN0cmF0 aW9uIGRhdGFiYXNlOiAlcyIsIGVycm9yTWVzc2FnZS0+dXRmOCgpLmRhdGEoKSk7CisgICAgICAg IFJFTEVBU0VfTE9HX0VSUk9SKFNlcnZpY2VXb3JrZXIsICJGYWlsZWQgdG8gb3BlbiBTZXJ2aWNl IFdvcmtlciByZWdpc3RyYXRpb24gZGF0YWJhc2U6ICV7cHVibGljfXMiLCBlcnJvck1lc3NhZ2Ut PnV0ZjgoKS5kYXRhKCkpOwogICAgICAgICBtX2RhdGFiYXNlID0gbnVsbHB0cjsKICAgICAgICAg cG9zdFRhc2tSZXBseShjcmVhdGVDcm9zc1RocmVhZFRhc2soKnRoaXMsICZSZWdpc3RyYXRpb25E YXRhYmFzZTo6ZGF0YWJhc2VGYWlsZWRUb09wZW4pKTsKICAgICB9KTsK 334047 2018-02-16 09:51:34 -0800 2018-02-16 10:48:36 -0800 Patch bug-182795-20180216095133.patch text/plain 1845 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4NTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmJjZjUyZGY1M2MxYTc1 NmQ2Mjc4MDc5ZmU0OTg1M2RlMzIxNzA4MC4uMjlmMzY4NjU0MWIzODk0OGVhN2JlNzY0YTYzNDJk NjNhZjA2YWVhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTAyLTE2ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBMb2cgdGhlIGVycm9yIG1l c3NhZ2Ugd2hlbiBmYWlsaW5nIHRvIG9wZW4gdGhlIGRhdGFiYXNlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODI3OTUKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzM3NTkyMzk5PgorCisgICAgICAgIFVucmV2aWV3ZWQuCisgICAgICAgIEZpeGluZyBp T1Mgc2ltdWxhdG9yIGRlYnVnIGJ1aWxkLgorCisgICAgICAgICogd29ya2Vycy9zZXJ2aWNlL3Nl cnZlci9SZWdpc3RyYXRpb25EYXRhYmFzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZWdpc3Ry YXRpb25EYXRhYmFzZTo6b3BlblNRTGl0ZURhdGFiYXNlKToKKwogMjAxOC0wMi0xNSAgWW91ZW5u IEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIFJlc291cmNlTG9hZGVy IHRvIGxvYWQgYXBwY2FjaGUgbWFuaWZlc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dv cmtlcnMvc2VydmljZS9zZXJ2ZXIvUmVnaXN0cmF0aW9uRGF0YWJhc2UuY3BwIGIvU291cmNlL1dl YkNvcmUvd29ya2Vycy9zZXJ2aWNlL3NlcnZlci9SZWdpc3RyYXRpb25EYXRhYmFzZS5jcHAKaW5k ZXggMDMyMGRkZDNhNmVlMjc1ZmZjMzViNjkxYmFhYjJiMzJjNTg0YzlmMC4uMDUxY2FkYWI5NGU1 YzU2YjI3MTE3ZTA0MzU2NGFlOGFkNDNkM2ZiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv d29ya2Vycy9zZXJ2aWNlL3NlcnZlci9SZWdpc3RyYXRpb25EYXRhYmFzZS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL3NlcnZlci9SZWdpc3RyYXRpb25EYXRhYmFzZS5j cHAKQEAgLTEwOCw3ICsxMDgsMTMgQEAgdm9pZCBSZWdpc3RyYXRpb25EYXRhYmFzZTo6b3BlblNR TGl0ZURhdGFiYXNlKGNvbnN0IFN0cmluZyYgZnVsbEZpbGVuYW1lKQogICAgIFN0cmluZyBlcnJv ck1lc3NhZ2U7CiAgICAgYXV0byBzY29wZUV4aXQgPSBtYWtlU2NvcGVFeGl0KFsmLCBlcnJvck1l c3NhZ2UgPSAmZXJyb3JNZXNzYWdlXSB7CiAgICAgICAgIEFTU0VSVF9VTlVTRUQoZXJyb3JNZXNz YWdlLCAhZXJyb3JNZXNzYWdlLT5pc051bGwoKSk7CisKKyNpZiBSRUxFQVNFX0xPR19ESVNBQkxF RAorICAgICAgICBMT0dfRVJST1IoU2VydmljZVdvcmtlciwgIkZhaWxlZCB0byBvcGVuIFNlcnZp Y2UgV29ya2VyIHJlZ2lzdHJhdGlvbiBkYXRhYmFzZTogJXMiLCBlcnJvck1lc3NhZ2UtPnV0Zjgo KS5kYXRhKCkpOworI2Vsc2UKICAgICAgICAgUkVMRUFTRV9MT0dfRVJST1IoU2VydmljZVdvcmtl ciwgIkZhaWxlZCB0byBvcGVuIFNlcnZpY2UgV29ya2VyIHJlZ2lzdHJhdGlvbiBkYXRhYmFzZTog JXtwdWJsaWN9cyIsIGVycm9yTWVzc2FnZS0+dXRmOCgpLmRhdGEoKSk7CisjZW5kaWYKKwogICAg ICAgICBtX2RhdGFiYXNlID0gbnVsbHB0cjsKICAgICAgICAgcG9zdFRhc2tSZXBseShjcmVhdGVD cm9zc1RocmVhZFRhc2soKnRoaXMsICZSZWdpc3RyYXRpb25EYXRhYmFzZTo6ZGF0YWJhc2VGYWls ZWRUb09wZW4pKTsKICAgICB9KTsK