182784 2018-02-14 03:09:36 -0800 Fix ReplaceSelectionCommand::InsertedNodes::willRemoveNodePreservingChildren 2018-06-13 23:19:08 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=184884 https://bugs.webkit.org/show_bug.cgi?id=186555 P2 Normal --- 1 fujii fujii cdumez mcatanzaro rniwa wenson_hsieh oldest_to_newest 1399013 0 fujii 2018-02-14 03:09:36 -0800 Fix ReplaceSelectionCommand::InsertedNodes::willRemoveNodePreservingChildren 1399014 1 333780 fujii 2018-02-14 03:10:05 -0800 Created attachment 333780 WIP patch 1399794 2 334004 fujii 2018-02-15 22:33:30 -0800 Created attachment 334004 Patch 1399903 3 334004 mcatanzaro 2018-02-16 09:28:20 -0800 Comment on attachment 334004 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334004&action=review > Source/WebCore/ChangeLog:13 > + No new tests (No behavior change) This is definitely a behavior change... maybe you could explain at a higher-level what you've fixed, why this is correct, and why it's hard to write a test for it. 1400153 4 334004 rniwa 2018-02-16 21:43:28 -0800 Comment on attachment 334004 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334004&action=review >> Source/WebCore/ChangeLog:13 >> + No new tests (No behavior change) > > This is definitely a behavior change... maybe you could explain at a higher-level what you've fixed, why this is correct, and why it's hard to write a test for it. Yes, we definitely need a test. 1432940 5 fujii 2018-06-13 23:19:08 -0700 Fixed in bug 186555. 333780 2018-02-14 03:10:05 -0800 2018-02-15 22:33:25 -0800 WIP patch a.patch text/plain 1160 fujii ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvUmVwbGFjZVNlbGVjdGlvbkNvbW1h bmQuY3BwIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9SZXBsYWNlU2VsZWN0aW9uQ29tbWFuZC5j cHAKaW5kZXggOTNhOGRiMGY3M2UuLjhiZDA0M2Y0OGJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9lZGl0aW5nL1JlcGxhY2VTZWxlY3Rpb25Db21tYW5kLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9lZGl0aW5nL1JlcGxhY2VTZWxlY3Rpb25Db21tYW5kLmNwcApAQCAtMzQzLDEwICszNDMs MTMgQEAgaW5saW5lIHZvaWQgUmVwbGFjZVNlbGVjdGlvbkNvbW1hbmQ6Okluc2VydGVkTm9kZXM6 OnJlc3BvbmRUb05vZGVJbnNlcnRpb24oTm9kZSoKIAogaW5saW5lIHZvaWQgUmVwbGFjZVNlbGVj dGlvbkNvbW1hbmQ6Okluc2VydGVkTm9kZXM6OndpbGxSZW1vdmVOb2RlUHJlc2VydmluZ0NoaWxk cmVuKE5vZGUqIG5vZGUpCiB7Ci0gICAgaWYgKG1fZmlyc3ROb2RlSW5zZXJ0ZWQgPT0gbm9kZSkK KyAgICBpZiAobV9maXJzdE5vZGVJbnNlcnRlZCA9PSBub2RlICYmIG1fbGFzdE5vZGVJbnNlcnRl ZCA9PSBub2RlKSB7CisgICAgICAgIG1fZmlyc3ROb2RlSW5zZXJ0ZWQgPSBub2RlLT5maXJzdENo aWxkKCk7CisgICAgICAgIG1fbGFzdE5vZGVJbnNlcnRlZCA9IG5vZGUtPmxhc3RDaGlsZCgpOwor ICAgIH0gZWxzZSBpZiAobV9maXJzdE5vZGVJbnNlcnRlZCA9PSBub2RlKQogICAgICAgICBtX2Zp cnN0Tm9kZUluc2VydGVkID0gTm9kZVRyYXZlcnNhbDo6bmV4dCgqbm9kZSk7Ci0gICAgaWYgKG1f bGFzdE5vZGVJbnNlcnRlZCA9PSBub2RlKQotICAgICAgICBtX2xhc3ROb2RlSW5zZXJ0ZWQgPSBu b2RlLT5sYXN0Q2hpbGQoKSA/IG5vZGUtPmxhc3RDaGlsZCgpIDogTm9kZVRyYXZlcnNhbDo6bmV4 dFNraXBwaW5nQ2hpbGRyZW4oKm5vZGUpOworICAgIGVsc2UgaWYgKG1fbGFzdE5vZGVJbnNlcnRl ZCA9PSBub2RlKQorICAgICAgICBtX2xhc3ROb2RlSW5zZXJ0ZWQgPSBub2RlLT5sYXN0Q2hpbGQo KSA/IG5vZGUtPmxhc3RDaGlsZCgpIDogbm9kZS0+cHJldmlvdXNTaWJsaW5nKCk7CiB9CiAKIGlu bGluZSB2b2lkIFJlcGxhY2VTZWxlY3Rpb25Db21tYW5kOjpJbnNlcnRlZE5vZGVzOjp3aWxsUmVt b3ZlTm9kZShOb2RlKiBub2RlKQo= 334004 2018-02-15 22:33:30 -0800 2018-02-16 21:43:28 -0800 Patch bug-182784-20180215223313.patch text/plain 2415 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4NTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTlkZDFkZjhlNzJhNzVh YmJmN2YxZTU1ZDIxYzhiM2U2MjQzNzc0Zi4uODUxM2RmNGY4MTYxNDNjZTZlZDg5NjRjOTA4YWUx NTgyMmQyZTYzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE4LTAyLTE1ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIEZpeCBSZXBs YWNlU2VsZWN0aW9uQ29tbWFuZDo6SW5zZXJ0ZWROb2Rlczo6d2lsbFJlbW92ZU5vZGVQcmVzZXJ2 aW5nQ2hpbGRyZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE4Mjc4NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIElmIG1fZmlyc3ROb2RlSW5zZXJ0ZWQgYW5kIG1fbGFzdE5vZGVJbnNlcnRlZCBhcmUgbm9k ZSBhbmQgbm9kZQorICAgICAgICBoYXMgbm8gY2hpbGQsIG1fZmlyc3ROb2RlSW5zZXJ0ZWQgYW5k IG1fbGFzdE5vZGVJbnNlcnRlZCBzaG91bGQKKyAgICAgICAgYmVjb21lIG51bGwuIElmIG1fbGFz dE5vZGVJbnNlcnRlZCBpcyBub2RlIGFuZCBub2RlIGhhcyBubyBjaGlsZCwKKyAgICAgICAgbV9s YXN0Tm9kZUluc2VydGVkIHNob3VsZCBiZWNvbWUgdGhlIHByZXZpb3VzIHNpYmxpbmcgb2Ygbm9k ZS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE5vIGJlaGF2aW9yIGNoYW5nZSkKKworICAgICAg ICAqIGVkaXRpbmcvUmVwbGFjZVNlbGVjdGlvbkNvbW1hbmQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UmVwbGFjZVNlbGVjdGlvbkNvbW1hbmQ6Okluc2VydGVkTm9kZXM6OndpbGxSZW1vdmVOb2Rl UHJlc2VydmluZ0NoaWxkcmVuKToKKwogMjAxOC0wMi0xNSAgWmFsYW4gQnVqdGFzICA8emFsYW5A YXBwbGUuY29tPgogCiAgICAgICAgIFtSZW5kZXJUcmVlQnVpbGRlcl0gcGFyZW50LlJlbmRlcio6 OmFkZENoaWxkKCkgY2xlYW51cApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9S ZXBsYWNlU2VsZWN0aW9uQ29tbWFuZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1JlcGxh Y2VTZWxlY3Rpb25Db21tYW5kLmNwcAppbmRleCAwYmNlZjNmZDNkODMxMzAxMWFhNzE1YmRjYmVk NjcxMTA2Zjg0NmIzLi43MGFhMjY0YTg4Y2Y5ZDJhMDU2NGM2NGMxMzkyZTc4MTMwNzc0NGZlIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1JlcGxhY2VTZWxlY3Rpb25Db21tYW5k LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1JlcGxhY2VTZWxlY3Rpb25Db21tYW5k LmNwcApAQCAtMzQzLDEwICszNDMsMTMgQEAgaW5saW5lIHZvaWQgUmVwbGFjZVNlbGVjdGlvbkNv bW1hbmQ6Okluc2VydGVkTm9kZXM6OnJlc3BvbmRUb05vZGVJbnNlcnRpb24oTm9kZSoKIAogaW5s aW5lIHZvaWQgUmVwbGFjZVNlbGVjdGlvbkNvbW1hbmQ6Okluc2VydGVkTm9kZXM6OndpbGxSZW1v dmVOb2RlUHJlc2VydmluZ0NoaWxkcmVuKE5vZGUqIG5vZGUpCiB7Ci0gICAgaWYgKG1fZmlyc3RO b2RlSW5zZXJ0ZWQgPT0gbm9kZSkKLSAgICAgICAgbV9maXJzdE5vZGVJbnNlcnRlZCA9IE5vZGVU cmF2ZXJzYWw6Om5leHQoKm5vZGUpOwotICAgIGlmIChtX2xhc3ROb2RlSW5zZXJ0ZWQgPT0gbm9k ZSkKLSAgICAgICAgbV9sYXN0Tm9kZUluc2VydGVkID0gbm9kZS0+bGFzdENoaWxkKCkgPyBub2Rl LT5sYXN0Q2hpbGQoKSA6IE5vZGVUcmF2ZXJzYWw6Om5leHRTa2lwcGluZ0NoaWxkcmVuKCpub2Rl KTsKKyAgICBpZiAobV9maXJzdE5vZGVJbnNlcnRlZCA9PSBub2RlICYmIG1fbGFzdE5vZGVJbnNl cnRlZCA9PSBub2RlKSB7CisgICAgICAgIG1fZmlyc3ROb2RlSW5zZXJ0ZWQgPSBub2RlLT5maXJz dENoaWxkKCk7CisgICAgICAgIG1fbGFzdE5vZGVJbnNlcnRlZCA9IG5vZGUtPmxhc3RDaGlsZCgp OworICAgIH0gZWxzZSBpZiAobV9maXJzdE5vZGVJbnNlcnRlZCA9PSBub2RlKQorICAgICAgICBt X2ZpcnN0Tm9kZUluc2VydGVkID0gbm9kZS0+Zmlyc3RDaGlsZCgpID8gbm9kZS0+Zmlyc3RDaGls ZCgpIDogbm9kZS0+bmV4dFNpYmxpbmcoKTsKKyAgICBlbHNlIGlmIChtX2xhc3ROb2RlSW5zZXJ0 ZWQgPT0gbm9kZSkKKyAgICAgICAgbV9sYXN0Tm9kZUluc2VydGVkID0gbm9kZS0+bGFzdENoaWxk KCkgPyBub2RlLT5sYXN0Q2hpbGQoKSA6IG5vZGUtPnByZXZpb3VzU2libGluZygpOwogfQogCiBp bmxpbmUgdm9pZCBSZXBsYWNlU2VsZWN0aW9uQ29tbWFuZDo6SW5zZXJ0ZWROb2Rlczo6d2lsbFJl bW92ZU5vZGUoTm9kZSogbm9kZSkK