182742 2018-02-13 13:07:21 -0800 Web Automation: don't return an error if resizing/moving a window has no effect 2018-02-13 14:37:19 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg cgarcia commit-queue joepeck thorton webkit-bug-importer oldest_to_newest 1398738 0 bburg 2018-02-13 13:07:21 -0800 The specification has no such demands, and it just causes tests to fail unnecessarily. Remove the error case. 1398758 1 333721 bburg 2018-02-13 13:52:59 -0800 Created attachment 333721 Proposed Fix 1398762 2 333721 thorton 2018-02-13 13:59:16 -0800 Comment on attachment 333721 Proposed Fix What's the testing story? I would have expected the original code to come with a test, but I don't see you removing one? 1398771 3 bburg 2018-02-13 14:21:14 -0800 (In reply to Tim Horton from comment #2) > Comment on attachment 333721 [details] > Proposed Fix > > What's the testing story? I would have expected the original code to come > with a test, but I don't see you removing one? The Set Window Rect W3C endpoint for safaridriver is blocked by other reviews, but once it's hooked up, I hit this in my branch while running conformance tests. It expects setting window rect to be idempotent without error if you get the window frame then set the window frame to the same rect. https://github.com/w3c/web-platform-tests/blob/master/webdriver/tests/set_window_rect.py#L261 1398778 4 333721 commit-queue 2018-02-13 14:36:20 -0800 Comment on attachment 333721 Proposed Fix Clearing flags on attachment: 333721 Committed r228434: <https://trac.webkit.org/changeset/228434> 1398779 5 commit-queue 2018-02-13 14:36:21 -0800 All reviewed patches have been landed. Closing bug. 1398782 6 webkit-bug-importer 2018-02-13 14:37:19 -0800 <rdar://problem/37513710> 333721 2018-02-13 13:52:59 -0800 2018-02-13 14:36:20 -0800 Proposed Fix bug-182742-20180213135258.patch text/plain 3130 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4Mzg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGVhMmY3ZGMzYWJiOGM4NmMy ZDM0ZDVmOGJlMjNmYWVjMzYyYzJlZWYuLmZkZjc4OWJkNTA2Nzk5NTM3MGY2ZTJmYzA3ZTQxZmIx NmM5MDYwZGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDItMTMgIEJyaWFuIEJ1 cmcgIDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEF1dG9tYXRpb246IGRvbid0IHJl dHVybiBhbiBlcnJvciBpZiByZXNpemluZy9tb3ZpbmcgYSB3aW5kb3cgaGFzIG5vIGVmZmVjdAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyNzQyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nl c3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvbi5jcHA6CisgICAgICAgIChXZWJLaXQ6 OldlYkF1dG9tYXRpb25TZXNzaW9uOjpyZXNpemVXaW5kb3dPZkJyb3dzaW5nQ29udGV4dCk6Cisg ICAgICAgIChXZWJLaXQ6OldlYkF1dG9tYXRpb25TZXNzaW9uOjptb3ZlV2luZG93T2ZCcm93c2lu Z0NvbnRleHQpOgorICAgICAgICBVbmlmeSB0aGUgYmVoYXZpb3IgZm9yIGFsbCBwb3J0cy4gRG9u J3QgcmFpc2UgYW4gZXJyb3IgaWYgdGhlIGNvbW1hbmQgd2FzCisgICAgICAgIGlkZW1wb3RlbnQg KGJ5IG1pc3Rha2Ugb3Igbm90KS4gSXQgc2hvdWxkIG5vdCBiZSBhbiBlcnJvciB0byByZS1tYXhp bWl6ZSBhIHdpbmRvdy4KKwogMjAxOC0wMi0wOSAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNv bT4KIAogICAgICAgICBbQ29jb2FdIFdlYiBBdXRvbWF0aW9uOiBwcm92aWRlIGEgd2F5IHRvIGFz ayBjbGllbnRzIHRoZSB0eXBlIG9mIGEgSmF2YVNjcmlwdCBkaWFsb2cKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0F1dG9tYXRpb24vV2ViQXV0b21hdGlvblNlc3Npb24uY3Bw IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lv bi5jcHAKaW5kZXggNjJlYjQyNjVhZDIzZWJkMjljNTM2MjA0MjhlNmQyYTcwOTM2NTE1Ni4uMTM2 NTk0YTMyZmE0MDZhM2I3NWUwMGM1ODgzNjg4ZGU5NDBiN2RjMCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvbi5jcHAKKysr IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lv bi5jcHAKQEAgLTM0NCwxOSArMzQ0LDcgQEAgdm9pZCBXZWJBdXRvbWF0aW9uU2Vzc2lvbjo6cmVz aXplV2luZG93T2ZCcm93c2luZ0NvbnRleHQoSW5zcGVjdG9yOjpFcnJvclN0cmluZyYKICAgICAg ICAgICAgIHJldHVybiBjYWxsYmFjay0+c2VuZFN1Y2Nlc3MoKTsKIAogICAgICAgICBwYWdlLT5z ZXRXaW5kb3dGcmFtZShuZXdGcmFtZSk7Ci0KLSNpZiBQTEFURk9STShHVEspCiAgICAgICAgIGNh bGxiYWNrLT5zZW5kU3VjY2VzcygpOwotI2Vsc2UKLSAgICAgICAgLy8gSWYgbm90aGluZyBjaGFu Z2VkIGF0IGFsbCwgaXQncyBwcm9iYWJseSBmYWlyIHRvIHJlcG9ydCB0aGF0IHNvbWV0aGluZyB3 ZW50IHdyb25nLgotICAgICAgICAvLyAoV2UgY2FuJ3QgYXNzdW1lIHRoYXQgdGhlIHJlcXVlc3Rl ZCBmcmFtZSBzaXplIHdpbGwgYmUgaG9ub3JlZCBleGFjdGx5LCBob3dldmVyLikKLSAgICAgICAg cGFnZS0+Z2V0V2luZG93RnJhbWVXaXRoQ2FsbGJhY2soW2NhbGxiYWNrID0gV1RGTW92ZShjYWxs YmFjayksIG9yaWdpbmFsRnJhbWVdKFdlYkNvcmU6OkZsb2F0UmVjdCB1cGRhdGVkRnJhbWUpIHsK LSAgICAgICAgICAgIGlmIChvcmlnaW5hbEZyYW1lID09IHVwZGF0ZWRGcmFtZSkKLSAgICAgICAg ICAgICAgICBjYWxsYmFjay0+c2VuZEZhaWx1cmUoU1RSSU5HX0ZPUl9QUkVERUZJTkVEX0VSUk9S X05BTUVfQU5EX0RFVEFJTFMoSW50ZXJuYWxFcnJvciwgIlRoZSB3aW5kb3cgc2l6ZSB3YXMgZXhw ZWN0ZWQgdG8gaGF2ZSBjaGFuZ2VkLCBidXQgZGlkIG5vdC4iKSk7Ci0gICAgICAgICAgICBlbHNl Ci0gICAgICAgICAgICAgICAgY2FsbGJhY2stPnNlbmRTdWNjZXNzKCk7Ci0gICAgICAgIH0pOwot I2VuZGlmCiAgICAgfSk7CiAjZW5kaWYKIH0KQEAgLTM5MiwxOSArMzgwLDcgQEAgdm9pZCBXZWJB dXRvbWF0aW9uU2Vzc2lvbjo6bW92ZVdpbmRvd09mQnJvd3NpbmdDb250ZXh0KEluc3BlY3Rvcjo6 RXJyb3JTdHJpbmcmIGUKICAgICAgICAgICAgIHJldHVybiBjYWxsYmFjay0+c2VuZFN1Y2Nlc3Mo KTsKIAogICAgICAgICBwYWdlLT5zZXRXaW5kb3dGcmFtZShuZXdGcmFtZSk7Ci0KLSNpZiBQTEFU Rk9STShHVEspCiAgICAgICAgIGNhbGxiYWNrLT5zZW5kU3VjY2VzcygpOwotI2Vsc2UKLSAgICAg ICAgLy8gSWYgbm90aGluZyBjaGFuZ2VkIGF0IGFsbCwgaXQncyBwcm9iYWJseSBmYWlyIHRvIHJl cG9ydCB0aGF0IHNvbWV0aGluZyB3ZW50IHdyb25nLgotICAgICAgICAvLyAoV2UgY2FuJ3QgYXNz dW1lIHRoYXQgdGhlIHJlcXVlc3RlZCBmcmFtZSBzaXplIHdpbGwgYmUgaG9ub3JlZCBleGFjdGx5 LCBob3dldmVyLikKLSAgICAgICAgcGFnZS0+Z2V0V2luZG93RnJhbWVXaXRoQ2FsbGJhY2soW2Nh bGxiYWNrID0gV1RGTW92ZShjYWxsYmFjayksIG9yaWdpbmFsRnJhbWVdKFdlYkNvcmU6OkZsb2F0 UmVjdCB1cGRhdGVkRnJhbWUpIHsKLSAgICAgICAgICAgIGlmIChvcmlnaW5hbEZyYW1lID09IHVw ZGF0ZWRGcmFtZSkKLSAgICAgICAgICAgICAgICBjYWxsYmFjay0+c2VuZEZhaWx1cmUoU1RSSU5H X0ZPUl9QUkVERUZJTkVEX0VSUk9SX05BTUVfQU5EX0RFVEFJTFMoSW50ZXJuYWxFcnJvciwgIlRo ZSB3aW5kb3cgcG9zaXRpb24gd2FzIGV4cGVjdGVkIHRvIGhhdmUgY2hhbmdlZCwgYnV0IGRpZCBu b3QuIikpOwotICAgICAgICAgICAgZWxzZQotICAgICAgICAgICAgICAgIGNhbGxiYWNrLT5zZW5k U3VjY2VzcygpOwotICAgICAgICB9KTsKLSNlbmRpZgogICAgIH0pOwogI2VuZGlmCiB9Cg==