182740 2018-02-13 12:26:58 -0800 [GTK][WPE] Fullscreen video is broken 2018-02-18 23:49:22 -0800 1 1 1 Unclassified WebKit Media Other PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro pnormand magomez mcatanzaro Ms2ger pnormand webkit-bug-importer oldest_to_newest 1398723 0 mcatanzaro 2018-02-13 12:26:58 -0800 Load https://bug791090.bugzilla-attachments.gnome.org/attachment.cgi?id=368326 Try to click the fullscreen icon, or right click and "switch video to fullscreen". Nothing happens. This is using 2.19.90. 1399455 1 pnormand 2018-02-15 07:39:04 -0800 ENABLE(VIDEO_USES_ELEMENT_FULLSCREEN) is not enabled and should be enabled for the GTK and WPE ports. What's the best way to enable it? 1399511 2 mcatanzaro 2018-02-15 10:40:31 -0800 Add it to WebKitFeatures.cmake, default to ON, and add a WEBKIT_OPTION_DEPEND to make it depend on ENABLE_VIDEO. 1399842 3 334022 pnormand 2018-02-16 01:18:46 -0800 Created attachment 334022 Patch 1399843 4 334023 pnormand 2018-02-16 01:19:30 -0800 Created attachment 334023 Patch 1399852 5 334029 pnormand 2018-02-16 02:42:05 -0800 Created attachment 334029 Patch 1399902 6 334029 mcatanzaro 2018-02-16 09:25:37 -0800 Comment on attachment 334029 Patch My question is: for how long has this been broken? Surely it used to work...? 1400040 7 pnormand 2018-02-16 14:45:33 -0800 It's been broken for 3 months. See also https://bugs.webkit.org/show_bug.cgi?id=179721 1400270 8 pnormand 2018-02-18 23:44:01 -0800 *** Bug 182109 has been marked as a duplicate of this bug. *** 1400272 9 pnormand 2018-02-18 23:44:12 -0800 *** Bug 179721 has been marked as a duplicate of this bug. *** 1400273 10 pnormand 2018-02-18 23:48:04 -0800 https://trac.webkit.org/changeset/228608/webkit 1400274 11 webkit-bug-importer 2018-02-18 23:49:22 -0800 <rdar://problem/37662566> 334022 2018-02-16 01:18:46 -0800 2018-02-16 01:19:26 -0800 Patch bug-182740-20180216091844.patch text/plain 2077 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4NTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKaW5k ZXggNTdhMGU1MmU3YmVhZTk3YWEwYTgyZGMzYjM2NDM0NTdhNGQ2MGRjMy4uZDcyMDljNDgwOWIw OWVjMDU0ZWNjMDk1N2FjNjAxMzNkYjM3MzI1YSAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dl YktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFr ZQpAQCAtMTcyLDYgKzE3Miw3IEBAIG1hY3JvKFdFQktJVF9PUFRJT05fQkVHSU4pCiAgICAgV0VC S0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX1VTRVJfTUVTU0FHRV9IQU5ETEVSUyAiVG9nZ2xlIHVz ZXIgc2NyaXB0IG1lc3NhZ2UgaGFuZGxlciBzdXBwb3J0IiBQUklWQVRFIE9OKQogICAgIFdFQktJ VF9PUFRJT05fREVGSU5FKEVOQUJMRV9WSURFTyAiVG9nZ2xlIFZpZGVvIHN1cHBvcnQiIFBSSVZB VEUgT04pCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX1ZJREVPX1RSQUNLICJUb2dn bGUgVHJhY2sgc3VwcG9ydCBmb3IgSFRNTDUgdmlkZW8iIFBSSVZBVEUgT04pCisgICAgV0VCS0lU X09QVElPTl9ERUZJTkUoRU5BQkxFX1ZJREVPX1VTRVNfRUxFTUVOVF9GVUxMU0NSRUVOLCAiVG9n Z2xlIHZpZGVvIGVsZW1lbnQgZnVsbHNjcmVlbiBzdXBwb3J0IiBQUklWQVRFIE9OKQogICAgIFdF QktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9XRUJBU1NFTUJMWSAiVG9nZ2xlIFdlYkFzc2VtYmx5 IHN1cHBvcnQiIFBSSVZBVEUgJHtFTkFCTEVfRlRMX0RFRkFVTFR9KQogICAgIFdFQktJVF9PUFRJ T05fREVGSU5FKEVOQUJMRV9XRUJEUklWRVIgIldoZXRoZXIgdG8gZW5hYmxlIHRoZSBXZWJEcml2 ZXIgc2VydmljZSBwcm9jZXNzIiBQUklWQVRFIE9GRikKICAgICBXRUJLSVRfT1BUSU9OX0RFRklO RShFTkFCTEVfV0VCR0wgIlRvZ2dsZSBXZWJHTCBzdXBwb3J0IiBQUklWQVRFIE9OKQpAQCAtMTk2 LDYgKzE5Nyw3IEBAIG1hY3JvKFdFQktJVF9PUFRJT05fQkVHSU4pCiAgICAgV0VCS0lUX09QVElP Tl9ERVBFTkQoRU5BQkxFX01FRElBX1NPVVJDRSBFTkFCTEVfVklERU8pCiAgICAgV0VCS0lUX09Q VElPTl9ERVBFTkQoRU5BQkxFX01FRElBX1NUUkVBTSBFTkFCTEVfVklERU8pCiAgICAgV0VCS0lU X09QVElPTl9ERVBFTkQoRU5BQkxFX1ZJREVPX1RSQUNLIEVOQUJMRV9WSURFTykKKyAgICBXRUJL SVRfT1BUSU9OX0RFUEVORChWSURFT19VU0VTX0VMRU1FTlRfRlVMTFNDUkVFTiwgRU5BQkxFX1ZJ REVPKQogICAgIFdFQktJVF9PUFRJT05fREVQRU5EKEVOQUJMRV9UT1VDSF9TTElERVIgRU5BQkxF X1RPVUNIX0VWRU5UUykKICAgICBXRUJLSVRfT1BUSU9OX0RFUEVORChFTkFCTEVfU1VCVExFX0NS WVBUTyBFTkFCTEVfV0VCX0NSWVBUTykKIGVuZG1hY3JvKCkKZGlmZiAtLWdpdCBhL0NoYW5nZUxv ZyBiL0NoYW5nZUxvZwppbmRleCA3YmRjODkyMWJjYTg0NWRmNzNjZmMyMmM5OGFmMGU5OTFjZGM1 NWE4Li5iM2IxNGI1Mjg4ZDkzMTk0OWVmNzA2ZmVmZGQyYmExNGRiNTc0MDZlIDEwMDY0NAotLS0g YS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMDItMTYg IFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtd W1dQRV0gRnVsbHNjcmVlbiB2aWRlbyBpcyBicm9rZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4Mjc0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL2NtYWtlL1dlYktpdEZlYXR1cmVzLmNt YWtlOiBFbmFibGUgdGhlCisgICAgICAgIFZJREVPX1VTRVNfRUxFTUVOVF9GVUxMU0NSRUVOIGZl YXR1cmUgb24gQ01ha2UgcG9ydHMuCisKIDIwMTgtMDItMDkgIFJvc3MgS2lyc2xpbmcgIDxyb3Nz LmtpcnNsaW5nQHNvbnkuY29tPgogCiAgICAgICAgIFNpbXBsaWZ5IC5naXRpZ25vcmUncyBXZWJL aXRMaWJyYXJpZXMvd2luIHNlY3Rpb24uCg== 334023 2018-02-16 01:19:30 -0800 2018-02-16 02:42:01 -0800 Patch bug-182740-20180216091928.patch text/plain 2084 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4NTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKaW5k ZXggNTdhMGU1MmU3YmVhZTk3YWEwYTgyZGMzYjM2NDM0NTdhNGQ2MGRjMy4uNTMzNDQxNTBjMTE0 MjczYjAzN2YyZmNhNTY5MTE3ZTcyNTU4MTcxZCAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dl YktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFr ZQpAQCAtMTcyLDYgKzE3Miw3IEBAIG1hY3JvKFdFQktJVF9PUFRJT05fQkVHSU4pCiAgICAgV0VC S0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX1VTRVJfTUVTU0FHRV9IQU5ETEVSUyAiVG9nZ2xlIHVz ZXIgc2NyaXB0IG1lc3NhZ2UgaGFuZGxlciBzdXBwb3J0IiBQUklWQVRFIE9OKQogICAgIFdFQktJ VF9PUFRJT05fREVGSU5FKEVOQUJMRV9WSURFTyAiVG9nZ2xlIFZpZGVvIHN1cHBvcnQiIFBSSVZB VEUgT04pCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX1ZJREVPX1RSQUNLICJUb2dn bGUgVHJhY2sgc3VwcG9ydCBmb3IgSFRNTDUgdmlkZW8iIFBSSVZBVEUgT04pCisgICAgV0VCS0lU X09QVElPTl9ERUZJTkUoRU5BQkxFX1ZJREVPX1VTRVNfRUxFTUVOVF9GVUxMU0NSRUVOLCAiVG9n Z2xlIHZpZGVvIGVsZW1lbnQgZnVsbHNjcmVlbiBzdXBwb3J0IiBQUklWQVRFIE9OKQogICAgIFdF QktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9XRUJBU1NFTUJMWSAiVG9nZ2xlIFdlYkFzc2VtYmx5 IHN1cHBvcnQiIFBSSVZBVEUgJHtFTkFCTEVfRlRMX0RFRkFVTFR9KQogICAgIFdFQktJVF9PUFRJ T05fREVGSU5FKEVOQUJMRV9XRUJEUklWRVIgIldoZXRoZXIgdG8gZW5hYmxlIHRoZSBXZWJEcml2 ZXIgc2VydmljZSBwcm9jZXNzIiBQUklWQVRFIE9GRikKICAgICBXRUJLSVRfT1BUSU9OX0RFRklO RShFTkFCTEVfV0VCR0wgIlRvZ2dsZSBXZWJHTCBzdXBwb3J0IiBQUklWQVRFIE9OKQpAQCAtMTk2 LDYgKzE5Nyw3IEBAIG1hY3JvKFdFQktJVF9PUFRJT05fQkVHSU4pCiAgICAgV0VCS0lUX09QVElP Tl9ERVBFTkQoRU5BQkxFX01FRElBX1NPVVJDRSBFTkFCTEVfVklERU8pCiAgICAgV0VCS0lUX09Q VElPTl9ERVBFTkQoRU5BQkxFX01FRElBX1NUUkVBTSBFTkFCTEVfVklERU8pCiAgICAgV0VCS0lU X09QVElPTl9ERVBFTkQoRU5BQkxFX1ZJREVPX1RSQUNLIEVOQUJMRV9WSURFTykKKyAgICBXRUJL SVRfT1BUSU9OX0RFUEVORChFTkFCTEVfVklERU9fVVNFU19FTEVNRU5UX0ZVTExTQ1JFRU4sIEVO QUJMRV9WSURFTykKICAgICBXRUJLSVRfT1BUSU9OX0RFUEVORChFTkFCTEVfVE9VQ0hfU0xJREVS IEVOQUJMRV9UT1VDSF9FVkVOVFMpCiAgICAgV0VCS0lUX09QVElPTl9ERVBFTkQoRU5BQkxFX1NV QlRMRV9DUllQVE8gRU5BQkxFX1dFQl9DUllQVE8pCiBlbmRtYWNybygpCmRpZmYgLS1naXQgYS9D aGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggN2JkYzg5MjFiY2E4NDVkZjczY2ZjMjJjOThhZjBl OTkxY2RjNTVhOC4uYjNiMTRiNTI4OGQ5MzE5NDllZjcwNmZlZmRkMmJhMTRkYjU3NDA2ZSAxMDA2 NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE4 LTAyLTE2ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAg ICBbR1RLXVtXUEVdIEZ1bGxzY3JlZW4gdmlkZW8gaXMgYnJva2VuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODI3NDAKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRGZWF0 dXJlcy5jbWFrZTogRW5hYmxlIHRoZQorICAgICAgICBWSURFT19VU0VTX0VMRU1FTlRfRlVMTFND UkVFTiBmZWF0dXJlIG9uIENNYWtlIHBvcnRzLgorCiAyMDE4LTAyLTA5ICBSb3NzIEtpcnNsaW5n ICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4KIAogICAgICAgICBTaW1wbGlmeSAuZ2l0aWdub3Jl J3MgV2ViS2l0TGlicmFyaWVzL3dpbiBzZWN0aW9uLgo= 334029 2018-02-16 02:42:05 -0800 2018-02-16 09:25:37 -0800 Patch bug-182740-20180216104204.patch text/plain 2082 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4NTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKaW5k ZXggNTdhMGU1MmU3YmVhZTk3YWEwYTgyZGMzYjM2NDM0NTdhNGQ2MGRjMy4uZTZhMDJhZTVkNDFj ZWUwZjU5NWJjZmNlNzE0M2Q3NmJiNTYzZTFkNSAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dl YktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFr ZQpAQCAtMTcyLDYgKzE3Miw3IEBAIG1hY3JvKFdFQktJVF9PUFRJT05fQkVHSU4pCiAgICAgV0VC S0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX1VTRVJfTUVTU0FHRV9IQU5ETEVSUyAiVG9nZ2xlIHVz ZXIgc2NyaXB0IG1lc3NhZ2UgaGFuZGxlciBzdXBwb3J0IiBQUklWQVRFIE9OKQogICAgIFdFQktJ VF9PUFRJT05fREVGSU5FKEVOQUJMRV9WSURFTyAiVG9nZ2xlIFZpZGVvIHN1cHBvcnQiIFBSSVZB VEUgT04pCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX1ZJREVPX1RSQUNLICJUb2dn bGUgVHJhY2sgc3VwcG9ydCBmb3IgSFRNTDUgdmlkZW8iIFBSSVZBVEUgT04pCisgICAgV0VCS0lU X09QVElPTl9ERUZJTkUoRU5BQkxFX1ZJREVPX1VTRVNfRUxFTUVOVF9GVUxMU0NSRUVOICJUb2dn bGUgdmlkZW8gZWxlbWVudCBmdWxsc2NyZWVuIHN1cHBvcnQiIFBSSVZBVEUgT04pCiAgICAgV0VC S0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX1dFQkFTU0VNQkxZICJUb2dnbGUgV2ViQXNzZW1ibHkg c3VwcG9ydCIgUFJJVkFURSAke0VOQUJMRV9GVExfREVGQVVMVH0pCiAgICAgV0VCS0lUX09QVElP Tl9ERUZJTkUoRU5BQkxFX1dFQkRSSVZFUiAiV2hldGhlciB0byBlbmFibGUgdGhlIFdlYkRyaXZl ciBzZXJ2aWNlIHByb2Nlc3MiIFBSSVZBVEUgT0ZGKQogICAgIFdFQktJVF9PUFRJT05fREVGSU5F KEVOQUJMRV9XRUJHTCAiVG9nZ2xlIFdlYkdMIHN1cHBvcnQiIFBSSVZBVEUgT04pCkBAIC0xOTYs NiArMTk3LDcgQEAgbWFjcm8oV0VCS0lUX09QVElPTl9CRUdJTikKICAgICBXRUJLSVRfT1BUSU9O X0RFUEVORChFTkFCTEVfTUVESUFfU09VUkNFIEVOQUJMRV9WSURFTykKICAgICBXRUJLSVRfT1BU SU9OX0RFUEVORChFTkFCTEVfTUVESUFfU1RSRUFNIEVOQUJMRV9WSURFTykKICAgICBXRUJLSVRf T1BUSU9OX0RFUEVORChFTkFCTEVfVklERU9fVFJBQ0sgRU5BQkxFX1ZJREVPKQorICAgIFdFQktJ VF9PUFRJT05fREVQRU5EKEVOQUJMRV9WSURFT19VU0VTX0VMRU1FTlRfRlVMTFNDUkVFTiBFTkFC TEVfVklERU8pCiAgICAgV0VCS0lUX09QVElPTl9ERVBFTkQoRU5BQkxFX1RPVUNIX1NMSURFUiBF TkFCTEVfVE9VQ0hfRVZFTlRTKQogICAgIFdFQktJVF9PUFRJT05fREVQRU5EKEVOQUJMRV9TVUJU TEVfQ1JZUFRPIEVOQUJMRV9XRUJfQ1JZUFRPKQogZW5kbWFjcm8oKQpkaWZmIC0tZ2l0IGEvQ2hh bmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDdiZGM4OTIxYmNhODQ1ZGY3M2NmYzIyYzk4YWYwZTk5 MWNkYzU1YTguLmIzYjE0YjUyODhkOTMxOTQ5ZWY3MDZmZWZkZDJiYTE0ZGI1NzQwNmUgMTAwNjQ0 Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxOC0w Mi0xNiAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAg W0dUS11bV1BFXSBGdWxsc2NyZWVuIHZpZGVvIGlzIGJyb2tlbgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyNzQwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVy ZXMuY21ha2U6IEVuYWJsZSB0aGUKKyAgICAgICAgVklERU9fVVNFU19FTEVNRU5UX0ZVTExTQ1JF RU4gZmVhdHVyZSBvbiBDTWFrZSBwb3J0cy4KKwogMjAxOC0wMi0wOSAgUm9zcyBLaXJzbGluZyAg PHJvc3Mua2lyc2xpbmdAc29ueS5jb20+CiAKICAgICAgICAgU2ltcGxpZnkgLmdpdGlnbm9yZSdz IFdlYktpdExpYnJhcmllcy93aW4gc2VjdGlvbi4K