182706 2018-02-12 14:02:35 -0800 DFG::emitCodeToGetArgumentsArrayLength needs to handle NewArrayBuffer/PhantomNewArrayBuffer 2018-02-12 22:27:52 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff rmorisset ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1398459 0 saam 2018-02-12 14:02:35 -0800 We didn't have code for this. 1398460 1 saam 2018-02-12 14:03:20 -0800 <rdar://problem/36833681> 1398467 2 333631 saam 2018-02-12 14:10:18 -0800 Created attachment 333631 patch 1398509 3 333631 commit-queue 2018-02-12 15:41:22 -0800 Comment on attachment 333631 patch Clearing flags on attachment: 333631 Committed r228401: <https://trac.webkit.org/changeset/228401> 1398510 4 commit-queue 2018-02-12 15:41:23 -0800 All reviewed patches have been landed. Closing bug. 1398612 5 ysuzuki 2018-02-12 22:26:52 -0800 Thank you for fixing this 1398613 6 saam 2018-02-12 22:27:52 -0800 (In reply to Yusuke Suzuki from comment #5) > Thank you for fixing this 👍🏼 333631 2018-02-12 14:10:18 -0800 2018-02-12 15:41:22 -0800 patch c-backup.diff text/plain 3653 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMjgzOTIpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE1IEBACisyMDE4LTAyLTEyICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIERGRzo6ZW1pdENvZGVUb0dldEFyZ3VtZW50c0FycmF5TGVuZ3RoIG5l ZWRzIHRvIGhhbmRsZSBOZXdBcnJheUJ1ZmZlci9QaGFudG9tTmV3QXJyYXlCdWZmZXIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjcwNgorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMzY4MzM2ODE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvZ2V0LWFycmF5LWxlbmd0aC1waGFudG9tLW5l dy1hcnJheS1idWZmZXIuanM6IEFkZGVkLgorICAgICAgICAoZWZmZWN0cyk6CisgICAgICAgIChm b28pOgorCiAyMDE4LTAyLTA5ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAg ICAgICAgRG9uJ3Qgd2FzdGUgbWVtb3J5IGZvciBlcnJvci5zdGFjawpJbmRleDogSlNUZXN0cy9z dHJlc3MvZ2V0LWFycmF5LWxlbmd0aC1waGFudG9tLW5ldy1hcnJheS1idWZmZXIuanMKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gSlNUZXN0cy9zdHJlc3MvZ2V0LWFycmF5LWxlbmd0aC1waGFudG9tLW5ldy1hcnJh eS1idWZmZXIuanMJKG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy9zdHJlc3MvZ2V0LWFycmF5LWxl bmd0aC1waGFudG9tLW5ldy1hcnJheS1idWZmZXIuanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCAr MSwxNCBAQAorZnVuY3Rpb24gZWZmZWN0cygpIHt9Citub0lubGluZShlZmZlY3RzKTsKKworZnVu Y3Rpb24gZm9vKCkgeworICAgIGxldCB4ID0gWzEsMiwzXTsKKyAgICBlZmZlY3RzKCk7CisgICAg cmV0dXJuIHgubGVuZ3RoOworfQorbm9JbmxpbmUoZm9vKTsKKworZm9yIChsZXQgaSA9IDA7IGkg PCAxMDAwMDA7ICsraSkgeworICAgIGlmIChmb28oKSAhPT0gMykKKyAgICAgICAgdGhyb3cgbmV3 IEVycm9yKCk7Cit9CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyODM5 MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAg LTEsMyArMSwyMCBAQAorMjAxOC0wMi0xMiAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNv bT4KKworICAgICAgICBERkc6OmVtaXRDb2RlVG9HZXRBcmd1bWVudHNBcnJheUxlbmd0aCBuZWVk cyB0byBoYW5kbGUgTmV3QXJyYXlCdWZmZXIvUGhhbnRvbU5ld0FycmF5QnVmZmVyCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODI3MDYKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzM2ODMzNjgxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdoZW4gd2UgYWRkZWQgc3VwcG9ydCBmb3IgUGhhbnRvbU5ld0Fy cmF5QnVmZmVyLCB3ZSBmb3Jnb3QgdG8gdXBkYXRlCisgICAgICAgIHRoZSBlbWl0Q29kZVRvR2V0 QXJndW1lbnRzQXJyYXlMZW5ndGggZnVuY3Rpb24gdG8gaGFuZGxlIFBoYW50b21OZXdBcnJheUJ1 ZmZlci4KKyAgICAgICAgVGhpcyBwYXRjaCBhZGRzIHRoYXQgc3VwcG9ydC4gSXQncyB0cml2aWFs IHRvIGdlbmVyYXRlIHRoZSBsZW5ndGggZm9yCisgICAgICAgIGEgUGhhbnRvbU5ld0FycmF5QnVm ZmVyIG5vZGUgc2luY2UgaXQncyBhIGNvbnN0YW50IGJ1ZmZlciwgd2l0aCBhIGNvbnN0YW50Cisg ICAgICAgIGxlbmd0aC4KKworICAgICAgICAqIGRmZy9ERkdBcmd1bWVudHNVdGlsaXRpZXMuY3Bw OgorICAgICAgICAoSlNDOjpERkc6OmVtaXRDb2RlVG9HZXRBcmd1bWVudHNBcnJheUxlbmd0aCk6 CisKIDIwMTgtMDItMTIgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAg IEZpeCBtaXNzaW5nIGV4Y2VwdGlvbiBjaGVjayBpbiBSZWdFeHBPYmplY3Q6Om1hdGNoR2xvYmFs KCkuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0FyZ3VtZW50c1V0aWxpdGll cy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBcmd1bWVu dHNVdGlsaXRpZXMuY3BwCShyZXZpc2lvbiAyMjgzOTApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvZGZnL0RGR0FyZ3VtZW50c1V0aWxpdGllcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY1LDkg KzY1LDE1IEBAIE5vZGUqIGVtaXRDb2RlVG9HZXRBcmd1bWVudHNBcnJheUxlbmd0aCgKICAgICBE RkdfQVNTRVJUKAogICAgICAgICBncmFwaCwgYXJndW1lbnRzLAogICAgICAgICBhcmd1bWVudHMt Pm9wKCkgPT0gQ3JlYXRlRGlyZWN0QXJndW1lbnRzIHx8IGFyZ3VtZW50cy0+b3AoKSA9PSBDcmVh dGVTY29wZWRBcmd1bWVudHMKLSAgICAgICAgfHwgYXJndW1lbnRzLT5vcCgpID09IENyZWF0ZUNs b25lZEFyZ3VtZW50cyB8fCBhcmd1bWVudHMtPm9wKCkgPT0gQ3JlYXRlUmVzdAotICAgICAgICB8 fCBhcmd1bWVudHMtPm9wKCkgPT0gUGhhbnRvbURpcmVjdEFyZ3VtZW50cyB8fCBhcmd1bWVudHMt Pm9wKCkgPT0gUGhhbnRvbUNsb25lZEFyZ3VtZW50cyB8fCBhcmd1bWVudHMtPm9wKCkgPT0gUGhh bnRvbUNyZWF0ZVJlc3QsCisgICAgICAgIHx8IGFyZ3VtZW50cy0+b3AoKSA9PSBDcmVhdGVDbG9u ZWRBcmd1bWVudHMgfHwgYXJndW1lbnRzLT5vcCgpID09IENyZWF0ZVJlc3QgfHwgYXJndW1lbnRz LT5vcCgpID09IE5ld0FycmF5QnVmZmVyCisgICAgICAgIHx8IGFyZ3VtZW50cy0+b3AoKSA9PSBQ aGFudG9tRGlyZWN0QXJndW1lbnRzIHx8IGFyZ3VtZW50cy0+b3AoKSA9PSBQaGFudG9tQ2xvbmVk QXJndW1lbnRzCisgICAgICAgIHx8IGFyZ3VtZW50cy0+b3AoKSA9PSBQaGFudG9tQ3JlYXRlUmVz dCB8fCBhcmd1bWVudHMtPm9wKCkgPT0gUGhhbnRvbU5ld0FycmF5QnVmZmVyLAogICAgICAgICBh cmd1bWVudHMtPm9wKCkpOworCisgICAgaWYgKGFyZ3VtZW50cy0+b3AoKSA9PSBOZXdBcnJheUJ1 ZmZlciB8fCBhcmd1bWVudHMtPm9wKCkgPT0gUGhhbnRvbU5ld0FycmF5QnVmZmVyKSB7CisgICAg ICAgIHJldHVybiBpbnNlcnRpb25TZXQuaW5zZXJ0Q29uc3RhbnQoCisgICAgICAgICAgICBub2Rl SW5kZXgsIG9yaWdpbiwganNOdW1iZXIoYXJndW1lbnRzLT5jYXN0T3BlcmFuZDxKU0ZpeGVkQXJy YXkqPigpLT5sZW5ndGgoKSkpOworICAgIH0KICAgICAKICAgICBJbmxpbmVDYWxsRnJhbWUqIGlu bGluZUNhbGxGcmFtZSA9IGFyZ3VtZW50cy0+b3JpZ2luLnNlbWFudGljLmlubGluZUNhbGxGcmFt ZTsKIAo=