182700 2018-02-12 10:39:04 -0800 [RenderTreeBuilder] Remove redundant RenderTreeBuilder instance 2018-02-12 12:40:38 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1398382 0 zalan 2018-02-12 10:39:04 -0800 Now that we pass the builder in. 1398383 1 webkit-bug-importer 2018-02-12 10:39:34 -0800 <rdar://problem/37463958> 1398384 2 333606 zalan 2018-02-12 10:40:33 -0800 Created attachment 333606 Patch 1398389 3 333606 commit-queue 2018-02-12 10:44:28 -0800 Comment on attachment 333606 Patch Rejecting attachment 333606 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 333606, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.webkit.org/results/6468089 1398391 4 333608 zalan 2018-02-12 10:52:44 -0800 Created attachment 333608 Patch 1398410 5 333611 zalan 2018-02-12 11:56:26 -0800 Created attachment 333611 Patch 1398417 6 333611 commit-queue 2018-02-12 12:12:40 -0800 Comment on attachment 333611 Patch Clearing flags on attachment: 333611 Committed r228387: <https://trac.webkit.org/changeset/228387> 1398418 7 commit-queue 2018-02-12 12:12:42 -0800 All reviewed patches have been landed. Closing bug. 1398426 8 333611 simon.fraser 2018-02-12 12:40:38 -0800 Comment on attachment 333611 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333611&action=review > Source/WebCore/dom/Document.cpp:2319 > + RenderTreeBuilder builder(*m_renderView); Not clear why you need one here; you didn't say any words. > Source/WebCore/rendering/RenderView.cpp:619 > + while (firstChild()) > + removeAndDestroyChild(builder, *firstChild()); Why don't you need one here? 333606 2018-02-12 10:40:33 -0800 2018-02-12 10:52:42 -0800 Patch bug-182700-20180212104032.patch text/plain 1333 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4Mzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTIxMWY3MjgwNTQxZTRm NDdkNjQ1YTc4MDM5ODA4YjNjMTYxNTIwNC4uMTRjNTRkODdiODAxMDE5NGNkMjA1YTJjMzUzZjI0 ZGEyM2Q3OTA3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE4LTAyLTEyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1JlbmRlclRyZWVCdWlsZGVy XSBSZW1vdmUgcmVkdW5kYW50IFJlbmRlclRyZWVCdWlsZGVyIGluc3RhbmNlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODI3MDAKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzM3NDYzOTU4PgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclZpZXcu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVmlldzo6d2lsbEJlRGVzdHJveWVkKToKKwog MjAxOC0wMi0xMiAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAg ICAgIEFYOiBkZWZlciBmb2N1c2VkVUlFbGVtZW50IG5vdGlmaWNhdGlvbnMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJWaWV3LmNwcAppbmRleCBmN2I3Y2E4ZmY4MmFhODc2MGE2MTEyM2Zm YmZmN2MyNGU3ZDQ3ODgyLi4xZGQ4ZDhmYzljYmU5Y2RkNWU4MGIyOGFmMzk3NjE0MzgwOTdlOTEw IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZXcuY3BwCkBAIC02MTYsNyArNjE2 LDYgQEAgdm9pZCBSZW5kZXJWaWV3Ojp3aWxsQmVEZXN0cm95ZWQoUmVuZGVyVHJlZUJ1aWxkZXIm IGJ1aWxkZXIpCiAgICAgUmVuZGVyQmxvY2tGbG93Ojp3aWxsQmVEZXN0cm95ZWQoYnVpbGRlcik7 CiAgICAgLy8gRklYTUU6IFRoaXMgaXMgYSB3b3JrYXJvdW5kIGZvciBsZWZ0b3ZlciBjb250ZW50 IChzZWUgd2Via2l0Lm9yZy9iLzE4MjU0NykuCiAgICAgaWYgKGZpcnN0Q2hpbGQoKSkgewotICAg ICAgICBSZW5kZXJUcmVlQnVpbGRlciBidWlsZGVyKCp0aGlzKTsKICAgICAgICAgd2hpbGUgKGZp cnN0Q2hpbGQoKSkKICAgICAgICAgICAgIHJlbW92ZUFuZERlc3Ryb3lDaGlsZChidWlsZGVyLCAq Zmlyc3RDaGlsZCgpKTsKICAgICB9Cg== 333608 2018-02-12 10:52:44 -0800 2018-02-12 11:45:19 -0800 Patch bug-182700-20180212105243.patch text/plain 1372 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4Mzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTIxMWY3MjgwNTQxZTRm NDdkNjQ1YTc4MDM5ODA4YjNjMTYxNTIwNC4uYWJhZTcwYjY3ZGZiMjA1MTE4NWUwMThlODNjZDQw NjU4NjZhNmFmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTAyLTEyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1JlbmRlclRyZWVCdWlsZGVy XSBSZW1vdmUgcmVkdW5kYW50IFJlbmRlclRyZWVCdWlsZGVyIGluc3RhbmNlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODI3MDAKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzM3NDYzOTU4PgorCisgICAgICAgIFJldmlld2VkIGJ5IEFudHRpIEtvaXZp c3RvLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclZpZXcuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UmVuZGVyVmlldzo6d2lsbEJlRGVzdHJveWVkKToKKwogMjAxOC0wMi0xMiAgQ2hyaXMg RmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIEFYOiBkZWZlciBmb2N1 c2VkVUlFbGVtZW50IG5vdGlmaWNhdGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJWaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJW aWV3LmNwcAppbmRleCBmN2I3Y2E4ZmY4MmFhODc2MGE2MTEyM2ZmYmZmN2MyNGU3ZDQ3ODgyLi4x ZGQ4ZDhmYzljYmU5Y2RkNWU4MGIyOGFmMzk3NjE0MzgwOTdlOTEwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclZpZXcuY3BwCkBAIC02MTYsNyArNjE2LDYgQEAgdm9pZCBSZW5kZXJW aWV3Ojp3aWxsQmVEZXN0cm95ZWQoUmVuZGVyVHJlZUJ1aWxkZXImIGJ1aWxkZXIpCiAgICAgUmVu ZGVyQmxvY2tGbG93Ojp3aWxsQmVEZXN0cm95ZWQoYnVpbGRlcik7CiAgICAgLy8gRklYTUU6IFRo aXMgaXMgYSB3b3JrYXJvdW5kIGZvciBsZWZ0b3ZlciBjb250ZW50IChzZWUgd2Via2l0Lm9yZy9i LzE4MjU0NykuCiAgICAgaWYgKGZpcnN0Q2hpbGQoKSkgewotICAgICAgICBSZW5kZXJUcmVlQnVp bGRlciBidWlsZGVyKCp0aGlzKTsKICAgICAgICAgd2hpbGUgKGZpcnN0Q2hpbGQoKSkKICAgICAg ICAgICAgIHJlbW92ZUFuZERlc3Ryb3lDaGlsZChidWlsZGVyLCAqZmlyc3RDaGlsZCgpKTsKICAg ICB9Cg== 333611 2018-02-12 11:56:26 -0800 2018-02-12 12:12:40 -0800 Patch bug-182700-20180212115625.patch text/plain 2222 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4Mzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTIxMWY3MjgwNTQxZTRm NDdkNjQ1YTc4MDM5ODA4YjNjMTYxNTIwNC4uYWJhZTcwYjY3ZGZiMjA1MTE4NWUwMThlODNjZDQw NjU4NjZhNmFmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTAyLTEyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1JlbmRlclRyZWVCdWlsZGVy XSBSZW1vdmUgcmVkdW5kYW50IFJlbmRlclRyZWVCdWlsZGVyIGluc3RhbmNlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODI3MDAKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzM3NDYzOTU4PgorCisgICAgICAgIFJldmlld2VkIGJ5IEFudHRpIEtvaXZp c3RvLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclZpZXcuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UmVuZGVyVmlldzo6d2lsbEJlRGVzdHJveWVkKToKKwogMjAxOC0wMi0xMiAgQ2hyaXMg RmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIEFYOiBkZWZlciBmb2N1 c2VkVUlFbGVtZW50IG5vdGlmaWNhdGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IDAy MDA3N2NiZWIwN2JiZDJjM2JhNjYwNDk2NzU2ZDlkMzk4MWQ5YzYuLmZlYzlmZjkyNTM3OTMwNWNi MTlhZjNlMGY5MjNhN2NiNmM2MTE2Y2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9E b2N1bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcApAQCAtMjMx NSw3ICsyMzE1LDEwIEBAIHZvaWQgRG9jdW1lbnQ6OmRlc3Ryb3lSZW5kZXJUcmVlKCkKICAgICB1 bnNjaGVkdWxlU3R5bGVSZWNhbGMoKTsKIAogICAgIC8vIEZJWE1FOiBSZW5kZXJPYmplY3Q6OnZp ZXcoKSB1c2VzIG1fcmVuZGVyVmlldyBhbmQgd2UgY2FuJ3QgbnVsbCBpdCBiZWZvcmUgZGVzdHJ1 Y3Rpb24gaXMgY29tcGxldGVkCi0gICAgbV9yZW5kZXJWaWV3LT5kZXN0cm95KCk7CisgICAgewor ICAgICAgICBSZW5kZXJUcmVlQnVpbGRlciBidWlsZGVyKCptX3JlbmRlclZpZXcpOworICAgICAg ICBtX3JlbmRlclZpZXctPmRlc3Ryb3koKTsKKyAgICB9CiAgICAgbV9yZW5kZXJWaWV3LnJlbGVh c2UoKTsKIAogICAgIE5vZGU6OnNldFJlbmRlcmVyKG51bGxwdHIpOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclZpZXcuY3BwCmluZGV4IGY3YjdjYThmZjgyYWE4NzYwYTYxMTIzZmZiZmY3 YzI0ZTdkNDc4ODIuLjEzNzdiOWQ0MDY5YzFjZmIyYzJkOTk0Zjc4Mzg0ZjUzZGQ3OTdlMDkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWV3LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5jcHAKQEAgLTYxNSwxMSArNjE1LDgg QEAgdm9pZCBSZW5kZXJWaWV3Ojp3aWxsQmVEZXN0cm95ZWQoUmVuZGVyVHJlZUJ1aWxkZXImIGJ1 aWxkZXIpCiB7CiAgICAgUmVuZGVyQmxvY2tGbG93Ojp3aWxsQmVEZXN0cm95ZWQoYnVpbGRlcik7 CiAgICAgLy8gRklYTUU6IFRoaXMgaXMgYSB3b3JrYXJvdW5kIGZvciBsZWZ0b3ZlciBjb250ZW50 IChzZWUgd2Via2l0Lm9yZy9iLzE4MjU0NykuCi0gICAgaWYgKGZpcnN0Q2hpbGQoKSkgewotICAg ICAgICBSZW5kZXJUcmVlQnVpbGRlciBidWlsZGVyKCp0aGlzKTsKLSAgICAgICAgd2hpbGUgKGZp cnN0Q2hpbGQoKSkKLSAgICAgICAgICAgIHJlbW92ZUFuZERlc3Ryb3lDaGlsZChidWlsZGVyLCAq Zmlyc3RDaGlsZCgpKTsKLSAgICB9CisgICAgd2hpbGUgKGZpcnN0Q2hpbGQoKSkKKyAgICAgICAg cmVtb3ZlQW5kRGVzdHJveUNoaWxkKGJ1aWxkZXIsICpmaXJzdENoaWxkKCkpOwogCiAgICAgQVNT RVJUX1dJVEhfTUVTU0FHRShtX3JlbmRlcmVyQ291bnQgPT0gMSwgIkFsbCBvdGhlciByZW5kZXJl cnMgaW4gdGhpcyByZW5kZXIgdHJlZSBzaG91bGQgaGF2ZSBiZWVuIGRlc3Ryb3llZCIpOwogfQo=