18270 2008-04-01 18:07:55 -0700 treating x-user-defined different from windows-1252 breaks some Indian web sites 2008-10-12 15:39:07 -0700 1 1 1 Unclassified WebKit Page Loading 525.x (Safari 3.1) All All RESOLVED FIXED http://loksatta.com/ P2 Normal --- 1 jshin darin ap ojan oldest_to_newest 76101 0 jshin 2008-04-01 18:07:55 -0700 1. Download MillenniumVarun font from http://loksatta.com/MillenniumVarun.zip 2. Go to http://loksatta.com/ 3. Half of characters are rendered with empty boxes or question marks. 4. Set the encoding manually to 'Western European' 5. All the characters are rendered correctly. The page has 3 meta charset declarations. The first is 'x-user-defined' and Safari (as well as FF) maps [0x80-0xff] to a PUA block ( U+F780-U+F7FF ?), but MillenniumVarun font installed above does not have any glyph in that range. It's their fault. They should have done either of the following: - use 'Symbol' cmap (rather than Microsoft Windows 1255 cmap) in their font - specify their page encoding as windows-1255 (or iso-8859-1) rather than x-user-defined. webkit treats them synonymously. Nonetheless, MS IE does not have a problem with the above page (and pages like that). I didn't enable webfont for IE so that it's 'thanks to' IE's handling of 'x-user-defined'. Perhaps, webkit also has to treat x-user-defined as an alias to windows-1255. That would save some code, too (TextCodecUserDefined.cpp). There are still a lot of Indian web pages with this problem, I believe although Unicode becomes more and more widespread. 76124 1 ap 2008-04-01 23:25:43 -0700 See bug 15555, where we decided to match the Firefox implementation. I assume you meant windows-1252, not windows-1255? My understanding is that IE treats x-user-defined differently based on some Registry settings, so matching it fully is not really possible. 77716 2 jshin 2008-04-15 13:10:33 -0700 Yes, I meant windows-1252 :-). Do you know what registry setting controls IE's behavior? It appears that out of the box, IE treats x-user-defined synonymously with Windows-1252. If that's the case, the majority of Indian users would regard Safari as not working for them. Of course, there's a risk of doing this because some web sites may rely on [0x80-0xFF] of x-user-defined being mapped to [U+F780 - U+F7FF] (hope I remember this range correctly). However, given that IE's default appears not to support this, the risk should be rather minimal. 77775 3 ap 2008-04-16 02:30:37 -0700 No, I don't really understand how x-user-defined works in IE, or how it is controlled. Sources such as <http://msdn2.microsoft.com/en-us/library/aa752010(VS.85).aspx> and <http://www.ntu.edu.sg/home5/pg03053527/Tips/TipsForIE/Tip_for_IE.htm> suggest that it is not just a synonym for windows-1252 though. People are using x-user-defined to work around some XMLHttpRequest restrictions, so it is importatnt to keep thing compatible with Firefox. 90598 4 23280 jshin 2008-09-08 17:03:56 -0700 Created attachment 23280 patch (layout test missing) We can do something like this. I ran webkit-test and no test broke due to this patch. I did spot checks of a few Indian web sites that declare x-user-defined and the fonts used there. Their fonts have glyphs for U+2018 (corresponding to 0x93 in windows-1252) and U+2014 (0x97 in windows-1252) but do not have glyphs for U+0093 or U+0097 (unicode characters for 0x93/0x97 if they're interpreted as ISO-8859-1). There are several dozens (if not more) of 'font-encoded' fonts used for Indian web sites. So, this spot check is far from complete. Some sites declare ISO-8859-1 and their fonts cover indeed ISO-8859-1 repertoire rather than windows-1252 repertoire. What this patch does is to alias 'x-user-defined' to 'windows-1252' and does not break those sites with an "iso-8859-1 font". It's not very clear what IE does, but judging from the fact that a lot of Indian web sites get away with 'x-user-defined' and 'windows-1252 fonts', I guess this patch brings webkit closer to IE's behavior without breaking FF compatibility with XHR. If this is acceptable, I'll make a layout test for this. 90640 5 ap 2008-09-09 01:32:30 -0700 I don't really like the idea of different decoding rules depending on where the encoding is specified. I'd be happier if the change was made unconditionally. Yes, this poses a theoretical risk for some XHR requests, but I'd prefer a decision to employ an ugly workaround like this to be made based on knowledge of real life severity. + // treat x-user-defined as windows-1252 (bug 18270) With so many WebKit bug trackers around, it's better to use complete URLs like https://bugs.webkit.org/show_bug.cgi?id=18270. > I did spot checks of a few Indian web sites It would be highly desirable to have a list including several sites that are fixed with this patch. Changes like this tend to do both good and harm (and to be incomplete), so having a list of sites that were fixed may help to make an informed decision in the future. 91699 6 jshin 2008-09-18 17:07:47 -0700 40 Indian web sites (mostly newspaper web sites) were tested. Out of 40, 8 use x-user-defined and are 'saved' by this change. I guess, this stat is not a very strong argument. If you want a more convincing stat, I can generate one, but it'll take a while. BTW, I don't like this hack, either. :-) 91728 7 ap 2008-09-18 23:31:05 -0700 This is very convincing, in my opinion - please do provide the URLs for future reference. 92432 8 jshin 2008-09-23 16:56:52 -0700 Sorry for the delay. Here's the list of sites that are fixed by the change: Web site name Language URL Font Bartaman Patrika Bengali http://www.bartamanpatrika.com/ Aaadurga Ananda Bazar Patrika Bengali http://www.anandabazar.com/ AabpBengali Gujarat Samachar Gujarati http://www.gujaratsamachar.com/ Gopika Kannada Prabha Kannada http://www.kannadaprabha.com KNW-TTNandi Bombay Samachar Gujarati http://bombaysamachar.com/ KrishnaWeb Loksatta Marathi http://www.loksatta.com/ MilleniumVarun Deepika Malayalam http://www.deepika.com/ ML-TTKarthika Arabia365 Malayalam http://www.arabia365.com/ MLW-TTKarthika 94947 9 24281 jshin 2008-10-10 16:49:51 -0700 Created attachment 24281 patch with layout test 94956 10 24281 darin 2008-10-10 17:19:28 -0700 Comment on attachment 24281 patch with layout test + * ChangeLog: The ChangeLog itself should not be mentioned in the ChangeLog. The strcasecmp function is generally not good to use anywhere in WebKit because its behavior depends on the current locale (as in the standard C setlocale function). But I see it used in two other places inside the text encoding machinery, so I suppose I can't reject this use. The correct thing to do would be to make an ASCII version of this function like the functions in <wtf/ASCIICType.h>, which exist for the same reason. It could maybe go in WTF, perhaps <wtf/ASCIICString.h> or maybe in PlatformString.h as an overload of equalIgnoringCase. + if (source == EncodingFromMetaTag + && strcasecmp(encoding.name(), "x-user-defined") == 0) + m_decoder.reset("windows-1252"); + else if (source == EncodingFromMetaTag || source == EncodingFromXMLHeader || source == EncodingFromCSSCharset) I think this first if would look better all on one line. It wouldn't be any longer than the next if statement below it. I usually indent the "&&" one extra level to avoid lining it up perfectly with the statement inside the if r=me 94966 11 24286 jshin 2008-10-10 18:28:14 -0700 Created attachment 24286 patch with Darin's review comment addressed Thank you for the review. I addressed your review comments. Can you check this in? I'll file a separate bug about case-sensitive comparision for ASCII strings. (btw, I wonder why 'ChangeLog' contained 'ChangeLog' line because it's generated by PrepareChangelog script. Perhaps, I misused it somehow? ). 95002 12 darin 2008-10-11 15:37:33 -0700 (In reply to comment #11) > Thank you for the review. I addressed your review comments. Can you check this > in? I'm not sure I'll have a chance. I'm working on reviewing first; I'll check patches in if I can get through enough of the review queue. But it's in the "to be checked in queue" along with other reviewed patches. I'm sure that one of the committers will get to it eventually. > I'll file a separate bug about case-sensitive comparision for ASCII strings. Thanks. > (btw, I wonder why 'ChangeLog' contained 'ChangeLog' line because it's > generated by PrepareChangelog script. Perhaps, I misused it somehow? ). Three thoughts on that (all minor things): 1) You probably modified the ChangeLog file before running the prepare-ChangeLog script. 2) The prepare-ChangeLog script does include the ChangeLog if you've already modified it before invoking that script. Maybe we should change that, since it's almost never useful. 3) The prepare-ChangeLog script is intended to help you write a change log. Too many people working on this project treat what it writes out as "sacred", but it's really just a tool to save time; it sometimes generates incorrect things like bad function names and we shouldn't just check them in. 95087 13 darin 2008-10-12 15:16:18 -0700 Grabbing this bug now. I'm about to land it. 95090 14 darin 2008-10-12 15:39:07 -0700 http://trac.webkit.org/changeset/37530 23280 2008-09-08 17:03:56 -0700 2008-10-10 16:49:51 -0700 patch (layout test missing) 18270.patch.1 text/plain 981 jshin SW5kZXg6IFdlYkNvcmUvbG9hZGVyL1RleHRSZXNvdXJjZURlY29kZXIuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvbG9hZGVyL1RleHRSZXNvdXJjZURlY29kZXIuY3BwCShyZXZpc2lvbiAzNjEx OCkKKysrIFdlYkNvcmUvbG9hZGVyL1RleHRSZXNvdXJjZURlY29kZXIuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0zNDAsNyArMzQwLDEyIEBAIHZvaWQgVGV4dFJlc291cmNlRGVjb2Rlcjo6c2V0RW5j b2RpbmcoY28KICAgICBpZiAoIWVuY29kaW5nLmlzVmFsaWQoKSkKICAgICAgICAgcmV0dXJuOwog Ci0gICAgaWYgKHNvdXJjZSA9PSBFbmNvZGluZ0Zyb21NZXRhVGFnIHx8IHNvdXJjZSA9PSBFbmNv ZGluZ0Zyb21YTUxIZWFkZXIgfHwgc291cmNlID09IEVuY29kaW5nRnJvbUNTU0NoYXJzZXQpICAg ICAgICAKKyAgICAvLyBXaGVuIGVuY29kaW5nIGNvbWVzIGZyb20gbWV0YSB0YWcgKGkuZS4gaXQg Y2Fubm90IGJlIFhNTCBmaWxlcyBzZW50IHZpYSBYSFIpLAorICAgIC8vIHRyZWF0IHgtdXNlci1k ZWZpbmVkIGFzIHdpbmRvd3MtMTI1MiAoYnVnIDE4MjcwKQorICAgIGlmIChzb3VyY2UgPT0gRW5j b2RpbmdGcm9tTWV0YVRhZworICAgICAgICAmJiBzdHJjYXNlY21wKGVuY29kaW5nLm5hbWUoKSwg IngtdXNlci1kZWZpbmVkIikgPT0gMCkKKyAgICAgICAgbV9kZWNvZGVyLnJlc2V0KCJ3aW5kb3dz LTEyNTIiKTsgCisgICAgZWxzZSBpZiAoc291cmNlID09IEVuY29kaW5nRnJvbU1ldGFUYWcgfHwg c291cmNlID09IEVuY29kaW5nRnJvbVhNTEhlYWRlciB8fCBzb3VyY2UgPT0gRW5jb2RpbmdGcm9t Q1NTQ2hhcnNldCkgICAgICAgIAogICAgICAgICBtX2RlY29kZXIucmVzZXQoZW5jb2RpbmcuY2xv c2VzdDhCaXRFcXVpdmFsZW50KCkpOwogICAgIGVsc2UKICAgICAgICAgbV9kZWNvZGVyLnJlc2V0 KGVuY29kaW5nKTsK 24281 2008-10-10 16:49:51 -0700 2008-10-10 18:28:14 -0700 patch with layout test 18270.patch.2 text/plain 5304 jshin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNzQ5NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDgtMTAtMTAgIEp1bmdzaGlrIFNoaW4gIDxqc2hpbkBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VHJlYXQgeC11c2VyLWRlZmluZWQgYXMgd2luZG93cy0xMjUyIGZvciBodG1sIGZpbGVzIHdpdGgg bWV0YSBjaGFyc2V0CisgICAgICAgIGRlY2xhcmF0aW9uIHRvIGJlIGNvbXBhdGlibGUgd2l0aCBJ bmRpYW4gd2ViIHNpdGVzLgorICAgICAgICAoIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xODI3MCApCisKKyAgICAgICAgVGVzdDogZmFzdC9lbmNvZGluZy9jaGFyc2V0 LXh1c2VyLWRlZmluZWQuaHRtbAorCisgICAgICAgICogQ2hhbmdlTG9nOgorICAgICAgICAqIGxv YWRlci9UZXh0UmVzb3VyY2VEZWNvZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRleHRSZXNv dXJjZURlY29kZXI6OnNldEVuY29kaW5nKToKKwogMjAwOC0xMC0xMCAgT2xpdmVyIEh1bnQgIDxv bGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IENhbWVyb24gWndhcmljaC4K SW5kZXg6IFdlYkNvcmUvbG9hZGVyL1RleHRSZXNvdXJjZURlY29kZXIuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvbG9hZGVyL1RleHRSZXNvdXJjZURlY29kZXIuY3BwCShyZXZpc2lvbiAzNzQ1 NikKKysrIFdlYkNvcmUvbG9hZGVyL1RleHRSZXNvdXJjZURlY29kZXIuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0zNDAsNyArMzQwLDEyIEBAIHZvaWQgVGV4dFJlc291cmNlRGVjb2Rlcjo6c2V0RW5j b2RpbmcoY28KICAgICBpZiAoIWVuY29kaW5nLmlzVmFsaWQoKSkKICAgICAgICAgcmV0dXJuOwog Ci0gICAgaWYgKHNvdXJjZSA9PSBFbmNvZGluZ0Zyb21NZXRhVGFnIHx8IHNvdXJjZSA9PSBFbmNv ZGluZ0Zyb21YTUxIZWFkZXIgfHwgc291cmNlID09IEVuY29kaW5nRnJvbUNTU0NoYXJzZXQpICAg ICAgICAKKyAgICAvLyBXaGVuIGVuY29kaW5nIGNvbWVzIGZyb20gbWV0YSB0YWcgKGkuZS4gaXQg Y2Fubm90IGJlIFhNTCBmaWxlcyBzZW50IHZpYSBYSFIpLAorICAgIC8vIHRyZWF0IHgtdXNlci1k ZWZpbmVkIGFzIHdpbmRvd3MtMTI1MiAoYnVnIDE4MjcwKQorICAgIGlmIChzb3VyY2UgPT0gRW5j b2RpbmdGcm9tTWV0YVRhZworICAgICAgICAmJiBzdHJjYXNlY21wKGVuY29kaW5nLm5hbWUoKSwg IngtdXNlci1kZWZpbmVkIikgPT0gMCkKKyAgICAgICAgbV9kZWNvZGVyLnJlc2V0KCJ3aW5kb3dz LTEyNTIiKTsgCisgICAgZWxzZSBpZiAoc291cmNlID09IEVuY29kaW5nRnJvbU1ldGFUYWcgfHwg c291cmNlID09IEVuY29kaW5nRnJvbVhNTEhlYWRlciB8fCBzb3VyY2UgPT0gRW5jb2RpbmdGcm9t Q1NTQ2hhcnNldCkgICAgICAgIAogICAgICAgICBtX2RlY29kZXIucmVzZXQoZW5jb2RpbmcuY2xv c2VzdDhCaXRFcXVpdmFsZW50KCkpOwogICAgIGVsc2UKICAgICAgICAgbV9kZWNvZGVyLnJlc2V0 KGVuY29kaW5nKTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDM3NDk0KQorKysgTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMTAtMTAgIEp1bmdz aGlrIFNoaW4gIDxqc2hpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVHJlYXQgeC11c2VyLWRlZmluZWQgYXMgd2luZG93cy0x MjUyIGZvciBodG1sIGZpbGVzIHdpdGggbWV0YSBjaGFyc2V0CisgICAgICAgIGRlY2xhcmF0aW9u IHRvIGJlIGNvbXBhdGlibGUgd2l0aCBJbmRpYW4gd2ViIHNpdGVzLgorICAgICAgICAoIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODI3MCApCisKKyAgICAgICAgKiBm YXN0L2VuY29kaW5nL2NoYXJzZXQteHVzZXItZGVmaW5lZC1leHBlY3RlZC50eHQ6IEFkZGVkLgor ICAgICAgICAqIGZhc3QvZW5jb2RpbmcvY2hhcnNldC14dXNlci1kZWZpbmVkLmh0bWw6IEFkZGVk LgorCiAyMDA4LTEwLTEwICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KIAog ICAgICAgICBMYXlvdXQgdGVzdCBmb3IgcGxhY2Vob2xkZXIgYXR0cmlidXRlIGNoYW5nZWQuCklu ZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2VuY29kaW5nL2NoYXJzZXQteHVzZXItZGVmaW5lZC1leHBl Y3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9lbmNvZGluZy9jaGFyc2V0 LXh1c2VyLWRlZmluZWQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMv ZmFzdC9lbmNvZGluZy9jaGFyc2V0LXh1c2VyLWRlZmluZWQtZXhwZWN0ZWQudHh0CShyZXZpc2lv biAwKQpAQCAtMCwwICsxLDQgQEAKK1Rlc3QgYnVnemlsbGEgYnVnIDE4MjcwIChJbnRlcnByZXRp bmcgeC11c2VyLWRlZmluZWQgYXMgd2luZG93cy0xMjUyIHdoZW4gZGVjbGFyZWQgaW4gbWV0YSB0 YWcpLiBUd28gbGluZXMgYmVsb3cgc2hvdWxkIGJlIGlkZW50aWNhbC4KKwor4oKsIOKAmsaS4oCe 4oCm4oCg4oChy4bigLDFoOKAucWSIMW9IOKAmOKAmeKAnOKAneKAouKAk+KAlMuc4oSixaHigLrF kyDFvsW4wqDCocKiwqPCpMKlwqbCp8KowqnCqsKrwqwgwq7Cr8KwwrHCssKzwrTCtcK2wrfCuMK5 wrrCu8K8wr3CvsK/w4DDgcOCw4PDhMOFw4bDh8OIw4nDisOLw4zDjcOOw4/DkMORw5LDk8OUw5XD lsOXw5jDmcOaw5vDnMOdw57Dn8Ogw6HDosOjw6TDpcOmw6fDqMOpw6rDq8Osw63DrsOvw7DDscOy w7PDtMO1w7bDt8O4w7nDusO7w7zDvcO+w78KK+KCrCDigJrGkuKAnuKApuKAoOKAocuG4oCwxaDi gLnFkiDFvSDigJjigJnigJzigJ3igKLigJPigJTLnOKEosWh4oC6xZMgxb7FuMKgwqHCosKjwqTC pcKmwqfCqMKpwqrCq8KsIMKuwq/CsMKxwrLCs8K0wrXCtsK3wrjCucK6wrvCvMK9wr7Cv8OAw4HD gsODw4TDhcOGw4fDiMOJw4rDi8OMw43DjsOPw5DDkcOSw5PDlMOVw5bDl8OYw5nDmsObw5zDncOe w5/DoMOhw6LDo8Okw6XDpsOnw6jDqcOqw6vDrMOtw67Dr8Oww7HDssOzw7TDtcO2w7fDuMO5w7rD u8O8w73DvsO/CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2VuY29kaW5nL2NoYXJzZXQteHVzZXIt ZGVmaW5lZC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZW5jb2RpbmcvY2hh cnNldC14dXNlci1kZWZpbmVkLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0 L2VuY29kaW5nL2NoYXJzZXQteHVzZXItZGVmaW5lZC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCww ICsxLDE3IEBACis8aHRtbD4KKzxoZWFkPgorPG1ldGEgaHR0cC1lcXVpdj0iY29udGVudC10eXBl IiBjb250ZW50PSJ0ZXh0L2h0bWw7IGNoYXJzZXQ9eC11c2VyLWRlZmluZWQiPgorPHRpdGxlPngt dXNlci1kZWZpbmVkIChidWcgPC90aXRsZT4KKzwvaGVhZD4KKzxib2R5PgorPHNjcmlwdD4KK2lm ICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisJbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVt cEFzVGV4dCgpOworPC9zY3JpcHQ+Cis8cD5UZXN0IDxhIGhyZWY9Imh0dHA6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjcwIj5idWd6aWxsYSBidWcgMTgyNzA8L2E+IChJbnRl cnByZXRpbmcgeC11c2VyLWRlZmluZWQgYXMgd2luZG93cy0xMjUyIHdoZW4KK2RlY2xhcmVkIGlu IG1ldGEgdGFnKS4gVHdvIGxpbmVzIGJlbG93IHNob3VsZCBiZSBpZGVudGljYWwuPC9wPgorCiuA IIKDhIWGh4iJiouMII4gIJGSk5SVlpeYmZqbnCCen6ChoqOkpaanqKmqq6ytrq+wsbKztLW2t7i5 uru8vb6/wMHCw8TFxsfIycrLzM3Oz9DR0tPU1dbX2Nna29zd3t/g4eLj5OXm5+jp6uvs7e7v8PHy 8/T19vf4+fr7/P3+/zxiciAvPgorJiN4MjBhYzsgJiN4MjAxYTsmI3gwMTkyOyYjeDIwMWU7JiN4 MjAyNjsmI3gyMDIwOyYjeDIwMjE7JiN4MDJjNjsmI3gyMDMwOyYjeDAxNjA7JiN4MjAzOTsmI3gw MTUyOyAmI3gwMTdkOyAgJiN4MjAxODsmI3gyMDE5OyYjeDIwMWM7JiN4MjAxZDsmI3gyMDIyOyYj eDIwMTM7JiN4MjAxNDsmI3gwMmRjOyYjeDIxMjI7JiN4MDE2MTsmI3gyMDNhOyYjeDAxNTM7ICYj eDAxN2U7JiN4MDE3ODsmI3gwMGEwOyYjeDAwYTE7JiN4MDBhMjsmI3gwMGEzOyYjeDAwYTQ7JiN4 MDBhNTsmI3gwMGE2OyYjeDAwYTc7JiN4MDBhODsmI3gwMGE5OyYjeDAwYWE7JiN4MDBhYjsmI3gw MGFjOyYjeDAwYWQ7JiN4MDBhZTsmI3gwMGFmOyYjeDAwYjA7JiN4MDBiMTsmI3gwMGIyOyYjeDAw YjM7JiN4MDBiNDsmI3gwMGI1OyYjeDAwYjY7JiN4MDBiNzsmI3gwMGI4OyYjeDAwYjk7JiN4MDBi YTsmI3gwMGJiOyYjeDAwYmM7JiN4MDBiZDsmI3gwMGJlOyYjeDAwYmY7JiN4MDBjMDsmI3gwMGMx OyYjeDAwYzI7JiN4MDBjMzsmI3gwMGM0OyYjeDAwYzU7JiN4MDBjNjsmI3gwMGM3OyYjeDAwYzg7 JiN4MDBjOTsmI3gwMGNhOyYjeDAwY2I7JiN4MDBjYzsmI3gwMGNkOyYjeDAwY2U7JiN4MDBjZjsm I3gwMGQwOyYjeDAwZDE7JiN4MDBkMjsmI3gwMGQzOyYjeDAwZDQ7JiN4MDBkNTsmI3gwMGQ2OyYj eDAwZDc7JiN4MDBkODsmI3gwMGQ5OyYjeDAwZGE7JiN4MDBkYjsmI3gwMGRjOyYjeDAwZGQ7JiN4 MDBkZTsmI3gwMGRmOyYjeDAwZTA7JiN4MDBlMTsmI3gwMGUyOyYjeDAwZTM7JiN4MDBlNDsmI3gw MGU1OyYjeDAwZTY7JiN4MDBlNzsmI3gwMGU4OyYjeDAwZTk7JiN4MDBlYTsmI3gwMGViOyYjeDAw ZWM7JiN4MDBlZDsmI3gwMGVlOyYjeDAwZWY7JiN4MDBmMDsmI3gwMGYxOyYjeDAwZjI7JiN4MDBm MzsmI3gwMGY0OyYjeDAwZjU7JiN4MDBmNjsmI3gwMGY3OyYjeDAwZjg7JiN4MDBmOTsmI3gwMGZh OyYjeDAwZmI7JiN4MDBmYzsmI3gwMGZkOyYjeDAwZmU7JiN4MDBmZjsKKzwvYm9keT4KKzwvaHRt bD4K 24286 2008-10-10 18:28:14 -0700 2008-10-11 13:21:22 -0700 patch with Darin's review comment addressed 18270.patch.3 text/plain 5273 jshin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNzQ5NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDgtMTAtMTAgIEp1bmdzaGlrIFNoaW4gIDxqc2hpbkBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VHJlYXQgeC11c2VyLWRlZmluZWQgYXMgd2luZG93cy0xMjUyIGZvciBodG1sIGZpbGVzIHdpdGgg bWV0YSBjaGFyc2V0CisgICAgICAgIGRlY2xhcmF0aW9uIHRvIGJlIGNvbXBhdGlibGUgd2l0aCBJ bmRpYW4gd2ViIHNpdGVzLgorICAgICAgICAoIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xODI3MCApCisKKyAgICAgICAgVGVzdDogZmFzdC9lbmNvZGluZy9jaGFyc2V0 LXh1c2VyLWRlZmluZWQuaHRtbAorCisgICAgICAgICogbG9hZGVyL1RleHRSZXNvdXJjZURlY29k ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGV4dFJlc291cmNlRGVjb2Rlcjo6c2V0RW5jb2Rp bmcpOgorCiAyMDA4LTEwLTEwICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgQ2FtZXJvbiBad2FyaWNoLgpJbmRleDogV2ViQ29yZS9sb2FkZXIv VGV4dFJlc291cmNlRGVjb2Rlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9sb2FkZXIvVGV4 dFJlc291cmNlRGVjb2Rlci5jcHAJKHJldmlzaW9uIDM3NDU2KQorKysgV2ViQ29yZS9sb2FkZXIv VGV4dFJlc291cmNlRGVjb2Rlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM0MCw3ICszNDAsMTEg QEAgdm9pZCBUZXh0UmVzb3VyY2VEZWNvZGVyOjpzZXRFbmNvZGluZyhjbwogICAgIGlmICghZW5j b2RpbmcuaXNWYWxpZCgpKQogICAgICAgICByZXR1cm47CiAKLSAgICBpZiAoc291cmNlID09IEVu Y29kaW5nRnJvbU1ldGFUYWcgfHwgc291cmNlID09IEVuY29kaW5nRnJvbVhNTEhlYWRlciB8fCBz b3VyY2UgPT0gRW5jb2RpbmdGcm9tQ1NTQ2hhcnNldCkgICAgICAgIAorICAgIC8vIFdoZW4gZW5j b2RpbmcgY29tZXMgZnJvbSBtZXRhIHRhZyAoaS5lLiBpdCBjYW5ub3QgYmUgWE1MIGZpbGVzIHNl bnQgdmlhIFhIUiksCisgICAgLy8gdHJlYXQgeC11c2VyLWRlZmluZWQgYXMgd2luZG93cy0xMjUy IChidWcgMTgyNzApCisgICAgaWYgKHNvdXJjZSA9PSBFbmNvZGluZ0Zyb21NZXRhVGFnICYmIHN0 cmNhc2VjbXAoZW5jb2RpbmcubmFtZSgpLCAieC11c2VyLWRlZmluZWQiKSA9PSAwKQorICAgICAg ICBtX2RlY29kZXIucmVzZXQoIndpbmRvd3MtMTI1MiIpOyAKKyAgICBlbHNlIGlmIChzb3VyY2Ug PT0gRW5jb2RpbmdGcm9tTWV0YVRhZyB8fCBzb3VyY2UgPT0gRW5jb2RpbmdGcm9tWE1MSGVhZGVy IHx8IHNvdXJjZSA9PSBFbmNvZGluZ0Zyb21DU1NDaGFyc2V0KSAgICAgICAgCiAgICAgICAgIG1f ZGVjb2Rlci5yZXNldChlbmNvZGluZy5jbG9zZXN0OEJpdEVxdWl2YWxlbnQoKSk7CiAgICAgZWxz ZQogICAgICAgICBtX2RlY29kZXIucmVzZXQoZW5jb2RpbmcpOwpJbmRleDogTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24g Mzc0OTQpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyAr MSwxNCBAQAorMjAwOC0xMC0xMCAgSnVuZ3NoaWsgU2hpbiAgPGpzaGluQGNocm9taXVtLm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUcmVhdCB4 LXVzZXItZGVmaW5lZCBhcyB3aW5kb3dzLTEyNTIgZm9yIGh0bWwgZmlsZXMgd2l0aCBtZXRhIGNo YXJzZXQKKyAgICAgICAgZGVjbGFyYXRpb24gdG8gYmUgY29tcGF0aWJsZSB3aXRoIEluZGlhbiB3 ZWIgc2l0ZXMuCisgICAgICAgICggaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE4MjcwICkKKworICAgICAgICAqIGZhc3QvZW5jb2RpbmcvY2hhcnNldC14dXNlci1kZWZp bmVkLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9lbmNvZGluZy9jaGFyc2V0 LXh1c2VyLWRlZmluZWQuaHRtbDogQWRkZWQuCisKIDIwMDgtMTAtMTAgIFRpbW90aHkgSGF0Y2hl ciAgPHRpbW90aHlAYXBwbGUuY29tPgogCiAgICAgICAgIExheW91dCB0ZXN0IGZvciBwbGFjZWhv bGRlciBhdHRyaWJ1dGUgY2hhbmdlZC4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZW5jb2Rpbmcv Y2hhcnNldC14dXNlci1kZWZpbmVkLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9mYXN0L2VuY29kaW5nL2NoYXJzZXQteHVzZXItZGVmaW5lZC1leHBlY3RlZC50eHQJKHJl dmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2VuY29kaW5nL2NoYXJzZXQteHVzZXItZGVm aW5lZC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNCBAQAorVGVzdCBidWd6 aWxsYSBidWcgMTgyNzAgKEludGVycHJldGluZyB4LXVzZXItZGVmaW5lZCBhcyB3aW5kb3dzLTEy NTIgd2hlbiBkZWNsYXJlZCBpbiBtZXRhIHRhZykuIFR3byBsaW5lcyBiZWxvdyBzaG91bGQgYmUg aWRlbnRpY2FsLgorCivigqwg4oCaxpLigJ7igKbigKDigKHLhuKAsMWg4oC5xZIgxb0g4oCY4oCZ 4oCc4oCd4oCi4oCT4oCUy5zihKLFoeKAusWTIMW+xbjCoMKhwqLCo8KkwqXCpsKnwqjCqcKqwqvC rCDCrsKvwrDCscKywrPCtMK1wrbCt8K4wrnCusK7wrzCvcK+wr/DgMOBw4LDg8OEw4XDhsOHw4jD icOKw4vDjMONw47Dj8OQw5HDksOTw5TDlcOWw5fDmMOZw5rDm8Ocw53DnsOfw6DDocOiw6PDpMOl w6bDp8Oow6nDqsOrw6zDrcOuw6/DsMOxw7LDs8O0w7XDtsO3w7jDucO6w7vDvMO9w77Dvwor4oKs IOKAmsaS4oCe4oCm4oCg4oChy4bigLDFoOKAucWSIMW9IOKAmOKAmeKAnOKAneKAouKAk+KAlMuc 4oSixaHigLrFkyDFvsW4wqDCocKiwqPCpMKlwqbCp8KowqnCqsKrwqwgwq7Cr8KwwrHCssKzwrTC tcK2wrfCuMK5wrrCu8K8wr3CvsK/w4DDgcOCw4PDhMOFw4bDh8OIw4nDisOLw4zDjcOOw4/DkMOR w5LDk8OUw5XDlsOXw5jDmcOaw5vDnMOdw57Dn8Ogw6HDosOjw6TDpcOmw6fDqMOpw6rDq8Osw63D rsOvw7DDscOyw7PDtMO1w7bDt8O4w7nDusO7w7zDvcO+w78KSW5kZXg6IExheW91dFRlc3RzL2Zh c3QvZW5jb2RpbmcvY2hhcnNldC14dXNlci1kZWZpbmVkLmh0bWwKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvZmFzdC9lbmNvZGluZy9jaGFyc2V0LXh1c2VyLWRlZmluZWQuaHRtbAkocmV2aXNp b24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZW5jb2RpbmcvY2hhcnNldC14dXNlci1kZWZpbmVk Lmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTcgQEAKKzxodG1sPgorPGhlYWQ+Cis8bWV0 YSBodHRwLWVxdWl2PSJjb250ZW50LXR5cGUiIGNvbnRlbnQ9InRleHQvaHRtbDsgY2hhcnNldD14 LXVzZXItZGVmaW5lZCI+Cis8dGl0bGU+eC11c2VyLWRlZmluZWQgKGJ1ZyA8L3RpdGxlPgorPC9o ZWFkPgorPGJvZHk+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikK KwlsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Cis8L3NjcmlwdD4KKzxwPlRlc3Qg PGEgaHJlZj0iaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyNzAiPmJ1 Z3ppbGxhIGJ1ZyAxODI3MDwvYT4gKEludGVycHJldGluZyB4LXVzZXItZGVmaW5lZCBhcyB3aW5k b3dzLTEyNTIgd2hlbgorZGVjbGFyZWQgaW4gbWV0YSB0YWcpLiBUd28gbGluZXMgYmVsb3cgc2hv dWxkIGJlIGlkZW50aWNhbC48L3A+CisKK4AggoOEhYaHiImKi4wgjiAgkZKTlJWWl5iZmpucIJ6f oKGio6SlpqeoqaqrrK2ur7CxsrO0tba3uLm6u7y9vr/AwcLDxMXGx8jJysvMzc7P0NHS09TV1tfY 2drb3N3e3+Dh4uPk5ebn6Onq6+zt7u/w8fLz9PX29/j5+vv8/f7/PGJyIC8+CismI3gyMGFjOyAm I3gyMDFhOyYjeDAxOTI7JiN4MjAxZTsmI3gyMDI2OyYjeDIwMjA7JiN4MjAyMTsmI3gwMmM2OyYj eDIwMzA7JiN4MDE2MDsmI3gyMDM5OyYjeDAxNTI7ICYjeDAxN2Q7ICAmI3gyMDE4OyYjeDIwMTk7 JiN4MjAxYzsmI3gyMDFkOyYjeDIwMjI7JiN4MjAxMzsmI3gyMDE0OyYjeDAyZGM7JiN4MjEyMjsm I3gwMTYxOyYjeDIwM2E7JiN4MDE1MzsgJiN4MDE3ZTsmI3gwMTc4OyYjeDAwYTA7JiN4MDBhMTsm I3gwMGEyOyYjeDAwYTM7JiN4MDBhNDsmI3gwMGE1OyYjeDAwYTY7JiN4MDBhNzsmI3gwMGE4OyYj eDAwYTk7JiN4MDBhYTsmI3gwMGFiOyYjeDAwYWM7JiN4MDBhZDsmI3gwMGFlOyYjeDAwYWY7JiN4 MDBiMDsmI3gwMGIxOyYjeDAwYjI7JiN4MDBiMzsmI3gwMGI0OyYjeDAwYjU7JiN4MDBiNjsmI3gw MGI3OyYjeDAwYjg7JiN4MDBiOTsmI3gwMGJhOyYjeDAwYmI7JiN4MDBiYzsmI3gwMGJkOyYjeDAw YmU7JiN4MDBiZjsmI3gwMGMwOyYjeDAwYzE7JiN4MDBjMjsmI3gwMGMzOyYjeDAwYzQ7JiN4MDBj NTsmI3gwMGM2OyYjeDAwYzc7JiN4MDBjODsmI3gwMGM5OyYjeDAwY2E7JiN4MDBjYjsmI3gwMGNj OyYjeDAwY2Q7JiN4MDBjZTsmI3gwMGNmOyYjeDAwZDA7JiN4MDBkMTsmI3gwMGQyOyYjeDAwZDM7 JiN4MDBkNDsmI3gwMGQ1OyYjeDAwZDY7JiN4MDBkNzsmI3gwMGQ4OyYjeDAwZDk7JiN4MDBkYTsm I3gwMGRiOyYjeDAwZGM7JiN4MDBkZDsmI3gwMGRlOyYjeDAwZGY7JiN4MDBlMDsmI3gwMGUxOyYj eDAwZTI7JiN4MDBlMzsmI3gwMGU0OyYjeDAwZTU7JiN4MDBlNjsmI3gwMGU3OyYjeDAwZTg7JiN4 MDBlOTsmI3gwMGVhOyYjeDAwZWI7JiN4MDBlYzsmI3gwMGVkOyYjeDAwZWU7JiN4MDBlZjsmI3gw MGYwOyYjeDAwZjE7JiN4MDBmMjsmI3gwMGYzOyYjeDAwZjQ7JiN4MDBmNTsmI3gwMGY2OyYjeDAw Zjc7JiN4MDBmODsmI3gwMGY5OyYjeDAwZmE7JiN4MDBmYjsmI3gwMGZjOyYjeDAwZmQ7JiN4MDBm ZTsmI3gwMGZmOworPC9ib2R5PgorPC9odG1sPgo=