182674 2018-02-11 09:47:59 -0800 Add support for configuring WebsiteDatastore service worker and cache storage path 2018-02-14 13:23:18 -0800 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen beidson cdumez commit-queue webkit-bug-importer oldest_to_newest 1398270 0 youennf 2018-02-11 09:47:59 -0800 Add support for configuring WebsiteDatastore service worker and cache storage path 1398271 1 333569 youennf 2018-02-11 09:51:15 -0800 Created attachment 333569 Patch 1398833 2 333569 commit-queue 2018-02-13 16:08:45 -0800 Comment on attachment 333569 Patch Clearing flags on attachment: 333569 Committed r228442: <https://trac.webkit.org/changeset/228442> 1398834 3 commit-queue 2018-02-13 16:08:46 -0800 All reviewed patches have been landed. Closing bug. 1398836 4 webkit-bug-importer 2018-02-13 16:09:47 -0800 <rdar://problem/37517744> 1399230 5 333569 ap 2018-02-14 13:23:18 -0800 Comment on attachment 333569 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333569&action=review > Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm:109 > + return _cacheStorageDirectoryURL.get(); Is it OK to just return internal objects here, or do we need copy+autorelease? 333569 2018-02-11 09:51:15 -0800 2018-02-13 16:08:45 -0800 Patch bug-182674-20180211095108.patch text/plain 5047 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4MzExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDUwNmQzZTk4MmZhNzNmZGZj ZGRkYzQ0Y2U1MmFiYjBlNjhhNGY0YjQuLjU4NTRkZjdkNWFjODk3OWE0ODgwY2ZmNDdhZmQ4M2Fh MjcxMjYyNzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTgtMDItMTEgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBzdXBwb3J0IGZvciBjb25m aWd1cmluZyBXZWJzaXRlRGF0YXN0b3JlIHNlcnZpY2Ugd29ya2VyIGFuZCBjYWNoZSBzdG9yYWdl IHBhdGgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4 MjY3NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJl ZWYgdXAgV0tXZWJzaXRlRGF0YVN0b3JlQ29uZmlndXJhdGlvbiB0byBlYXNpbHkgc2V0IHRoZSBX ZWJzaXRlRGF0YVN0b3JlCisgICAgICAgIHNlcnZpY2Ugd29ya2VyIHJlZ2lzdHJhdGlvbiBhbmQg Y2FjaGUgc3RvcmFnZSBkaXJlY3RvcnkgcGF0aC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkv Q29jb2EvV0tXZWJzaXRlRGF0YVN0b3JlLm1tOgorICAgICAgICAoLVtXS1dlYnNpdGVEYXRhU3Rv cmUgX2luaXRXaXRoQ29uZmlndXJhdGlvbjpdKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0Nv Y29hL19XS1dlYnNpdGVEYXRhU3RvcmVDb25maWd1cmF0aW9uLmg6CisgICAgICAgICogVUlQcm9j ZXNzL0FQSS9Db2NvYS9fV0tXZWJzaXRlRGF0YVN0b3JlQ29uZmlndXJhdGlvbi5tbToKKyAgICAg ICAgKC1bX1dLV2Vic2l0ZURhdGFTdG9yZUNvbmZpZ3VyYXRpb24gX2NhY2hlU3RvcmFnZURpcmVj dG9yeV0pOgorICAgICAgICAoLVtfV0tXZWJzaXRlRGF0YVN0b3JlQ29uZmlndXJhdGlvbiBfc2V0 Q2FjaGVTdG9yYWdlRGlyZWN0b3J5Ol0pOgorICAgICAgICAoLVtfV0tXZWJzaXRlRGF0YVN0b3Jl Q29uZmlndXJhdGlvbiBfc2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbkRpcmVjdG9yeV0pOgorICAg ICAgICAoLVtfV0tXZWJzaXRlRGF0YVN0b3JlQ29uZmlndXJhdGlvbiBfc2V0U2VydmljZVdvcmtl clJlZ2lzdHJhdGlvbkRpcmVjdG9yeTpdKToKKwogMjAxOC0wMi0wOCAgQ2hyaXMgRHVtZXogIDxj ZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFRoZXJlIHNob3VsZCBiZSBhIHdheSB0byBkaXNh YmxlIFtPdmVycmlkZUJ1aWx0aW5zXSBiZWhhdmlvciBpbiBhIGdpdmVuIERPTVdyYXBwZXJXb3Js ZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vic2l0 ZURhdGFTdG9yZS5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYnNp dGVEYXRhU3RvcmUubW0KaW5kZXggNDJjMjc3ZmRlMTAyZTNhNmY0MjQ4Y2RiNjFiMGI3ODI3ZWNj NWQwZi4uOGMzNWI5NTMyZTNmN2Q1Y2EwMjgwODliZjlkMmYyNjIyMjQwNzVlMCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vic2l0ZURhdGFTdG9yZS5t bQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJzaXRlRGF0YVN0 b3JlLm1tCkBAIC0yMDAsNiArMjAwLDEwIEBAIHN0YXRpYyBWZWN0b3I8V2ViS2l0OjpXZWJzaXRl RGF0YVJlY29yZD4gdG9XZWJzaXRlRGF0YVJlY29yZHMoTlNBcnJheSAqZGF0YVJlY29yCiAgICAg ICAgIGNvbmZpZy5jb29raWVTdG9yYWdlRmlsZSA9IGNvbmZpZ3VyYXRpb24uX2Nvb2tpZVN0b3Jh Z2VGaWxlLnBhdGg7CiAgICAgaWYgKGNvbmZpZ3VyYXRpb24uX3Jlc291cmNlTG9hZFN0YXRpc3Rp Y3NEaXJlY3RvcnkpCiAgICAgICAgIGNvbmZpZy5yZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGlyZWN0 b3J5ID0gY29uZmlndXJhdGlvbi5fcmVzb3VyY2VMb2FkU3RhdGlzdGljc0RpcmVjdG9yeS5wYXRo OworICAgIGlmIChjb25maWd1cmF0aW9uLl9jYWNoZVN0b3JhZ2VEaXJlY3RvcnkpCisgICAgICAg IGNvbmZpZy5jYWNoZVN0b3JhZ2VEaXJlY3RvcnkgPSBjb25maWd1cmF0aW9uLl9jYWNoZVN0b3Jh Z2VEaXJlY3RvcnkucGF0aDsKKyAgICBpZiAoY29uZmlndXJhdGlvbi5fc2VydmljZVdvcmtlclJl Z2lzdHJhdGlvbkRpcmVjdG9yeSkKKyAgICAgICAgY29uZmlnLnNlcnZpY2VXb3JrZXJSZWdpc3Ry YXRpb25EaXJlY3RvcnkgPSBjb25maWd1cmF0aW9uLl9zZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9u RGlyZWN0b3J5LnBhdGg7CiAKICAgICBBUEk6Ok9iamVjdDo6Y29uc3RydWN0SW5XcmFwcGVyPEFQ STo6V2Vic2l0ZURhdGFTdG9yZT4oc2VsZiwgY29uZmlnLCBQQUw6OlNlc3Npb25JRDo6Z2VuZXJh dGVQZXJzaXN0ZW50U2Vzc2lvbklEKCkpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BUEkvQ29jb2EvX1dLV2Vic2l0ZURhdGFTdG9yZUNvbmZpZ3VyYXRpb24uaCBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tXZWJzaXRlRGF0YVN0b3JlQ29uZmln dXJhdGlvbi5oCmluZGV4IDRlZGRmNjAxNGQzZGVmMzlmNmViZjBhMTdhYzNjNzAwNWJjNjFkOWIu LjdmNjQ0ZmMxYTZiNGE2NmM2MDA4ZDU2NmNjZmZkOTAyYTA5ZjA4NjggMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tXZWJzaXRlRGF0YVN0b3JlQ29uZmln dXJhdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tXZWJz aXRlRGF0YVN0b3JlQ29uZmlndXJhdGlvbi5oCkBAIC0zOSw2ICszOSw4IEBAIFdLX0NMQVNTX0FW QUlMQUJMRShtYWNvc3goMTAuMTMpLCBpb3MoMTEuMCkpCiBAcHJvcGVydHkgKG5vbmF0b21pYywg Y29weSwgc2V0dGVyPV9zZXRXZWJTUUxEYXRhYmFzZURpcmVjdG9yeTopIE5TVVJMICpfd2ViU1FM RGF0YWJhc2VEaXJlY3Rvcnk7CiBAcHJvcGVydHkgKG5vbmF0b21pYywgY29weSwgc2V0dGVyPV9z ZXRDb29raWVTdG9yYWdlRmlsZTopIE5TVVJMICpfY29va2llU3RvcmFnZUZpbGU7CiBAcHJvcGVy dHkgKG5vbmF0b21pYywgY29weSwgc2V0dGVyPV9zZXRSZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGly ZWN0b3J5OikgTlNVUkwgKl9yZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGlyZWN0b3J5IFdLX0FQSV9B VkFJTEFCTEUobWFjb3N4KFdLX01BQ19UQkEpLCBpb3MoV0tfSU9TX1RCQSkpOworQHByb3BlcnR5 IChub25hdG9taWMsIGNvcHksIHNldHRlcj1fc2V0Q2FjaGVTdG9yYWdlRGlyZWN0b3J5OikgTlNV UkwgKl9jYWNoZVN0b3JhZ2VEaXJlY3RvcnkgV0tfQVBJX0FWQUlMQUJMRShtYWNvc3goV0tfTUFD X1RCQSksIGlvcyhXS19JT1NfVEJBKSk7CitAcHJvcGVydHkgKG5vbmF0b21pYywgY29weSwgc2V0 dGVyPV9zZXRTZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uRGlyZWN0b3J5OikgTlNVUkwgKl9zZXJ2 aWNlV29ya2VyUmVnaXN0cmF0aW9uRGlyZWN0b3J5IFdLX0FQSV9BVkFJTEFCTEUobWFjb3N4KFdL X01BQ19UQkEpLCBpb3MoV0tfSU9TX1RCQSkpOwogCiBAZW5kCiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tXZWJzaXRlRGF0YVN0b3JlQ29uZmlndXJh dGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tXZWJzaXRlRGF0 YVN0b3JlQ29uZmlndXJhdGlvbi5tbQppbmRleCBlMDAxZWJkOThmMmM2OTk2ZTMxNWM1MTcyZGM1 OTExNzdmNDE2NzJjLi41MTlmYWQ4NDRhYzY1NmNiNTZhM2M4YmY1ZTQxYzI4NGZmMTE0MzIyIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLV2Vic2l0ZURh dGFTdG9yZUNvbmZpZ3VyYXRpb24ubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJ L0NvY29hL19XS1dlYnNpdGVEYXRhU3RvcmVDb25maWd1cmF0aW9uLm1tCkBAIC00Miw2ICs0Miw4 IEBAIHN0YXRpYyB2b2lkIGNoZWNrVVJMQXJndW1lbnQoTlNVUkwgKnVybCkKICAgICBSZXRhaW5Q dHI8TlNVUkw+IF93ZWJTUUxEYXRhYmFzZURpcmVjdG9yeVVSTDsKICAgICBSZXRhaW5QdHI8TlNV Ukw+IF9jb29raWVTdG9yYWdlRmlsZVVSTDsKICAgICBSZXRhaW5QdHI8TlNVUkw+IF9yZXNvdXJj ZUxvYWRTdGF0aXN0aWNzRGlyZWN0b3J5VVJMOworICAgIFJldGFpblB0cjxOU1VSTD4gX2NhY2hl U3RvcmFnZURpcmVjdG9yeVVSTDsKKyAgICBSZXRhaW5QdHI8TlNVUkw+IF9zZXJ2aWNlV29ya2Vy UmVnaXN0cmF0aW9uRGlyZWN0b3J5VVJMOwogfQogCiAtIChOU1VSTCAqKV93ZWJTdG9yYWdlRGly ZWN0b3J5CkBAIC0xMDIsNiArMTA0LDI4IEBAIHN0YXRpYyB2b2lkIGNoZWNrVVJMQXJndW1lbnQo TlNVUkwgKnVybCkKICAgICBfcmVzb3VyY2VMb2FkU3RhdGlzdGljc0RpcmVjdG9yeVVSTCA9IGFk b3B0TlMoW3VybCBjb3B5XSk7CiB9CiAKKy0gKE5TVVJMICopX2NhY2hlU3RvcmFnZURpcmVjdG9y eQoreworICAgIHJldHVybiBfY2FjaGVTdG9yYWdlRGlyZWN0b3J5VVJMLmdldCgpOworfQorCist ICh2b2lkKV9zZXRDYWNoZVN0b3JhZ2VEaXJlY3Rvcnk6KE5TVVJMICopdXJsCit7CisgICAgY2hl Y2tVUkxBcmd1bWVudCh1cmwpOworICAgIF9jYWNoZVN0b3JhZ2VEaXJlY3RvcnlVUkwgPSBhZG9w dE5TKFt1cmwgY29weV0pOworfQorCistIChOU1VSTCAqKV9zZXJ2aWNlV29ya2VyUmVnaXN0cmF0 aW9uRGlyZWN0b3J5Cit7CisgICAgcmV0dXJuIF9zZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uRGly ZWN0b3J5VVJMLmdldCgpOworfQorCistICh2b2lkKV9zZXRTZXJ2aWNlV29ya2VyUmVnaXN0cmF0 aW9uRGlyZWN0b3J5OihOU1VSTCAqKXVybAoreworICAgIGNoZWNrVVJMQXJndW1lbnQodXJsKTsK KyAgICBfc2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbkRpcmVjdG9yeVVSTCA9IGFkb3B0TlMoW3Vy bCBjb3B5XSk7Cit9CisKIEBlbmQKIAogI2VuZGlmCg==