182642 2018-02-09 08:53:49 -0800 Improve of string.h include after r228317. 2018-02-09 10:04:26 -0800 1 1 1 Unclassified WebKit bmalloc WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 clopez clopez clopez fpizlo ggaren mark.lam mcatanzaro msaboff saam webkit-bug-importer oldest_to_newest 1397952 0 clopez 2018-02-09 08:53:49 -0800 From https://bugs.webkit.org/show_bug.cgi?id=182563#c22 > (In reply to Carlos Alberto Lopez Perez from comment #20) > > Committed r228317: <https://trac.webkit.org/changeset/228317> > > We should avoid architecture-specific #includes whenever possible. Adding > one #include <string.h> is not going to slow down the build very much at > all; it's not worth the cost of the include guards, IMO. 1397954 1 333493 clopez 2018-02-09 09:04:29 -0800 Created attachment 333493 Patch 1397956 2 333494 clopez 2018-02-09 09:06:16 -0800 Created attachment 333494 Patch 1397988 3 333494 clopez 2018-02-09 10:03:07 -0800 Comment on attachment 333494 Patch Clearing flags on attachment: 333494 Committed r228324: <https://trac.webkit.org/changeset/228324> 1397989 4 clopez 2018-02-09 10:03:11 -0800 All reviewed patches have been landed. Closing bug. 1397993 5 webkit-bug-importer 2018-02-09 10:04:26 -0800 <rdar://problem/37394750> 333493 2018-02-09 09:04:29 -0800 2018-02-09 09:06:09 -0800 Patch bug-182642-20180209180428.patch text/plain 1208 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4MzE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggYzVhN2JjOTFjZjExNmQ0 YWE5Y2M1YTAyYzI5ODA5NWEzMTJhNjNmNC4uZTI1YzExYmVkZmYwM2RlN2M5NzJiOGQxMzUyZDI0 YjA1ZDY0NzliYyAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE0IEBACiAyMDE4LTAyLTA5ICBDYXJs b3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgogCisgICAgICAgIElt cHJvdmUgb2Ygc3RyaW5nLmggaW5jbHVkZSBhZnRlciByMjI4MzE3LgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyNjQyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBibWFsbG9jL0FsZ29yaXRobS5oOiBB dm9pZCBhbiBhcmNoaXRlY3R1cmUtc3BlY2lmaWMgI2luY2x1ZGUuCisKKzIwMTgtMDItMDkgIENh cmxvcyBBbGJlcnRvIExvcGV6IFBlcmV6ICA8Y2xvcGV6QGlnYWxpYS5jb20+CisKICAgICAgICAg Rml4IGJ1aWxkIGZvciAhQkNQVShYODZfNjQpIGFmdGVyIHIyMjgzMDYKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjU2MwogCmRpZmYgLS1naXQgYS9T b3VyY2UvYm1hbGxvYy9ibWFsbG9jL0FsZ29yaXRobS5oIGIvU291cmNlL2JtYWxsb2MvYm1hbGxv Yy9BbGdvcml0aG0uaAppbmRleCA4NmE1ZjkyYmFhY2JjZmQ4ZDAyNzkwMGVlNDZmNjg2OTA1YzEz MmFkLi43NzI0MTMyYzU4MzZlZDA5ZjJmZWU0OThkZTBiZGE2NmU5ZGRmMWQ1IDEwMDY0NAotLS0g YS9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0FsZ29yaXRobS5oCisrKyBiL1NvdXJjZS9ibWFsbG9j L2JtYWxsb2MvQWxnb3JpdGhtLmgKQEAgLTMxLDEyICszMSwxMCBAQAogI2luY2x1ZGUgPGNzdGRp bnQ+CiAjaW5jbHVkZSA8Y3N0ZGRlZj4KICNpbmNsdWRlIDxsaW1pdHM+CisjaW5jbHVkZSA8c3Ry aW5nLmg+CiAjaW5jbHVkZSA8dHlwZV90cmFpdHM+CiAjaW5jbHVkZSA8Y2hyb25vPgogCi0jaWYg IUJDUFUoWDg2XzY0KQotI2luY2x1ZGUgPHN0cmluZy5oPgotI2VuZGlmCiAKIG5hbWVzcGFjZSBi bWFsbG9jIHsKIAo= 333494 2018-02-09 09:06:16 -0800 2018-02-09 10:03:07 -0800 Patch bug-182642-20180209180615.patch text/plain 1285 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4MzE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggYzVhN2JjOTFjZjExNmQ0 YWE5Y2M1YTAyYzI5ODA5NWEzMTJhNjNmNC4uZTI1YzExYmVkZmYwM2RlN2M5NzJiOGQxMzUyZDI0 YjA1ZDY0NzliYyAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE0IEBACiAyMDE4LTAyLTA5ICBDYXJs b3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgogCisgICAgICAgIElt cHJvdmUgb2Ygc3RyaW5nLmggaW5jbHVkZSBhZnRlciByMjI4MzE3LgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyNjQyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBibWFsbG9jL0FsZ29yaXRobS5oOiBB dm9pZCBhbiBhcmNoaXRlY3R1cmUtc3BlY2lmaWMgI2luY2x1ZGUuCisKKzIwMTgtMDItMDkgIENh cmxvcyBBbGJlcnRvIExvcGV6IFBlcmV6ICA8Y2xvcGV6QGlnYWxpYS5jb20+CisKICAgICAgICAg Rml4IGJ1aWxkIGZvciAhQkNQVShYODZfNjQpIGFmdGVyIHIyMjgzMDYKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjU2MwogCmRpZmYgLS1naXQgYS9T b3VyY2UvYm1hbGxvYy9ibWFsbG9jL0FsZ29yaXRobS5oIGIvU291cmNlL2JtYWxsb2MvYm1hbGxv Yy9BbGdvcml0aG0uaAppbmRleCA4NmE1ZjkyYmFhY2JjZmQ4ZDAyNzkwMGVlNDZmNjg2OTA1YzEz MmFkLi43OTQ4ZjQzMmFmMjZlZTVmNGI1NDBlYmJmODE1NDVkOTI0NzY0NWQyIDEwMDY0NAotLS0g YS9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0FsZ29yaXRobS5oCisrKyBiL1NvdXJjZS9ibWFsbG9j L2JtYWxsb2MvQWxnb3JpdGhtLmgKQEAgLTMxLDEzICszMSwxMCBAQAogI2luY2x1ZGUgPGNzdGRp bnQ+CiAjaW5jbHVkZSA8Y3N0ZGRlZj4KICNpbmNsdWRlIDxsaW1pdHM+CisjaW5jbHVkZSA8c3Ry aW5nLmg+CiAjaW5jbHVkZSA8dHlwZV90cmFpdHM+CiAjaW5jbHVkZSA8Y2hyb25vPgogCi0jaWYg IUJDUFUoWDg2XzY0KQotI2luY2x1ZGUgPHN0cmluZy5oPgotI2VuZGlmCi0KIG5hbWVzcGFjZSBi bWFsbG9jIHsKIAogLy8gVmVyc2lvbnMgb2YgbWluIGFuZCBtYXggdGhhdCBhcmUgY29tcGF0aWJs ZSB3aXRoIGNvbXBpbGUtdGltZSBjb25zdGFudHMuCg==