182624 2018-02-08 13:57:55 -0800 Switch http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-deletion.html from testRunner.installStatisticsDidModifyDataRecordsCallback() to testRunner.installStatisticsDidScanDataRecordsCallback() 2018-02-12 16:09:45 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=182719 InRadar P2 Normal --- 1 wilander wilander jlewis3 lforschler ryanhaddad webkit-bug-importer oldest_to_newest 1397707 0 wilander 2018-02-08 13:57:55 -0800 We should switch from testRunner.installStatisticsDidModifyDataRecordsCallback() to testRunner.installStatisticsDidScanDataRecordsCallback() in http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-deletion.html to make it not be a flaky timeout. 1397708 1 webkit-bug-importer 2018-02-08 13:58:26 -0800 <rdar://problem/37364749> 1397712 2 wilander 2018-02-08 14:00:50 -0800 Committed r228294: <https://trac.webkit.org/changeset/228294> 1398153 3 ryanhaddad 2018-02-09 16:33:57 -0800 Good news: the test isn't a flaky timeout anymore. Bad news: it is a flaky failure. --- /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-deletion-expected.txt +++ /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-deletion-actual.txt @@ -27,13 +27,13 @@ -------- After removal, should receive no cookies. Did not receive cookie named 'firstPartyCookie'. -Did not receive cookie named 'thirdPartyCookie'. -Client-side document.cookie: +Received cookie named 'thirdPartyCookie'. +Client-side document.cookie: thirdPartyCookie=value -------- Frame: '<!--framePath //<!--frame4-->-->' -------- After user interaction, should receive no cookies. -Did not receive cookie named 'firstPartyCookie'. +Received cookie named 'firstPartyCookie'. Did not receive cookie named 'thirdPartyCookie'. -Client-side document.cookie: +Client-side document.cookie: firstPartyCookie=value https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/r228318%20(2007)/results.html 1398170 4 wilander 2018-02-09 17:08:12 -0800 I think I understand why this happens. This is down to flakiness of cookies. Earlier, we sometimes didn't get the notification of data records removal so we timed out. Now we instead wait for a notification of data records scanning which sometimes fires before removal has finished underneath us. So cookies are still there. :( 1398519 5 jlewis3 2018-02-12 15:59:21 -0800 Marked as flaky in https://trac.webkit.org/changeset/228403/webkit