182610 2018-02-08 11:48:55 -0800 [MIPS] JSC needs to be built with -latomic 2018-02-11 23:33:28 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=182622 InRadar P2 Normal --- 1 guijemont webkit-unassigned aperez commit-queue webkit-bug-importer zan oldest_to_newest 1397622 0 guijemont 2018-02-08 11:48:55 -0800 Since r228149, on MIPS we need to link with -latomic, since __atomic_fetch_add_8 is not available as a compiler intrinsic. 1397668 1 333412 guijemont 2018-02-08 12:52:02 -0800 Created attachment 333412 Patch Patch fixing this. 1397671 2 333412 zan 2018-02-08 12:56:49 -0800 Comment on attachment 333412 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333412&action=review > Source/JavaScriptCore/CMakeLists.txt:125 > +if (WTF_CPU_MIPS) > + list(APPEND JavaScriptCore_LIBRARIES > + -latomic > + ) > +endif () Similar comment to what's in the ChangeLog would be nice here as well. 1397677 3 333412 aperez 2018-02-08 13:02:07 -0800 Comment on attachment 333412 Patch In Source/WebKit/CMakeLists.txt, after line 780, there's a check that tries to compile a snippet which uses “std::atomic<int64_t>” and determines whether using libatomic is needed or not. Instead of unconditionally adding the library as your patch does, could you please change the CMake code there so it adds it conditionally? The resulting snippet patch should be something like: if (ATOMIC_INT64_REQUIRES_LIBATOMIC) list(APPEND WebKit_LIBRARIES atomic) + list(APPEND JavaScriptCore_LIBRARIES atomic) endif () Thanks! 1397679 4 aperez 2018-02-08 13:04:45 -0800 (In reply to Adrian Perez from comment #3) > Comment on attachment 333412 [details] > Patch > > In Source/WebKit/CMakeLists.txt, after line 780, there's a check > that tries to compile a snippet which uses “std::atomic<int64_t>” > and determines whether using libatomic is needed or not. Instead > of unconditionally adding the library as your patch does, could > you please change the CMake code there so it adds it conditionally? > > The resulting snippet patch should be something like: > > if (ATOMIC_INT64_REQUIRES_LIBATOMIC) > list(APPEND WebKit_LIBRARIES atomic) > + list(APPEND JavaScriptCore_LIBRARIES atomic) > endif () > > Thanks! Correction: This is in the CMakeLists.txt for *WebKit*, so it would be better to move the check to one of the top-level CMakeLists.txt and then in Source/JavaScriptCore/CMakeLists.txt append the library conditionally to the list. 1397969 5 333495 guijemont 2018-02-09 09:28:55 -0800 Created attachment 333495 Patch New patch addressing Zan's comments. 1397970 6 guijemont 2018-02-09 09:30:32 -0800 Note that this is to fix the build quickly. A more correct solution will be developed in bug#182622. 1398320 7 333495 commit-queue 2018-02-11 23:32:20 -0800 Comment on attachment 333495 Patch Clearing flags on attachment: 333495 Committed r228370: <https://trac.webkit.org/changeset/228370> 1398321 8 commit-queue 2018-02-11 23:32:22 -0800 All reviewed patches have been landed. Closing bug. 1398322 9 webkit-bug-importer 2018-02-11 23:33:28 -0800 <rdar://problem/37451082> 333412 2018-02-08 12:52:02 -0800 2018-02-09 09:28:52 -0800 Patch bug-182610-20180208145202.patch text/plain 1446 guijemont U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4MjI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 NjdlMmU0ODFjODNmN2UxNDkyYTMwNWZmZjQ2ZGI3MDgxY2FkOTQyLi5kMmNmOThjZDlhOTA2ZDBj MmJiNDlhYjNiMDE0NTQzOGQwNDQwYzhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOC0wMi0wOCAgR3VpbGxhdW1lIEVtb250ICA8Z3VpamVtb250QGlnYWxp YS5jb20+CisKKyAgICAgICAgW01JUFNdIEpTQyBuZWVkcyB0byBiZSBidWlsdCB3aXRoIC1sYXRv bWljCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODI2 MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaW5j ZSByMjI4MTQ5LCBvbiBNSVBTIHdlIG5lZWQgdG8gbGluayB3aXRoIC1sYXRvbWljLCBiZWNhdXNl CisgICAgICAgIF9fYXRvbWljX2ZldGNoX2FkZF84IGlzIG5vdCBhdmFpbGFibGUgYXMgYSBjb21w aWxlciBpbnRyaW5zaWMuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDoKKwogMjAxOC0wMi0w NiAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9y OiBwcm90b2NvbCBnZW5lcmF0b3Igc2hvdWxkIGF1dG9tYXRpY2FsbHkgZGVkdWNlIHRoZSBjb3Jy ZWN0IGluY2x1ZGUgc3R5bGUgdG8gdXNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQK aW5kZXggMGY3ZTFlNGE1NzU3Y2NjYWUwNTRkZTZkODNjYTQ4ZDRmNzkwZjE1Yy4uMjVkNGUxOGRj ZDE3YzYyYjNkODk2NzRkYWEwM2RkOTM3YzQ3OTc2NSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFr ZUxpc3RzLnR4dApAQCAtMTE4LDYgKzExOCwxMiBAQCBzZXQoSmF2YVNjcmlwdENvcmVfTElCUkFS SUVTCiAgICAgJHtMTFZNX0xJQlJBUklFU30KICkKIAoraWYgKFdURl9DUFVfTUlQUykKKyAgICBs aXN0KEFQUEVORCBKYXZhU2NyaXB0Q29yZV9MSUJSQVJJRVMKKyAgICAgICAgLWxhdG9taWMKKyAg ICApCitlbmRpZiAoKQorCiBzZXQoSmF2YVNjcmlwdENvcmVfU0NSSVBUU19TT1VSQ0VTX0RJUiAi JHtKQVZBU0NSSVBUQ09SRV9ESVJ9L1NjcmlwdHMiKQogCiAjIEdsb2JiaW5nIHJlbGllcyBvbiB0 aGUgZmFjdCB0aGF0IGdlbmVyYXRvci1zcGVjaWZpYyBmaWxlIG5hbWVzIGFyZSBwcmVmaXhlZCB3 aXRoIHRoZWlyIGRpcmVjdG9yeS4K 333495 2018-02-09 09:28:55 -0800 2018-02-11 23:32:20 -0800 Patch bug-182610-20180209112854.patch text/plain 1692 guijemont U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4MjI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 NjdlMmU0ODFjODNmN2UxNDkyYTMwNWZmZjQ2ZGI3MDgxY2FkOTQyLi5kMmNmOThjZDlhOTA2ZDBj MmJiNDlhYjNiMDE0NTQzOGQwNDQwYzhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOC0wMi0wOCAgR3VpbGxhdW1lIEVtb250ICA8Z3VpamVtb250QGlnYWxp YS5jb20+CisKKyAgICAgICAgW01JUFNdIEpTQyBuZWVkcyB0byBiZSBidWlsdCB3aXRoIC1sYXRv bWljCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODI2 MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaW5j ZSByMjI4MTQ5LCBvbiBNSVBTIHdlIG5lZWQgdG8gbGluayB3aXRoIC1sYXRvbWljLCBiZWNhdXNl CisgICAgICAgIF9fYXRvbWljX2ZldGNoX2FkZF84IGlzIG5vdCBhdmFpbGFibGUgYXMgYSBjb21w aWxlciBpbnRyaW5zaWMuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDoKKwogMjAxOC0wMi0w NiAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9y OiBwcm90b2NvbCBnZW5lcmF0b3Igc2hvdWxkIGF1dG9tYXRpY2FsbHkgZGVkdWNlIHRoZSBjb3Jy ZWN0IGluY2x1ZGUgc3R5bGUgdG8gdXNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQK aW5kZXggMGY3ZTFlNGE1NzU3Y2NjYWUwNTRkZTZkODNjYTQ4ZDRmNzkwZjE1Yy4uMjU4ZGRiOWZk ODJiNTlhZjQ1Nzk1NWE2YzMxYzFmM2JjNDkwY2FkMSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFr ZUxpc3RzLnR4dApAQCAtMTE4LDYgKzExOCwxNiBAQCBzZXQoSmF2YVNjcmlwdENvcmVfTElCUkFS SUVTCiAgICAgJHtMTFZNX0xJQlJBUklFU30KICkKIAorIyBTaW5jZSByMjI4MTQ5LCBvbiBNSVBT IHdlIG5lZWQgdG8gbGluayB3aXRoIC1sYXRvbWljLCBiZWNhdXNlCisjIF9fYXRvbWljX2ZldGNo X2FkZF84IGlzIG5vdCBhdmFpbGFibGUgYXMgYSBjb21waWxlciBpbnRyaW5zaWMuIEl0IGlzCisj IGF2YWlsYWJsZSBvbiBvdGhlciBwbGF0Zm9ybXMgKGluY2x1ZGluZyAzMi1iaXQgQXJtKSwgc28g dGhlIGxpbmsgd2l0aAorIyBsaWJhdG9taWMgaXMgb25seSBuZWVkZSBvbiBNSVBTLgoraWYgKFdU Rl9DUFVfTUlQUykKKyAgICBsaXN0KEFQUEVORCBKYXZhU2NyaXB0Q29yZV9MSUJSQVJJRVMKKyAg ICAgICAgLWxhdG9taWMKKyAgICApCitlbmRpZiAoKQorCiBzZXQoSmF2YVNjcmlwdENvcmVfU0NS SVBUU19TT1VSQ0VTX0RJUiAiJHtKQVZBU0NSSVBUQ09SRV9ESVJ9L1NjcmlwdHMiKQogCiAjIEds b2JiaW5nIHJlbGllcyBvbiB0aGUgZmFjdCB0aGF0IGdlbmVyYXRvci1zcGVjaWZpYyBmaWxlIG5h bWVzIGFyZSBwcmVmaXhlZCB3aXRoIHRoZWlyIGRpcmVjdG9yeS4K