<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>182607</bug_id>
          
          <creation_ts>2018-02-08 10:07:31 -0800</creation_ts>
          <short_desc>[RenderTreeBuilder] Do not use RenderTreeBuilder::current() in RenderRubyRun::takeChild</short_desc>
          <delta_ts>2018-02-08 12:49:56 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="alan">zalan</reporter>
          <assigned_to name="alan">zalan</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>commit-queue</cc>
    
    <cc>koivisto</cc>
    
    <cc>sam</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1397566</commentid>
    <comment_count>0</comment_count>
    <who name="alan">zalan</who>
    <bug_when>2018-02-08 10:07:31 -0800</bug_when>
    <thetext>we&apos;ve got the builder argument.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397567</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-02-08 10:08:03 -0800</bug_when>
    <thetext>&lt;rdar://problem/37355944&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397571</commentid>
    <comment_count>2</comment_count>
      <attachid>333384</attachid>
    <who name="alan">zalan</who>
    <bug_when>2018-02-08 10:12:03 -0800</bug_when>
    <thetext>Created attachment 333384
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397621</commentid>
    <comment_count>3</comment_count>
      <attachid>333384</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-02-08 11:48:53 -0800</bug_when>
    <thetext>Comment on attachment 333384
Patch

Rejecting attachment 333384 from commit-queue.

Failed to run &quot;[&apos;/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=webkit-queues.webkit.org&apos;, &apos;--bot-id=webkit-cq-01&apos;, &apos;apply-attachment&apos;, &apos;--no-update&apos;, &apos;--non-interactive&apos;, 333384, &apos;--port=mac&apos;]&quot; exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
u&apos;Sam Weinig&apos;]&quot; exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/rendering/RenderRubyRun.cpp
Hunk #1 FAILED at 110.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/RenderRubyRun.cpp.rej

Failed to run &quot;[u&apos;/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply&apos;, &apos;--force&apos;, &apos;--reviewer&apos;, u&apos;Sam Weinig&apos;]&quot; exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/6418483</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397630</commentid>
    <comment_count>4</comment_count>
      <attachid>333402</attachid>
    <who name="alan">zalan</who>
    <bug_when>2018-02-08 12:00:50 -0800</bug_when>
    <thetext>Created attachment 333402
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397661</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-02-08 12:49:26 -0800</bug_when>
    <thetext>The commit-queue encountered the following flaky tests while processing attachment 333402:

media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen.html bug 182571 (authors: graouts@apple.com and ryanhaddad@apple.com)
The commit-queue is continuing to process your patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397664</commentid>
    <comment_count>6</comment_count>
      <attachid>333402</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-02-08 12:49:55 -0800</bug_when>
    <thetext>Comment on attachment 333402
Patch

Clearing flags on attachment: 333402

Committed r228289: &lt;https://trac.webkit.org/changeset/228289&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397665</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-02-08 12:49:56 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>333384</attachid>
            <date>2018-02-08 10:12:03 -0800</date>
            <delta_ts>2018-02-08 12:00:49 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-182607-20180208101202.patch</filename>
            <type>text/plain</type>
            <size>1836</size>
            <attacher name="alan">zalan</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4Mjc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDRjMWNjOGUyZmZhMTI4
OTQ3MzNhOGU1M2VmNDAxOTI0YThjM2U2NS4uM2EwZjczMmI4MWNhZmU1Nzk1MzA3ZDdhMDFkMmI2
NGExZDhjZThlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTAyLTA4ICBaYWxh
biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1JlbmRlclRyZWVCdWlsZGVy
XSBEbyBub3QgdXNlIFJlbmRlclRyZWVCdWlsZGVyOjpjdXJyZW50KCkgaW4gUmVuZGVyUnVieVJ1
bjo6dGFrZUNoaWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD0xODI2MDcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM3MzU1OTQ0PgorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIGNoYW5nZSBpbiBmdW5j
dGlvbmFsaXR5LgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclJ1YnlSdW4uY3BwOgorICAg
ICAgICAoV2ViQ29yZTo6UmVuZGVyUnVieVJ1bjo6dGFrZUNoaWxkKToKKwogMjAxOC0wMi0wOCAg
WmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtSZW5kZXJUcmVlQnVp
bGRlcl0gTW92ZSBSZW5kZXJFbGVtZW50OjpyZW1vdmVBbm9ueW1vdXNXcmFwcGVyc0ZvcklubGlu
ZXNJZk5lY2Vzc2FyeSB0byBSZW5kZXJUcmVlQnVpbGRlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YkNvcmUvcmVuZGVyaW5nL1JlbmRlclJ1YnlSdW4uY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy
aW5nL1JlbmRlclJ1YnlSdW4uY3BwCmluZGV4IDRhZWE1OWZkZGZjYTY1NzUyMmQ1ZjBlZWFiMmY3
MmIxMDA5OWJkMDYuLmIxNjA2NGE3NzcwNTZkMWQ4OTNiNTk0ZjY2YmZmYzBlNjA0MDRhYTcgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJSdWJ5UnVuLmNwcAorKysg
Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUnVieVJ1bi5jcHAKQEAgLTExMCw3ICsx
MTAsNyBAQCBSZW5kZXJQdHI8UmVuZGVyT2JqZWN0PiBSZW5kZXJSdWJ5UnVuOjp0YWtlQ2hpbGQo
UmVuZGVyVHJlZUJ1aWxkZXImIGJ1aWxkZXIsIFJlbgogICAgICAgICAgICAgaWYgKHJpZ2h0UnVu
Lmhhc1J1YnlCYXNlKCkpIHsKICAgICAgICAgICAgICAgICBSZW5kZXJSdWJ5QmFzZSogcmlnaHRC
YXNlID0gcmlnaHRSdW4ucnVieUJhc2UoKTsKICAgICAgICAgICAgICAgICAvLyBDb2xsZWN0IGFs
bCBjaGlsZHJlbiBpbiBhIHNpbmdsZSBiYXNlLCB0aGVuIHN3YXAgdGhlIGJhc2VzLgotICAgICAg
ICAgICAgICAgIFJlbmRlclRyZWVCdWlsZGVyOjpjdXJyZW50KCktPm1vdmVSdWJ5Q2hpbGRyZW4o
KnJpZ2h0QmFzZSwgKmJhc2UpOworICAgICAgICAgICAgICAgIGJ1aWxkZXIubW92ZVJ1YnlDaGls
ZHJlbigqcmlnaHRCYXNlLCAqYmFzZSk7CiAgICAgICAgICAgICAgICAgbW92ZUNoaWxkVG8oJnJp
Z2h0UnVuLCBiYXNlLCBSZW5kZXJCb3hNb2RlbE9iamVjdDo6Tm9ybWFsaXplQWZ0ZXJJbnNlcnRp
b246Ok5vKTsKICAgICAgICAgICAgICAgICByaWdodFJ1bi5tb3ZlQ2hpbGRUbyh0aGlzLCByaWdo
dEJhc2UsIFJlbmRlckJveE1vZGVsT2JqZWN0OjpOb3JtYWxpemVBZnRlckluc2VydGlvbjo6Tm8p
OwogICAgICAgICAgICAgICAgIC8vIFRoZSBub3cgZW1wdHkgcnVieSBiYXNlIHdpbGwgYmUgcmVt
b3ZlZCBiZWxvdy4K
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>333402</attachid>
            <date>2018-02-08 12:00:50 -0800</date>
            <delta_ts>2018-02-08 12:49:55 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-182607-20180208120049.patch</filename>
            <type>text/plain</type>
            <size>1796</size>
            <attacher name="alan">zalan</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4Mjg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmRmYjdkMDQxMWFkYmE0
OWZjMmJlYjVkMzUyM2QzZTc4MjlmNmU5NS4uOTBhYmQ0ZjdiNTUyZTI4MTA3NDFkMjlhOGIxN2Rj
YWM2YTNjZjdiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTAyLTA4ICBaYWxh
biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1JlbmRlclRyZWVCdWlsZGVy
XSBEbyBub3QgdXNlIFJlbmRlclRyZWVCdWlsZGVyOjpjdXJyZW50KCkgaW4gUmVuZGVyUnVieVJ1
bjo6dGFrZUNoaWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD0xODI2MDcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM3MzU1OTQ0PgorCisgICAgICAg
IFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCisKKyAgICAgICAgTm8gY2hhbmdlIGluIGZ1bmN0aW9u
YWxpdHkuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyUnVieVJ1bi5jcHA6CisgICAgICAg
IChXZWJDb3JlOjpSZW5kZXJSdWJ5UnVuOjp0YWtlQ2hpbGQpOgorCiAyMDE4LTAyLTA4ICBBbnR0
aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBVc2UgaW52YWxpZGF0aW9u
IHJ1bGVzZXRzIGZvciBhdHRyaWJ1dGUgc2VsZWN0b3JzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi
Q29yZS9yZW5kZXJpbmcvUmVuZGVyUnVieVJ1bi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp
bmcvUmVuZGVyUnVieVJ1bi5jcHAKaW5kZXggNWJlNDc1OTU0OWFmZjI0NWQ4YTA4OTFhNGJmMzhh
NWUwMDJmMmNjYy4uMjYyYjYzYmIyMjgxZjNjNGI4MjUyNThlZTdlMTU5MjcyMzk5NGQ4MSAxMDA2
NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclJ1YnlSdW4uY3BwCisrKyBi
L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJSdWJ5UnVuLmNwcApAQCAtMTEwLDcgKzEx
MCw3IEBAIFJlbmRlclB0cjxSZW5kZXJPYmplY3Q+IFJlbmRlclJ1YnlSdW46OnRha2VDaGlsZChS
ZW5kZXJUcmVlQnVpbGRlciYgYnVpbGRlciwgUmVuCiAgICAgICAgICAgICBpZiAocmlnaHRSdW4u
aGFzUnVieUJhc2UoKSkgewogICAgICAgICAgICAgICAgIFJlbmRlclJ1YnlCYXNlKiByaWdodEJh
c2UgPSByaWdodFJ1bi5ydWJ5QmFzZSgpOwogICAgICAgICAgICAgICAgIC8vIENvbGxlY3QgYWxs
IGNoaWxkcmVuIGluIGEgc2luZ2xlIGJhc2UsIHRoZW4gc3dhcCB0aGUgYmFzZXMuCi0gICAgICAg
ICAgICAgICAgUmVuZGVyVHJlZUJ1aWxkZXI6OmN1cnJlbnQoKS0+bW92ZVJ1YnlDaGlsZHJlbigq
cmlnaHRCYXNlLCAqYmFzZSk7CisgICAgICAgICAgICAgICAgYnVpbGRlci5tb3ZlUnVieUNoaWxk
cmVuKCpyaWdodEJhc2UsICpiYXNlKTsKICAgICAgICAgICAgICAgICBtb3ZlQ2hpbGRUbyhidWls
ZGVyLCAmcmlnaHRSdW4sIGJhc2UsIFJlbmRlckJveE1vZGVsT2JqZWN0OjpOb3JtYWxpemVBZnRl
ckluc2VydGlvbjo6Tm8pOwogICAgICAgICAgICAgICAgIHJpZ2h0UnVuLm1vdmVDaGlsZFRvKGJ1
aWxkZXIsIHRoaXMsIHJpZ2h0QmFzZSwgUmVuZGVyQm94TW9kZWxPYmplY3Q6Ok5vcm1hbGl6ZUFm
dGVySW5zZXJ0aW9uOjpObyk7CiAgICAgICAgICAgICAgICAgLy8gVGhlIG5vdyBlbXB0eSBydWJ5
IGJhc2Ugd2lsbCBiZSByZW1vdmVkIGJlbG93Lgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>