182591 2018-02-07 17:25:48 -0800 ASSERTION FAILED: vm->currentThreadIsHoldingAPILock() seen with http/tests/paymentrequest/payment-request-show-method.https.html 2018-02-07 20:11:45 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad aestes aestes cdumez commit-queue jlewis3 keith_miller mark.lam sam thorton webkit-bug-importer youennf oldest_to_newest 1397397 0 ryanhaddad 2018-02-07 17:25:48 -0800 LayoutTest http/tests/paymentrequest/payment-request-show-method.https.html is frequently failing an assertion on the bots: ASSERTION FAILED: vm->currentThreadIsHoldingAPILock() ./runtime/VM.cpp(1031) : void JSC::sanitizeStackForVM(JSC::VM *) 1 0x1133ea41d WTFCrash 2 0x11328e4ad JSC::sanitizeStackForVM(JSC::VM*) 3 0x1129706dc JSC::DFG::prepareOSREntry(JSC::ExecState*, JSC::CodeBlock*, unsigned int) 4 0x112dc032b operationOptimize 5 0x4d0b3916730 6 0x11241d08e llint_entry 7 0x112415002 vmEntryToJavaScript 8 0x112db326e JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) 9 0x112d583c5 JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) 10 0x112fc280a JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) 11 0x1172dd8fb WebCore::callFunction(JSC::ExecState&, JSC::JSValue, JSC::JSValue, JSC::ArgList const&) 12 0x1172dd735 WebCore::DOMPromise::whenSettled(std::__1::function<void ()>&&) 13 0x1170b4257 WebCore::PaymentRequest::whenDetailsSettled(std::__1::function<void ()>&&) 14 0x1170b40ab WebCore::PaymentRequest::shippingAddressChanged(WTF::Ref<WebCore::PaymentAddress, WTF::DumbPtrTraits<WebCore::PaymentAddress> >&&) 15 0x116dbf40d WebCore::ApplePayPaymentHandler::didSelectShippingContact(WebCore::PaymentContact const&) 16 0x116dbf45c non-virtual thunk to WebCore::ApplePayPaymentHandler::didSelectShippingContact(WebCore::PaymentContact const&) 17 0x116dbb82e WebCore::PaymentCoordinator::didSelectShippingContact(WebCore::PaymentContact const&) 18 0x12f0f5bc3 WebCore::MockPaymentCoordinator::completeMerchantValidation(WebCore::PaymentMerchantSession const&)::$_3::operator()() 19 0x12f0f5a89 WTF::Function<void ()>::CallableWrapper<WebCore::MockPaymentCoordinator::completeMerchantValidation(WebCore::PaymentMerchantSession const&)::$_3>::call() 20 0x12f0bdf6b WTF::Function<void ()>::operator()() const 21 0x12f0f116c WebCore::dispatchIfShowing(WTF::Function<void ()>&&)::$_8::operator()() const 22 0x12f0f1089 WTF::Function<void ()>::CallableWrapper<WebCore::dispatchIfShowing(WTF::Function<void ()>&&)::$_8>::call() 23 0x1134066ab WTF::Function<void ()>::operator()() const 24 0x113449d23 WTF::RunLoop::performWork() 25 0x11344a5c4 WTF::RunLoop::performWork(void*) 26 0x10afe22b1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 27 0x10b081d31 __CFRunLoopDoSource0 28 0x10afc6c19 __CFRunLoopDoSources0 29 0x10afc61ff __CFRunLoopRun 30 0x10afc5a89 CFRunLoopRunSpecific 31 0x10689de5e -[NSRunLoop(NSRunLoop) runMode:beforeDate:] LEAK: 1 WebPageProxy https://build.webkit.org/results/Apple%20iOS%2011%20Simulator%20Debug%20WK2%20(Tests)/r228244%20(2594)/results.html 1397401 1 333343 aestes 2018-02-07 17:38:26 -0800 Created attachment 333343 Patch 1397406 2 keith_miller 2018-02-07 17:56:51 -0800 LGTM too. As an update to our offline discussion, you can totally hold the API lock as many times as you want. 1397437 3 333343 commit-queue 2018-02-07 20:10:13 -0800 Comment on attachment 333343 Patch Clearing flags on attachment: 333343 Committed r228258: <https://trac.webkit.org/changeset/228258> 1397438 4 commit-queue 2018-02-07 20:10:14 -0800 All reviewed patches have been landed. Closing bug. 1397439 5 webkit-bug-importer 2018-02-07 20:11:44 -0800 <rdar://problem/37339056> 333343 2018-02-07 17:38:26 -0800 2018-02-07 20:10:13 -0800 Patch bug-182591-20180207173826.patch text/plain 1852 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4MjQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGU3YmIxOTYxZDg3Mjcy MmJiMDIwNjYyNTY2MWZkOGYzNTVmYTk2Ni4uNDY5ODE5OGVlOGM5OGNjMzgwNmFkZjdmODEyYmFm ZmNjNWM2NjBjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE4LTAyLTA3ICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBBU1NFUlRJT04gRkFJTEVEOiB2 bS0+Y3VycmVudFRocmVhZElzSG9sZGluZ0FQSUxvY2soKSBzZWVuIHdpdGggaHR0cC90ZXN0cy9w YXltZW50cmVxdWVzdC9wYXltZW50LXJlcXVlc3Qtc2hvdy1tZXRob2QuaHR0cHMuaHRtbAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyNTkxCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZXMgYXNzZXJ0 aW9uIGZhaWx1cmVzIGluIGh0dHAvdGVzdHMvcGF5bWVudHJlcXVlc3QvcGF5bWVudC1yZXF1ZXN0 LXNob3ctbWV0aG9kLmh0dHBzLmh0bWwuCisKKyAgICAgICAgRE9NUHJvbWlzZTo6d2hlblNldHRs ZWQoKSBjYWxscyB0aGUgSlNDIEFQSSB3aXRob3V0IGZpcnN0IGFxdWlyaW5nIHRoZSBBUEkgbG9j aywgYW5kCisgICAgICAgIHIyMjgxOTUgYWRkZWQgYSBjYWxsIHRvIHdoZW5TZXR0bGVkKCkgd2hl cmUgdGhlIGxvY2sgaXMgbm90IGd1YXJhbnRlZWQgdG8gYmUgYWxyZWFkeQorICAgICAgICBhY3F1 aXJlZC4KKworICAgICAgICBGaXggdGhpcyBieSBjcmVhdGluZyBhIEpTTG9ja0hvbGRlciBpbiBE T01Qcm9taXNlOjp3aGVuU2V0dGxlZCgpLgorCisgICAgICAgICogYmluZGluZ3MvanMvSlNET01Q cm9taXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRPTVByb21pc2U6OndoZW5TZXR0bGVkKToK KwogMjAxOC0wMi0wNyAgUGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAg ICAgICAgQXNzZXJ0IHRoYXQgTlNBcHAgaXMgbm90IHJ1bm5pbmcgaW4gdGhlIFdlYlByb2Nlc3Mu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVByb21pc2UuY3Bw IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01Qcm9taXNlLmNwcAppbmRleCAwZTNm NDI4OGFmZDZmYzYzMDU1MzEzZjQ0YTU1YmViNGFiMGVhOTI1Li45MjhiM2UxNTAwYTg1OTkyYjI5 ZDc0MmE2NzAwNGJkYjczZjA3ZjBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9qcy9KU0RPTVByb21pc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pT RE9NUHJvbWlzZS5jcHAKQEAgLTU1LDYgKzU1LDcgQEAgdm9pZCBET01Qcm9taXNlOjp3aGVuU2V0 dGxlZChzdGQ6OmZ1bmN0aW9uPHZvaWQoKT4mJiBjYWxsYmFjaykKIHsKICAgICBhdXRvJiBzdGF0 ZSA9ICpnbG9iYWxPYmplY3QoKS0+Z2xvYmFsRXhlYygpOwogICAgIGF1dG8mIHZtID0gc3RhdGUu dm0oKTsKKyAgICBKU0xvY2tIb2xkZXIgbG9jayh2bSk7CiAgICAgYXV0byogaGFuZGxlciA9IEpT Qzo6SlNOYXRpdmVTdGRGdW5jdGlvbjo6Y3JlYXRlKHZtLCBnbG9iYWxPYmplY3QoKSwgMSwgU3Ry aW5nIHsgfSwgW2NhbGxiYWNrID0gV1RGTW92ZShjYWxsYmFjayldIChFeGVjU3RhdGUqKSBtdXRh YmxlIHsKICAgICAgICAgY2FsbGJhY2soKTsKICAgICAgICAgcmV0dXJuIEpTQzo6SlNWYWx1ZTo6 ZW5jb2RlKEpTQzo6anNVbmRlZmluZWQoKSk7Cg==