182589 2018-02-07 17:08:33 -0800 REGRESSION(r227983): fast/dom/adopt-node-crash-2.html is flaky 2018-08-03 15:09:52 -0700 1 1 1 Unclassified WebKit UI Events WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa ap cdumez eocanha jlewis3 koivisto ryanhaddad simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1397386 0 rniwa 2018-02-07 17:08:33 -0800 Ryan Haddad 2018-02-07 16:57:14 PST (In reply to Ryosuke Niwa from comment #20) > Committed r227983: <https://trac.webkit.org/changeset/227983> This change has caused LayoutTest fast/dom/adopt-node-crash-2.html to become a flaky failure on High Sierra Release WK2 and Sierra Release WK2: https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r228225%20(7494)/results.html I am able to reproduce the failure with a build of r227984 with the following: run-webkit-tests fast/dom/adopt-node-crash-2.html -fg --iter 100 --exit-after-n-failures 1 I cannot reproduce with a build of r227982. 1397586 1 ryanhaddad 2018-02-08 10:49:23 -0800 Ryosuke, is this something you intend to fix shortly or do you want to mark the test as failing? 1397642 2 rniwa 2018-02-08 12:14:38 -0800 (In reply to Ryan Haddad from comment #1) > Ryosuke, is this something you intend to fix shortly or do you want to mark > the test as failing? Sorry, adding a test expectation short terms is a good fix. Will look into it ASAP but I have another bug I need to urgently address first. 1397657 3 ryanhaddad 2018-02-08 12:49:02 -0800 (In reply to Ryosuke Niwa from comment #2) > (In reply to Ryan Haddad from comment #1) > > Ryosuke, is this something you intend to fix shortly or do you want to mark > > the test as failing? > > Sorry, adding a test expectation short terms is a good fix. Will look into > it ASAP but I have another bug I need to urgently address first. Marked test as flaky in https://trac.webkit.org/r228288. 1397701 4 rniwa 2018-02-08 13:43:26 -0800 Thanks! 1398838 5 webkit-bug-importer 2018-02-13 16:14:00 -0800 <rdar://problem/37517904> 1398856 6 ap 2018-02-13 16:54:02 -0800 --- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/fast/dom/adopt-node-crash-2-expected.txt +++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/fast/dom/adopt-node-crash-2-actual.txt @@ -1,3 +1,2 @@ Tests for a crash due to adopting a DOM node during DOMFocusOut event. Test passes if it doesn't crash. - 1423014 7 340165 rniwa 2018-05-10 20:45:02 -0700 Created attachment 340165 Speculative fix 1423015 8 rniwa 2018-05-10 20:46:28 -0700 I can't reproduce this flakiness locally, and we haven't seen the flakiness since April but GTK+ bots are still occasionally seeing it. I think r227983 introducing a flakiness to this test sort of makes sense since it delays the layout update upon focus so I've crafted a speculative fix for it based on my observation. 1423026 9 340165 wenson_hsieh 2018-05-10 21:26:55 -0700 Comment on attachment 340165 Speculative fix View in context: https://bugs.webkit.org/attachment.cgi?id=340165&action=review > LayoutTests/fast/dom/adopt-node-crash-2.html:39 > setTimeout("doit()", 1); The `1` is an interesting choice here. Does it not work if we schedule this on a 0-delay timer? 1423028 10 340165 rniwa 2018-05-10 21:38:47 -0700 Comment on attachment 340165 Speculative fix View in context: https://bugs.webkit.org/attachment.cgi?id=340165&action=review >> LayoutTests/fast/dom/adopt-node-crash-2.html:39 >> setTimeout("doit()", 1); > > The `1` is an interesting choice here. Does it not work if we schedule this on a 0-delay timer? Indeed... I think it probably would but I couldn't figure out if this test would catch the bug after that change since reverting https://trac.webkit.org/changeset/135914 is kind of hard at this point. 1423043 11 rniwa 2018-05-10 22:00:25 -0700 Committed r231690: <https://trac.webkit.org/changeset/231690> 1446484 12 rniwa 2018-07-30 23:07:36 -0700 Oops, the test is still failing because I forgot to update the expected result & remove the flaky expectation. 1447042 13 rniwa 2018-08-01 16:26:04 -0700 Committed r234485: <https://trac.webkit.org/changeset/234485> 1447790 14 rniwa 2018-08-03 15:09:34 -0700 *** Bug 132183 has been marked as a duplicate of this bug. *** 1447791 15 rniwa 2018-08-03 15:09:52 -0700 The test appears to be passing consistently now. 340165 2018-05-10 20:45:02 -0700 2018-05-10 21:26:55 -0700 Speculative fix bug-182589-20180510204502.patch text/plain 2425 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIzMTY4NikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE4LTA1LTEwICBSeW9zdWtlIE5pd2EgIDxy bml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjIyNzk4Myk6IGZhc3QvZG9t L2Fkb3B0LW5vZGUtY3Jhc2gtMi5odG1sIGlzIGZsYWt5CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODI1ODkKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIGEgc3BlY3VsYXRpdmUgZml4IGZvciB0 aGUgdGVzdCBzaW5jZSBJIGNhbid0IHJlcHJvZHVjZSB0aGUgZmxha2luZXNzIGxvY2FsbHkuIEJl Y2F1c2UgcjIyNzk4MyBtYWtlcworICAgICAgICB0aGUgbGF5b3V0IHVwZGF0ZSBhc3luYywgSSBz dXNwZWN0IHRoZSBmb2N1cyBjaGFuZ2Ugd2hpY2ggb2NjdXJzIHRvIHRoZSBrZXlnZW4gaGF2aW5n IGF1dG9mb2N1cyBhdHRyaWJ1dGUKKyAgICAgICAgaXNuJ3QgdXBkYXRpbmcgdGhlIGxheW91dCBp biB0aW1lIGZvciBub3RpZnlEb25lIGNhbGwuIE1hbnVhbGx5IHVwZGF0ZSB0aGUgbGF5b3V0IGJl Zm9yZS9hZnRlciB0aGUgdGVzdC4KKworICAgICAgICBBbHNvIHdhaXQgZm9yIHRoZSBsb2FkIGV2 ZW50IHRvIGZpZ3VyZSBiZWZvcmUgc3RhcnRpbmcgdGhlIHRlc3Qgc2luY2UgbGF5b3V0LCBldGMu Li4gbWF5IG5vdCBiZSB1cGRhdGVkCisgICAgICAgIGltbWVkaWF0ZWx5IGFmdGVyIERPTUNvbnRl bnRMb2FkZWQuCisKKyAgICAgICAgKiBmYXN0L2RvbS9hZG9wdC1ub2RlLWNyYXNoLTIuaHRtbDoK KwogMjAxOC0wNS0xMCAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAog ICAgICAgICBbRXh0cmEgem9vbSBtb2RlXSBmYXN0L3Zpc3VhbC12aWV3cG9ydC9leHRyYXpvb20v bGF5b3V0LXZpZXdwb3J0LWFmdGVyLXNjcm9sbGluZy1hbmQtcmVzaXppbmcuaHRtbCBzb21ldGlt ZXMgZmFpbHMKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL2Fkb3B0LW5vZGUtY3Jhc2gtMi5o dG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL2Fkb3B0LW5vZGUtY3Jhc2gt Mi5odG1sCShyZXZpc2lvbiAyMzE2ODYpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9hZG9wdC1u b2RlLWNyYXNoLTIuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMjAsMTMgKzIwLDIzIEBAIGlmICh3 aW5kb3cudGVzdFJ1bm5lcikgewogPHNjcmlwdD4KIGZ1bmN0aW9uIGRvaXQoKQogewotICAgIGRp djIuYWRkRXZlbnRMaXN0ZW5lcigiRE9NRm9jdXNPdXQiLCBmdW5jdGlvbiAoKSB7IGRvY3VtZW50 LmltcGxlbWVudGF0aW9uLmNyZWF0ZURvY3VtZW50KCIiLCAiIiwgbnVsbCkuYWRvcHROb2RlKGRp djIpOyB9LCBmYWxzZSk7CisgICAgZGl2Mi5hZGRFdmVudExpc3RlbmVyKCJET01Gb2N1c091dCIs IGZ1bmN0aW9uICgpIHsKKyAgICAgICAgZG9jdW1lbnQuaW1wbGVtZW50YXRpb24uY3JlYXRlRG9j dW1lbnQoIiIsICIiLCBudWxsKS5hZG9wdE5vZGUoZGl2Mik7CisgICAgICAgIHNldFRpbWVvdXQo KCkgPT4geworICAgICAgICAgICAgaWYgKHdpbmRvdy5pbnRlcm5hbHMpCisgICAgICAgICAgICAg ICAgaW50ZXJuYWxzLnVwZGF0ZUxheW91dElnbm9yZVBlbmRpbmdTdHlsZXNoZWV0c0FuZFJ1blBv c3RMYXlvdXRUYXNrcygpOworICAgICAgICAgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAg ICAgICAgICAgICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOworICAgICAgICB9LCAwKTsKKyAg ICB9LCBmYWxzZSk7CiAgICAgZGl2MS5vdXRlckhUTUwgPSBoZWFkZXIxLm91dGVySFRNTDsKLSAg ICBpZiAod2luZG93LnRlc3RSdW5uZXIpCi0gICAgICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgp OwogfQotZG9jdW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigiRE9NQ29udGVudExvYWRlZCIsIGZ1bmN0 aW9uKCkgeword2luZG93Lm9ubG9hZCA9IGZ1bmN0aW9uKCkgeworICAgIGlmICh3aW5kb3cuaW50 ZXJuYWxzKQorICAgICAgICBpbnRlcm5hbHMudXBkYXRlTGF5b3V0SWdub3JlUGVuZGluZ1N0eWxl c2hlZXRzQW5kUnVuUG9zdExheW91dFRhc2tzKCk7CisgICAgZWxzZQorICAgICAgICBkaXYyLmdl dEJvdW5kaW5nQ2xpZW50UmVjdCgpOwogICAgIHNldFRpbWVvdXQoImRvaXQoKSIsIDEpOwotfSwg ZmFsc2UpOworfQogPC9zY3JpcHQ+CiA8L2h0bWw+Cg==