182583 2018-02-07 15:01:23 -0800 [Curl] Cookie Database has some warnings when compiled in clang 2018-02-07 16:41:03 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 chris.reid webkit-unassigned achristensen bfulgham commit-queue darin don.olmstead webkit-bug-importer oldest_to_newest 1397316 0 chris.reid 2018-02-07 15:01:23 -0800 Here are the warnings: - Unused parameters in CookieJarCurlDatabase and CookieJarDB. - The NetworkStorageSessionCurl constructor has a different order than its header. - I accidentally had a '#pragma once' in CookieJarCurlDatabase.cpp. - CookieJarDB.cpp(175,26): warning : missing field 'st_ino' initializer [-Wmissing-field-initializers] 1397322 1 333319 chris.reid 2018-02-07 15:08:45 -0800 Created attachment 333319 patch 1397374 2 333319 commit-queue 2018-02-07 16:39:22 -0800 Comment on attachment 333319 patch Clearing flags on attachment: 333319 Committed r228250: <https://trac.webkit.org/changeset/228250> 1397375 3 commit-queue 2018-02-07 16:39:23 -0800 All reviewed patches have been landed. Closing bug. 1397376 4 webkit-bug-importer 2018-02-07 16:41:03 -0800 <rdar://problem/37332502> 333319 2018-02-07 15:08:45 -0800 2018-02-07 16:39:22 -0800 patch 182583.diff text/plain 5567 chris.reid ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlYTlmODI4ZjRhMC4uNmU1Mjk4MDZlZjggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxOC0wMi0wNyAgQ2hyaXN0b3BoZXIgUmVpZCAgPGNocmlzLnJlaWRAc29u eS5jb20+CisKKyAgICAgICAgW0N1cmxdIENvb2tpZSBEYXRhYmFzZSBoYXMgc29tZSB3YXJuaW5n cyB3aGVuIGNvbXBpbGVkIGluIGNsYW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xODI1ODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKwor ICAgICAgICBGaXhpbmcgdW51c2VkLXBhcmFtZXRlciwgbWlzc2luZy1maWVsZC1pbml0aWFsaXpl cnMsIHJlb3JkZXIsIGFuZCBwcmFnbWEtb25jZS1vdXRzaWRlLWhlYWRlciB3YXJuaW5ncy4KKwor ICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvTmV0d29ya1N0b3JhZ2VTZXNzaW9uLmg6CisgICAg ICAgICogcGxhdGZvcm0vbmV0d29yay9jdXJsL0Nvb2tpZUphckN1cmxEYXRhYmFzZS5jcHA6Cisg ICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jdXJsL0Nvb2tpZUphckRCLmNwcDoKKyAgICAgICAg KiBwbGF0Zm9ybS9uZXR3b3JrL2N1cmwvTmV0d29ya1N0b3JhZ2VTZXNzaW9uQ3VybC5jcHA6CisK IDIwMTgtMDItMDIgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAg IENsZWFyaW5nIGFsbCBzZXJ2aWNlIHdvcmtlciByZWdpc3RyYXRpb25zIHNob3VsZCB3YWl0IGZv ciBpbXBvcnRpbmcgc2VydmljZSB3b3JrZXIgcmVnaXN0cmF0aW9uIHRvIGZpbmlzaApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9OZXR3b3JrU3RvcmFnZVNlc3Np b24uaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvTmV0d29ya1N0b3JhZ2VTZXNz aW9uLmgKaW5kZXggNjNjOWNmMDBmYzguLjliYTE0OWIzNzZkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL05ldHdvcmtTdG9yYWdlU2Vzc2lvbi5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvTmV0d29ya1N0b3JhZ2VTZXNzaW9uLmgKQEAg LTE2MiwxMCArMTYyLDEwIEBAIHByaXZhdGU6CiAgICAgR1JlZlB0cjxHQ2FuY2VsbGFibGU+IG1f cGVyc2lzZW50U3RvcmFnZUNhbmNlbGxhYmxlOwogI2VuZGlmCiAjZWxpZiBVU0UoQ1VSTCkKKyAg ICBSZWZQdHI8TmV0d29ya2luZ0NvbnRleHQ+IG1fY29udGV4dDsKKwogICAgIFVuaXF1ZVJlZjxD b29raWVKYXJDdXJsPiBtX2Nvb2tpZVN0b3JhZ2U7CiAgICAgbXV0YWJsZSBDb29raWVKYXJEQiBt X2Nvb2tpZURhdGFiYXNlOwotCi0gICAgUmVmUHRyPE5ldHdvcmtpbmdDb250ZXh0PiBtX2NvbnRl eHQ7CiAjZWxzZQogICAgIFJlZlB0cjxOZXR3b3JraW5nQ29udGV4dD4gbV9jb250ZXh0OwogI2Vu ZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ29v a2llSmFyQ3VybERhdGFiYXNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv Y3VybC9Db29raWVKYXJDdXJsRGF0YWJhc2UuY3BwCmluZGV4IDk0NGZhODk2ZDA1Li5jZjM4MGM4 YjI2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0Nv b2tpZUphckN1cmxEYXRhYmFzZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9jdXJsL0Nvb2tpZUphckN1cmxEYXRhYmFzZS5jcHAKQEAgLTIyLDggKzIyLDYgQEAKICAq IFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFN QUdFLgogICovCiAKLSNwcmFnbWEgb25jZQotCiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVk ZSAiQ29va2llSmFyQ3VybERhdGFiYXNlLmgiCiAKQEAgLTY1LDYgKzYzLDcgQEAgdm9pZCBDb29r aWVKYXJDdXJsRGF0YWJhc2U6OnNldENvb2tpZXNGcm9tRE9NKGNvbnN0IE5ldHdvcmtTdG9yYWdl U2Vzc2lvbiYgc2Vzc2kKIHsKICAgICBVTlVTRURfUEFSQU0oZnJhbWVJRCk7CiAgICAgVU5VU0VE X1BBUkFNKHBhZ2VJRCk7CisgICAgVU5VU0VEX1BBUkFNKGZpcnN0UGFydHkpOwogCiAgICAgQ29v a2llSmFyREImIGNvb2tpZUphckRCID0gc2Vzc2lvbi5jb29raWVEYXRhYmFzZSgpOwogICAgIGNv b2tpZUphckRCLnNldENvb2tpZSh1cmwuc3RyaW5nKCksIHZhbHVlLCB0cnVlKTsKQEAgLTk2LDcg Kzk1LDcgQEAgc3RkOjpwYWlyPFN0cmluZywgYm9vbD4gQ29va2llSmFyQ3VybERhdGFiYXNlOjpj b29raWVSZXF1ZXN0SGVhZGVyRmllbGRWYWx1ZShjb24KIAogYm9vbCBDb29raWVKYXJDdXJsRGF0 YWJhc2U6OmNvb2tpZXNFbmFibGVkKGNvbnN0IE5ldHdvcmtTdG9yYWdlU2Vzc2lvbiYgc2Vzc2lv bikgY29uc3QKIHsKLSAgICByZXR1cm4gdHJ1ZTsKKyAgICByZXR1cm4gc2Vzc2lvbi5jb29raWVE YXRhYmFzZSgpLmlzRW5hYmxlZCgpOwogfQogCiBib29sIENvb2tpZUphckN1cmxEYXRhYmFzZTo6 Z2V0UmF3Q29va2llcyhjb25zdCBOZXR3b3JrU3RvcmFnZVNlc3Npb24mIHNlc3Npb24sIGNvbnN0 IFVSTCYgZmlyc3RQYXJ0eSwgY29uc3QgVVJMJiwgc3RkOjpvcHRpb25hbDx1aW50NjRfdD4gZnJh bWVJRCwgc3RkOjpvcHRpb25hbDx1aW50NjRfdD4gcGFnZUlELCBWZWN0b3I8Q29va2llPiYgcmF3 Q29va2llcykgY29uc3QKQEAgLTEwOCwxNyArMTA3LDE3IEBAIGJvb2wgQ29va2llSmFyQ3VybERh dGFiYXNlOjpnZXRSYXdDb29raWVzKGNvbnN0IE5ldHdvcmtTdG9yYWdlU2Vzc2lvbiYgc2Vzc2lv biwKICAgICByZXR1cm4gY29va2llSmFyREIuc2VhcmNoQ29va2llcyhmaXJzdFBhcnR5LnN0cmlu ZygpLCBzdGQ6Om51bGxvcHQsIHN0ZDo6bnVsbG9wdCwgc3RkOjpudWxsb3B0LCByYXdDb29raWVz KTsKIH0KIAotdm9pZCBDb29raWVKYXJDdXJsRGF0YWJhc2U6OmRlbGV0ZUNvb2tpZShjb25zdCBO ZXR3b3JrU3RvcmFnZVNlc3Npb24mLCBjb25zdCBVUkwmIHVybCwgY29uc3QgU3RyaW5nJiBjb29r aWVOYW1lKSBjb25zdAordm9pZCBDb29raWVKYXJDdXJsRGF0YWJhc2U6OmRlbGV0ZUNvb2tpZShj b25zdCBOZXR3b3JrU3RvcmFnZVNlc3Npb24mLCBjb25zdCBVUkwmLCBjb25zdCBTdHJpbmcmKSBj b25zdAogewogICAgIC8vIEZJWE1FOiBOb3QgeWV0IGltcGxlbWVudGVkCiB9CiAKLXZvaWQgQ29v a2llSmFyQ3VybERhdGFiYXNlOjpnZXRIb3N0bmFtZXNXaXRoQ29va2llcyhjb25zdCBOZXR3b3Jr U3RvcmFnZVNlc3Npb24mLCBIYXNoU2V0PFN0cmluZz4mIGhvc3RuYW1lcykgY29uc3QKK3ZvaWQg Q29va2llSmFyQ3VybERhdGFiYXNlOjpnZXRIb3N0bmFtZXNXaXRoQ29va2llcyhjb25zdCBOZXR3 b3JrU3RvcmFnZVNlc3Npb24mLCBIYXNoU2V0PFN0cmluZz4mKSBjb25zdAogewogICAgIC8vIEZJ WE1FOiBOb3QgeWV0IGltcGxlbWVudGVkCiB9CiAKLXZvaWQgQ29va2llSmFyQ3VybERhdGFiYXNl OjpkZWxldGVDb29raWVzRm9ySG9zdG5hbWVzKGNvbnN0IE5ldHdvcmtTdG9yYWdlU2Vzc2lvbiYs IGNvbnN0IFZlY3RvcjxTdHJpbmc+JiBjb29raWVIb3N0TmFtZXMpIGNvbnN0Cit2b2lkIENvb2tp ZUphckN1cmxEYXRhYmFzZTo6ZGVsZXRlQ29va2llc0Zvckhvc3RuYW1lcyhjb25zdCBOZXR3b3Jr U3RvcmFnZVNlc3Npb24mLCBjb25zdCBWZWN0b3I8U3RyaW5nPiYpIGNvbnN0CiB7CiAgICAgLy8g RklYTUU6IE5vdCB5ZXQgaW1wbGVtZW50ZWQKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvY3VybC9Db29raWVKYXJEQi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ29va2llSmFyREIuY3BwCmluZGV4IDE2NjIzYzFiNmJjLi45 NjU5NTg0MzllOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9j dXJsL0Nvb2tpZUphckRCLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L2N1cmwvQ29va2llSmFyREIuY3BwCkBAIC0xNzIsNyArMTcyLDcgQEAgYm9vbCBDb29raWVKYXJE Qjo6Y2hlY2tEYXRhYmFzZUNvcnJ1cHRpb25BbmRSZW1vdmVJZk5lZWRlZCgpCiAgICAgaWYgKGlz T25NZW1vcnkoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgc3RydWN0IHN0YXQgc3Qg PSB7IDAgfTsKKyAgICBzdHJ1Y3Qgc3RhdCBzdDsKICAgICBpbnQgcmV0ID0gc3RhdChnZXRDb3Jy dXB0aW9uTWFya2VyUGF0aCgpLnV0ZjgoKS5kYXRhKCksICZzdCk7CiAgICAgaWYgKCFyZXQpCiAg ICAgICAgIHJldHVybiBmYWxzZTsKQEAgLTQ0NSw3ICs0NDUsNyBAQCBpbnQgQ29va2llSmFyREI6 OmRlbGV0ZUNvb2tpZUludGVybmFsKGNvbnN0IFN0cmluZyYgbmFtZSwgY29uc3QgU3RyaW5nJiBk b21haW4sCiAgICAgcmV0dXJuIHN0YXRlbWVudC0+c3RlcCgpOwogfQogCi1pbnQgQ29va2llSmFy REI6OmRlbGV0ZUNvb2tpZXMoY29uc3QgU3RyaW5nJiB1cmwpCitpbnQgQ29va2llSmFyREI6OmRl bGV0ZUNvb2tpZXMoY29uc3QgU3RyaW5nJikKIHsKICAgICAvLyBOT1QgSU1QTEVNRU5URUQKICAg ICAvLyBUT0RPOiB0aGlzIGZ1bmN0aW9uIHdpbGwgYmUgY2FsbGVkIGlmIGFwcGxpY2F0aW9uIGNh bGxzIFdLQ29va2llTWFuYWdlckRlbGV0ZUNvb2tpZXNGb3JIb3N0bmFtZSgpIGluIFdLQ29va2ll TWFuYWdlci5oLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9j dXJsL05ldHdvcmtTdG9yYWdlU2Vzc2lvbkN1cmwuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9jdXJsL05ldHdvcmtTdG9yYWdlU2Vzc2lvbkN1cmwuY3BwCmluZGV4IGI4ODAz NmE0Y2I2Li43YjZmODA3YWI0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9jdXJsL05ldHdvcmtTdG9yYWdlU2Vzc2lvbkN1cmwuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9OZXR3b3JrU3RvcmFnZVNlc3Npb25DdXJsLmNw cApAQCAtNTksOCArNTksOCBAQCBzdGF0aWMgU3RyaW5nIGRlZmF1bHRDb29raWVKYXJQYXRoKCkK IE5ldHdvcmtTdG9yYWdlU2Vzc2lvbjo6TmV0d29ya1N0b3JhZ2VTZXNzaW9uKFBBTDo6U2Vzc2lv bklEIHNlc3Npb25JRCwgTmV0d29ya2luZ0NvbnRleHQqIGNvbnRleHQpCiAgICAgOiBtX3Nlc3Np b25JRChzZXNzaW9uSUQpCiAgICAgLCBtX2NvbnRleHQoY29udGV4dCkKLSAgICAsIG1fY29va2ll RGF0YWJhc2UoZGVmYXVsdENvb2tpZUphclBhdGgoKSkKICAgICAsIG1fY29va2llU3RvcmFnZSht YWtlVW5pcXVlUmVmPENvb2tpZUphckN1cmxEYXRhYmFzZT4oKSkKKyAgICAsIG1fY29va2llRGF0 YWJhc2UoZGVmYXVsdENvb2tpZUphclBhdGgoKSkKIHsKIH0KIAo=