182573 2018-02-07 09:26:43 -0800 Improve NetworkResourceLoader logging to capture redirect cases 2018-02-07 14:53:37 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham cdumez webkit-bug-importer wilander oldest_to_newest 1397202 0 bfulgham 2018-02-07 09:26:43 -0800 The logging updates in Bug 182455 did not catch redirects, which should be logged, too. 1397215 1 webkit-bug-importer 2018-02-07 09:50:33 -0800 <rdar://problem/37316714> 1397216 2 333299 bfulgham 2018-02-07 09:55:41 -0800 Created attachment 333299 Patch 1397280 3 333299 cdumez 2018-02-07 13:46:10 -0800 Comment on attachment 333299 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333299&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:34 > +#import "NetworkResourceLoader.h" I am unclear why this import is needed. 1397285 4 333299 bfulgham 2018-02-07 13:53:06 -0800 Comment on attachment 333299 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333299&action=review >> Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:34 >> +#import "NetworkResourceLoader.h" > > I am unclear why this import is needed. Oh! You are right. I added that by mistake. I'll remove it. 1397288 5 wilander 2018-02-07 13:58:32 -0800 Just a heads up: You might have to merge since I recently landed https://bugs.webkit.org/show_bug.cgi?id=182559 that touches this code. 1397313 6 bfulgham 2018-02-07 14:53:37 -0800 Committed r228244: <https://trac.webkit.org/changeset/228244> 333299 2018-02-07 09:55:41 -0800 2018-02-07 13:46:10 -0800 Patch bug-182573-20180207095540.patch text/plain 3274 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjgyMjgpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE4LTAyLTA3ICBCcmVudCBGdWxn aGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIEltcHJvdmUgTmV0d29ya1Jlc291 cmNlTG9hZGVyIGxvZ2dpbmcgdG8gY2FwdHVyZSByZWRpcmVjdCBjYXNlcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyNTczCisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8zNzMxNjcxND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGQgbG9nZ2luZyBmb3IgY29va2llIHBhcnRpdGlvbmluZyBvciBibG9j a2luZyBkdXJpbmcgcmVkaXJlY3RzLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY29jb2Ev TmV0d29ya0RhdGFUYXNrQ29jb2EubW06CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtEYXRhVGFz a0NvY29hOjp3aWxsUGVyZm9ybUhUVFBSZWRpcmVjdGlvbik6CisKIDIwMTgtMDItMDcgIE1pY2hh ZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFR5 cG8gaW4gYSB0cmFuc2xhdGFibGUgc3RyaW5nCkluZGV4OiBTb3VyY2UvV2ViS2l0L05ldHdvcmtQ cm9jZXNzL2NvY29hL05ldHdvcmtEYXRhVGFza0NvY29hLm1tCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya0RhdGFUYXNrQ29jb2EubW0JKHJl dmlzaW9uIDIyODIyOCkKKysrIFNvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0 d29ya0RhdGFUYXNrQ29jb2EubW0JKHdvcmtpbmcgY29weSkKQEAgLTMxLDYgKzMxLDcgQEAKICNp bXBvcnQgIkRvd25sb2FkUHJveHlNZXNzYWdlcy5oIgogI2ltcG9ydCAiTG9nZ2luZy5oIgogI2lt cG9ydCAiTmV0d29ya1Byb2Nlc3MuaCIKKyNpbXBvcnQgIk5ldHdvcmtSZXNvdXJjZUxvYWRlci5o IgogI2ltcG9ydCAiTmV0d29ya1Nlc3Npb25Db2NvYS5oIgogI2ltcG9ydCAiU2Vzc2lvblRyYWNr ZXIuaCIKICNpbXBvcnQgIldlYkNvcmVBcmd1bWVudENvZGVycy5oIgpAQCAtMzE1LDEyICszMTYs MjIgQEAgdm9pZCBOZXR3b3JrRGF0YVRhc2tDb2NvYTo6d2lsbFBlcmZvcm1IVAogICAgIAogI2lm IEhBVkUoQ0ZORVRXT1JLX1NUT1JBR0VfUEFSVElUSU9OSU5HKQogICAgIGF1dG8gc2hvdWxkQmxv Y2tDb29raWVzID0gbV9zZXNzaW9uLT5uZXR3b3JrU3RvcmFnZVNlc3Npb24oKS5zaG91bGRCbG9j a0Nvb2tpZXMocmVxdWVzdCk7CisjaWYgIVJFTEVBU0VfTE9HX0RJU0FCTEVECisgICAgaWYgKE5l dHdvcmtQcm9jZXNzOjpzaW5nbGV0b24oKS5zaG91bGRMb2dDb29raWVJbmZvcm1hdGlvbigpKQor ICAgICAgICBSRUxFQVNFX0xPR19JRihtX3Nlc3Npb24tPnNlc3Npb25JRCgpLmlzQWx3YXlzT25M b2dnaW5nQWxsb3dlZCgpLCBOZXR3b3JrLCAiJXAgLSBOZXR3b3JrRGF0YVRhc2tDb2NvYTo6d2ls bFBlcmZvcm1IVFRQUmVkaXJlY3Rpb246OmxvZ0Nvb2tpZUluZm9ybWF0aW9uOiBwYWdlSUQgPSAl bGx1LCBmcmFtZUlEID0gJWxsdSwgdGFza0lEID0gJWx1OiAlcyBjb29raWVzIGZvciByZWRpcmVj dCBVUkwgJXMiLCB0aGlzLCBtX3BhZ2VJRCwgbV9mcmFtZUlELCAodW5zaWduZWQgbG9uZylbbV90 YXNrIHRhc2tJZGVudGlmaWVyXSwgKHNob3VsZEJsb2NrQ29va2llcyA/ICJCbG9ja2luZyIgOiAi Tm90IGJsb2NraW5nIiksIHJlcXVlc3QudXJsKCkuc3RyaW5nKCkudXRmOCgpLmRhdGEoKSk7Cisj ZWxzZQogICAgIExPRyhOZXR3b3JrU2Vzc2lvbiwgIiVsbHUgJXMgY29va2llcyBmb3IgcmVkaXJl Y3QgVVJMICVzIiwgW21fdGFzayB0YXNrSWRlbnRpZmllcl0sIChzaG91bGRCbG9ja0Nvb2tpZXMg PyAiQmxvY2tpbmciIDogIk5vdCBibG9ja2luZyIpLCByZXF1ZXN0LnVybCgpLnN0cmluZygpLnV0 ZjgoKS5kYXRhKCkpOworI2VuZGlmCiAgICAgYXBwbHlDb29raWVCbG9ja2luZ1BvbGljeShzaG91 bGRCbG9ja0Nvb2tpZXMpOwogCiAgICAgaWYgKCFzaG91bGRCbG9ja0Nvb2tpZXMpIHsKICAgICAg ICAgYXV0byByZXF1aXJlZFN0b3JhZ2VQYXJ0aXRpb24gPSBtX3Nlc3Npb24tPm5ldHdvcmtTdG9y YWdlU2Vzc2lvbigpLmNvb2tpZVN0b3JhZ2VQYXJ0aXRpb24ocmVxdWVzdCwgbV9mcmFtZUlELCBt X3BhZ2VJRCk7CisjaWYgIVJFTEVBU0VfTE9HX0RJU0FCTEVECisgICAgICAgIGlmIChOZXR3b3Jr UHJvY2Vzczo6c2luZ2xldG9uKCkuc2hvdWxkTG9nQ29va2llSW5mb3JtYXRpb24oKSkKKyAgICAg ICAgICAgIFJFTEVBU0VfTE9HX0lGKG1fc2Vzc2lvbi0+c2Vzc2lvbklEKCkuaXNBbHdheXNPbkxv Z2dpbmdBbGxvd2VkKCksIE5ldHdvcmssICIlcCAtIE5ldHdvcmtEYXRhVGFza0NvY29hOjp3aWxs UGVyZm9ybUhUVFBSZWRpcmVjdGlvbjo6bG9nQ29va2llSW5mb3JtYXRpb246IHBhZ2VJRCA9ICVs bHUsIGZyYW1lSUQgPSAlbGx1LCB0YXNrSUQgPSAlbHU6ICVzIGNvb2tpZXMgZm9yIHJlZGlyZWN0 IFVSTCAlcyIsIHRoaXMsIG1fcGFnZUlELCBtX2ZyYW1lSUQsICh1bnNpZ25lZCBsb25nKVttX3Rh c2sgdGFza0lkZW50aWZpZXJdLCAocmVxdWlyZWRTdG9yYWdlUGFydGl0aW9uLmlzRW1wdHkoKSA/ ICJOb3QgcGFydGl0aW9uaW5nIiA6ICJQYXJ0aXRpb25pbmciKSwgcmVxdWVzdC51cmwoKS5zdHJp bmcoKS51dGY4KCkuZGF0YSgpKTsKKyNlbHNlCiAgICAgICAgIExPRyhOZXR3b3JrU2Vzc2lvbiwg IiVsbHUgJXMgY29va2llcyBmb3IgcmVkaXJlY3QgVVJMICVzIiwgW21fdGFzayB0YXNrSWRlbnRp Zmllcl0sIChyZXF1aXJlZFN0b3JhZ2VQYXJ0aXRpb24uaXNFbXB0eSgpID8gIk5vdCBwYXJ0aXRp b25pbmciIDogIlBhcnRpdGlvbmluZyIpLCByZXF1ZXN0LnVybCgpLnN0cmluZygpLnV0ZjgoKS5k YXRhKCkpOworI2VuZGlmCiAgICAgICAgIGFwcGx5Q29va2llUGFydGl0aW9uaW5nUG9saWN5KHJl cXVpcmVkU3RvcmFnZVBhcnRpdGlvbiwgbV90YXNrLmdldCgpLl9zdG9yYWdlUGFydGl0aW9uSWRl bnRpZmllcik7CiAgICAgfQogI2VuZGlmCg==