<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>182555</bug_id>
          
          <creation_ts>2018-02-06 15:52:58 -0800</creation_ts>
          <short_desc>[CMake] Add libsoup platform file</short_desc>
          <delta_ts>2018-02-13 21:43:45 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>WONTFIX</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Don Olmstead">don.olmstead</reporter>
          <assigned_to name="Don Olmstead">don.olmstead</assigned_to>
          <cc>achristensen</cc>
    
    <cc>annulen</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>fujii</cc>
    
    <cc>lforschler</cc>
    
    <cc>mcatanzaro</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1396988</commentid>
    <comment_count>0</comment_count>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2018-02-06 15:52:58 -0800</bug_when>
    <thetext>Add a Soup.cmake file within WebCore/platform for sharing CMake information on libsoup.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1396989</commentid>
    <comment_count>1</comment_count>
      <attachid>333232</attachid>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2018-02-06 15:56:01 -0800</bug_when>
    <thetext>Created attachment 333232
Patch

So I realize that with the unified sources build this seems a bit excessive to have an include. However with https://bugs.webkit.org/show_bug.cgi?id=182512 the forwarding headers are all going to be enumerated which would increase the amount of information within this file so I&apos;d like to land this unless there are major objections.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397026</commentid>
    <comment_count>2</comment_count>
      <attachid>333241</attachid>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2018-02-06 18:07:22 -0800</bug_when>
    <thetext>Created attachment 333241
Patch

Fix the include type</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397027</commentid>
    <comment_count>3</comment_count>
    <who name="EWS Watchlist">ews-watchlist</who>
    <bug_when>2018-02-06 18:09:40 -0800</bug_when>
    <thetext>Attachment 333241 did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the &apos;No new tests&apos; and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397029</commentid>
    <comment_count>4</comment_count>
      <attachid>333243</attachid>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2018-02-06 18:11:55 -0800</bug_when>
    <thetext>Created attachment 333243
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397033</commentid>
    <comment_count>5</comment_count>
      <attachid>333245</attachid>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2018-02-06 18:15:20 -0800</bug_when>
    <thetext>Created attachment 333245
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397138</commentid>
    <comment_count>6</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2018-02-07 03:49:44 -0800</bug_when>
    <thetext>I think this is not a right way to go. When I introduced these &quot;platform&quot; cmake files (for ImageDecoders, GStreamer and TextureMapper), I had following motivations:

* Share file lists
* Share conditional logic

In addition, I haven&apos;t understood cmake&apos;s imported targets well yet at that point.

For this particual case, it would be better to define imported &quot;LibSoup&quot; target with library and include directories in FindLibSoup.cmake, and link to &quot;LibSoup&quot; instead of using ${LIBSOUP_LIBRARIES} and ${LIBSOUP_INCLUDE_DIRS}. Remaining unshared part is SourcesSoup.txt, but I&apos;m not really sure that this files need to be part of unified build, and even if they do, it&apos;s just one extra line of cmake code.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397139</commentid>
    <comment_count>7</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-02-07 05:28:47 -0800</bug_when>
    <thetext>But note &quot;libsoup&quot; is all lowercase.

(In reply to Konstantin Tokarev from comment #6)
&gt; For this particual case, it would be better to define imported &quot;LibSoup&quot;
&gt; target with library and include directories in FindLibSoup.cmake, and link
&gt; to &quot;LibSoup&quot; instead of using ${LIBSOUP_LIBRARIES} and
&gt; ${LIBSOUP_INCLUDE_DIRS}.

Its own build target? Isn&apos;t that overkill?

&gt; Remaining unshared part is SourcesSoup.txt, but I&apos;m
&gt; not really sure that this files need to be part of unified build, and even
&gt; if they do, it&apos;s just one extra line of cmake code.

They should remain part of the unified build, but yes, one extra line of CMake code is not hard.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397148</commentid>
    <comment_count>8</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2018-02-07 05:55:41 -0800</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #7)
&gt; Its own build target? Isn&apos;t that overkill?

Not a build target but imported target, and no, it&apos;s not an overkill, it&apos;s rather recommended approach for modern cmake find modules. See e.g. FindZLIB.cmake in sufficiently new cmake

&gt; They should remain part of the unified build, but yes, one extra line of
&gt; CMake code is not hard.

I see, thanks</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397149</commentid>
    <comment_count>9</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2018-02-07 05:56:59 -0800</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #7)
&gt; But note &quot;libsoup&quot; is all lowercase.

Huh? Find modules is named FindLibSoup, so it&apos;s LibSoup for cmake :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397183</commentid>
    <comment_count>10</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-02-07 08:29:54 -0800</bug_when>
    <thetext>The find module is wrong!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397188</commentid>
    <comment_count>11</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2018-02-07 08:45:15 -0800</bug_when>
    <thetext>That was (partially) kidding, as any target name can be used. However, it&apos;s common to name targets that resemble cmake module name, optionally with namespace.

Naming target as &quot;libsoup&quot; can be confusing (because one can use raw library names in target_link_libraries etc.), but WebKit::libsoup should be fine.

Of course we can continue using ${LIBSOUP_LIBRARIES} with changed content of variable, and drop ${LIBSOUP_INCLUDE_DIRS}, but with target names it looks somewhat cleaner</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397242</commentid>
    <comment_count>12</comment_count>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2018-02-07 11:04:46 -0800</bug_when>
    <thetext>I think we&apos;re losing sight of why I&apos;m proposing this change.

I&apos;m working towards copying all WebCore headers needed by the individual ports. In this case I am enumerating ALL headers within WebCore to copy. This is over 1000 headers that are being declared.

Because GTK and WPE use Soup and there are associated headers to copy I thought it would be a good idea to create a common Soup.cmake so I could put them all in there to remove duplication and to make it easier to keep things in sync.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397246</commentid>
    <comment_count>13</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2018-02-07 11:08:55 -0800</bug_when>
    <thetext>Enumerations of headers doubles effort needed to maintain file lists. Why do we need it at all?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397255</commentid>
    <comment_count>14</comment_count>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2018-02-07 11:40:35 -0800</bug_when>
    <thetext>(In reply to Konstantin Tokarev from comment #13)
&gt; Enumerations of headers doubles effort needed to maintain file lists. Why do
&gt; we need it at all?

For the same reason you enumerate all the source files in CMake rather than using globs. The macro made in https://bugs.webkit.org/show_bug.cgi?id=180921 creates a target which copies the headers with each being an input and each declaring an output. My plan is to use that directly and I&apos;m going through the trouble of enumerating all the headers because I might as well do it right.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397314</commentid>
    <comment_count>15</comment_count>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2018-02-07 14:53:44 -0800</bug_when>
    <thetext>Michael and Konstantin so I&apos;m prepping a patch for https://bugs.webkit.org/show_bug.cgi?id=182512.

If this patch lands I would be adding into that in a similar manner to the modifications within Curl. So within Soup.platform there would be the following which would be shared by WPE/GTK.

list(APPEND WebCore_FORWARDING_HEADERS
    platform/network/soup/AuthenticationChallenge.h
    platform/network/soup/CertificateInfo.h
    platform/network/soup/GRefPtrSoup.h
    platform/network/soup/GUniquePtrSoup.h
    platform/network/soup/ResourceError.h
    platform/network/soup/ResourceRequest.h
    platform/network/soup/ResourceResponse.h
    platform/network/soup/SocketStreamHandleImpl.h
)

If you guys don&apos;t want this patch lets close it and I&apos;ll just duplicate those lines in PlatformGTK/WPE within Source/WebCore.

I do think we should avoid the duplication which fits Konstantin&apos;s &quot;share file lists&quot; requirement but I&apos;m not a GTK/WPE developer so these aren&apos;t things I&apos;ll be touching in the future so I can just close as WONTFIX.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397354</commentid>
    <comment_count>16</comment_count>
      <attachid>333245</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-02-07 15:53:25 -0800</bug_when>
    <thetext>Comment on attachment 333245
Patch

At this point I think adding a new file is going to make it harder, rather than easier, to edit the build system. I appreciate the desire to avoid listing headers multiple times, but it seems like only a small amount of duplication.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397356</commentid>
    <comment_count>17</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2018-02-07 16:05:25 -0800</bug_when>
    <thetext>I&apos;m all for sharing file list but I&apos;m not really convinced that we need to have header listings. I think you should use generate-forwarding-headers.pl like other ports, and maybe modify it to copy headers instead of making forward headers. It doesn&apos;t use any globbing, instead it parses #include directives and detects all headers which require &quot;forwarding&quot;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397442</commentid>
    <comment_count>18</comment_count>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2018-02-07 20:15:28 -0800</bug_when>
    <thetext>(In reply to Konstantin Tokarev from comment #17)
&gt; I&apos;m all for sharing file list but I&apos;m not really convinced that we need to
&gt; have header listings. I think you should use generate-forwarding-headers.pl
&gt; like other ports, and maybe modify it to copy headers instead of making
&gt; forward headers. It doesn&apos;t use any globbing, instead it parses #include
&gt; directives and detects all headers which require &quot;forwarding&quot;.

See https://bugs.webkit.org/show_bug.cgi?id=182512#c13 for generate-forwarding-headers.pl reasoning.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397451</commentid>
    <comment_count>19</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2018-02-07 21:01:02 -0800</bug_when>
    <thetext>(In reply to Konstantin Tokarev from comment #17)
&gt; I think you should use generate-forwarding-headers.pl like
&gt; other ports, and maybe modify it to copy headers instead of
&gt; making forward headers.

This idea does work as expected for the copying header approach.
Ninja has to know which files are generated by
generate-forwarding-headers.pl for incremental builds.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1398950</commentid>
    <comment_count>20</comment_count>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2018-02-13 21:43:45 -0800</bug_when>
    <thetext>Closing</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>333232</attachid>
            <date>2018-02-06 15:56:01 -0800</date>
            <delta_ts>2018-02-06 18:07:22 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-182555.diff</filename>
            <type>text/plain</type>
            <size>3841</size>
            <attacher name="Don Olmstead">don.olmstead</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCA4NDkxMmY3NzNmNy4uOGI4YjkyMjJkNGQgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNiBAQAorMjAxOC0wMi0wNiAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnku
Y29tPgorCisgICAgICAgIFtDTWFrZV0gQWRkIGxpYnNvdXAgcGxhdGZvcm0gZmlsZQorICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyNTU1CisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBO
byBjaGFuZ2UgaW4gYmVodmFpb3IuCisKKyAgICAgICAgKiBQbGF0Zm9ybUdUSy5jbWFrZToKKyAg
ICAgICAgKiBQbGF0Zm9ybVdQRS5jbWFrZToKKyAgICAgICAgKiBwbGF0Zm9ybS9Tb3VwLmNtYWtl
OiBBZGRlZC4KKwogMjAxOC0wMi0wNiAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAK
ICAgICAgICAgW1BheW1lbnQgUmVxdWVzdF0gc2hvdygpIHNob3VsZCB0YWtlIGFuIG9wdGlvbmFs
IFBheW1lbnREZXRhaWxzVXBkYXRlIHByb21pc2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl
L1BsYXRmb3JtR1RLLmNtYWtlIGIvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsuY21ha2UKaW5k
ZXggMzJjNmNjY2QyODIuLjliZjk3NWZhZDQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Q
bGF0Zm9ybUdUSy5jbWFrZQorKysgYi9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUdUSy5jbWFrZQpA
QCAtMyw2ICszLDcgQEAgaW5jbHVkZShwbGF0Zm9ybS9GcmVlVHlwZS5jbWFrZSkKIGluY2x1ZGUo
cGxhdGZvcm0vR0NyeXB0LmNtYWtlKQogaW5jbHVkZShwbGF0Zm9ybS9HU3RyZWFtZXIuY21ha2Up
CiBpbmNsdWRlKHBsYXRmb3JtL0ltYWdlRGVjb2RlcnMuY21ha2UpCitpbmNsdWRlKHBsYXRmb3Jt
L1NvdXAuY21ha2UpCiBpbmNsdWRlKHBsYXRmb3JtL1RleHR1cmVNYXBwZXIuY21ha2UpCiAKIHNl
dChXZWJDb3JlX09VVFBVVF9OQU1FIFdlYkNvcmVHVEspCkBAIC0xMSw3ICsxMiw2IEBAIGxpc3Qo
QVBQRU5EIFdlYkNvcmVfVU5JRklFRF9TT1VSQ0VfTElTVF9GSUxFUwogICAgICJTb3VyY2VzR1RL
LnR4dCIKIAogICAgICJwbGF0Zm9ybS9Tb3VyY2VzR0xpYi50eHQiCi0gICAgInBsYXRmb3JtL1Nv
dXJjZXNTb3VwLnR4dCIKICkKIAogbGlzdChBUFBFTkQgV2ViQ29yZV9JTkNMVURFX0RJUkVDVE9S
SUVTCkBAIC0zMiw3ICszMiw2IEBAIGxpc3QoQVBQRU5EIFdlYkNvcmVfSU5DTFVERV9ESVJFQ1RP
UklFUwogICAgICIke1dFQkNPUkVfRElSfS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9ndGsiCiAgICAg
IiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL21vY2svbWVkaWFzb3VyY2UiCiAgICAgIiR7V0VCQ09S
RV9ESVJ9L3BsYXRmb3JtL25ldHdvcmsvZ3RrIgotICAgICIke1dFQkNPUkVfRElSfS9wbGF0Zm9y
bS9uZXR3b3JrL3NvdXAiCiAgICAgIiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL3RleHQvZ3RrIgog
KQogCkBAIC0xMDMsNyArMTAyLDYgQEAgbGlzdChBUFBFTkQgV2ViQ29yZV9MSUJSQVJJRVMKICAg
ICAke0dMSUJfR09CSkVDVF9MSUJSQVJJRVN9CiAgICAgJHtHTElCX0xJQlJBUklFU30KICAgICAk
e0xJQlNFQ1JFVF9MSUJSQVJJRVN9Ci0gICAgJHtMSUJTT1VQX0xJQlJBUklFU30KICAgICAke0xJ
QlRBU04xX0xJQlJBUklFU30KICAgICAke0hZUEhFTl9MSUJSQVJJRVN9CiAgICAgJHtVUE9XRVJH
TElCX0xJQlJBUklFU30KQEAgLTEyMiw3ICsxMjAsNiBAQCBsaXN0KEFQUEVORCBXZWJDb3JlX1NZ
U1RFTV9JTkNMVURFX0RJUkVDVE9SSUVTCiAgICAgJHtHSU9fVU5JWF9JTkNMVURFX0RJUlN9CiAg
ICAgJHtHTElCX0lOQ0xVREVfRElSU30KICAgICAke0xJQlNFQ1JFVF9JTkNMVURFX0RJUlN9Ci0g
ICAgJHtMSUJTT1VQX0lOQ0xVREVfRElSU30KICAgICAke0xJQlRBU04xX0lOQ0xVREVfRElSU30K
ICAgICAke1VQT1dFUkdMSUJfSU5DTFVERV9ESVJTfQogICAgICR7WkxJQl9JTkNMVURFX0RJUlN9
CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybVdQRS5jbWFrZSBiL1NvdXJjZS9X
ZWJDb3JlL1BsYXRmb3JtV1BFLmNtYWtlCmluZGV4IGIxOGI3OTQ0OTE2Li5jNjI0ZmJmYzkxZSAx
MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1XUEUuY21ha2UKKysrIGIvU291cmNl
L1dlYkNvcmUvUGxhdGZvcm1XUEUuY21ha2UKQEAgLTksNyArOSw2IEBAIGxpc3QoQVBQRU5EIFdl
YkNvcmVfVU5JRklFRF9TT1VSQ0VfTElTVF9GSUxFUwogICAgICJTb3VyY2VzV1BFLnR4dCIKIAog
ICAgICJwbGF0Zm9ybS9Tb3VyY2VzR0xpYi50eHQiCi0gICAgInBsYXRmb3JtL1NvdXJjZXNTb3Vw
LnR4dCIKICkKIAogIyBBbGxvdyBidWlsZGluZyBBTkdMRSBvbiBwbGF0Zm9ybXMgdGhhdCBkb24n
dCBwcm92aWRlIFgxMSBoZWFkZXJzLgpAQCAtMjcsNyArMjYsNiBAQCBsaXN0KEFQUEVORCBXZWJD
b3JlX0lOQ0xVREVfRElSRUNUT1JJRVMKICAgICAiJHtXRUJDT1JFX0RJUn0vcGxhdGZvcm0vZ3Jh
cGhpY3Mvd3BlIgogICAgICIke1dFQkNPUkVfRElSfS9wbGF0Zm9ybS9ncmFwaGljcy93YXlsYW5k
IgogICAgICIke1dFQkNPUkVfRElSfS9wbGF0Zm9ybS9tb2NrL21lZGlhc291cmNlIgotICAgICIk
e1dFQkNPUkVfRElSfS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAiCiAgICAgIiR7V0VCQ09SRV9ESVJ9
L3BsYXRmb3JtL3RleHQvaWN1IgogKQogCkBAIC00OSw3ICs0Nyw2IEBAIGxpc3QoQVBQRU5EIFdl
YkNvcmVfTElCUkFSSUVTCiAgICAgJHtHTElCX0dPQkpFQ1RfTElCUkFSSUVTfQogICAgICR7R0xJ
Ql9MSUJSQVJJRVN9CiAgICAgJHtJQ1VfTElCUkFSSUVTfQotICAgICR7TElCU09VUF9MSUJSQVJJ
RVN9CiAgICAgJHtMSUJUQVNOMV9MSUJSQVJJRVN9CiAgICAgJHtVUE9XRVJHTElCX0xJQlJBUklF
U30KICAgICAke1dQRV9MSUJSQVJJRVN9CkBAIC02MCw3ICs1Nyw2IEBAIGxpc3QoQVBQRU5EIFdl
YkNvcmVfU1lTVEVNX0lOQ0xVREVfRElSRUNUT1JJRVMKICAgICAke0dJT19VTklYX0lOQ0xVREVf
RElSU30KICAgICAke0dMSUJfSU5DTFVERV9ESVJTfQogICAgICR7SUNVX0lOQ0xVREVfRElSU30K
LSAgICAke0xJQlNPVVBfSU5DTFVERV9ESVJTfQogICAgICR7TElCVEFTTjFfSU5DTFVERV9ESVJT
fQogICAgICR7VVBPV0VSR0xJQl9JTkNMVURFX0RJUlN9CiAgICAgJHtXUEVfSU5DTFVERV9ESVJT
fQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU291cC5jbWFrZSBiL1NvdXJj
ZS9XZWJDb3JlL3BsYXRmb3JtL1NvdXAuY21ha2UKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg
MDAwMDAwMDAwMDAuLmM3MDZhOTU1YTkzCi0tLSAvZGV2L251bGwKKysrIGIvU291cmNlL1dlYkNv
cmUvcGxhdGZvcm0vU291cC5jbWFrZQpAQCAtMCwwICsxLDE1IEBACitsaXN0KEFQUEVORCBXZWJD
b3JlX1BSSVZBVEVfSU5DTFVERV9ESVJFQ1RPUklFUworICAgICIke1dFQkNPUkVfRElSfS9wbGF0
Zm9ybS9uZXR3b3JrL3NvdXAiCispCisKK2xpc3QoQVBQRU5EIFdlYkNvcmVfVU5JRklFRF9TT1VS
Q0VfTElTVF9GSUxFUworICAgICJwbGF0Zm9ybS9Tb3VyY2VzU291cC50eHQiCispCisKK2xpc3Qo
QVBQRU5EIFdlYkNvcmVfU1lTVEVNX0lOQ0xVREVfRElSRUNUT1JJRVMKKyAgICAke0xJQlNPVVBf
SU5DTFVERV9ESVJTfQorKQorCitsaXN0KEFQUEVORCBXZWJDb3JlX0xJQlJBUklFUworICAgICR7
TElCU09VUF9MSUJSQVJJRVN9CispCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>333241</attachid>
            <date>2018-02-06 18:07:22 -0800</date>
            <delta_ts>2018-02-06 18:11:55 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-182555.diff</filename>
            <type>text/plain</type>
            <size>3818</size>
            <attacher name="Don Olmstead">don.olmstead</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCA4NDkxMmY3NzNmNy4uZDQyOWI4NjEyNWEgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNiBAQAorMjAxOC0wMi0wNiAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnku
Y29tPgorCisgICAgICAgIFtDTWFrZV0gQWRkIGxpYnNvdXAgcGxhdGZvcm0gZmlsZQorICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyNTU1CisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIChP
T1BTISkuCisKKyAgICAgICAgKiBQbGF0Zm9ybUdUSy5jbWFrZToKKyAgICAgICAgKiBQbGF0Zm9y
bVdQRS5jbWFrZToKKyAgICAgICAgKiBwbGF0Zm9ybS9Tb3VwLmNtYWtlOiBBZGRlZC4KKwogMjAx
OC0wMi0wNiAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgW1BheW1l
bnQgUmVxdWVzdF0gc2hvdygpIHNob3VsZCB0YWtlIGFuIG9wdGlvbmFsIFBheW1lbnREZXRhaWxz
VXBkYXRlIHByb21pc2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNt
YWtlIGIvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggMzJjNmNjY2QyODIu
LjliZjk3NWZhZDQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUdUSy5jbWFr
ZQorKysgYi9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUdUSy5jbWFrZQpAQCAtMyw2ICszLDcgQEAg
aW5jbHVkZShwbGF0Zm9ybS9GcmVlVHlwZS5jbWFrZSkKIGluY2x1ZGUocGxhdGZvcm0vR0NyeXB0
LmNtYWtlKQogaW5jbHVkZShwbGF0Zm9ybS9HU3RyZWFtZXIuY21ha2UpCiBpbmNsdWRlKHBsYXRm
b3JtL0ltYWdlRGVjb2RlcnMuY21ha2UpCitpbmNsdWRlKHBsYXRmb3JtL1NvdXAuY21ha2UpCiBp
bmNsdWRlKHBsYXRmb3JtL1RleHR1cmVNYXBwZXIuY21ha2UpCiAKIHNldChXZWJDb3JlX09VVFBV
VF9OQU1FIFdlYkNvcmVHVEspCkBAIC0xMSw3ICsxMiw2IEBAIGxpc3QoQVBQRU5EIFdlYkNvcmVf
VU5JRklFRF9TT1VSQ0VfTElTVF9GSUxFUwogICAgICJTb3VyY2VzR1RLLnR4dCIKIAogICAgICJw
bGF0Zm9ybS9Tb3VyY2VzR0xpYi50eHQiCi0gICAgInBsYXRmb3JtL1NvdXJjZXNTb3VwLnR4dCIK
ICkKIAogbGlzdChBUFBFTkQgV2ViQ29yZV9JTkNMVURFX0RJUkVDVE9SSUVTCkBAIC0zMiw3ICsz
Miw2IEBAIGxpc3QoQVBQRU5EIFdlYkNvcmVfSU5DTFVERV9ESVJFQ1RPUklFUwogICAgICIke1dF
QkNPUkVfRElSfS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9ndGsiCiAgICAgIiR7V0VCQ09SRV9ESVJ9
L3BsYXRmb3JtL21vY2svbWVkaWFzb3VyY2UiCiAgICAgIiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3Jt
L25ldHdvcmsvZ3RrIgotICAgICIke1dFQkNPUkVfRElSfS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAi
CiAgICAgIiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL3RleHQvZ3RrIgogKQogCkBAIC0xMDMsNyAr
MTAyLDYgQEAgbGlzdChBUFBFTkQgV2ViQ29yZV9MSUJSQVJJRVMKICAgICAke0dMSUJfR09CSkVD
VF9MSUJSQVJJRVN9CiAgICAgJHtHTElCX0xJQlJBUklFU30KICAgICAke0xJQlNFQ1JFVF9MSUJS
QVJJRVN9Ci0gICAgJHtMSUJTT1VQX0xJQlJBUklFU30KICAgICAke0xJQlRBU04xX0xJQlJBUklF
U30KICAgICAke0hZUEhFTl9MSUJSQVJJRVN9CiAgICAgJHtVUE9XRVJHTElCX0xJQlJBUklFU30K
QEAgLTEyMiw3ICsxMjAsNiBAQCBsaXN0KEFQUEVORCBXZWJDb3JlX1NZU1RFTV9JTkNMVURFX0RJ
UkVDVE9SSUVTCiAgICAgJHtHSU9fVU5JWF9JTkNMVURFX0RJUlN9CiAgICAgJHtHTElCX0lOQ0xV
REVfRElSU30KICAgICAke0xJQlNFQ1JFVF9JTkNMVURFX0RJUlN9Ci0gICAgJHtMSUJTT1VQX0lO
Q0xVREVfRElSU30KICAgICAke0xJQlRBU04xX0lOQ0xVREVfRElSU30KICAgICAke1VQT1dFUkdM
SUJfSU5DTFVERV9ESVJTfQogICAgICR7WkxJQl9JTkNMVURFX0RJUlN9CmRpZmYgLS1naXQgYS9T
b3VyY2UvV2ViQ29yZS9QbGF0Zm9ybVdQRS5jbWFrZSBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3Jt
V1BFLmNtYWtlCmluZGV4IGIxOGI3OTQ0OTE2Li5jNjI0ZmJmYzkxZSAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYkNvcmUvUGxhdGZvcm1XUEUuY21ha2UKKysrIGIvU291cmNlL1dlYkNvcmUvUGxhdGZv
cm1XUEUuY21ha2UKQEAgLTksNyArOSw2IEBAIGxpc3QoQVBQRU5EIFdlYkNvcmVfVU5JRklFRF9T
T1VSQ0VfTElTVF9GSUxFUwogICAgICJTb3VyY2VzV1BFLnR4dCIKIAogICAgICJwbGF0Zm9ybS9T
b3VyY2VzR0xpYi50eHQiCi0gICAgInBsYXRmb3JtL1NvdXJjZXNTb3VwLnR4dCIKICkKIAogIyBB
bGxvdyBidWlsZGluZyBBTkdMRSBvbiBwbGF0Zm9ybXMgdGhhdCBkb24ndCBwcm92aWRlIFgxMSBo
ZWFkZXJzLgpAQCAtMjcsNyArMjYsNiBAQCBsaXN0KEFQUEVORCBXZWJDb3JlX0lOQ0xVREVfRElS
RUNUT1JJRVMKICAgICAiJHtXRUJDT1JFX0RJUn0vcGxhdGZvcm0vZ3JhcGhpY3Mvd3BlIgogICAg
ICIke1dFQkNPUkVfRElSfS9wbGF0Zm9ybS9ncmFwaGljcy93YXlsYW5kIgogICAgICIke1dFQkNP
UkVfRElSfS9wbGF0Zm9ybS9tb2NrL21lZGlhc291cmNlIgotICAgICIke1dFQkNPUkVfRElSfS9w
bGF0Zm9ybS9uZXR3b3JrL3NvdXAiCiAgICAgIiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL3RleHQv
aWN1IgogKQogCkBAIC00OSw3ICs0Nyw2IEBAIGxpc3QoQVBQRU5EIFdlYkNvcmVfTElCUkFSSUVT
CiAgICAgJHtHTElCX0dPQkpFQ1RfTElCUkFSSUVTfQogICAgICR7R0xJQl9MSUJSQVJJRVN9CiAg
ICAgJHtJQ1VfTElCUkFSSUVTfQotICAgICR7TElCU09VUF9MSUJSQVJJRVN9CiAgICAgJHtMSUJU
QVNOMV9MSUJSQVJJRVN9CiAgICAgJHtVUE9XRVJHTElCX0xJQlJBUklFU30KICAgICAke1dQRV9M
SUJSQVJJRVN9CkBAIC02MCw3ICs1Nyw2IEBAIGxpc3QoQVBQRU5EIFdlYkNvcmVfU1lTVEVNX0lO
Q0xVREVfRElSRUNUT1JJRVMKICAgICAke0dJT19VTklYX0lOQ0xVREVfRElSU30KICAgICAke0dM
SUJfSU5DTFVERV9ESVJTfQogICAgICR7SUNVX0lOQ0xVREVfRElSU30KLSAgICAke0xJQlNPVVBf
SU5DTFVERV9ESVJTfQogICAgICR7TElCVEFTTjFfSU5DTFVERV9ESVJTfQogICAgICR7VVBPV0VS
R0xJQl9JTkNMVURFX0RJUlN9CiAgICAgJHtXUEVfSU5DTFVERV9ESVJTfQpkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU291cC5jbWFrZSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm
b3JtL1NvdXAuY21ha2UKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLmJk
NjkyZDViYTA0Ci0tLSAvZGV2L251bGwKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU291
cC5jbWFrZQpAQCAtMCwwICsxLDE1IEBACitsaXN0KEFQUEVORCBXZWJDb3JlX0lOQ0xVREVfRElS
RUNUT1JJRVMKKyAgICAiJHtXRUJDT1JFX0RJUn0vcGxhdGZvcm0vbmV0d29yay9zb3VwIgorKQor
CitsaXN0KEFQUEVORCBXZWJDb3JlX1VOSUZJRURfU09VUkNFX0xJU1RfRklMRVMKKyAgICAicGxh
dGZvcm0vU291cmNlc1NvdXAudHh0IgorKQorCitsaXN0KEFQUEVORCBXZWJDb3JlX1NZU1RFTV9J
TkNMVURFX0RJUkVDVE9SSUVTCisgICAgJHtMSUJTT1VQX0lOQ0xVREVfRElSU30KKykKKworbGlz
dChBUFBFTkQgV2ViQ29yZV9MSUJSQVJJRVMKKyAgICAke0xJQlNPVVBfTElCUkFSSUVTfQorKQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>333243</attachid>
            <date>2018-02-06 18:11:55 -0800</date>
            <delta_ts>2018-02-06 18:15:20 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-182555.diff</filename>
            <type>text/plain</type>
            <size>3833</size>
            <attacher name="Don Olmstead">don.olmstead</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCA4NDkxMmY3NzNmNy4uY2M1MzAzODdmYmYgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNiBAQAorMjAxOC0wMi0wNiAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnku
Y29tPgorCisgICAgICAgIFtDTWFrZV0gQWRkIGxpYnNvdXAgcGxhdGZvcm0gZmlsZQorICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyNTU1CisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBO
byBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBQbGF0Zm9ybUdUSy5jbWFrZToKKyAg
ICAgICAgKiBQbGF0Zm9ybVdQRS5jbWFrZToKKyAgICAgICAgKiBwbGF0Zm9ybS9Tb3VwLmNtYWtl
OiBBZGRlZC4KKwogMjAxOC0wMi0wNiAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAK
ICAgICAgICAgW1BheW1lbnQgUmVxdWVzdF0gc2hvdygpIHNob3VsZCB0YWtlIGFuIG9wdGlvbmFs
IFBheW1lbnREZXRhaWxzVXBkYXRlIHByb21pc2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl
L1BsYXRmb3JtR1RLLmNtYWtlIGIvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsuY21ha2UKaW5k
ZXggMzJjNmNjY2QyODIuLjliZjk3NWZhZDQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Q
bGF0Zm9ybUdUSy5jbWFrZQorKysgYi9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUdUSy5jbWFrZQpA
QCAtMyw2ICszLDcgQEAgaW5jbHVkZShwbGF0Zm9ybS9GcmVlVHlwZS5jbWFrZSkKIGluY2x1ZGUo
cGxhdGZvcm0vR0NyeXB0LmNtYWtlKQogaW5jbHVkZShwbGF0Zm9ybS9HU3RyZWFtZXIuY21ha2Up
CiBpbmNsdWRlKHBsYXRmb3JtL0ltYWdlRGVjb2RlcnMuY21ha2UpCitpbmNsdWRlKHBsYXRmb3Jt
L1NvdXAuY21ha2UpCiBpbmNsdWRlKHBsYXRmb3JtL1RleHR1cmVNYXBwZXIuY21ha2UpCiAKIHNl
dChXZWJDb3JlX09VVFBVVF9OQU1FIFdlYkNvcmVHVEspCkBAIC0xMSw3ICsxMiw2IEBAIGxpc3Qo
QVBQRU5EIFdlYkNvcmVfVU5JRklFRF9TT1VSQ0VfTElTVF9GSUxFUwogICAgICJTb3VyY2VzR1RL
LnR4dCIKIAogICAgICJwbGF0Zm9ybS9Tb3VyY2VzR0xpYi50eHQiCi0gICAgInBsYXRmb3JtL1Nv
dXJjZXNTb3VwLnR4dCIKICkKIAogbGlzdChBUFBFTkQgV2ViQ29yZV9JTkNMVURFX0RJUkVDVE9S
SUVTCkBAIC0zMiw3ICszMiw2IEBAIGxpc3QoQVBQRU5EIFdlYkNvcmVfSU5DTFVERV9ESVJFQ1RP
UklFUwogICAgICIke1dFQkNPUkVfRElSfS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9ndGsiCiAgICAg
IiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL21vY2svbWVkaWFzb3VyY2UiCiAgICAgIiR7V0VCQ09S
RV9ESVJ9L3BsYXRmb3JtL25ldHdvcmsvZ3RrIgotICAgICIke1dFQkNPUkVfRElSfS9wbGF0Zm9y
bS9uZXR3b3JrL3NvdXAiCiAgICAgIiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL3RleHQvZ3RrIgog
KQogCkBAIC0xMDMsNyArMTAyLDYgQEAgbGlzdChBUFBFTkQgV2ViQ29yZV9MSUJSQVJJRVMKICAg
ICAke0dMSUJfR09CSkVDVF9MSUJSQVJJRVN9CiAgICAgJHtHTElCX0xJQlJBUklFU30KICAgICAk
e0xJQlNFQ1JFVF9MSUJSQVJJRVN9Ci0gICAgJHtMSUJTT1VQX0xJQlJBUklFU30KICAgICAke0xJ
QlRBU04xX0xJQlJBUklFU30KICAgICAke0hZUEhFTl9MSUJSQVJJRVN9CiAgICAgJHtVUE9XRVJH
TElCX0xJQlJBUklFU30KQEAgLTEyMiw3ICsxMjAsNiBAQCBsaXN0KEFQUEVORCBXZWJDb3JlX1NZ
U1RFTV9JTkNMVURFX0RJUkVDVE9SSUVTCiAgICAgJHtHSU9fVU5JWF9JTkNMVURFX0RJUlN9CiAg
ICAgJHtHTElCX0lOQ0xVREVfRElSU30KICAgICAke0xJQlNFQ1JFVF9JTkNMVURFX0RJUlN9Ci0g
ICAgJHtMSUJTT1VQX0lOQ0xVREVfRElSU30KICAgICAke0xJQlRBU04xX0lOQ0xVREVfRElSU30K
ICAgICAke1VQT1dFUkdMSUJfSU5DTFVERV9ESVJTfQogICAgICR7WkxJQl9JTkNMVURFX0RJUlN9
CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybVdQRS5jbWFrZSBiL1NvdXJjZS9X
ZWJDb3JlL1BsYXRmb3JtV1BFLmNtYWtlCmluZGV4IGIxOGI3OTQ0OTE2Li5jNjI0ZmJmYzkxZSAx
MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1XUEUuY21ha2UKKysrIGIvU291cmNl
L1dlYkNvcmUvUGxhdGZvcm1XUEUuY21ha2UKQEAgLTksNyArOSw2IEBAIGxpc3QoQVBQRU5EIFdl
YkNvcmVfVU5JRklFRF9TT1VSQ0VfTElTVF9GSUxFUwogICAgICJTb3VyY2VzV1BFLnR4dCIKIAog
ICAgICJwbGF0Zm9ybS9Tb3VyY2VzR0xpYi50eHQiCi0gICAgInBsYXRmb3JtL1NvdXJjZXNTb3Vw
LnR4dCIKICkKIAogIyBBbGxvdyBidWlsZGluZyBBTkdMRSBvbiBwbGF0Zm9ybXMgdGhhdCBkb24n
dCBwcm92aWRlIFgxMSBoZWFkZXJzLgpAQCAtMjcsNyArMjYsNiBAQCBsaXN0KEFQUEVORCBXZWJD
b3JlX0lOQ0xVREVfRElSRUNUT1JJRVMKICAgICAiJHtXRUJDT1JFX0RJUn0vcGxhdGZvcm0vZ3Jh
cGhpY3Mvd3BlIgogICAgICIke1dFQkNPUkVfRElSfS9wbGF0Zm9ybS9ncmFwaGljcy93YXlsYW5k
IgogICAgICIke1dFQkNPUkVfRElSfS9wbGF0Zm9ybS9tb2NrL21lZGlhc291cmNlIgotICAgICIk
e1dFQkNPUkVfRElSfS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAiCiAgICAgIiR7V0VCQ09SRV9ESVJ9
L3BsYXRmb3JtL3RleHQvaWN1IgogKQogCkBAIC00OSw3ICs0Nyw2IEBAIGxpc3QoQVBQRU5EIFdl
YkNvcmVfTElCUkFSSUVTCiAgICAgJHtHTElCX0dPQkpFQ1RfTElCUkFSSUVTfQogICAgICR7R0xJ
Ql9MSUJSQVJJRVN9CiAgICAgJHtJQ1VfTElCUkFSSUVTfQotICAgICR7TElCU09VUF9MSUJSQVJJ
RVN9CiAgICAgJHtMSUJUQVNOMV9MSUJSQVJJRVN9CiAgICAgJHtVUE9XRVJHTElCX0xJQlJBUklF
U30KICAgICAke1dQRV9MSUJSQVJJRVN9CkBAIC02MCw3ICs1Nyw2IEBAIGxpc3QoQVBQRU5EIFdl
YkNvcmVfU1lTVEVNX0lOQ0xVREVfRElSRUNUT1JJRVMKICAgICAke0dJT19VTklYX0lOQ0xVREVf
RElSU30KICAgICAke0dMSUJfSU5DTFVERV9ESVJTfQogICAgICR7SUNVX0lOQ0xVREVfRElSU30K
LSAgICAke0xJQlNPVVBfSU5DTFVERV9ESVJTfQogICAgICR7TElCVEFTTjFfSU5DTFVERV9ESVJT
fQogICAgICR7VVBPV0VSR0xJQl9JTkNMVURFX0RJUlN9CiAgICAgJHtXUEVfSU5DTFVERV9ESVJT
fQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU291cC5jbWFrZSBiL1NvdXJj
ZS9XZWJDb3JlL3BsYXRmb3JtL1NvdXAuY21ha2UKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg
MDAwMDAwMDAwMDAuLmJkNjkyZDViYTA0Ci0tLSAvZGV2L251bGwKKysrIGIvU291cmNlL1dlYkNv
cmUvcGxhdGZvcm0vU291cC5jbWFrZQpAQCAtMCwwICsxLDE1IEBACitsaXN0KEFQUEVORCBXZWJD
b3JlX0lOQ0xVREVfRElSRUNUT1JJRVMKKyAgICAiJHtXRUJDT1JFX0RJUn0vcGxhdGZvcm0vbmV0
d29yay9zb3VwIgorKQorCitsaXN0KEFQUEVORCBXZWJDb3JlX1VOSUZJRURfU09VUkNFX0xJU1Rf
RklMRVMKKyAgICAicGxhdGZvcm0vU291cmNlc1NvdXAudHh0IgorKQorCitsaXN0KEFQUEVORCBX
ZWJDb3JlX1NZU1RFTV9JTkNMVURFX0RJUkVDVE9SSUVTCisgICAgJHtMSUJTT1VQX0lOQ0xVREVf
RElSU30KKykKKworbGlzdChBUFBFTkQgV2ViQ29yZV9MSUJSQVJJRVMKKyAgICAke0xJQlNPVVBf
TElCUkFSSUVTfQorKQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>333245</attachid>
            <date>2018-02-06 18:15:20 -0800</date>
            <delta_ts>2018-02-07 15:53:25 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-182555.diff</filename>
            <type>text/plain</type>
            <size>4046</size>
            <attacher name="Don Olmstead">don.olmstead</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCA4NDkxMmY3NzNmNy4uY2M1MzAzODdmYmYgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNiBAQAorMjAxOC0wMi0wNiAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnku
Y29tPgorCisgICAgICAgIFtDTWFrZV0gQWRkIGxpYnNvdXAgcGxhdGZvcm0gZmlsZQorICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyNTU1CisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBO
byBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBQbGF0Zm9ybUdUSy5jbWFrZToKKyAg
ICAgICAgKiBQbGF0Zm9ybVdQRS5jbWFrZToKKyAgICAgICAgKiBwbGF0Zm9ybS9Tb3VwLmNtYWtl
OiBBZGRlZC4KKwogMjAxOC0wMi0wNiAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAK
ICAgICAgICAgW1BheW1lbnQgUmVxdWVzdF0gc2hvdygpIHNob3VsZCB0YWtlIGFuIG9wdGlvbmFs
IFBheW1lbnREZXRhaWxzVXBkYXRlIHByb21pc2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl
L1BsYXRmb3JtR1RLLmNtYWtlIGIvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsuY21ha2UKaW5k
ZXggMzJjNmNjY2QyODIuLjliZjk3NWZhZDQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Q
bGF0Zm9ybUdUSy5jbWFrZQorKysgYi9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUdUSy5jbWFrZQpA
QCAtMyw2ICszLDcgQEAgaW5jbHVkZShwbGF0Zm9ybS9GcmVlVHlwZS5jbWFrZSkKIGluY2x1ZGUo
cGxhdGZvcm0vR0NyeXB0LmNtYWtlKQogaW5jbHVkZShwbGF0Zm9ybS9HU3RyZWFtZXIuY21ha2Up
CiBpbmNsdWRlKHBsYXRmb3JtL0ltYWdlRGVjb2RlcnMuY21ha2UpCitpbmNsdWRlKHBsYXRmb3Jt
L1NvdXAuY21ha2UpCiBpbmNsdWRlKHBsYXRmb3JtL1RleHR1cmVNYXBwZXIuY21ha2UpCiAKIHNl
dChXZWJDb3JlX09VVFBVVF9OQU1FIFdlYkNvcmVHVEspCkBAIC0xMSw3ICsxMiw2IEBAIGxpc3Qo
QVBQRU5EIFdlYkNvcmVfVU5JRklFRF9TT1VSQ0VfTElTVF9GSUxFUwogICAgICJTb3VyY2VzR1RL
LnR4dCIKIAogICAgICJwbGF0Zm9ybS9Tb3VyY2VzR0xpYi50eHQiCi0gICAgInBsYXRmb3JtL1Nv
dXJjZXNTb3VwLnR4dCIKICkKIAogbGlzdChBUFBFTkQgV2ViQ29yZV9JTkNMVURFX0RJUkVDVE9S
SUVTCkBAIC0zMiw3ICszMiw2IEBAIGxpc3QoQVBQRU5EIFdlYkNvcmVfSU5DTFVERV9ESVJFQ1RP
UklFUwogICAgICIke1dFQkNPUkVfRElSfS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9ndGsiCiAgICAg
IiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL21vY2svbWVkaWFzb3VyY2UiCiAgICAgIiR7V0VCQ09S
RV9ESVJ9L3BsYXRmb3JtL25ldHdvcmsvZ3RrIgotICAgICIke1dFQkNPUkVfRElSfS9wbGF0Zm9y
bS9uZXR3b3JrL3NvdXAiCiAgICAgIiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL3RleHQvZ3RrIgog
KQogCkBAIC0xMDMsNyArMTAyLDYgQEAgbGlzdChBUFBFTkQgV2ViQ29yZV9MSUJSQVJJRVMKICAg
ICAke0dMSUJfR09CSkVDVF9MSUJSQVJJRVN9CiAgICAgJHtHTElCX0xJQlJBUklFU30KICAgICAk
e0xJQlNFQ1JFVF9MSUJSQVJJRVN9Ci0gICAgJHtMSUJTT1VQX0xJQlJBUklFU30KICAgICAke0xJ
QlRBU04xX0xJQlJBUklFU30KICAgICAke0hZUEhFTl9MSUJSQVJJRVN9CiAgICAgJHtVUE9XRVJH
TElCX0xJQlJBUklFU30KQEAgLTEyMiw3ICsxMjAsNiBAQCBsaXN0KEFQUEVORCBXZWJDb3JlX1NZ
U1RFTV9JTkNMVURFX0RJUkVDVE9SSUVTCiAgICAgJHtHSU9fVU5JWF9JTkNMVURFX0RJUlN9CiAg
ICAgJHtHTElCX0lOQ0xVREVfRElSU30KICAgICAke0xJQlNFQ1JFVF9JTkNMVURFX0RJUlN9Ci0g
ICAgJHtMSUJTT1VQX0lOQ0xVREVfRElSU30KICAgICAke0xJQlRBU04xX0lOQ0xVREVfRElSU30K
ICAgICAke1VQT1dFUkdMSUJfSU5DTFVERV9ESVJTfQogICAgICR7WkxJQl9JTkNMVURFX0RJUlN9
CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybVdQRS5jbWFrZSBiL1NvdXJjZS9X
ZWJDb3JlL1BsYXRmb3JtV1BFLmNtYWtlCmluZGV4IGIxOGI3OTQ0OTE2Li41NDk2MWQ5NDEyMiAx
MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1XUEUuY21ha2UKKysrIGIvU291cmNl
L1dlYkNvcmUvUGxhdGZvcm1XUEUuY21ha2UKQEAgLTMsMTMgKzMsMTMgQEAgaW5jbHVkZShwbGF0
Zm9ybS9GcmVlVHlwZS5jbWFrZSkKIGluY2x1ZGUocGxhdGZvcm0vR0NyeXB0LmNtYWtlKQogaW5j
bHVkZShwbGF0Zm9ybS9HU3RyZWFtZXIuY21ha2UpCiBpbmNsdWRlKHBsYXRmb3JtL0ltYWdlRGVj
b2RlcnMuY21ha2UpCitpbmNsdWRlKHBsYXRmb3JtL1NvdXAuY21ha2UpCiBpbmNsdWRlKHBsYXRm
b3JtL1RleHR1cmVNYXBwZXIuY21ha2UpCiAKIGxpc3QoQVBQRU5EIFdlYkNvcmVfVU5JRklFRF9T
T1VSQ0VfTElTVF9GSUxFUwogICAgICJTb3VyY2VzV1BFLnR4dCIKIAogICAgICJwbGF0Zm9ybS9T
b3VyY2VzR0xpYi50eHQiCi0gICAgInBsYXRmb3JtL1NvdXJjZXNTb3VwLnR4dCIKICkKIAogIyBB
bGxvdyBidWlsZGluZyBBTkdMRSBvbiBwbGF0Zm9ybXMgdGhhdCBkb24ndCBwcm92aWRlIFgxMSBo
ZWFkZXJzLgpAQCAtMjcsNyArMjcsNiBAQCBsaXN0KEFQUEVORCBXZWJDb3JlX0lOQ0xVREVfRElS
RUNUT1JJRVMKICAgICAiJHtXRUJDT1JFX0RJUn0vcGxhdGZvcm0vZ3JhcGhpY3Mvd3BlIgogICAg
ICIke1dFQkNPUkVfRElSfS9wbGF0Zm9ybS9ncmFwaGljcy93YXlsYW5kIgogICAgICIke1dFQkNP
UkVfRElSfS9wbGF0Zm9ybS9tb2NrL21lZGlhc291cmNlIgotICAgICIke1dFQkNPUkVfRElSfS9w
bGF0Zm9ybS9uZXR3b3JrL3NvdXAiCiAgICAgIiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL3RleHQv
aWN1IgogKQogCkBAIC00OSw3ICs0OCw2IEBAIGxpc3QoQVBQRU5EIFdlYkNvcmVfTElCUkFSSUVT
CiAgICAgJHtHTElCX0dPQkpFQ1RfTElCUkFSSUVTfQogICAgICR7R0xJQl9MSUJSQVJJRVN9CiAg
ICAgJHtJQ1VfTElCUkFSSUVTfQotICAgICR7TElCU09VUF9MSUJSQVJJRVN9CiAgICAgJHtMSUJU
QVNOMV9MSUJSQVJJRVN9CiAgICAgJHtVUE9XRVJHTElCX0xJQlJBUklFU30KICAgICAke1dQRV9M
SUJSQVJJRVN9CkBAIC02MCw3ICs1OCw2IEBAIGxpc3QoQVBQRU5EIFdlYkNvcmVfU1lTVEVNX0lO
Q0xVREVfRElSRUNUT1JJRVMKICAgICAke0dJT19VTklYX0lOQ0xVREVfRElSU30KICAgICAke0dM
SUJfSU5DTFVERV9ESVJTfQogICAgICR7SUNVX0lOQ0xVREVfRElSU30KLSAgICAke0xJQlNPVVBf
SU5DTFVERV9ESVJTfQogICAgICR7TElCVEFTTjFfSU5DTFVERV9ESVJTfQogICAgICR7VVBPV0VS
R0xJQl9JTkNMVURFX0RJUlN9CiAgICAgJHtXUEVfSU5DTFVERV9ESVJTfQpkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU291cC5jbWFrZSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm
b3JtL1NvdXAuY21ha2UKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLmJk
NjkyZDViYTA0Ci0tLSAvZGV2L251bGwKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU291
cC5jbWFrZQpAQCAtMCwwICsxLDE1IEBACitsaXN0KEFQUEVORCBXZWJDb3JlX0lOQ0xVREVfRElS
RUNUT1JJRVMKKyAgICAiJHtXRUJDT1JFX0RJUn0vcGxhdGZvcm0vbmV0d29yay9zb3VwIgorKQor
CitsaXN0KEFQUEVORCBXZWJDb3JlX1VOSUZJRURfU09VUkNFX0xJU1RfRklMRVMKKyAgICAicGxh
dGZvcm0vU291cmNlc1NvdXAudHh0IgorKQorCitsaXN0KEFQUEVORCBXZWJDb3JlX1NZU1RFTV9J
TkNMVURFX0RJUkVDVE9SSUVTCisgICAgJHtMSUJTT1VQX0lOQ0xVREVfRElSU30KKykKKworbGlz
dChBUFBFTkQgV2ViQ29yZV9MSUJSQVJJRVMKKyAgICAke0xJQlNPVVBfTElCUkFSSUVTfQorKQo=
</data>
<flag name="review"
          id="352157"
          type_id="1"
          status="-"
          setter="mcatanzaro"
    />
          </attachment>
      

    </bug>

</bugzilla>