182535 2018-02-06 09:38:55 -0800 Service workers registrations are saved to disk before the install / activation succeeds 2018-02-06 10:43:56 -0800 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez beidson commit-queue rniwa webkit-bug-importer youennf oldest_to_newest 1396808 0 cdumez 2018-02-06 09:38:55 -0800 Service workers registrations are saved to disk before the install / activation succeeds. This means if the browser exists before the install / activation succeeds, we may restore from disk a registration with an “active” worker which may have never been installed / activated. 1396809 1 cdumez 2018-02-06 09:39:08 -0800 <rdar://problem/36591485> 1396811 2 333182 cdumez 2018-02-06 09:43:07 -0800 Created attachment 333182 Patch 1396817 3 333182 youennf 2018-02-06 10:03:39 -0800 Comment on attachment 333182 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333182&action=review > Source/WebCore/ChangeLog:10 > + This means if the browser exists before the install / activation succeeds, we may restore s/exists/exits > Source/WebCore/ChangeLog:12 > + activated. Indeed, this is in particular important for service worker doing some cache storage operations only in install step. 1396819 4 333186 cdumez 2018-02-06 10:08:49 -0800 Created attachment 333186 Patch 1396834 5 333186 commit-queue 2018-02-06 10:43:54 -0800 Comment on attachment 333186 Patch Clearing flags on attachment: 333186 Committed r228180: <https://trac.webkit.org/changeset/228180> 1396835 6 commit-queue 2018-02-06 10:43:56 -0800 All reviewed patches have been landed. Closing bug. 333182 2018-02-06 09:43:07 -0800 2018-02-06 10:08:47 -0800 Patch bug-182535-20180206094306.patch text/plain 2646 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4MTcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzdkZDUzMWFlMDgxODU2 MDkwODYzODA3YzRhM2EzMmRhOGZhNDAxMS4uZGYwNTgzNTFlN2UwN2M2OGRlYzQ4ZGI1NzhjYjk0 ZmI1MTk1MWFlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE4LTAyLTA2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU2VydmljZSB3b3JrZXJzIHJl Z2lzdHJhdGlvbnMgYXJlIHNhdmVkIHRvIGRpc2sgYmVmb3JlIHRoZSBpbnN0YWxsIC8gYWN0aXZh dGlvbiBzdWNjZWVkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTgyNTM1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNjU5MTQ4NT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTZXJ2aWNlIHdvcmtlcnMg cmVnaXN0cmF0aW9ucyBhcmUgc2F2ZWQgdG8gZGlzayBiZWZvcmUgdGhlIGluc3RhbGwgLyBhY3Rp dmF0aW9uIHN1Y2NlZWRzLgorICAgICAgICBUaGlzIG1lYW5zIGlmIHRoZSBicm93c2VyIGV4aXN0 cyBiZWZvcmUgdGhlIGluc3RhbGwgLyBhY3RpdmF0aW9uIHN1Y2NlZWRzLCB3ZSBtYXkgcmVzdG9y ZQorICAgICAgICBmcm9tIGRpc2sgYSByZWdpc3RyYXRpb24gd2l0aCBhbiDigJxhY3RpdmXigJ0g d29ya2VyIHdoaWNoIG1heSBoYXZlIG5ldmVyIGJlZW4gaW5zdGFsbGVkIC8KKyAgICAgICAgYWN0 aXZhdGVkLgorCisgICAgICAgIFRvIGFkZHJlc3MgdGhlIGlzc3VlLCB3ZSBub3cgZGVsYXkgc2F2 aW5nIHRoZSByZWdpc3RyYXRpb24gdG8gZGlzayB1bnRpbCBhZnRlciB0aGUgc2VydmljZQorICAg ICAgICB3b3JrZXIgaGFzIGJlZW4gYWN0aXZhdGVkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywg cmVzdG9yYXRpb24gZnJvbSBkaXNrIGlzIGNvdmVyZWQgYnkgQVBJIHRlc3RzIHRoYXQgc3RpbGwg cGFzcy4KKworICAgICAgICAqIHdvcmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6U1dTZXJ2ZXI6OmRpZEZpbmlzaEFjdGl2YXRpb24pOgorICAgICAg ICAoV2ViQ29yZTo6U1dTZXJ2ZXI6Omluc3RhbGxDb250ZXh0RGF0YSk6CisKIDIwMTgtMDItMDYg IE1zMmdlciAgPE1zMmdlckBpZ2FsaWEuY29tPgogCiAgICAgICAgIEluaXRpYWxpemUgSW1hZ2VC aXRtYXA6Om1fYml0bWFwRGF0YSBpbiB0aGUgY29uc3RydWN0b3IuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2Uvc2VydmVyL1NXU2VydmVyLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3dvcmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXIuY3BwCmluZGV4IDRiNWI5ODdi MTg4NDc2MjI1ZjgyZmU3OWEyYTdlNGFlODgwMGQ3NzEuLjQwMjM1YmMyNzgzYjE5N2M4MjI0YTk2 ZTFjNTI2YmIxMWZlM2RiY2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2Vy dmljZS9zZXJ2ZXIvU1dTZXJ2ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2Vy dmljZS9zZXJ2ZXIvU1dTZXJ2ZXIuY3BwCkBAIC00MDEsOCArNDAxLDEyIEBAIHZvaWQgU1dTZXJ2 ZXI6OmRpZEZpbmlzaEFjdGl2YXRpb24oU1dTZXJ2ZXJXb3JrZXImIHdvcmtlcikKIHsKICAgICBS RUxFQVNFX0xPRyhTZXJ2aWNlV29ya2VyLCAiJXAgLSBTV1NlcnZlcjo6ZGlkRmluaXNoQWN0aXZh dGlvbjogRmluaXNoZWQgYWN0aXZhdGlvbiBmb3Igc2VydmljZSB3b3JrZXIgJWxsdSIsIHRoaXMs IHdvcmtlci5pZGVudGlmaWVyKCkudG9VSW50NjQoKSk7CiAKLSAgICBpZiAoYXV0byogcmVnaXN0 cmF0aW9uID0gZ2V0UmVnaXN0cmF0aW9uKHdvcmtlci5yZWdpc3RyYXRpb25LZXkoKSkpCi0gICAg ICAgIHJlZ2lzdHJhdGlvbi0+ZGlkRmluaXNoQWN0aXZhdGlvbih3b3JrZXIuaWRlbnRpZmllcigp KTsKKyAgICBhdXRvKiByZWdpc3RyYXRpb24gPSBnZXRSZWdpc3RyYXRpb24od29ya2VyLnJlZ2lz dHJhdGlvbktleSgpKTsKKyAgICBpZiAoIXJlZ2lzdHJhdGlvbikKKyAgICAgICAgcmV0dXJuOwor CisgICAgbV9yZWdpc3RyYXRpb25TdG9yZS51cGRhdGVSZWdpc3RyYXRpb24od29ya2VyLmNvbnRl eHREYXRhKCkpOworICAgIHJlZ2lzdHJhdGlvbi0+ZGlkRmluaXNoQWN0aXZhdGlvbih3b3JrZXIu aWRlbnRpZmllcigpKTsKIH0KIAogLy8gaHR0cHM6Ly93M2MuZ2l0aHViLmlvL1NlcnZpY2VXb3Jr ZXIvI2NsaWVudHMtZ2V0YWxsCkBAIC01MzIsOCArNTM2LDYgQEAgdm9pZCBTV1NlcnZlcjo6aW5z dGFsbENvbnRleHREYXRhKGNvbnN0IFNlcnZpY2VXb3JrZXJDb250ZXh0RGF0YSYgZGF0YSkKICAg ICAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBtX3JlZ2lzdHJhdGlvblN0b3JlLnVwZGF0 ZVJlZ2lzdHJhdGlvbihkYXRhKTsKLQogICAgIGF1dG8qIGNvbm5lY3Rpb24gPSBTV1NlcnZlclRv Q29udGV4dENvbm5lY3Rpb246Omdsb2JhbFNlcnZlclRvQ29udGV4dENvbm5lY3Rpb24oKTsKICAg ICBBU1NFUlQoY29ubmVjdGlvbik7CiAK 333186 2018-02-06 10:08:49 -0800 2018-02-06 10:43:54 -0800 Patch bug-182535-20180206100848.patch text/plain 2644 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4MTcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzdkZDUzMWFlMDgxODU2 MDkwODYzODA3YzRhM2EzMmRhOGZhNDAxMS4uYzY3MzZiZDVjMTA1YmRkZjk0M2Q5M2UxNDU3Yjhl MjRlNTZhZTg5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE4LTAyLTA2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU2VydmljZSB3b3JrZXJzIHJl Z2lzdHJhdGlvbnMgYXJlIHNhdmVkIHRvIGRpc2sgYmVmb3JlIHRoZSBpbnN0YWxsIC8gYWN0aXZh dGlvbiBzdWNjZWVkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTgyNTM1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNjU5MTQ4NT4KKworICAgICAg ICBSZXZpZXdlZCBieSBZb3Vlbm4gRmFibGV0LgorCisgICAgICAgIFNlcnZpY2Ugd29ya2VycyBy ZWdpc3RyYXRpb25zIGFyZSBzYXZlZCB0byBkaXNrIGJlZm9yZSB0aGUgaW5zdGFsbCAvIGFjdGl2 YXRpb24gc3VjY2VlZHMuCisgICAgICAgIFRoaXMgbWVhbnMgaWYgdGhlIGJyb3dzZXIgZXhpdHMg YmVmb3JlIHRoZSBpbnN0YWxsIC8gYWN0aXZhdGlvbiBzdWNjZWVkcywgd2UgbWF5IHJlc3RvcmUK KyAgICAgICAgZnJvbSBkaXNrIGEgcmVnaXN0cmF0aW9uIHdpdGggYW4g4oCcYWN0aXZl4oCdIHdv cmtlciB3aGljaCBtYXkgaGF2ZSBuZXZlciBiZWVuIGluc3RhbGxlZCAvCisgICAgICAgIGFjdGl2 YXRlZC4KKworICAgICAgICBUbyBhZGRyZXNzIHRoZSBpc3N1ZSwgd2Ugbm93IGRlbGF5IHNhdmlu ZyB0aGUgcmVnaXN0cmF0aW9uIHRvIGRpc2sgdW50aWwgYWZ0ZXIgdGhlIHNlcnZpY2UKKyAgICAg ICAgd29ya2VyIGhhcyBiZWVuIGFjdGl2YXRlZC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIHJl c3RvcmF0aW9uIGZyb20gZGlzayBpcyBjb3ZlcmVkIGJ5IEFQSSB0ZXN0cyB0aGF0IHN0aWxsIHBh c3MuCisKKyAgICAgICAgKiB3b3JrZXJzL3NlcnZpY2Uvc2VydmVyL1NXU2VydmVyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlNXU2VydmVyOjpkaWRGaW5pc2hBY3RpdmF0aW9uKToKKyAgICAgICAg KFdlYkNvcmU6OlNXU2VydmVyOjppbnN0YWxsQ29udGV4dERhdGEpOgorCiAyMDE4LTAyLTA2ICBN czJnZXIgIDxNczJnZXJAaWdhbGlhLmNvbT4KIAogICAgICAgICBJbml0aWFsaXplIEltYWdlQml0 bWFwOjptX2JpdG1hcERhdGEgaW4gdGhlIGNvbnN0cnVjdG9yLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL3NlcnZlci9TV1NlcnZlci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS93b3JrZXJzL3NlcnZpY2Uvc2VydmVyL1NXU2VydmVyLmNwcAppbmRleCA0YjViOTg3YjE4 ODQ3NjIyNWY4MmZlNzlhMmE3ZTRhZTg4MDBkNzcxLi40MDIzNWJjMjc4M2IxOTdjODIyNGE5NmUx YzUyNmJiMTFmZTNkYmNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZp Y2Uvc2VydmVyL1NXU2VydmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZp Y2Uvc2VydmVyL1NXU2VydmVyLmNwcApAQCAtNDAxLDggKzQwMSwxMiBAQCB2b2lkIFNXU2VydmVy OjpkaWRGaW5pc2hBY3RpdmF0aW9uKFNXU2VydmVyV29ya2VyJiB3b3JrZXIpCiB7CiAgICAgUkVM RUFTRV9MT0coU2VydmljZVdvcmtlciwgIiVwIC0gU1dTZXJ2ZXI6OmRpZEZpbmlzaEFjdGl2YXRp b246IEZpbmlzaGVkIGFjdGl2YXRpb24gZm9yIHNlcnZpY2Ugd29ya2VyICVsbHUiLCB0aGlzLCB3 b3JrZXIuaWRlbnRpZmllcigpLnRvVUludDY0KCkpOwogCi0gICAgaWYgKGF1dG8qIHJlZ2lzdHJh dGlvbiA9IGdldFJlZ2lzdHJhdGlvbih3b3JrZXIucmVnaXN0cmF0aW9uS2V5KCkpKQotICAgICAg ICByZWdpc3RyYXRpb24tPmRpZEZpbmlzaEFjdGl2YXRpb24od29ya2VyLmlkZW50aWZpZXIoKSk7 CisgICAgYXV0byogcmVnaXN0cmF0aW9uID0gZ2V0UmVnaXN0cmF0aW9uKHdvcmtlci5yZWdpc3Ry YXRpb25LZXkoKSk7CisgICAgaWYgKCFyZWdpc3RyYXRpb24pCisgICAgICAgIHJldHVybjsKKwor ICAgIG1fcmVnaXN0cmF0aW9uU3RvcmUudXBkYXRlUmVnaXN0cmF0aW9uKHdvcmtlci5jb250ZXh0 RGF0YSgpKTsKKyAgICByZWdpc3RyYXRpb24tPmRpZEZpbmlzaEFjdGl2YXRpb24od29ya2VyLmlk ZW50aWZpZXIoKSk7CiB9CiAKIC8vIGh0dHBzOi8vdzNjLmdpdGh1Yi5pby9TZXJ2aWNlV29ya2Vy LyNjbGllbnRzLWdldGFsbApAQCAtNTMyLDggKzUzNiw2IEBAIHZvaWQgU1dTZXJ2ZXI6Omluc3Rh bGxDb250ZXh0RGF0YShjb25zdCBTZXJ2aWNlV29ya2VyQ29udGV4dERhdGEmIGRhdGEpCiAgICAg ICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgbV9yZWdpc3RyYXRpb25TdG9yZS51cGRhdGVS ZWdpc3RyYXRpb24oZGF0YSk7Ci0KICAgICBhdXRvKiBjb25uZWN0aW9uID0gU1dTZXJ2ZXJUb0Nv bnRleHRDb25uZWN0aW9uOjpnbG9iYWxTZXJ2ZXJUb0NvbnRleHRDb25uZWN0aW9uKCk7CiAgICAg QVNTRVJUKGNvbm5lY3Rpb24pOwogCg==