182532 2018-02-06 03:18:08 -0800 REGRESSION(r227758): Webpage fails to load due to crash in com.apple.WebKit: WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse + 267 2018-02-07 19:30:40 -0800 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto youennf achristensen ap beidson cdumez commit-queue youennf oldest_to_newest 1396759 0 koivisto 2018-02-06 03:18:08 -0800 boom (lldb) bt * thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0xbbadbeef) frame #0: 0x000000047098cfe4 JavaScriptCore`::WTFCrash() at Assertions.cpp:272 frame #1: 0x0000000103d7d381 WebKit`WTF::Function<void (WebCore::PolicyAction)>::operator(this=0x00007ffeec018890, in=Ignore)(WebCore::PolicyAction) const at Function.h:55 * frame #2: 0x000000010450d2c4 WebKit`WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse(this=0x00007fd3cd427640, response=0x00000004767f7b18, request=0x00000004767f7a08, function=0x00007ffeec018890)>&&) at WebFrameLoaderClient.cpp:753 frame #3: 0x00000004624dfe91 WebCore`WebCore::FrameLoader::checkContentPolicy(this=0x00007fd3cd41c240, response=0x00000004767f7b18, function=0x00007ffeec018890)>&&) at FrameLoader.cpp:360 frame #4: 0x0000000462497ba0 WebCore`WebCore::DocumentLoader::responseReceived(this=0x00000004767f7400, response=0x0000000475774910) at DocumentLoader.cpp:786 frame #5: 0x000000046249955e WebCore`WebCore::DocumentLoader::responseReceived(this=0x00000004767f7400, resource=0x0000000475774700, response=0x0000000475774910) at DocumentLoader.cpp:699 frame #6: 0x00000004624995a4 WebCore`non-virtual thunk to WebCore::DocumentLoader::responseReceived(this=0x00000004767f7400, resource=0x0000000475774700, response=0x0000000475774910) at DocumentLoader.cpp:0 frame #7: 0x00000004625b7751 WebCore`WebCore::CachedRawResource::responseReceived(this=0x0000000475774700, response=0x00007ffeec0193d8) at CachedRawResource.cpp:201 frame #8: 0x0000000462554665 WebCore`WebCore::SubresourceLoader::didReceiveResponse(this=0x0000000475770800, response=0x00007ffeec0193d8) at SubresourceLoader.cpp:353 frame #9: 0x0000000104960755 WebKit`WebKit::WebResourceLoader::didReceiveResponse(this=0x00000004757f20e0, response=0x00007ffeec0193d8, needsContinueDidReceiveResponseMessage=true) at WebResourceLoader.cpp:115 1396760 1 koivisto 2018-02-06 03:18:31 -0800 <rdar://problem/36414017> 1396762 2 333168 koivisto 2018-02-06 03:27:20 -0800 Created attachment 333168 patch 1396763 3 333169 koivisto 2018-02-06 03:30:16 -0800 Created attachment 333169 patch 1396803 4 333169 cdumez 2018-02-06 09:19:36 -0800 Comment on attachment 333169 patch View in context: https://bugs.webkit.org/attachment.cgi?id=333169&action=review > Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:749 > if (!coreFrame) Couldn't we move those null checks *betore* setting up the policy listener on the WebFrame earlier? This way, we can keep using the function as is, and we do not unnecessarily set up a policy listener. 1396846 5 koivisto 2018-02-06 11:03:11 -0800 > Couldn't we move those null checks *betore* setting up the policy listener > on the WebFrame earlier? This way, we can keep using the function as is, and > we do not unnecessarily set up a policy listener. I assumed there was a reason why they are after. Specifically setUpPolicyListener may call arbitrary code (m_willSubmitFormCompletionHandlers in invalidatePolicyListener) and if those null coreFrame/provisionalDocumentLoader we would crash. Alex needs to answer whether that was the reason the checks are after setUpPolicyListener. 1396849 6 koivisto 2018-02-06 11:07:17 -0800 > I assumed there was a reason why they are after. Specifically > setUpPolicyListener may call arbitrary code > (m_willSubmitFormCompletionHandlers in invalidatePolicyListener) and if > those null coreFrame/provisionalDocumentLoader we would crash. Also it calls any existing m_policyFunction. 1396853 7 333169 ap 2018-02-06 11:20:25 -0800 Comment on attachment 333169 patch View in context: https://bugs.webkit.org/attachment.cgi?id=333169&action=review > Source/WebKit/ChangeLog:9 > + No test case, don't know how to make one. The repro involves multipart HTTP streaming and details are hazy. We have some tests for multipart, those are actually not hard to write. Is there some particular detail that makes this unreproducible? 1397389 8 333341 youennf 2018-02-07 17:10:22 -0800 Created attachment 333341 Patch 1397419 9 333341 cdumez 2018-02-07 18:43:36 -0800 Comment on attachment 333341 Patch r=me 1397432 10 333341 commit-queue 2018-02-07 19:30:38 -0800 Comment on attachment 333341 Patch Clearing flags on attachment: 333341 Committed r228257: <https://trac.webkit.org/changeset/228257> 1397433 11 commit-queue 2018-02-07 19:30:40 -0800 All reviewed patches have been landed. Closing bug. 333168 2018-02-06 03:27:20 -0800 2018-02-06 03:30:16 -0800 patch multipart-policy-ignore.patch text/plain 4129 koivisto SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjgxNTQpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDE4LTAyLTA2ICBBbnR0aSBLb2l2 aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyMjc3NTgpOiBX ZWJwYWdlIGZhaWxzIHRvIGxvYWQgZHVlIHRvIGNyYXNoIGluIGNvbS5hcHBsZS5XZWJLaXQ6IFdl YktpdDo6V2ViRnJhbWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNoRGVjaWRlUG9saWN5Rm9yUmVzcG9u c2UgKyAyNjcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4MjUzMgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzY0MTQwMTc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gdGVzdCBjYXNlLCBkb24ndCBr bm93IGhvdyB0byBtYWtlIG9uZS4gVGhlIHJlcHJvIGludm9sdmVzIG11bHRpcGFydCBIVFRQIHN0 cmVhbWluZyBhbmQgZGV0YWlscyBhcmUgaGF6eS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2Vi Q29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJGcmFtZUxvYWRlckNsaWVudDo6ZGlzcGF0Y2hEZWNpZGVQb2xpY3lGb3JSZXNwb25zZSk6CisK KyAgICAgICAgV2Ugd2VyZSBjYWxsaW5nIGEgZnVuY3Rpb24gdGhhdCB3YXMgV1RGTW92ZWQgYXdh eSBqdXN0IGEgZmV3IGxpbmVzIGFib3ZlLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdl L1dlYkZyYW1lLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViRnJhbWU6OmNhbmNlbFBvbGljeUFj dGlvbik6CisKKyAgICAgICAgQWxsb3cgbWFraW5nIGlnbm9yZSBjYWxsIHZpYSBtX3BvbGljeUZ1 bmN0aW9uIHdpdGhvdXQgZ29pbmcgdGhyb3VnaCB0aGUgcmVzdCBvZiB0aGUgbWFjaGluZXJ5LiBB bHNvIGNsZWFyIGl0IGFmdGVyd2FyZHMuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2Uv V2ViRnJhbWUuaDoKKwogMjAxOC0wMi0wNSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29t PgogCiAgICAgICAgIEF2b2lkIHVubmVjZXNzYXJpbHkgY29uc3RydWN0aW5nIFJ1bkxvb3BzIGZv ciBHQyBBdXRvbWF0aWNUaHJlYWRzIGluIENvbm5lY3Rpb246OnNlbmRNZXNzYWdlKCkgYWZ0ZXIg cjIyODAwMQpJbmRleDogU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dl YkZyYW1lTG9hZGVyQ2xpZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCShyZXZpc2lvbiAy MjgxNTIpCisrKyBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJh bWVMb2FkZXJDbGllbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03NDcsMTAgKzc0NywxMCBAQCB2 b2lkIFdlYkZyYW1lTG9hZGVyQ2xpZW50OjpkaXNwYXRjaERlY2lkCiAgICAgUmVmPFdlYkZyYW1l PiBwcm90ZWN0KCptX2ZyYW1lKTsKICAgICBXZWJDb3JlOjpGcmFtZSogY29yZUZyYW1lID0gbV9m cmFtZS0+Y29yZUZyYW1lKCk7CiAgICAgaWYgKCFjb3JlRnJhbWUpCi0gICAgICAgIHJldHVybiBm dW5jdGlvbihQb2xpY3lBY3Rpb246Oklnbm9yZSk7CisgICAgICAgIHJldHVybiBtX2ZyYW1lLT5j YW5jZWxQb2xpY3lBY3Rpb24oKTsKICAgICBhdXRvKiBwb2xpY3lEb2N1bWVudExvYWRlciA9IGNv cmVGcmFtZS0+bG9hZGVyKCkucHJvdmlzaW9uYWxEb2N1bWVudExvYWRlcigpOwogICAgIGlmICgh cG9saWN5RG9jdW1lbnRMb2FkZXIpCi0gICAgICAgIHJldHVybiBmdW5jdGlvbihQb2xpY3lBY3Rp b246Oklnbm9yZSk7CisgICAgICAgIHJldHVybiBtX2ZyYW1lLT5jYW5jZWxQb2xpY3lBY3Rpb24o KTsKICAgICBhdXRvIG5hdmlnYXRpb25JRCA9IHN0YXRpY19jYXN0PFdlYkRvY3VtZW50TG9hZGVy Jj4oKnBvbGljeURvY3VtZW50TG9hZGVyKS5uYXZpZ2F0aW9uSUQoKTsKICAgICBpZiAoIXdlYlBh Z2UtPnNlbmRTeW5jKE1lc3NhZ2VzOjpXZWJQYWdlUHJveHk6OkRlY2lkZVBvbGljeUZvclJlc3Bv bnNlU3luYyhtX2ZyYW1lLT5mcmFtZUlEKCksIFNlY3VyaXR5T3JpZ2luRGF0YTo6ZnJvbUZyYW1l KGNvcmVGcmFtZSksIG5hdmlnYXRpb25JRCwgcmVzcG9uc2UsIHJlcXVlc3QsIGNhblNob3dNSU1F VHlwZSwgbGlzdGVuZXJJRCwgVXNlckRhdGEoV2ViUHJvY2Vzczo6c2luZ2xldG9uKCkudHJhbnNm b3JtT2JqZWN0c1RvSGFuZGxlcyh1c2VyRGF0YS5nZXQoKSkuZ2V0KCkpKSwgTWVzc2FnZXM6Oldl YlBhZ2VQcm94eTo6RGVjaWRlUG9saWN5Rm9yUmVzcG9uc2VTeW5jOjpSZXBseShyZWNlaXZlZFBv bGljeUFjdGlvbiwgcG9saWN5QWN0aW9uLCBkb3dubG9hZElEKSwgU2Vjb25kczo6aW5maW5pdHko KSwgSVBDOjpTZW5kU3luY09wdGlvbjo6SW5mb3JtUGxhdGZvcm1Qcm9jZXNzV2lsbFN1c3BlbmQp KSB7CiAgICAgICAgIG1fZnJhbWUtPmRpZFJlY2VpdmVQb2xpY3lEZWNpc2lvbihsaXN0ZW5lcklE LCBQb2xpY3lBY3Rpb246Oklnbm9yZSwgMCwgeyB9LCB7IH0pOwpJbmRleDogU291cmNlL1dlYktp dC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViRnJhbWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkZyYW1lLmNwcAkocmV2aXNpb24gMjI4MTUyKQor KysgU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViRnJhbWUuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0yODMsNiArMjgzLDEzIEBAIHZvaWQgV2ViRnJhbWU6OmRpZFJlY2VpdmVQb2xp Y3lEZWNpc2lvbigKICAgICBmdW5jdGlvbihhY3Rpb24pOwogfQogCit2b2lkIFdlYkZyYW1lOjpj YW5jZWxQb2xpY3lBY3Rpb24oKQoreworICAgIGF1dG8gZnVuY3Rpb24gPSBXVEZNb3ZlKG1fcG9s aWN5RnVuY3Rpb24pOworICAgIGZ1bmN0aW9uKFBvbGljeUFjdGlvbjo6SWdub3JlKTsKKyAgICBt X3BvbGljeUxpc3RlbmVySUQgPSAwOworfQorCiB2b2lkIFdlYkZyYW1lOjpzdGFydERvd25sb2Fk KGNvbnN0IFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCwgY29uc3QgU3RyaW5nJiBz dWdnZXN0ZWROYW1lKQogewogICAgIEFTU0VSVChtX3BvbGljeURvd25sb2FkSUQuZG93bmxvYWRJ RCgpKTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkZyYW1lLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViRnJhbWUu aAkocmV2aXNpb24gMjI4MTUyKQorKysgU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2Uv V2ViRnJhbWUuaAkod29ya2luZyBjb3B5KQpAQCAtODcsNiArODcsNyBAQCBwdWJsaWM6CiAgICAg dWludDY0X3Qgc2V0VXBQb2xpY3lMaXN0ZW5lcihXZWJDb3JlOjpGcmFtZVBvbGljeUZ1bmN0aW9u JiYsIEZvck5hdmlnYXRpb25BY3Rpb24pOwogICAgIHZvaWQgaW52YWxpZGF0ZVBvbGljeUxpc3Rl bmVyKCk7CiAgICAgdm9pZCBkaWRSZWNlaXZlUG9saWN5RGVjaXNpb24odWludDY0X3QgbGlzdGVu ZXJJRCwgV2ViQ29yZTo6UG9saWN5QWN0aW9uLCB1aW50NjRfdCBuYXZpZ2F0aW9uSUQsIERvd25s b2FkSUQsIHN0ZDo6b3B0aW9uYWw8V2Vic2l0ZVBvbGljaWVzRGF0YT4mJik7CisgICAgdm9pZCBj YW5jZWxQb2xpY3lBY3Rpb24oKTsKIAogICAgIHVpbnQ2NF90IHNldFVwV2lsbFN1Ym1pdEZvcm1M aXN0ZW5lcihXVEY6OkZ1bmN0aW9uPHZvaWQodm9pZCk+JiYpOwogICAgIHZvaWQgY29udGludWVX aWxsU3VibWl0Rm9ybSh1aW50NjRfdCk7Cg== 333169 2018-02-06 03:30:16 -0800 2018-02-07 17:10:20 -0800 patch multipart-policy-ignore-2.patch text/plain 4137 koivisto SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjgxNTQpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDE4LTAyLTA2ICBBbnR0aSBLb2l2 aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyMjc3NTgpOiBX ZWJwYWdlIGZhaWxzIHRvIGxvYWQgZHVlIHRvIGNyYXNoIGluIGNvbS5hcHBsZS5XZWJLaXQ6IFdl YktpdDo6V2ViRnJhbWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNoRGVjaWRlUG9saWN5Rm9yUmVzcG9u c2UgKyAyNjcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4MjUzMgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzY0MTQwMTc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gdGVzdCBjYXNlLCBkb24ndCBr bm93IGhvdyB0byBtYWtlIG9uZS4gVGhlIHJlcHJvIGludm9sdmVzIG11bHRpcGFydCBIVFRQIHN0 cmVhbWluZyBhbmQgZGV0YWlscyBhcmUgaGF6eS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2Vi Q29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJGcmFtZUxvYWRlckNsaWVudDo6ZGlzcGF0Y2hEZWNpZGVQb2xpY3lGb3JSZXNwb25zZSk6CisK KyAgICAgICAgV2Ugd2VyZSBjYWxsaW5nIGEgZnVuY3Rpb24gdGhhdCB3YXMgV1RGTW92ZWQgYXdh eSBqdXN0IGEgZmV3IGxpbmVzIGFib3ZlLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdl L1dlYkZyYW1lLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViRnJhbWU6OmNhbmNlbFBvbGljeUFj dGlvbik6CisKKyAgICAgICAgQWxsb3cgbWFraW5nIGlnbm9yZSBjYWxsIHZpYSBtX3BvbGljeUZ1 bmN0aW9uIHdpdGhvdXQgZ29pbmcgdGhyb3VnaCB0aGUgcmVzdCBvZiB0aGUgbWFjaGluZXJ5LiBB bHNvIGNsZWFyIGl0IGFmdGVyd2FyZHMuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2Uv V2ViRnJhbWUuaDoKKwogMjAxOC0wMi0wNSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29t PgogCiAgICAgICAgIEF2b2lkIHVubmVjZXNzYXJpbHkgY29uc3RydWN0aW5nIFJ1bkxvb3BzIGZv ciBHQyBBdXRvbWF0aWNUaHJlYWRzIGluIENvbm5lY3Rpb246OnNlbmRNZXNzYWdlKCkgYWZ0ZXIg cjIyODAwMQpJbmRleDogU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dl YkZyYW1lTG9hZGVyQ2xpZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCShyZXZpc2lvbiAy MjgxNTIpCisrKyBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJh bWVMb2FkZXJDbGllbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03NDcsMTAgKzc0NywxMCBAQCB2 b2lkIFdlYkZyYW1lTG9hZGVyQ2xpZW50OjpkaXNwYXRjaERlY2lkCiAgICAgUmVmPFdlYkZyYW1l PiBwcm90ZWN0KCptX2ZyYW1lKTsKICAgICBXZWJDb3JlOjpGcmFtZSogY29yZUZyYW1lID0gbV9m cmFtZS0+Y29yZUZyYW1lKCk7CiAgICAgaWYgKCFjb3JlRnJhbWUpCi0gICAgICAgIHJldHVybiBm dW5jdGlvbihQb2xpY3lBY3Rpb246Oklnbm9yZSk7CisgICAgICAgIHJldHVybiBtX2ZyYW1lLT5j YW5jZWxQb2xpY3lBY3Rpb24oKTsKICAgICBhdXRvKiBwb2xpY3lEb2N1bWVudExvYWRlciA9IGNv cmVGcmFtZS0+bG9hZGVyKCkucHJvdmlzaW9uYWxEb2N1bWVudExvYWRlcigpOwogICAgIGlmICgh cG9saWN5RG9jdW1lbnRMb2FkZXIpCi0gICAgICAgIHJldHVybiBmdW5jdGlvbihQb2xpY3lBY3Rp b246Oklnbm9yZSk7CisgICAgICAgIHJldHVybiBtX2ZyYW1lLT5jYW5jZWxQb2xpY3lBY3Rpb24o KTsKICAgICBhdXRvIG5hdmlnYXRpb25JRCA9IHN0YXRpY19jYXN0PFdlYkRvY3VtZW50TG9hZGVy Jj4oKnBvbGljeURvY3VtZW50TG9hZGVyKS5uYXZpZ2F0aW9uSUQoKTsKICAgICBpZiAoIXdlYlBh Z2UtPnNlbmRTeW5jKE1lc3NhZ2VzOjpXZWJQYWdlUHJveHk6OkRlY2lkZVBvbGljeUZvclJlc3Bv bnNlU3luYyhtX2ZyYW1lLT5mcmFtZUlEKCksIFNlY3VyaXR5T3JpZ2luRGF0YTo6ZnJvbUZyYW1l KGNvcmVGcmFtZSksIG5hdmlnYXRpb25JRCwgcmVzcG9uc2UsIHJlcXVlc3QsIGNhblNob3dNSU1F VHlwZSwgbGlzdGVuZXJJRCwgVXNlckRhdGEoV2ViUHJvY2Vzczo6c2luZ2xldG9uKCkudHJhbnNm b3JtT2JqZWN0c1RvSGFuZGxlcyh1c2VyRGF0YS5nZXQoKSkuZ2V0KCkpKSwgTWVzc2FnZXM6Oldl YlBhZ2VQcm94eTo6RGVjaWRlUG9saWN5Rm9yUmVzcG9uc2VTeW5jOjpSZXBseShyZWNlaXZlZFBv bGljeUFjdGlvbiwgcG9saWN5QWN0aW9uLCBkb3dubG9hZElEKSwgU2Vjb25kczo6aW5maW5pdHko KSwgSVBDOjpTZW5kU3luY09wdGlvbjo6SW5mb3JtUGxhdGZvcm1Qcm9jZXNzV2lsbFN1c3BlbmQp KSB7CiAgICAgICAgIG1fZnJhbWUtPmRpZFJlY2VpdmVQb2xpY3lEZWNpc2lvbihsaXN0ZW5lcklE LCBQb2xpY3lBY3Rpb246Oklnbm9yZSwgMCwgeyB9LCB7IH0pOwpJbmRleDogU291cmNlL1dlYktp dC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViRnJhbWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkZyYW1lLmNwcAkocmV2aXNpb24gMjI4MTUyKQor KysgU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViRnJhbWUuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0yODMsNiArMjgzLDEzIEBAIHZvaWQgV2ViRnJhbWU6OmRpZFJlY2VpdmVQb2xp Y3lEZWNpc2lvbigKICAgICBmdW5jdGlvbihhY3Rpb24pOwogfQogCit2b2lkIFdlYkZyYW1lOjpj YW5jZWxQb2xpY3lBY3Rpb24oKQoreworICAgIGlmIChhdXRvIGZ1bmN0aW9uID0gV1RGTW92ZSht X3BvbGljeUZ1bmN0aW9uKSkKKyAgICAgICAgZnVuY3Rpb24oUG9saWN5QWN0aW9uOjpJZ25vcmUp OworICAgIG1fcG9saWN5TGlzdGVuZXJJRCA9IDA7Cit9CisKIHZvaWQgV2ViRnJhbWU6OnN0YXJ0 RG93bmxvYWQoY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0JiByZXF1ZXN0LCBjb25zdCBT dHJpbmcmIHN1Z2dlc3RlZE5hbWUpCiB7CiAgICAgQVNTRVJUKG1fcG9saWN5RG93bmxvYWRJRC5k b3dubG9hZElEKCkpOwpJbmRleDogU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi RnJhbWUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9X ZWJGcmFtZS5oCShyZXZpc2lvbiAyMjgxNTIpCisrKyBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3Mv V2ViUGFnZS9XZWJGcmFtZS5oCSh3b3JraW5nIGNvcHkpCkBAIC04Nyw2ICs4Nyw3IEBAIHB1Ymxp YzoKICAgICB1aW50NjRfdCBzZXRVcFBvbGljeUxpc3RlbmVyKFdlYkNvcmU6OkZyYW1lUG9saWN5 RnVuY3Rpb24mJiwgRm9yTmF2aWdhdGlvbkFjdGlvbik7CiAgICAgdm9pZCBpbnZhbGlkYXRlUG9s aWN5TGlzdGVuZXIoKTsKICAgICB2b2lkIGRpZFJlY2VpdmVQb2xpY3lEZWNpc2lvbih1aW50NjRf dCBsaXN0ZW5lcklELCBXZWJDb3JlOjpQb2xpY3lBY3Rpb24sIHVpbnQ2NF90IG5hdmlnYXRpb25J RCwgRG93bmxvYWRJRCwgc3RkOjpvcHRpb25hbDxXZWJzaXRlUG9saWNpZXNEYXRhPiYmKTsKKyAg ICB2b2lkIGNhbmNlbFBvbGljeUFjdGlvbigpOwogCiAgICAgdWludDY0X3Qgc2V0VXBXaWxsU3Vi bWl0Rm9ybUxpc3RlbmVyKFdURjo6RnVuY3Rpb248dm9pZCh2b2lkKT4mJik7CiAgICAgdm9pZCBj b250aW51ZVdpbGxTdWJtaXRGb3JtKHVpbnQ2NF90KTsK 333341 2018-02-07 17:10:22 -0800 2018-02-07 19:30:38 -0800 Patch bug-182532-20180207171021.patch text/plain 3175 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4MTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGYyODcxMzBhODEzYTU0NGU3 NzRiNGI1MmU2MGEzYjc1N2MyMDcxMWIuLmEzZWE2ZTA5MzU4MTE3Yjg0Yjg3OWVhZjQyMjA5ODM5 ZjcyYTk1ODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMDItMDcgIEFudHRpIEtv aXZpc3RvICA8YW50dGlAYXBwbGUuY29tPiBhbmQgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBs ZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjI3NzU4KTogV2VicGFnZSBmYWlscyB0byBs b2FkIGR1ZSB0byBjcmFzaCBpbiBjb20uYXBwbGUuV2ViS2l0OiBXZWJLaXQ6OldlYkZyYW1lTG9h ZGVyQ2xpZW50OjpkaXNwYXRjaERlY2lkZVBvbGljeUZvclJlc3BvbnNlICsgMjY3CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODI1MzIKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzM2NDE0MDE3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIE5vIHRlc3QgY2FzZSwgZG9uJ3Qga25vdyBob3cgdG8gbWFrZSBv bmUuIFRoZSByZXBybyBpbnZvbHZlcyBtdWx0aXBhcnQgSFRUUCBzdHJlYW1pbmcgYW5kIGRldGFp bHMgYXJlIGhhenkuCisgICAgICAgIFdlIHdlcmUgY2FsbGluZyBhIGZ1bmN0aW9uIHRoYXQgd2Fz IFdURk1vdmVkIGF3YXkganVzdCBhIGZldyBsaW5lcyBhYm92ZS4KKworICAgICAgICAqIFdlYlBy b2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwOgorICAgICAgICAo V2ViS2l0OjpXZWJGcmFtZUxvYWRlckNsaWVudDo6ZGlzcGF0Y2hEZWNpZGVQb2xpY3lGb3JSZXNw b25zZSk6CisKIDIwMTgtMDItMDYgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgog CiAgICAgICAgIEFkZCBBUEkgdGVzdCB0byB2YWxpZGF0ZSBzZXR0aW5nIG9mIHNlcnZpY2Ugd29y a2VyIGFuZCBjYWNoZSBzdG9yYWdlIGRpcmVjdG9yaWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwIGIv U291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xp ZW50LmNwcAppbmRleCA3NjdiNDYxZDA4M2QwOTViYWE4OWNjYmY2NjZjNjhlMmYwMzJjYjJhLi4x ZTk4YjQ4M2IxODk4ZWEyNWUxMGRhY2MzMDYwYWMwNGE3ZGNjYTA1IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFt ZUxvYWRlckNsaWVudC5jcHAKQEAgLTczOSwxOCArNzM5LDE5IEBAIHZvaWQgV2ViRnJhbWVMb2Fk ZXJDbGllbnQ6OmRpc3BhdGNoRGVjaWRlUG9saWN5Rm9yUmVzcG9uc2UoY29uc3QgUmVzb3VyY2VS ZXNwb25zCiAKICAgICBib29sIGNhblNob3dNSU1FVHlwZSA9IHdlYlBhZ2UtPmNhblNob3dNSU1F VHlwZShyZXNwb25zZS5taW1lVHlwZSgpKTsKIAorICAgIFdlYkNvcmU6OkZyYW1lKiBjb3JlRnJh bWUgPSBtX2ZyYW1lLT5jb3JlRnJhbWUoKTsKKyAgICBhdXRvKiBwb2xpY3lEb2N1bWVudExvYWRl ciA9IGNvcmVGcmFtZSA/IGNvcmVGcmFtZS0+bG9hZGVyKCkucHJvdmlzaW9uYWxEb2N1bWVudExv YWRlcigpIDogbnVsbHB0cjsKKyAgICBpZiAoIXBvbGljeURvY3VtZW50TG9hZGVyKSB7CisgICAg ICAgIGZ1bmN0aW9uKFBvbGljeUFjdGlvbjo6SWdub3JlKTsKKyAgICAgICAgcmV0dXJuOworICAg IH0KKworICAgIFJlZjxXZWJGcmFtZT4gcHJvdGVjdG9yKCptX2ZyYW1lKTsKICAgICB1aW50NjRf dCBsaXN0ZW5lcklEID0gbV9mcmFtZS0+c2V0VXBQb2xpY3lMaXN0ZW5lcihXVEZNb3ZlKGZ1bmN0 aW9uKSwgV2ViRnJhbWU6OkZvck5hdmlnYXRpb25BY3Rpb246Ok5vKTsKICAgICBib29sIHJlY2Vp dmVkUG9saWN5QWN0aW9uOwogICAgIFBvbGljeUFjdGlvbiBwb2xpY3lBY3Rpb247CiAgICAgRG93 bmxvYWRJRCBkb3dubG9hZElEOwogCi0gICAgUmVmPFdlYkZyYW1lPiBwcm90ZWN0KCptX2ZyYW1l KTsKLSAgICBXZWJDb3JlOjpGcmFtZSogY29yZUZyYW1lID0gbV9mcmFtZS0+Y29yZUZyYW1lKCk7 Ci0gICAgaWYgKCFjb3JlRnJhbWUpCi0gICAgICAgIHJldHVybiBmdW5jdGlvbihQb2xpY3lBY3Rp b246Oklnbm9yZSk7Ci0gICAgYXV0byogcG9saWN5RG9jdW1lbnRMb2FkZXIgPSBjb3JlRnJhbWUt PmxvYWRlcigpLnByb3Zpc2lvbmFsRG9jdW1lbnRMb2FkZXIoKTsKLSAgICBpZiAoIXBvbGljeURv Y3VtZW50TG9hZGVyKQotICAgICAgICByZXR1cm4gZnVuY3Rpb24oUG9saWN5QWN0aW9uOjpJZ25v cmUpOwogICAgIGF1dG8gbmF2aWdhdGlvbklEID0gc3RhdGljX2Nhc3Q8V2ViRG9jdW1lbnRMb2Fk ZXImPigqcG9saWN5RG9jdW1lbnRMb2FkZXIpLm5hdmlnYXRpb25JRCgpOwogICAgIGlmICghd2Vi UGFnZS0+c2VuZFN5bmMoTWVzc2FnZXM6OldlYlBhZ2VQcm94eTo6RGVjaWRlUG9saWN5Rm9yUmVz cG9uc2VTeW5jKG1fZnJhbWUtPmZyYW1lSUQoKSwgU2VjdXJpdHlPcmlnaW5EYXRhOjpmcm9tRnJh bWUoY29yZUZyYW1lKSwgbmF2aWdhdGlvbklELCByZXNwb25zZSwgcmVxdWVzdCwgY2FuU2hvd01J TUVUeXBlLCBsaXN0ZW5lcklELCBVc2VyRGF0YShXZWJQcm9jZXNzOjpzaW5nbGV0b24oKS50cmFu c2Zvcm1PYmplY3RzVG9IYW5kbGVzKHVzZXJEYXRhLmdldCgpKS5nZXQoKSkpLCBNZXNzYWdlczo6 V2ViUGFnZVByb3h5OjpEZWNpZGVQb2xpY3lGb3JSZXNwb25zZVN5bmM6OlJlcGx5KHJlY2VpdmVk UG9saWN5QWN0aW9uLCBwb2xpY3lBY3Rpb24sIGRvd25sb2FkSUQpLCBTZWNvbmRzOjppbmZpbml0 eSgpLCBJUEM6OlNlbmRTeW5jT3B0aW9uOjpJbmZvcm1QbGF0Zm9ybVByb2Nlc3NXaWxsU3VzcGVu ZCkpIHsKICAgICAgICAgbV9mcmFtZS0+ZGlkUmVjZWl2ZVBvbGljeURlY2lzaW9uKGxpc3RlbmVy SUQsIFBvbGljeUFjdGlvbjo6SWdub3JlLCAwLCB7IH0sIHsgfSk7Cg==