182527 2018-02-05 22:05:22 -0800 [iOS] media tests failing ASSERT_NOT_REACHED() in WebCore::VideoFullscreenInterfaceAVKit::cleanupFullscreen() 2018-07-03 14:02:15 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 186945 https://bugs.webkit.org/show_bug.cgi?id=182497 InRadar P2 Normal --- 1 ryanhaddad eric.carlson eric.carlson jeremyj-wk jer.noble jlewis3 webkit-bug-importer oldest_to_newest 1396708 0 ryanhaddad 2018-02-05 22:05:22 -0800 The following LayoutTests are failing one of the assertions added in https://trac.webkit.org/changeset/228115/webkit media/media-fullscreen-loop-inline.html media/media-higher-prio-audio-stream.html media/video-background-playback.html -[AVPlayerViewController exitFullScreenAnimated:completionHandler:] failed with error View needs to be loaded before you can call -[AVPlayerViewController (0x7ff563005200) exitFullScreenAnimated:completionHandler:]! SHOULD NEVER BE REACHED /Volumes/Data/slave/ios-simulator-11-debug/build/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm(817) : auto WebCore::VideoFullscreenInterfaceAVKit::cleanupFullscreen()::(anonymous class)::operator()(BOOL, NSError *) const 1 0x10cac058d WTFCrash 2 0x11a6b3c86 WebCore::VideoFullscreenInterfaceAVKit::cleanupFullscreen()::$_5::operator()(bool, NSError*) const 3 0x11a6b3c01 invocation function for block in WebCore::VideoFullscreenInterfaceAVKit::cleanupFullscreen() 4 0x13171e444 -[AVPlayerViewController(AVPlayerViewController_WebKitOnly) exitFullScreenAnimated:completionHandler:] 5 0x11a6b3a3e WebCore::VideoFullscreenInterfaceAVKit::cleanupFullscreen() 6 0x1116d3b55 WebKit::VideoFullscreenManagerProxy::cleanupFullscreen(unsigned long long) 7 0x1116e49cd void IPC::callMemberFunctionImpl<WebKit::VideoFullscreenManagerProxy, void (WebKit::VideoFullscreenManagerProxy::*)(unsigned long long), std::__1::tuple<unsigned long long>, 0ul>(WebKit::VideoFullscreenManagerProxy*, void (WebKit::VideoFullscreenManagerProxy::*)(unsigned long long), std::__1::tuple<unsigned long long>&&, std::__1::integer_sequence<unsigned long, 0ul>) 8 0x1116e4920 void IPC::callMemberFunction<WebKit::VideoFullscreenManagerProxy, void (WebKit::VideoFullscreenManagerProxy::*)(unsigned long long), std::__1::tuple<unsigned long long>, std::__1::integer_sequence<unsigned long, 0ul> >(std::__1::tuple<unsigned long long>&&, WebKit::VideoFullscreenManagerProxy*, void (WebKit::VideoFullscreenManagerProxy::*)(unsigned long long)) 9 0x1116e3d40 void IPC::handleMessage<Messages::VideoFullscreenManagerProxy::CleanupFullscreen, WebKit::VideoFullscreenManagerProxy, void (WebKit::VideoFullscreenManagerProxy::*)(unsigned long long)>(IPC::Decoder&, WebKit::VideoFullscreenManagerProxy*, void (WebKit::VideoFullscreenManagerProxy::*)(unsigned long long)) 10 0x1116e33ae WebKit::VideoFullscreenManagerProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 11 0x1112c4018 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) 12 0x1111b4584 WebKit::ChildProcessProxy::dispatchMessage(IPC::Connection&, IPC::Decoder&) 13 0x111c4396a WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 14 0x111c43a64 non-virtual thunk to WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 15 0x1111c3ab3 IPC::Connection::dispatchMessage(IPC::Decoder&) 16 0x1111b96d8 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) 17 0x1111c40ba IPC::Connection::dispatchOneMessage() 18 0x1111dbedd IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14::operator()() 19 0x1111dbe39 WTF::Function<void ()>::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14>::call() 20 0x10cadc81b WTF::Function<void ()>::operator()() const 21 0x10cb1fe93 WTF::RunLoop::performWork() 22 0x10cb206f4 WTF::RunLoop::performWork(void*) 23 0x1151ba2b1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 24 0x115259d31 __CFRunLoopDoSource0 25 0x11519ec19 __CFRunLoopDoSources0 26 0x11519e1ff __CFRunLoopRun 27 0x11519da89 CFRunLoopRunSpecific 28 0x10aeaae5e -[NSRunLoop(NSRunLoop) runMode:beforeDate:] 29 0x109522c24 WTR::TestController::platformRunUntil(bool&, double) 30 0x1094fd389 WTR::TestController::runUntil(bool&, double) 31 0x10952652a WTR::TestInvocation::invoke() LEAK: 1 WebFrame LEAK: 75 RenderObject https://build.webkit.org/results/Apple%20iOS%2011%20Simulator%20Debug%20WK2%20(Tests)/r228150%20(2549)/results.html 1396709 1 ryanhaddad 2018-02-05 22:08:02 -0800 This appears to be 100% reproducible on iOS Debug bots. 1396807 2 webkit-bug-importer 2018-02-06 09:37:41 -0800 <rdar://problem/37277469> 1396977 3 ryanhaddad 2018-02-06 15:28:01 -0800 This also affects an API test on iOS: UNEXPECTEDLY EXITED WebKitLegacy.AudioSessionCategoryIOS 2018-02-06 14:51:05.313 TestWebKitAPI[57966:71952567] *** Warning: <AVPlayerViewController: 0x7faa2c004c00> is trying to enter full screen, but is not in its view's window's view controller hierarchy. This results in undefined behavior. 2018-02-06 14:51:05.314 TestWebKitAPI[57966:71952567] Presenting view controllers on detached view controllers is discouraged <AVPlayerViewController: 0x7faa2c004c00>. 2018-02-06 14:51:05.354 TestWebKitAPI[57966:71952567] *** Warning: <AVPlayerViewController: 0x7faa2c004c00> is trying to exit full screen, but is not in its view's window's view controller hierarchy. This results in undefined behavior. -[AVPlayerViewController exitFullScreenAnimated:completionHandler:] failed with error Invalid call of -[AVPlayerViewController (0x7faa2c004c00) _transitionFromFullScreenAnimated:completionHandler:]! SHOULD NEVER BE REACHED /Volumes/Data/slave/ios-simulator-11-debug/build/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm(779) : auto WebCore::VideoFullscreenInterfaceAVKit::exitFullscreen(const WebCore::IntRect &)::(anonymous class)::operator()(BOOL, NSError *) 1 0x10f25953d WTFCrash 2 0x11b24a5d9 WebCore::VideoFullscreenInterfaceAVKit::exitFullscreen(WebCore::IntRect const&)::$_4::operator()(bool, NSError*) 3 0x11b24a541 ___ZN7WebCore29VideoFullscreenInterfaceAVKit14exitFullscreenERKNS_7IntRectE_block_invoke.288 4 0x14372c114 -[AVPlayerViewController _transitionFromFullScreenAnimated:completionHandler:] 5 0x14372f4ed -[AVPlayerViewController(AVPlayerViewController_WebKitOnly) exitFullScreenAnimated:completionHandler:] 6 0x11b24a2e6 WebCore::VideoFullscreenInterfaceAVKit::exitFullscreen(WebCore::IntRect const&) 7 0x11896b09c VideoFullscreenControllerContext::exitFullscreen()::$_39::operator()() const 8 0x11896b019 invocation function for block in VideoFullscreenControllerContext::exitFullscreen() 9 0x117d0f273 _dispatch_call_block_and_release 10 0x117d102b5 _dispatch_client_callout 11 0x117d1a496 _dispatch_main_queue_callback_4CF 12 0x127c18ef9 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ 13 0x127bdd662 __CFRunLoopRun 14 0x127bdca89 CFRunLoopRunSpecific 15 0x116deae5e -[NSRunLoop(NSRunLoop) runMode:beforeDate:] 16 0x10da9c353 TestWebKitAPI::Util::run(bool*) 17 0x10d817493 TestWebKitAPI::WebKitLegacy_AudioSessionCategoryIOS_Test::TestBody() 18 0x10db4caaa testing::Test::Run() 19 0x10db4d56d testing::internal::TestInfoImpl::Run() 20 0x10db4e5bd testing::TestCase::Run() 21 0x10db5463b testing::internal::UnitTestImpl::RunAllTests() 22 0x10db542b9 testing::UnitTest::Run() 23 0x10da260ac TestWebKitAPI::TestsController::run(int, char**) 24 0x10db21d90 main 25 0x117d84d81 start https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Debug%20WK2%20%28Tests%29/builds/2564 1397220 4 jlewis3 2018-02-07 10:14:09 -0800 Spoke with Eric in person. We decided to remove the asserts temporarily but leave in the logging until he could look at it. https://trac.webkit.org/changeset/228229/webkit 1398390 5 333607 ryanhaddad 2018-02-12 10:45:11 -0800 Created attachment 333607 Remove another assert. 1398423 6 ryanhaddad 2018-02-12 12:32:05 -0800 Committed https://trac.webkit.org/r228389 1438974 7 ryanhaddad 2018-07-03 14:02:15 -0700 *** This bug has been marked as a duplicate of bug 186945 *** 333607 2018-02-12 10:45:11 -0800 2018-02-12 12:32:02 -0800 Remove another assert. bug-182527-20180212104510.patch text/plain 1649 ryanhaddad U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4Mzc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTIxMWY3MjgwNTQxZTRm NDdkNjQ1YTc4MDM5ODA4YjNjMTYxNTIwNC4uMDAzNDAyZTJmZjk5ZTRlOGYxNzY4OWUzZmI2MTYx ZjJiYTMwZDVhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTAyLTEyICBSeWFu IEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIG1lZGlhIHRl c3RzIGZhaWxpbmcgQVNTRVJUX05PVF9SRUFDSEVEKCkgaW4gV2ViQ29yZTo6VmlkZW9GdWxsc2Ny ZWVuSW50ZXJmYWNlQVZLaXQ6OmNsZWFudXBGdWxsc2NyZWVuKCkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjUyNworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlbXBvcmFyaWx5IHJlbW92ZSBhbiBhc3Nl cnRpb24gZnJvbSBWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdCB0byBzdG9wIHRlc3RzIGZy b20gY3Jhc2hpbmcgb24gaU9TCisgICAgICAgIHdoaWxlIHRoZSByb290IGNhdXNlIGlzIGJlaW5n IGludmVzdGlnYXRlZC4KKworICAgICAgICAqIHBsYXRmb3JtL2lvcy9WaWRlb0Z1bGxzY3JlZW5J bnRlcmZhY2VBVktpdC5tbToKKyAgICAgICAgKFZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0 OjpleGl0RnVsbHNjcmVlbkhhbmRsZXIpOgorCiAyMDE4LTAyLTEyICBDaHJpcyBGbGVpemFjaCAg PGNmbGVpemFjaEBhcHBsZS5jb20+CiAKICAgICAgICAgQVg6IGRlZmVyIGZvY3VzZWRVSUVsZW1l bnQgbm90aWZpY2F0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9z L1ZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Lm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vaW9zL1ZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Lm1tCmluZGV4IGVlMjczMTdiZTgw MDU2NjNlY2ZkMDc0N2QyMjBhZTNlNjUyYzkxZjkuLjdmY2VjODIyN2U2YTQ0NDlmNmFiYWY1MmNm NmNlZWNkODliZmY4MzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9W aWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9pb3MvVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW0KQEAgLTE1NTYsNyArMTU1 Niw2IEBAIHZvaWQgVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ6OmV4aXRGdWxsc2NyZWVu SGFuZGxlcihCT09MIHN1Y2Nlc3MsIE5TRXJyb3IqCiB7CiAgICAgaWYgKCFzdWNjZXNzKSB7CiAg ICAgICAgIFdURkxvZ0Fsd2F5cygiLVtBVlBsYXllclZpZXdDb250cm9sbGVyIGV4aXRGdWxsU2Ny ZWVuQW5pbWF0ZWQ6Y29tcGxldGlvbkhhbmRsZXI6XSBmYWlsZWQgd2l0aCBlcnJvciAlcyIsIFtb ZXJyb3IgbG9jYWxpemVkRGVzY3JpcHRpb25dIFVURjhTdHJpbmddKTsKLSAgICAgICAgQVNTRVJU X05PVF9SRUFDSEVEKCk7CiAgICAgfQogCiAgICAgVU5VU0VEX1BBUkFNKHN1Y2Nlc3MpOwo=