182502 2018-02-05 12:13:54 -0800 [GTK][WPE] Enable modern media controls 2022-08-26 07:49:54 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=214955 https://bugs.webkit.org/show_bug.cgi?id=244378 Gtk P2 Normal --- 1 zan philn bugs-noreply calvaris lmoura mcatanzaro pnormand oldest_to_newest 1396456 0 zan 2018-02-05 12:13:54 -0800 Unskipped in r228097, but are failing and timing out aplenty. https://trac.webkit.org/changeset/228097/webkit 1396476 1 mcatanzaro 2018-02-05 12:56:25 -0800 They're failing and timing out because we don't use modern media controls. 1396730 2 calvaris 2018-02-06 01:45:08 -0800 I think the wisest thing here is flag the tests for modern controls and in the case of WPE, it might be interesting to use the GTK+ ones, though I think there could be some theming issues with the iconns that would need to be solved. 1396733 3 calvaris 2018-02-06 01:45:56 -0800 Either that or we implement those modern controls, which would require contact with GNOME designers, etc. 1743673 4 lmoura 2021-03-24 22:43:52 -0700 r274810 unskipped the modern-media-control tests alongside other media-related changes and the GTK layout test step was exiting early with many modern-media-controls related issues. I've re-skipped the main folders back in r275010, althouth there are other tests failing related to this. Link to the first failing build: https://build.webkit.org/#/builders/57/builds/772 1872639 5 pnormand 2022-05-29 10:23:34 -0700 Pull request: https://github.com/WebKit/WebKit/pull/1147 1873594 6 ews-feeder 2022-06-02 08:37:47 -0700 Committed r295128 (251219@main): <https://commits.webkit.org/251219@main> Reviewed commits have been landed. Closing PR #1147 and removing active labels.