182487 2018-02-05 07:59:00 -0800 Initialize ImageBitmap::m_bitmapData in the constructor. 2018-02-06 01:46:30 -0800 1 1 1 Unclassified WebKit Canvas WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 Ms2ger Ms2ger cdumez commit-queue dino esprehn+autocc ews-watchlist gyuyoung.kim sam webkit-bug-importer oldest_to_newest 1396301 0 Ms2ger 2018-02-05 07:59:00 -0800 . 1396306 1 333082 Ms2ger 2018-02-05 08:02:38 -0800 Created attachment 333082 Patch 1396446 2 333082 sam 2018-02-05 11:55:24 -0800 Comment on attachment 333082 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333082&action=review > Source/WebCore/html/ImageBitmap.cpp:-287 > - // 7. Create a new ImageBitmap object. > - > - auto imageBitmap = create(); > - I like to leave a note when the steps change order, to indicate to future readers that the out of order numbers are intentional. 1396728 3 333082 Ms2ger 2018-02-06 01:22:42 -0800 Comment on attachment 333082 Patch The spec is being reorganized in https://github.com/whatwg/html/pull/3424, so I'm just going to land this now, and check up on the numbering after. 1396731 4 333082 commit-queue 2018-02-06 01:45:53 -0800 Comment on attachment 333082 Patch Clearing flags on attachment: 333082 Committed r228153: <https://trac.webkit.org/changeset/228153> 1396732 5 commit-queue 2018-02-06 01:45:55 -0800 All reviewed patches have been landed. Closing bug. 1396734 6 webkit-bug-importer 2018-02-06 01:46:30 -0800 <rdar://problem/37267595> 333082 2018-02-05 08:02:38 -0800 2018-02-06 01:45:53 -0800 Patch bug-182487-20180205170236.patch text/plain 7149 Ms2ger U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4MDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDQ1OWYxY2MwY2M4MTcz MDY0Yzk2MGZmNGYyYTU4NjM2NzY3OTdkNi4uZTdmOGU5ZjAzZjY5YzJhOTI5YWY2ODEyN2QwMzQ1 MjU0OGMzMWEyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE4LTAyLTA1ICBNczJn ZXIgIDxNczJnZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBJbml0aWFsaXplIEltYWdlQml0bWFw OjptX2JpdG1hcERhdGEgaW4gdGhlIGNvbnN0cnVjdG9yLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyNDg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyByZW1vdmVzIHRoZSBzcGFuIG9mIHRpbWUg d2hlcmUgYW4gSW1hZ2VCaXRtYXAgb2JqZWN0IHdvdWxkIGV4aXN0CisgICAgICAgIHdpdGggYSBu dWxsIG1fYml0bWFwRGF0YSBkdXJpbmcgaXRzIGNvbnN0cnVjdGlvbi4KKworICAgICAgICBObyBu ZXcgdGVzdHM6IG5vIGJlaGF2aW9yIGNoYW5nZXMuCisKKyAgICAgICAgKiBodG1sL0ltYWdlQml0 bWFwLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlQml0bWFwOjpjcmVhdGUpOiB1cGRhdGUg c2lnbmF0dXJlCisgICAgICAgIChXZWJDb3JlOjpJbWFnZUJpdG1hcDo6Y3JlYXRlUHJvbWlzZSk6 IHVwZGF0ZSBjYWxsZXJzCisgICAgICAgIChXZWJDb3JlOjpJbWFnZUJpdG1hcDo6SW1hZ2VCaXRt YXApOiB1cGRhdGUgc2lnbmF0dXJlCisgICAgICAgICogaHRtbC9JbWFnZUJpdG1hcC5oOiB1cGRh dGUgc2lnbmF0dXJlcworCiAyMDE4LTAyLTA1ICBNczJnZXIgIDxNczJnZXJAaWdhbGlhLmNvbT4K IAogICAgICAgICBJbXBsZW1lbnQgY3JlYXRlSW1hZ2VCaXRtYXAoSFRNTFZpZGVvRWxlbWVudCkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSW1hZ2VCaXRtYXAuY3BwIGIvU291cmNl L1dlYkNvcmUvaHRtbC9JbWFnZUJpdG1hcC5jcHAKaW5kZXggMTExMWQzNDQzYjM3ZTk1MGQ1Zjhi NjMyMGU3OWVhY2U3MDVjY2E4Yy4uZDlhNDBkZWM1ZTU2OTYwMmRkNDY5ZjMzYmJiNTdiN2ZmZTM1 OTY0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9JbWFnZUJpdG1hcC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvaHRtbC9JbWFnZUJpdG1hcC5jcHAKQEAgLTU2LDE0ICs1NiwxMiBA QCBzdGF0aWMgUmVuZGVyaW5nTW9kZSBidWZmZXJSZW5kZXJpbmdNb2RlID0gVW5hY2NlbGVyYXRl ZDsKIAogUmVmPEltYWdlQml0bWFwPiBJbWFnZUJpdG1hcDo6Y3JlYXRlKEludFNpemUgc2l6ZSkK IHsKLSAgICBhdXRvIGltYWdlQml0bWFwID0gYWRvcHRSZWYoKm5ldyBJbWFnZUJpdG1hcCk7Ci0g ICAgaW1hZ2VCaXRtYXAtPm1fYml0bWFwRGF0YSA9IEltYWdlQnVmZmVyOjpjcmVhdGUoRmxvYXRT aXplKHNpemUud2lkdGgoKSwgc2l6ZS5oZWlnaHQoKSksIGJ1ZmZlclJlbmRlcmluZ01vZGUpOwot ICAgIHJldHVybiBpbWFnZUJpdG1hcDsKKyAgICByZXR1cm4gY3JlYXRlKEltYWdlQnVmZmVyOjpj cmVhdGUoRmxvYXRTaXplKHNpemUud2lkdGgoKSwgc2l6ZS5oZWlnaHQoKSksIGJ1ZmZlclJlbmRl cmluZ01vZGUpKTsKIH0KIAotUmVmPEltYWdlQml0bWFwPiBJbWFnZUJpdG1hcDo6Y3JlYXRlKCkK K1JlZjxJbWFnZUJpdG1hcD4gSW1hZ2VCaXRtYXA6OmNyZWF0ZShzdGQ6OnVuaXF1ZV9wdHI8SW1h Z2VCdWZmZXI+JiYgYnVmZmVyKQogewotICAgIHJldHVybiBhZG9wdFJlZigqbmV3IEltYWdlQml0 bWFwKTsKKyAgICByZXR1cm4gYWRvcHRSZWYoKm5ldyBJbWFnZUJpdG1hcChXVEZNb3ZlKGJ1ZmZl cikpKTsKIH0KIAogdm9pZCBJbWFnZUJpdG1hcDo6Y3JlYXRlUHJvbWlzZShTY3JpcHRFeGVjdXRp b25Db250ZXh0JiBzY3JpcHRFeGVjdXRpb25Db250ZXh0LCBJbWFnZUJpdG1hcDo6U291cmNlJiYg c291cmNlLCBJbWFnZUJpdG1hcE9wdGlvbnMmJiBvcHRpb25zLCBJbWFnZUJpdG1hcDo6UHJvbWlz ZSYmIHByb21pc2UpCkBAIC0yODEsMTAgKzI3OSw2IEBAIHZvaWQgSW1hZ2VCaXRtYXA6OmNyZWF0 ZVByb21pc2UoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCYsIFJlZlB0cjxIVE1MSW1hZ2VFbGVtZW50 CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICAvLyA3LiBDcmVhdGUgYSBuZXcgSW1hZ2VC aXRtYXAgb2JqZWN0LgotCi0gICAgYXV0byBpbWFnZUJpdG1hcCA9IGNyZWF0ZSgpOwotCiAgICAg Ly8gOC4gTGV0IHRoZSBJbWFnZUJpdG1hcCBvYmplY3QncyBiaXRtYXAgZGF0YSBiZSBhIGNvcHkg b2YgaW1hZ2UncyBtZWRpYSBkYXRhLCBjcm9wcGVkIHRvCiAgICAgLy8gICAgdGhlIHNvdXJjZSBy ZWN0YW5nbGUgd2l0aCBmb3JtYXR0aW5nLiBJZiB0aGlzIGlzIGFuIGFuaW1hdGVkIGltYWdlLCB0 aGUgSW1hZ2VCaXRtYXAKICAgICAvLyAgICBvYmplY3QncyBiaXRtYXAgZGF0YSBtdXN0IG9ubHkg YmUgdGFrZW4gZnJvbSB0aGUgZGVmYXVsdCBpbWFnZSBvZiB0aGUgYW5pbWF0aW9uICh0aGUKQEAg LTMxMiw3ICszMDYsOCBAQCB2b2lkIEltYWdlQml0bWFwOjpjcmVhdGVQcm9taXNlKFNjcmlwdEV4 ZWN1dGlvbkNvbnRleHQmLCBSZWZQdHI8SFRNTEltYWdlRWxlbWVudAogCiAgICAgYml0bWFwRGF0 YS0+Y29udGV4dCgpLmRyYXdJbWFnZSgqaW1hZ2VGb3JSZW5kZXIsIGRlc3RSZWN0LCBzb3VyY2VS ZWN0YW5nbGUucmVsZWFzZVJldHVyblZhbHVlKCksIHBhaW50aW5nT3B0aW9ucyk7CiAKLSAgICBp bWFnZUJpdG1hcC0+bV9iaXRtYXBEYXRhID0gV1RGTW92ZShiaXRtYXBEYXRhKTsKKyAgICAvLyA3 LiBDcmVhdGUgYSBuZXcgSW1hZ2VCaXRtYXAgb2JqZWN0LgorICAgIGF1dG8gaW1hZ2VCaXRtYXAg PSBjcmVhdGUoV1RGTW92ZShiaXRtYXBEYXRhKSk7CiAKICAgICAvLyA5LiBJZiB0aGUgb3JpZ2lu IG9mIGltYWdlJ3MgaW1hZ2UgaXMgbm90IHRoZSBzYW1lIG9yaWdpbiBhcyB0aGUgb3JpZ2luIHNw ZWNpZmllZCBieSB0aGUKICAgICAvLyAgICBlbnRyeSBzZXR0aW5ncyBvYmplY3QsIHRoZW4gc2V0 IHRoZSBvcmlnaW4tY2xlYW4gZmxhZyBvZiB0aGUgSW1hZ2VCaXRtYXAgb2JqZWN0J3MKQEAgLTMz Nyw5ICszMzIsNiBAQCB2b2lkIEltYWdlQml0bWFwOjpjcmVhdGVQcm9taXNlKFNjcmlwdEV4ZWN1 dGlvbkNvbnRleHQmLCBSZWZQdHI8SFRNTENhbnZhc0VsZW1lbgogICAgICAgICByZXR1cm47CiAg ICAgfQogCi0gICAgLy8gMy4gQ3JlYXRlIGEgbmV3IEltYWdlQml0bWFwIG9iamVjdC4KLSAgICBh dXRvIGltYWdlQml0bWFwID0gY3JlYXRlKCk7Ci0KICAgICAvLyA0LiBMZXQgdGhlIEltYWdlQml0 bWFwIG9iamVjdCdzIGJpdG1hcCBkYXRhIGJlIGEgY29weSBvZiB0aGUgY2FudmFzIGVsZW1lbnQn cyBiaXRtYXAKICAgICAvLyAgICBkYXRhLCBjcm9wcGVkIHRvIHRoZSBzb3VyY2UgcmVjdGFuZ2xl IHdpdGggZm9ybWF0dGluZy4KIApAQCAtMzY0LDcgKzM1Niw4IEBAIHZvaWQgSW1hZ2VCaXRtYXA6 OmNyZWF0ZVByb21pc2UoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCYsIFJlZlB0cjxIVE1MQ2FudmFz RWxlbWVuCiAKICAgICBiaXRtYXBEYXRhLT5jb250ZXh0KCkuZHJhd0ltYWdlKCppbWFnZUZvclJl bmRlciwgZGVzdFJlY3QsIHNvdXJjZVJlY3RhbmdsZS5yZWxlYXNlUmV0dXJuVmFsdWUoKSwgcGFp bnRpbmdPcHRpb25zKTsKIAotICAgIGltYWdlQml0bWFwLT5tX2JpdG1hcERhdGEgPSBXVEZNb3Zl KGJpdG1hcERhdGEpOworICAgIC8vIDMuIENyZWF0ZSBhIG5ldyBJbWFnZUJpdG1hcCBvYmplY3Qu CisgICAgYXV0byBpbWFnZUJpdG1hcCA9IGNyZWF0ZShXVEZNb3ZlKGJpdG1hcERhdGEpKTsKIAog ICAgIC8vIDUuIFNldCB0aGUgb3JpZ2luLWNsZWFuIGZsYWcgb2YgdGhlIEltYWdlQml0bWFwIG9i amVjdCdzIGJpdG1hcCB0byB0aGUgc2FtZSB2YWx1ZSBhcwogICAgIC8vICAgIHRoZSBvcmlnaW4t Y2xlYW4gZmxhZyBvZiB0aGUgY2FudmFzIGVsZW1lbnQncyBiaXRtYXAuCkBAIC0zOTMsOSArMzg2 LDYgQEAgdm9pZCBJbWFnZUJpdG1hcDo6Y3JlYXRlUHJvbWlzZShTY3JpcHRFeGVjdXRpb25Db250 ZXh0JiBzY3JpcHRFeGVjdXRpb25Db250ZXh0LAogICAgICAgICByZXR1cm47CiAgICAgfQogCi0g ICAgLy8gNS4gTGV0IGltYWdlQml0bWFwIGJlIGEgbmV3IEltYWdlQml0bWFwIG9iamVjdC4KLSAg ICBhdXRvIGltYWdlQml0bWFwID0gY3JlYXRlKCk7Ci0KICAgICAvLyA2LjEuIElmIGltYWdlJ3Mg bmV0d29ya1N0YXRlIGF0dHJpYnV0ZSBpcyBORVRXT1JLX0VNUFRZLCB0aGVuIHJldHVybiBwCiAg ICAgLy8gICAgICByZWplY3RlZCB3aXRoIGFuICJJbnZhbGlkU3RhdGVFcnJvciIgRE9NRXhjZXB0 aW9uLgogICAgIGlmICh2aWRlby0+bmV0d29ya1N0YXRlKCkgPT0gSFRNTE1lZGlhRWxlbWVudDo6 TkVUV09SS19FTVBUWSkgewpAQCAtNDI5LDcgKzQxOSw4IEBAIHZvaWQgSW1hZ2VCaXRtYXA6OmNy ZWF0ZVByb21pc2UoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCYgc2NyaXB0RXhlY3V0aW9uQ29udGV4 dCwKICAgICAgICAgdmlkZW8tPnBhaW50Q3VycmVudEZyYW1lSW5Db250ZXh0KGMsIEZsb2F0UmVj dChGbG9hdFBvaW50KCksIHNpemUpKTsKICAgICB9CiAKLSAgICBpbWFnZUJpdG1hcC0+bV9iaXRt YXBEYXRhID0gV1RGTW92ZShiaXRtYXBEYXRhKTsKKyAgICAvLyA1LiBMZXQgaW1hZ2VCaXRtYXAg YmUgYSBuZXcgSW1hZ2VCaXRtYXAgb2JqZWN0LgorICAgIGF1dG8gaW1hZ2VCaXRtYXAgPSBjcmVh dGUoV1RGTW92ZShiaXRtYXBEYXRhKSk7CiAKICAgICAvLyA2LjMuIElmIHRoZSBvcmlnaW4gb2Yg aW1hZ2UncyB2aWRlbyBpcyBub3Qgc2FtZSBvcmlnaW4gd2l0aCBlbnRyeQogICAgIC8vICAgICAg c2V0dGluZ3Mgb2JqZWN0J3Mgb3JpZ2luLCB0aGVuIHNldCB0aGUgb3JpZ2luLWNsZWFuIGZsYWcg b2YKQEAgLTQ1MCw5ICs0NDEsNiBAQCB2b2lkIEltYWdlQml0bWFwOjpjcmVhdGVQcm9taXNlKFNj cmlwdEV4ZWN1dGlvbkNvbnRleHQmLCBSZWZQdHI8SW1hZ2VCaXRtYXA+JiBleAogICAgICAgICBy ZXR1cm47CiAgICAgfQogCi0gICAgLy8gMy4gQ3JlYXRlIGEgbmV3IEltYWdlQml0bWFwIG9iamVj dC4KLSAgICBhdXRvIGltYWdlQml0bWFwID0gY3JlYXRlKCk7Ci0KICAgICAvLyA0LiBMZXQgdGhl IEltYWdlQml0bWFwIG9iamVjdCdzIGJpdG1hcCBkYXRhIGJlIGEgY29weSBvZiB0aGUgaW1hZ2Ug YXJndW1lbnQncwogICAgIC8vICAgIGJpdG1hcCBkYXRhLCBjcm9wcGVkIHRvIHRoZSBzb3VyY2Ug cmVjdGFuZ2xlIHdpdGggZm9ybWF0dGluZy4KICAgICBhdXRvIHNvdXJjZVJlY3RhbmdsZSA9IGNy b3BwZWRTb3VyY2VSZWN0YW5nbGVXaXRoRm9ybWF0dGluZyhleGlzdGluZ0ltYWdlQml0bWFwLT5i dWZmZXIoKS0+bG9naWNhbFNpemUoKSwgb3B0aW9ucywgV1RGTW92ZShyZWN0KSk7CkBAIC00NzIs NyArNDYwLDggQEAgdm9pZCBJbWFnZUJpdG1hcDo6Y3JlYXRlUHJvbWlzZShTY3JpcHRFeGVjdXRp b25Db250ZXh0JiwgUmVmUHRyPEltYWdlQml0bWFwPiYgZXgKIAogICAgIGJpdG1hcERhdGEtPmNv bnRleHQoKS5kcmF3SW1hZ2UoKmltYWdlRm9yUmVuZGVyLCBkZXN0UmVjdCwgc291cmNlUmVjdGFu Z2xlLnJlbGVhc2VSZXR1cm5WYWx1ZSgpLCBwYWludGluZ09wdGlvbnMpOwogCi0gICAgaW1hZ2VC aXRtYXAtPm1fYml0bWFwRGF0YSA9IFdURk1vdmUoYml0bWFwRGF0YSk7CisgICAgLy8gMy4gQ3Jl YXRlIGEgbmV3IEltYWdlQml0bWFwIG9iamVjdC4KKyAgICBhdXRvIGltYWdlQml0bWFwID0gY3Jl YXRlKFdURk1vdmUoYml0bWFwRGF0YSkpOwogCiAgICAgLy8gNS4gU2V0IHRoZSBvcmlnaW4tY2xl YW4gZmxhZyBvZiB0aGUgSW1hZ2VCaXRtYXAgb2JqZWN0J3MgYml0bWFwIHRvIHRoZSBzYW1lCiAg ICAgLy8gICAgdmFsdWUgYXMgdGhlIG9yaWdpbi1jbGVhbiBmbGFnIG9mIHRoZSBiaXRtYXAgb2Yg dGhlIGltYWdlIGFyZ3VtZW50LgpAQCAtNjA1LDcgKzU5NCwxMSBAQCB2b2lkIEltYWdlQml0bWFw OjpjcmVhdGVQcm9taXNlKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQmLCBSZWZQdHI8SW1hZ2VEYXRh PiYgaW1hZwogICAgIHByb21pc2UucmVqZWN0KFR5cGVFcnJvciwgImNyZWF0ZUltYWdlQml0bWFw IHdpdGggSW1hZ2VEYXRhIGlzIG5vdCBpbXBsZW1lbnRlZCIpOwogfQogCi1JbWFnZUJpdG1hcDo6 SW1hZ2VCaXRtYXAoKSA9IGRlZmF1bHQ7CitJbWFnZUJpdG1hcDo6SW1hZ2VCaXRtYXAoc3RkOjp1 bmlxdWVfcHRyPEltYWdlQnVmZmVyPiYmIGJ1ZmZlcikKKyAgICA6IG1fYml0bWFwRGF0YShXVEZN b3ZlKGJ1ZmZlcikpCit7CisgICAgQVNTRVJUKG1fYml0bWFwRGF0YSk7Cit9CiAKIEltYWdlQml0 bWFwOjp+SW1hZ2VCaXRtYXAoKSA9IGRlZmF1bHQ7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvSW1hZ2VCaXRtYXAuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSW1hZ2VCaXRtYXAu aAppbmRleCA5ZDljZWJjNGVjYmQyMGQ3MmRkM2NjNzhiMGYzMDY3ZDdiMWMzOTZiLi45NWQ0OWI3 ZWE2YjUwMzk0MjU3YjE4MjAxZWMzNTg4OGFlNTg3NzBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0ltYWdlQml0bWFwLmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9JbWFnZUJp dG1hcC5oCkBAIC04Miw4ICs4Miw4IEBAIHB1YmxpYzoKIHByaXZhdGU6CiAgICAgZnJpZW5kIGNs YXNzIFBlbmRpbmdJbWFnZUJpdG1hcDsKIAotICAgIHN0YXRpYyBSZWY8SW1hZ2VCaXRtYXA+IGNy ZWF0ZSgpOwotICAgIEltYWdlQml0bWFwKCk7CisgICAgc3RhdGljIFJlZjxJbWFnZUJpdG1hcD4g Y3JlYXRlKHN0ZDo6dW5pcXVlX3B0cjxJbWFnZUJ1ZmZlcj4mJik7CisgICAgSW1hZ2VCaXRtYXAo c3RkOjp1bmlxdWVfcHRyPEltYWdlQnVmZmVyPiYmKTsKIAogICAgIHN0YXRpYyB2b2lkIGNyZWF0 ZVByb21pc2UoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCYsIFJlZlB0cjxIVE1MSW1hZ2VFbGVtZW50 PiYsIEltYWdlQml0bWFwT3B0aW9ucyYmLCBzdGQ6Om9wdGlvbmFsPEludFJlY3Q+LCBQcm9taXNl JiYpOwogI2lmIEVOQUJMRShWSURFTykK