182466 2018-02-04 01:36:49 -0800 [Cairo] Correctly calculate stride in GraphicsContext3D::paintToCanvas() 2018-02-05 02:24:45 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID InRadar P2 Normal --- 1 zan zan dino ews-watchlist graouts kondapallykalyan mcatanzaro webkit-bug-importer oldest_to_newest 1396181 0 zan 2018-02-04 01:36:49 -0800 [Cairo] Correctly calculate stride in GraphicsContext3D::paintToCanvas() 1396182 1 333049 zan 2018-02-04 01:40:44 -0800 Created attachment 333049 Patch 1396227 2 333049 zan 2018-02-04 23:38:11 -0800 Comment on attachment 333049 Patch Clearing flags on attachment: 333049 Committed r228085: <https://trac.webkit.org/changeset/228085> 1396228 3 zan 2018-02-04 23:38:16 -0800 All reviewed patches have been landed. Closing bug. 1396229 4 webkit-bug-importer 2018-02-04 23:39:24 -0800 <rdar://problem/37226268> 1396253 5 zan 2018-02-05 02:19:00 -0800 Reverted r228085 for reason: Pixel data stride is imposed by OpenGL and shouldn't be adjusted for Cairo Committed r228091: <https://trac.webkit.org/changeset/228091> 1396254 6 zan 2018-02-05 02:24:45 -0800 (In reply to Zan Dobersek from comment #5) > Reverted r228085 for reason: > > Pixel data stride is imposed by OpenGL and shouldn't be adjusted for Cairo > I.e., this isn't data we're providing like we do in ImageBufferCairo, but instead it's data that's filled out by OpenGL via glReadPixels(), and that has the prescribed stride that matches width multiplied by 4 bytes (RGBA format, 1 byte per each component). 333049 2018-02-04 01:40:44 -0800 2018-02-04 23:38:11 -0800 Patch bug-182466-20180204104043.patch text/plain 2033 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4MDUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzNiN2EyODY1MzczZWM0 MjAxZmM0M2Q2MTM2ZjEzYWNkZjcyZjk4My4uMDAzM2E1YTlkY2QwMzAyZTkzZThmZjQ2Y2Y5NDFj YTI2ZjMyMzg3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE4LTAyLTA0ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAorICAgICAgICBbQ2Fpcm9dIENvcnJl Y3RseSBjYWxjdWxhdGUgc3RyaWRlIGluIEdyYXBoaWNzQ29udGV4dDNEOjpwYWludFRvQ2FudmFz KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjQ2 NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0M0RDYWlyby5jcHA6CisgICAgICAg IChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRDo6cGFpbnRUb0NhbnZhcyk6CisgICAgICAgIFVz ZSBjYWlyb19mb3JtYXRfc3RyaWRlX2Zvcl93aWR0aCgpIHRvIG9idGFpbiBzdHJpZGUgdGhhdCBD YWlybyB0aGlua3MKKyAgICAgICAgaXMgYXBwcm9wcmlhdGUgZm9yIHRoZSBnaXZlbiB3aWR0aCwg dGFraW5nIGludG8gYWNjb3VudCBpbnRlcm5hbAorICAgICAgICBhbGlnbm1lbnQgcmVxdWlyZW1l bnRzLgorCisyMDE4LTAyLTA0ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4K KwogICAgICAgICBTaW1wbGlmeSBHcmFwaGljc0NvbnRleHQzRDo6cGFpbnRUb0NhbnZhcygpCiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODI0NTkKIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhp Y3NDb250ZXh0M0RDYWlyby5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j YWlyby9HcmFwaGljc0NvbnRleHQzRENhaXJvLmNwcAppbmRleCAxZGI3OWZhMDdlZjMzNGZiYmI3 ZDIxNjQ2ZGFmMzZiMmVkOWE3MGRmLi43MTEwM2VjYmFhNDJjMTUyYjlhODJhNzY4Njk3ZDcxNGMx YTVlODAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWly by9HcmFwaGljc0NvbnRleHQzRENhaXJvLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHQzRENhaXJvLmNwcApAQCAtMzYwLDcgKzM2 MCw4IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0M0Q6OnBhaW50VG9DYW52YXMoY29uc3QgdW5zaWdu ZWQgY2hhciogaW1hZ2VQaXhlbHMsIGNvbnN0IEluCiAgICAgY2Fpcm9fcGFpbnQoY3IpOwogCiAg ICAgUmVmUHRyPGNhaXJvX3N1cmZhY2VfdD4gaW1hZ2VTdXJmYWNlID0gYWRvcHRSZWYoY2Fpcm9f aW1hZ2Vfc3VyZmFjZV9jcmVhdGVfZm9yX2RhdGEoCi0gICAgICAgIGNvbnN0X2Nhc3Q8dW5zaWdu ZWQgY2hhcio+KGltYWdlUGl4ZWxzKSwgQ0FJUk9fRk9STUFUX0FSR0IzMiwgaW1hZ2VTaXplLndp ZHRoKCksIGltYWdlU2l6ZS5oZWlnaHQoKSwgaW1hZ2VTaXplLndpZHRoKCkgKiA0KSk7CisgICAg ICAgIGNvbnN0X2Nhc3Q8dW5zaWduZWQgY2hhcio+KGltYWdlUGl4ZWxzKSwgQ0FJUk9fRk9STUFU X0FSR0IzMiwgaW1hZ2VTaXplLndpZHRoKCksIGltYWdlU2l6ZS5oZWlnaHQoKSwKKyAgICAgICAg Y2Fpcm9fZm9ybWF0X3N0cmlkZV9mb3Jfd2lkdGgoQ0FJUk9fRk9STUFUX0FSR0IzMiwgaW1hZ2VT aXplLndpZHRoKCkpKSk7CiAKICAgICAvLyBPcGVuR0wga2VlcHMgdGhlIHBpeGVscyBzdG9yZWQg Ym90dG9tIHVwLCBzbyB3ZSBuZWVkIHRvIGZsaXAgdGhlIGltYWdlIGhlcmUuCiAgICAgY2Fpcm9f dHJhbnNsYXRlKGNyLCAwLCBpbWFnZVNpemUuaGVpZ2h0KCkpOwo=