182460 2018-02-03 15:20:08 -0800 UI process sometimes crashes under -[WKContentView _lookupForWebView:] 2018-02-03 19:36:11 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton commit-queue enrica megan_gardner wenson_hsieh oldest_to_newest 1396146 0 thorton 2018-02-03 15:20:08 -0800 UI process sometimes crashes under -[WKContentView _lookupForWebView:] 1396147 1 333039 thorton 2018-02-03 15:20:23 -0800 Created attachment 333039 Patch 1396148 2 thorton 2018-02-03 15:20:39 -0800 <rdar://problem/33260602> 1396149 3 333039 wenson_hsieh 2018-02-03 15:31:45 -0800 Comment on attachment 333039 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333039&action=review r=me > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2008 > + auto& editorState = view->_page->editorState(); It seems a bit strange that selectedText exists, but there are no selection rects. Is it possible we're missing post-layout data in this case? Or perhaps the if (!selectedText) early return above should be if (selectedText.isEmpty()) instead? 1396151 4 thorton 2018-02-03 15:43:15 -0800 I seem to recall there being some weird corner cases where we end up with no rects (or empty rects that get collapsed to no rects) despite having selected text, but couldn’t remember or re-discover what those cases are. Maybe Enrica remembers. In any case, it seems better to check the thing you’re about to depend on. Thank you for your review! 1396152 5 333039 commit-queue 2018-02-03 15:44:32 -0800 Comment on attachment 333039 Patch Rejecting attachment 333039 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 333039, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: rdparty/autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain result = func(*args) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 60] Operation timed out> Full output: http://webkit-queues.webkit.org/results/6348787 1396154 6 thorton 2018-02-03 15:46:08 -0800 Fine, I’ll do it myself. 1396162 7 thorton 2018-02-03 19:36:11 -0800 https://trac.webkit.org/changeset/228050/webkit 333039 2018-02-03 15:20:23 -0800 2018-02-03 15:44:32 -0800 Patch bug-182460-20180203152022.patch text/plain 3203 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3OTkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQ3MzU1Mjk4NDI4NmMwZWRi Yjk3YWNmODllZjNmMjQ4MDJkNzk5Y2QuLmY5MzJkODc3MjA5MDQ3NDRhZGUyNzUxMzNjNzhiYjRl NjE5OTE5NTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTgtMDItMDMgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgVUkgcHJvY2VzcyBzb21l dGltZXMgY3Jhc2hlcyB1bmRlciAtW1dLQ29udGVudFZpZXcgX2xvb2t1cEZvcldlYlZpZXc6XQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyNDYwCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMzI2MDYwMj4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0lu dGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IF9sb29rdXBGb3JXZWJWaWV3 Ol0pOgorICAgICAgICBJZiB5b3UgaGF2ZSBhIHJhbmdlIHNlbGVjdGlvbiwgYnV0IG5vIHJlY3Rz IGZvciB0aGUgc2VsZWN0aW9uLCByZXRyaWV2aW5nCisgICAgICAgIHRoZSAwdGggZWxlbWVudCBv ZiBzZWxlY3Rpb25SZWN0cyB3aWxsIGNyYXNoIHRoZSBVSSBwcm9jZXNzLiBUbyBmaXgsIGluCisg ICAgICAgIHRoaXMgY2FzZSwgdXNlIHRoZSByZWN0IGZvciB0aGUgc3RhcnRpbmcgY2FyZXQgaW5z dGVhZC4KKworICAgICAgICBJdCBkb2Vzbid0IHNlZW0gbGlrZSB0aGUgcHJlc2VudGF0aW9uUmVj dCBpcyBhY3R1YWxseSBjdXJyZW50bHkgdXNlZCBmb3IKKyAgICAgICAgdGhlIExvb2t1cCBzZXJ2 aWNlLCBzbyB0aGUgb25seSBpbXBhY3QgaXMgdGhhdCB3ZSBzaG91bGRuJ3QgY3Jhc2ggYW55bW9y ZS4KKwogMjAxOC0wMi0wMSAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAog ICAgICAgICBJbXByb3ZlIE5ldHdvcmtSZXNvdXJjZUxvZ2dlciB0byByZXBvcnQgYmxvY2tlZCAo dmVyc3VzIG5vbi1wYXJ0aXRpb25lZCkgY29va2llcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KaW5kZXggZjE4NzIy Njc4MDgyMzY2ZTNlYjIxYjEzMjZhNmJmODMzZDk0NmE5Ni4uODk0NzUzYjM2NTRlODUxNWRjOWRm ODMwYmRiOWQ4NjUyZGE5NTE3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv aW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC0yMDA0LDE1ICsyMDA0LDIy IEBAIC0gKHZvaWQpX2xvb2t1cEZvcldlYlZpZXc6KGlkKXNlbmRlcgogICAgICAgICAgICAgcmV0 dXJuOwogICAgICAgICBpZiAoIXNlbGVjdGVkVGV4dCkKICAgICAgICAgICAgIHJldHVybjsKLSAg ICAgICAgCi0gICAgICAgIENHUmVjdCBwcmVzZW50YXRpb25SZWN0ID0gdmlldy0+X3BhZ2UtPmVk aXRvclN0YXRlKCkuc2VsZWN0aW9uSXNSYW5nZSA/IHZpZXctPl9wYWdlLT5lZGl0b3JTdGF0ZSgp LnBvc3RMYXlvdXREYXRhKCkuc2VsZWN0aW9uUmVjdHNbMF0ucmVjdCgpIDogdmlldy0+X3BhZ2Ut PmVkaXRvclN0YXRlKCkucG9zdExheW91dERhdGEoKS5jYXJldFJlY3RBdFN0YXJ0OworCisgICAg ICAgIGF1dG8mIGVkaXRvclN0YXRlID0gdmlldy0+X3BhZ2UtPmVkaXRvclN0YXRlKCk7CisgICAg ICAgIGF1dG8mIHBvc3RMYXlvdXREYXRhID0gZWRpdG9yU3RhdGUucG9zdExheW91dERhdGEoKTsK KyAgICAgICAgQ0dSZWN0IHByZXNlbnRhdGlvblJlY3Q7CisgICAgICAgIGlmIChlZGl0b3JTdGF0 ZS5zZWxlY3Rpb25Jc1JhbmdlICYmICFwb3N0TGF5b3V0RGF0YS5zZWxlY3Rpb25SZWN0cy5pc0Vt cHR5KCkpCisgICAgICAgICAgICBwcmVzZW50YXRpb25SZWN0ID0gcG9zdExheW91dERhdGEuc2Vs ZWN0aW9uUmVjdHNbMF0ucmVjdCgpOworICAgICAgICBlbHNlCisgICAgICAgICAgICBwcmVzZW50 YXRpb25SZWN0ID0gcG9zdExheW91dERhdGEuY2FyZXRSZWN0QXRTdGFydDsKICAgICAgICAgCiAg ICAgICAgIFN0cmluZyBzZWxlY3Rpb25Db250ZXh0ID0gdGV4dEJlZm9yZSArIHNlbGVjdGVkVGV4 dCArIHRleHRBZnRlcjsKLSAgICAgICAgaWYgKHZpZXctPl90ZXh0U2VsZWN0aW9uQXNzaXN0YW50 KSB7Ci0gICAgICAgICAgICBbdmlldy0+X3RleHRTZWxlY3Rpb25Bc3Npc3RhbnQgbG9va3VwOnNl bGVjdGlvbkNvbnRleHQgd2l0aFJhbmdlOk5TTWFrZVJhbmdlKHRleHRCZWZvcmUubGVuZ3RoKCks IHNlbGVjdGVkVGV4dC5sZW5ndGgoKSkgZnJvbVJlY3Q6cHJlc2VudGF0aW9uUmVjdF07Ci0gICAg ICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICBbdmlldy0+X3dlYlNlbGVjdGlvbkFzc2lzdGFudCBs b29rdXA6c2VsZWN0aW9uQ29udGV4dCB3aXRoUmFuZ2U6TlNNYWtlUmFuZ2UodGV4dEJlZm9yZS5s ZW5ndGgoKSwgc2VsZWN0ZWRUZXh0Lmxlbmd0aCgpKSBmcm9tUmVjdDpwcmVzZW50YXRpb25SZWN0 XTsKLSAgICAgICAgfQorICAgICAgICBOU1JhbmdlIHNlbGVjdGVkUmFuZ2VJbkNvbnRleHQgPSBO U01ha2VSYW5nZSh0ZXh0QmVmb3JlLmxlbmd0aCgpLCBzZWxlY3RlZFRleHQubGVuZ3RoKCkpOwor CisgICAgICAgIGlmIChhdXRvIHRleHRTZWxlY3Rpb25Bc3Npc3RhbnQgPSB2aWV3LT5fdGV4dFNl bGVjdGlvbkFzc2lzdGFudCkKKyAgICAgICAgICAgIFt0ZXh0U2VsZWN0aW9uQXNzaXN0YW50IGxv b2t1cDpzZWxlY3Rpb25Db250ZXh0IHdpdGhSYW5nZTpzZWxlY3RlZFJhbmdlSW5Db250ZXh0IGZy b21SZWN0OnByZXNlbnRhdGlvblJlY3RdOworICAgICAgICBlbHNlCisgICAgICAgICAgICBbdmll dy0+X3dlYlNlbGVjdGlvbkFzc2lzdGFudCBsb29rdXA6c2VsZWN0aW9uQ29udGV4dCB3aXRoUmFu Z2U6c2VsZWN0ZWRSYW5nZUluQ29udGV4dCBmcm9tUmVjdDpwcmVzZW50YXRpb25SZWN0XTsKICAg ICB9KTsKIH0KIAo=