182446 2018-02-02 11:57:58 -0800 [Win] Enable multi cpu building on MSBuild. 2018-02-05 11:19:54 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 basuke basuke achristensen basuke bfulgham commit-queue dbates don.olmstead ews-watchlist lforschler pvollan webkit-bug-importer oldest_to_newest 1395935 0 basuke 2018-02-02 11:57:58 -0800 Compiling itself already uses multi cores, but other stuff is still on single core. This patch enables that by passing an argument to MSBuild.exe. 1395941 1 332990 basuke 2018-02-02 12:03:15 -0800 Created attachment 332990 patch 1395947 2 basuke 2018-02-02 12:15:11 -0800 32 min => 21 min ! (Core i7-8700K 3.7GHz 6 core) 1395948 3 332992 basuke 2018-02-02 12:20:26 -0800 Created attachment 332992 patch 1396058 4 332992 achristensen 2018-02-02 16:45:52 -0800 Comment on attachment 332992 patch View in context: https://bugs.webkit.org/attachment.cgi?id=332992&action=review > Tools/Scripts/webkitdirs.pm:438 > + $numberOfCPUs = 1; Don't we want an implementation for non-cygwin Windows? 1396091 5 332992 dbates 2018-02-02 19:47:33 -0800 Comment on attachment 332992 patch View in context: https://bugs.webkit.org/attachment.cgi?id=332992&action=review > Tools/Scripts/webkitdirs.pm:1922 > + my $maxCpuCount = '/maxcpucount:' . numberOfCPUs(); Nit: maxCpuCount => maxCPUCount (Since CPU is an abbreviation) 1396096 6 don.olmstead 2018-02-02 20:54:22 -0800 (In reply to Alex Christensen from comment #4) > Comment on attachment 332992 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=332992&action=review > > > Tools/Scripts/webkitdirs.pm:438 > > + $numberOfCPUs = 1; > > Don't we want an implementation for non-cygwin Windows? I THINK the environment variable checked above should be set on windows. There looks to be a perl module that will tell you the number of CPUs as well http://search.cpan.org/~burak/Sys-Info-Base-0.7802/lib/Sys/Info/Device/CPU.pm which sounds like it calls into WMI 1396165 7 basuke 2018-02-03 20:07:10 -0800 > Don't we want an implementation for non-cygwin Windows? Don is right. Here's the source. https://msdn.microsoft.com/en-us/library/fd7hxfdd(v=vs.84).aspx > Nit: maxCpuCount => maxCPUCount > (Since CPU is an abbreviation) Right. I'll send another patch. 1396166 8 333044 basuke 2018-02-03 20:07:46 -0800 Created attachment 333044 PATCH 1396411 9 333044 commit-queue 2018-02-05 11:15:14 -0800 Comment on attachment 333044 PATCH Clearing flags on attachment: 333044 Committed r228106: <https://trac.webkit.org/changeset/228106> 1396412 10 commit-queue 2018-02-05 11:15:15 -0800 All reviewed patches have been landed. Closing bug. 1396416 11 webkit-bug-importer 2018-02-05 11:19:54 -0800 <rdar://problem/37244015> 332990 2018-02-02 12:03:15 -0800 2018-02-02 12:16:18 -0800 patch 182446.diff text/plain 1582 basuke ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1Yzcy YzVmM2YzOS4uMDE1MmU4NTNjNWUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxOC0wMi0wMiAgQmFzdWtlIFN1enVr aSAgPEJhc3VrZS5TdXp1a2lAc29ueS5jb20+CisKKyAgICAgICAgW1dpbl0gRW5hYmxlIG11bHRp IENQVSBidWlsZGluZyBvbiBNU0J1aWxkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTgyNDQ2CisKKyAgICAgICAgQ29tcGlsaW5nIGl0c2VsZiBhbHJl YWR5IHVzZXMgbXVsdGkgY29yZXMsIGJ1dCBvdGhlciBzdHVmZiBpcyBzdGlsbCBvbiBzaW5nbGUg Y29yZS4KKyAgICAgICAgVGhpcyBwYXRjaCBlbmFibGVzIHRoYXQgYnkgcGFzc2luZyBhbiBhcmd1 bWVudCB0byBNU0J1aWxkLmV4ZS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGJ1aWxkVmlz dWFsU3R1ZGlvUHJvamVjdCk6CisKIDIwMTgtMDItMDIgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5A YXBwbGUuY29tPgogCiAgICAgICAgIENvbmZpZ3VyZSBzZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9u RGlyZWN0b3J5IG9uIHRoZSB3ZWIgc2l0ZSBkYXRhIHN0b3JlIGFuZCBtb3ZlIGl0IHRvIGEgQ2Fj aGVzIHN1YmZvbGRlciBhcyBhIGRlZmF1bHQKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0ZGlycy5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCA2MjBiMmIzYWEy MS4uZWY4MDc0NDkwZGYgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQor KysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTE5MTcsNyArMTkxNyw5IEBAIHN1 YiBidWlsZFZpc3VhbFN0dWRpb1Byb2plY3QKICAgICBjaG9tcCgkd2FybmluZ0xvZ0ZpbGUgPSBg Y3lncGF0aCAtdyAiJHdhcm5pbmdMb2dGaWxlImApIGlmIGlzQ3lnd2luKCk7CiAgICAgbXkgJHdh cm5pbmdMb2dnaW5nID0gIi9mbHAxOkxvZ0ZpbGU9IiAuICR3YXJuaW5nTG9nRmlsZSAuICI7V2Fy bmluZ3NPbmx5IjsKIAotICAgIG15IEBjb21tYW5kID0gKCR2Y0J1aWxkUGF0aCwgIi92ZXJib3Np dHk6bWluaW1hbCIsICRwcm9qZWN0LCAkYWN0aW9uLCAkY29uZmlnLCAkcGxhdGZvcm0sICIvZmwi LCAkZXJyb3JMb2dnaW5nLCAiL2ZsMSIsICR3YXJuaW5nTG9nZ2luZyk7CisgICAgbXkgJG1heENw dUNvdW50ID0gJy9tYXhjcHVjb3VudDonIC4gJG51bWJlck9mQ1BVczsKKworICAgIG15IEBjb21t YW5kID0gKCR2Y0J1aWxkUGF0aCwgIi92ZXJib3NpdHk6bWluaW1hbCIsICRwcm9qZWN0LCAkYWN0 aW9uLCAkY29uZmlnLCAkcGxhdGZvcm0sICIvZmwiLCAkZXJyb3JMb2dnaW5nLCAiL2ZsMSIsICR3 YXJuaW5nTG9nZ2luZywgJG1heENwdUNvdW50KTsKICAgICBwcmludCBqb2luKCIgIiwgQGNvbW1h bmQpLCAiXG4iOwogICAgIHJldHVybiBzeXN0ZW0gQGNvbW1hbmQ7CiB9Cg== 332992 2018-02-02 12:20:26 -0800 2018-02-03 20:07:46 -0800 patch 182446.diff text/plain 1927 basuke ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1Yzcy YzVmM2YzOS4uMGZhNDRhZGFiMjMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxOC0wMi0wMiAgQmFzdWtlIFN1enVr aSAgPEJhc3VrZS5TdXp1a2lAc29ueS5jb20+CisKKyAgICAgICAgW1dpbl0gRW5hYmxlIG11bHRp IENQVSBidWlsZGluZyBvbiBNU0J1aWxkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTgyNDQ2CisKKyAgICAgICAgQ29tcGlsaW5nIGl0c2VsZiBhbHJl YWR5IHVzZXMgbXVsdGkgY29yZXMsIGJ1dCBvdGhlciBzdHVmZiBpcyBzdGlsbCBvbiBzaW5nbGUg Y29yZS4KKyAgICAgICAgVGhpcyBwYXRjaCBlbmFibGVzIHRoYXQgYnkgcGFzc2luZyBhbiBhcmd1 bWVudCB0byBNU0J1aWxkLmV4ZS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGRldGVybWlu ZU51bWJlck9mQ1BVcyk6CisgICAgICAgIChidWlsZFZpc3VhbFN0dWRpb1Byb2plY3QpOgorCiAy MDE4LTAyLTAyICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBD b25maWd1cmUgc2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbkRpcmVjdG9yeSBvbiB0aGUgd2ViIHNp dGUgZGF0YSBzdG9yZSBhbmQgbW92ZSBpdCB0byBhIENhY2hlcyBzdWJmb2xkZXIgYXMgYSBkZWZh dWx0CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29scy9TY3Jp cHRzL3dlYmtpdGRpcnMucG0KaW5kZXggNjIwYjJiM2FhMjEuLjJjNzhiMmMyZmVmIDEwMDc1NQot LS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRkaXJzLnBtCkBAIC00MzQsNiArNDM0LDggQEAgc3ViIGRldGVybWluZU51bWJlck9mQ1BVcwog ICAgICAgICAkbnVtYmVyT2ZDUFVzID0gYGxzIC9wcm9jL3JlZ2lzdHJ5L0hLRVlfTE9DQUxfTUFD SElORS9IQVJEV0FSRS9ERVNDUklQVElPTi9TeXN0ZW0vQ2VudHJhbFByb2Nlc3NvciB8IHdjIC13 YDsKICAgICB9IGVsc2lmIChpc0RhcndpbigpIHx8IGlzQlNEKCkpIHsKICAgICAgICAgY2hvbXAo JG51bWJlck9mQ1BVcyA9IGBzeXNjdGwgLW4gaHcubmNwdWApOworICAgIH0gZWxzZSB7CisgICAg ICAgICRudW1iZXJPZkNQVXMgPSAxOwogICAgIH0KIH0KIApAQCAtMTkxNyw3ICsxOTE5LDkgQEAg c3ViIGJ1aWxkVmlzdWFsU3R1ZGlvUHJvamVjdAogICAgIGNob21wKCR3YXJuaW5nTG9nRmlsZSA9 IGBjeWdwYXRoIC13ICIkd2FybmluZ0xvZ0ZpbGUiYCkgaWYgaXNDeWd3aW4oKTsKICAgICBteSAk d2FybmluZ0xvZ2dpbmcgPSAiL2ZscDE6TG9nRmlsZT0iIC4gJHdhcm5pbmdMb2dGaWxlIC4gIjtX YXJuaW5nc09ubHkiOwogCi0gICAgbXkgQGNvbW1hbmQgPSAoJHZjQnVpbGRQYXRoLCAiL3ZlcmJv c2l0eTptaW5pbWFsIiwgJHByb2plY3QsICRhY3Rpb24sICRjb25maWcsICRwbGF0Zm9ybSwgIi9m bCIsICRlcnJvckxvZ2dpbmcsICIvZmwxIiwgJHdhcm5pbmdMb2dnaW5nKTsKKyAgICBteSAkbWF4 Q3B1Q291bnQgPSAnL21heGNwdWNvdW50OicgLiBudW1iZXJPZkNQVXMoKTsKKworICAgIG15IEBj b21tYW5kID0gKCR2Y0J1aWxkUGF0aCwgIi92ZXJib3NpdHk6bWluaW1hbCIsICRwcm9qZWN0LCAk YWN0aW9uLCAkY29uZmlnLCAkcGxhdGZvcm0sICIvZmwiLCAkZXJyb3JMb2dnaW5nLCAiL2ZsMSIs ICR3YXJuaW5nTG9nZ2luZywgJG1heENwdUNvdW50KTsKICAgICBwcmludCBqb2luKCIgIiwgQGNv bW1hbmQpLCAiXG4iOwogICAgIHJldHVybiBzeXN0ZW0gQGNvbW1hbmQ7CiB9Cg== 333044 2018-02-03 20:07:46 -0800 2018-02-05 11:15:14 -0800 PATCH 182446.diff text/plain 1927 basuke ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1Yzcy YzVmM2YzOS4uMGZhNDRhZGFiMjMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxOC0wMi0wMiAgQmFzdWtlIFN1enVr aSAgPEJhc3VrZS5TdXp1a2lAc29ueS5jb20+CisKKyAgICAgICAgW1dpbl0gRW5hYmxlIG11bHRp IENQVSBidWlsZGluZyBvbiBNU0J1aWxkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTgyNDQ2CisKKyAgICAgICAgQ29tcGlsaW5nIGl0c2VsZiBhbHJl YWR5IHVzZXMgbXVsdGkgY29yZXMsIGJ1dCBvdGhlciBzdHVmZiBpcyBzdGlsbCBvbiBzaW5nbGUg Y29yZS4KKyAgICAgICAgVGhpcyBwYXRjaCBlbmFibGVzIHRoYXQgYnkgcGFzc2luZyBhbiBhcmd1 bWVudCB0byBNU0J1aWxkLmV4ZS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGRldGVybWlu ZU51bWJlck9mQ1BVcyk6CisgICAgICAgIChidWlsZFZpc3VhbFN0dWRpb1Byb2plY3QpOgorCiAy MDE4LTAyLTAyICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBD b25maWd1cmUgc2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbkRpcmVjdG9yeSBvbiB0aGUgd2ViIHNp dGUgZGF0YSBzdG9yZSBhbmQgbW92ZSBpdCB0byBhIENhY2hlcyBzdWJmb2xkZXIgYXMgYSBkZWZh dWx0CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29scy9TY3Jp cHRzL3dlYmtpdGRpcnMucG0KaW5kZXggNjIwYjJiM2FhMjEuLjJjNzhiMmMyZmVmIDEwMDc1NQot LS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRkaXJzLnBtCkBAIC00MzQsNiArNDM0LDggQEAgc3ViIGRldGVybWluZU51bWJlck9mQ1BVcwog ICAgICAgICAkbnVtYmVyT2ZDUFVzID0gYGxzIC9wcm9jL3JlZ2lzdHJ5L0hLRVlfTE9DQUxfTUFD SElORS9IQVJEV0FSRS9ERVNDUklQVElPTi9TeXN0ZW0vQ2VudHJhbFByb2Nlc3NvciB8IHdjIC13 YDsKICAgICB9IGVsc2lmIChpc0RhcndpbigpIHx8IGlzQlNEKCkpIHsKICAgICAgICAgY2hvbXAo JG51bWJlck9mQ1BVcyA9IGBzeXNjdGwgLW4gaHcubmNwdWApOworICAgIH0gZWxzZSB7CisgICAg ICAgICRudW1iZXJPZkNQVXMgPSAxOwogICAgIH0KIH0KIApAQCAtMTkxNyw3ICsxOTE5LDkgQEAg c3ViIGJ1aWxkVmlzdWFsU3R1ZGlvUHJvamVjdAogICAgIGNob21wKCR3YXJuaW5nTG9nRmlsZSA9 IGBjeWdwYXRoIC13ICIkd2FybmluZ0xvZ0ZpbGUiYCkgaWYgaXNDeWd3aW4oKTsKICAgICBteSAk d2FybmluZ0xvZ2dpbmcgPSAiL2ZscDE6TG9nRmlsZT0iIC4gJHdhcm5pbmdMb2dGaWxlIC4gIjtX YXJuaW5nc09ubHkiOwogCi0gICAgbXkgQGNvbW1hbmQgPSAoJHZjQnVpbGRQYXRoLCAiL3ZlcmJv c2l0eTptaW5pbWFsIiwgJHByb2plY3QsICRhY3Rpb24sICRjb25maWcsICRwbGF0Zm9ybSwgIi9m bCIsICRlcnJvckxvZ2dpbmcsICIvZmwxIiwgJHdhcm5pbmdMb2dnaW5nKTsKKyAgICBteSAkbWF4 Q1BVQ291bnQgPSAnL21heGNwdWNvdW50OicgLiBudW1iZXJPZkNQVXMoKTsKKworICAgIG15IEBj b21tYW5kID0gKCR2Y0J1aWxkUGF0aCwgIi92ZXJib3NpdHk6bWluaW1hbCIsICRwcm9qZWN0LCAk YWN0aW9uLCAkY29uZmlnLCAkcGxhdGZvcm0sICIvZmwiLCAkZXJyb3JMb2dnaW5nLCAiL2ZsMSIs ICR3YXJuaW5nTG9nZ2luZywgJG1heENQVUNvdW50KTsKICAgICBwcmludCBqb2luKCIgIiwgQGNv bW1hbmQpLCAiXG4iOwogICAgIHJldHVybiBzeXN0ZW0gQGNvbW1hbmQ7CiB9Cg==