182433 2018-02-02 07:44:53 -0800 Fix bug in MediaTime comparison for negative values with different scale. 2018-02-05 01:15:32 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aboya webkit-unassigned calvaris commit-queue eocanha jer.noble webkit-bug-importer oldest_to_newest 1395852 0 aboya 2018-02-02 07:44:53 -0800 Currently comparisons like MediaTime(-8, 10) >= MediaTime(-1, 1) return false, incorrectly as -0.8 >= -1.0. 1395853 1 332967 aboya 2018-02-02 07:58:03 -0800 Created attachment 332967 Patch 1396242 2 332967 commit-queue 2018-02-05 01:14:14 -0800 Comment on attachment 332967 Patch Clearing flags on attachment: 332967 Committed r228089: <https://trac.webkit.org/changeset/228089> 1396243 3 commit-queue 2018-02-05 01:14:15 -0800 All reviewed patches have been landed. Closing bug. 1396244 4 webkit-bug-importer 2018-02-05 01:15:32 -0800 <rdar://problem/37228586> 332967 2018-02-02 07:58:03 -0800 2018-02-05 01:14:14 -0800 Patch bug-182433-20180202165801.patch text/plain 3559 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3OTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDFmNWUzZTg5MzEwM2I1OWUzZTY1OThk OWU1MmRiMTYxNzE0N2RkOGQuLjdhNzE5MDlmOGE0MzlkNWY0YmQ4ODliZGZlY2E2NWIxMTc2ZDU4 MWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMDItMDEgIEFsaWNpYSBCb3lhIEdhcmPDrWEg IDxhYm95YUBpZ2FsaWEuY29tPgorCisgICAgICAgIEZpeCBidWcgaW4gTWVkaWFUaW1lIGNvbXBh cmlzb24gZm9yIG5lZ2F0aXZlIHZhbHVlcyB3aXRoIGRpZmZlcmVudCBzY2FsZS4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjQzMworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL01lZGlhVGltZS5j cHA6CisgICAgICAgIChXVEY6Ok1lZGlhVGltZTo6Y29tcGFyZSBjb25zdCk6CisKIDIwMTgtMDIt MDEgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgogCiAgICAgICAg IFtXUEVdW0dUS10gTWFrZSBSdW5Mb29wOjpUaW1lckJhc2Ugcm9idXN0IHRvIGl0cyBvd24gZGVs ZXRpb24gaW5zaWRlIGl0cyBzb3VyY2UgY2FsbGJhY2sKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYv d3RmL01lZGlhVGltZS5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9NZWRpYVRpbWUuY3BwCmluZGV4IDU0 MDFkZGQ2YzY3Y2IzMjRlZGVjN2NmZjdlZDU5MWU5Yjk4NmVhNWQuLjAzMDUwYjUyNjQzNjhjNjdk YmM1ZTBiODRlNTc0ODJmMDRkM2Q0YTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL01lZGlh VGltZS5jcHAKKysrIGIvU291cmNlL1dURi93dGYvTWVkaWFUaW1lLmNwcApAQCAtMzkxLDExICsz OTEsMTkgQEAgTWVkaWFUaW1lOjpDb21wYXJpc29uRmxhZ3MgTWVkaWFUaW1lOjpjb21wYXJlKGNv bnN0IE1lZGlhVGltZSYgcmhzKSBjb25zdAogICAgIGlmIChtX3RpbWVWYWx1ZSA9PSByaHMubV90 aW1lVmFsdWUpCiAgICAgICAgIHJldHVybiBtX3RpbWVTY2FsZSA8IHJocy5tX3RpbWVTY2FsZSA/ IEdyZWF0ZXJUaGFuIDogTGVzc1RoYW47CiAKLSAgICBpZiAobV90aW1lVmFsdWUgPCByaHMubV90 aW1lVmFsdWUgJiYgbV90aW1lU2NhbGUgPiByaHMubV90aW1lU2NhbGUpCi0gICAgICAgIHJldHVy biBMZXNzVGhhbjsKKyAgICBpZiAobV90aW1lVmFsdWUgPj0gMCkgeworICAgICAgICBpZiAobV90 aW1lVmFsdWUgPCByaHMubV90aW1lVmFsdWUgJiYgbV90aW1lU2NhbGUgPiByaHMubV90aW1lU2Nh bGUpCisgICAgICAgICAgICByZXR1cm4gTGVzc1RoYW47CiAKLSAgICBpZiAobV90aW1lVmFsdWUg PiByaHMubV90aW1lVmFsdWUgJiYgbV90aW1lU2NhbGUgPCByaHMubV90aW1lU2NhbGUpCi0gICAg ICAgIHJldHVybiBHcmVhdGVyVGhhbjsKKyAgICAgICAgaWYgKG1fdGltZVZhbHVlID4gcmhzLm1f dGltZVZhbHVlICYmIG1fdGltZVNjYWxlIDwgcmhzLm1fdGltZVNjYWxlKQorICAgICAgICAgICAg cmV0dXJuIEdyZWF0ZXJUaGFuOworICAgIH0gZWxzZSB7CisgICAgICAgIGlmIChtX3RpbWVWYWx1 ZSA8IHJocy5tX3RpbWVWYWx1ZSAmJiBtX3RpbWVTY2FsZSA8IHJocy5tX3RpbWVTY2FsZSkKKyAg ICAgICAgICAgIHJldHVybiBMZXNzVGhhbjsKKworICAgICAgICBpZiAobV90aW1lVmFsdWUgPiBy aHMubV90aW1lVmFsdWUgJiYgbV90aW1lU2NhbGUgPiByaHMubV90aW1lU2NhbGUpCisgICAgICAg ICAgICByZXR1cm4gR3JlYXRlclRoYW47CisgICAgfQogCiAgICAgaW50NjRfdCBsaHNGYWN0b3I7 CiAgICAgaW50NjRfdCByaHNGYWN0b3I7CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9U b29scy9DaGFuZ2VMb2cKaW5kZXggZDhiZDY1MjIxNDU0ZmRlNTk1YWQ2OTNiMjIwNmNiYzZjMjFh YTg3ZS4uMmExZDJhMmQ2MTVlMTczZjU2ZmM3ZDE5YWY3YzRhNDg4ZTY1OWJiZSAxMDA2NDQKLS0t IGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBA CisyMDE4LTAyLTAxICBBbGljaWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KKwor ICAgICAgICBGaXggYnVnIGluIE1lZGlhVGltZSBjb21wYXJpc29uIGZvciBuZWdhdGl2ZSB2YWx1 ZXMgd2l0aCBkaWZmZXJlbnQgc2NhbGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xODI0MzMKKworICAgICAgICBJbXByb3ZlZCB0ZXN0IGNvdmVyYWdl IGZvciBNZWRpYVRpbWU6OmNvbXBhcmUoKS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL01lZGlhVGltZS5j cHA6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKToKKwogMjAxOC0wMi0wMSAgQWFrYXNo IEphaW4gIDxhYWthc2hfamFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgQnViYmxlcyBpbnRlcm1p dHRlbnRseSBkaXNhcHBlYXIgZnJvbSBib3Qgd2F0Y2hlcnMgZGFzaGJvYXJkCmRpZmYgLS1naXQg YS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9NZWRpYVRpbWUuY3BwIGIvVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XVEYvTWVkaWFUaW1lLmNwcAppbmRleCBkOGQ4YzMyOGQ2Y2FlODg1 NTBhYzdmMGMyNjk5M2Y3ZjhkOTllZjAyLi5kMWVjODEzZTYyNGJkYTczMTk1NGEwMTllMzRhNmIy NzU0ZjU5YzFmIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9NZWRp YVRpbWUuY3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL01lZGlhVGltZS5j cHAKQEAgLTg1LDYgKzg1LDEyIEBAIFRFU1QoV1RGLCBNZWRpYVRpbWUpCiAgICAgRVhQRUNUX0VR KE1lZGlhVGltZSgxLCAxKSAhPSBNZWRpYVRpbWUoMiwgMSksIHRydWUpOwogICAgIEVYUEVDVF9F UShNZWRpYVRpbWUoMiwgMSkgPT0gTWVkaWFUaW1lKDIsIDEpLCB0cnVlKTsKICAgICBFWFBFQ1Rf RVEoTWVkaWFUaW1lKDIsIDEpID09IE1lZGlhVGltZSg0LCAyKSwgdHJ1ZSk7CisgICAgRVhQRUNU X0VRKE1lZGlhVGltZSgtMiwgMSkgPCBNZWRpYVRpbWUoLTEsIDEpLCB0cnVlKTsKKyAgICBFWFBF Q1RfRVEoTWVkaWFUaW1lKC0yLCAxKSA8PSBNZWRpYVRpbWUoLTEsIDEpLCB0cnVlKTsKKyAgICBF WFBFQ1RfRVEoTWVkaWFUaW1lKC0xLCAxKSA8IE1lZGlhVGltZSgtMiwgMSksIGZhbHNlKTsKKyAg ICBFWFBFQ1RfRVEoTWVkaWFUaW1lKC0xLCAxKSA8IE1lZGlhVGltZSgyLCAxKSwgdHJ1ZSk7Cisg ICAgRVhQRUNUX0VRKE1lZGlhVGltZSgxLCAxKSA+IE1lZGlhVGltZSgtMiwgMSksIHRydWUpOwor ICAgIEVYUEVDVF9FUShNZWRpYVRpbWUoLTgsIDEwKSA+PSBNZWRpYVRpbWUoLTEsIDEpLCB0cnVl KTsKICAgICBFWFBFQ1RfVFJVRSgoYm9vbClNZWRpYVRpbWUoMSwgMSkpOwogICAgIEVYUEVDVF9U UlVFKCFNZWRpYVRpbWUoMCwgMSkpOwogCg==