<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>182402</bug_id>
          
          <creation_ts>2018-02-01 12:37:07 -0800</creation_ts>
          <short_desc>MapHash should return true to doesGC in the DFG depending on useKind because it might resolve a rope</short_desc>
          <delta_ts>2018-02-02 11:08:24 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Saam Barati">saam</reporter>
          <assigned_to name="Saam Barati">saam</assigned_to>
          <cc>benjamin</cc>
    
    <cc>commit-queue</cc>
    
    <cc>fpizlo</cc>
    
    <cc>ggaren</cc>
    
    <cc>gskachkov</cc>
    
    <cc>jfbastien</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>rmorisset</cc>
    
    <cc>ticaiolima</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1395600</commentid>
    <comment_count>0</comment_count>
    <who name="Saam Barati">saam</who>
    <bug_when>2018-02-01 12:37:07 -0800</bug_when>
    <thetext>It may resolve a rope.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1395751</commentid>
    <comment_count>1</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2018-02-01 22:20:24 -0800</bug_when>
    <thetext>I think we can return false for doesGC if MapHash with several edges like Int32Use.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1395888</commentid>
    <comment_count>2</comment_count>
      <attachid>332976</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2018-02-02 09:31:42 -0800</bug_when>
    <thetext>Created attachment 332976
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1395891</commentid>
    <comment_count>3</comment_count>
      <attachid>332976</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2018-02-02 09:34:10 -0800</bug_when>
    <thetext>Comment on attachment 332976
patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1395911</commentid>
    <comment_count>4</comment_count>
      <attachid>332976</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-02-02 11:07:35 -0800</bug_when>
    <thetext>Comment on attachment 332976
patch

Clearing flags on attachment: 332976

Committed r228018: &lt;https://trac.webkit.org/changeset/228018&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1395912</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-02-02 11:07:37 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1395913</commentid>
    <comment_count>6</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-02-02 11:08:24 -0800</bug_when>
    <thetext>&lt;rdar://problem/37162616&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>332976</attachid>
            <date>2018-02-02 09:31:42 -0800</date>
            <delta_ts>2018-02-02 11:07:35 -0800</delta_ts>
            <desc>patch</desc>
            <filename>a-backup.diff</filename>
            <type>text/plain</type>
            <size>1621</size>
            <attacher name="Saam Barati">saam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjI4MDE0KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA
CisyMDE4LTAyLTAyICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg
IE1hcEhhc2ggc2hvdWxkIHJldHVybiB0cnVlIHRvIGRvZXNHQyBpbiB0aGUgREZHIGRlcGVuZGlu
ZyBvbiB1c2VLaW5kIGJlY2F1c2UgaXQgbWlnaHQgcmVzb2x2ZSBhIHJvcGUKKyAgICAgICAgaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjQwMgorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZGZnL0RGR0RvZXNHQy5jcHA6
CisgICAgICAgIChKU0M6OkRGRzo6ZG9lc0dDKToKKwogMjAxOC0wMi0wMiAgWXVzdWtlIFN1enVr
aSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBbSlNDXSBDbGVhbiB1cCBBcnJh
eVNwZWNpZXNDcmVhdGUKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRG9lc0dD
LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0RvZXNHQy5j
cHAJKHJldmlzaW9uIDIyODAxMykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRG9l
c0dDLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjA1LDcgKzIwNSw2IEBAIGJvb2wgZG9lc0dDKEdy
YXBoJiBncmFwaCwgTm9kZSogbm9kZSkKICAgICBjYXNlIENQVUludHJpbnNpYzoKICAgICBjYXNl
IENoZWNrVHJhcHM6CiAgICAgY2FzZSBTdHJpbmdGcm9tQ2hhckNvZGU6Ci0gICAgY2FzZSBNYXBI
YXNoOgogICAgIGNhc2UgTm9ybWFsaXplTWFwS2V5OgogICAgIGNhc2UgR2V0TWFwQnVja2V0Ogog
ICAgIGNhc2UgR2V0TWFwQnVja2V0SGVhZDoKQEAgLTM1NSw2ICszNTQsMTggQEAgYm9vbCBkb2Vz
R0MoR3JhcGgmIGdyYXBoLCBOb2RlKiBub2RlKQogICAgIGNhc2UgU2V0QWRkOgogICAgIGNhc2Ug
TWFwU2V0OgogICAgICAgICByZXR1cm4gdHJ1ZTsKKworICAgIGNhc2UgTWFwSGFzaDoKKyAgICAg
ICAgc3dpdGNoIChub2RlLT5jaGlsZDEoKS51c2VLaW5kKCkpIHsKKyAgICAgICAgY2FzZSBCb29s
ZWFuVXNlOgorICAgICAgICBjYXNlIEludDMyVXNlOgorICAgICAgICBjYXNlIFN5bWJvbFVzZToK
KyAgICAgICAgY2FzZSBPYmplY3RVc2U6CisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAg
ICAgIGRlZmF1bHQ6CisgICAgICAgICAgICAvLyBXZSBtaWdodCByZXNvbHZlIGEgcm9wZS4KKyAg
ICAgICAgICAgIHJldHVybiB0cnVlOworICAgICAgICB9CiAgICAgICAgIAogICAgIGNhc2UgTXVs
dGlQdXRCeU9mZnNldDoKICAgICAgICAgcmV0dXJuIG5vZGUtPm11bHRpUHV0QnlPZmZzZXREYXRh
KCkucmVhbGxvY2F0ZXNTdG9yYWdlKCk7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>