182389 2018-02-01 08:05:15 -0800 -Wreturn-type warning in DFGObjectAllocationSinkingPhase.cpp 2018-02-01 09:29:06 -0800 1 1 1 Unclassified WebKit JavaScriptCore Other PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro commit-queue ews-watchlist keith_miller mark.lam mcatanzaro msaboff saam webkit-bug-importer ysuzuki oldest_to_newest 1395467 0 mcatanzaro 2018-02-01 08:05:15 -0800 -Wreturn-type warning in DFGObjectAllocationSinkingPhase.cpp: [1296/3695] Building CXX object Source.../unified-sources/UnifiedSource48.cpp.o In file included from DerivedSources/JavaScriptCore/unified-sources/UnifiedSource48.cpp:2:0: ../../Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp: In member function ‘JSC::DFG::Node* JSC::DFG::{anonymous}::ObjectAllocationSinkingPhase::createRecovery(JSC::DFG::BasicBlock*, JSC::DFG::PromotedHeapLocation, JSC::DFG::Node*, bool&)’: ../../Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp:2336:5: warning: control reaches end of non-void function [-Wreturn-type] } ^ 1395468 1 332878 mcatanzaro 2018-02-01 08:07:35 -0800 Created attachment 332878 Patch 1395469 2 332878 mcatanzaro 2018-02-01 08:10:25 -0800 Comment on attachment 332878 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332878&action=review > Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp:-1535 > - break; I dunno why these breaks were here, but they're right after return statements, so they can never be reached. It's unrelated to the warning; I can leave them if this is considered desirable code style. > Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp:2329 > DFG_CRASH(m_graph, base, "Bad location kind"); > break; Could get rid of this break, too. > Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp:2332 > + RELEASE_ASSERT_NOT_REACHED(); This is what's actually needed to silence the warning. 1395471 3 mcatanzaro 2018-02-01 08:11:28 -0800 (In reply to Michael Catanzaro from comment #2) > This is what's actually needed to silence the warning. Alternative would be to move the DFG_CRASH() down out of the switch case, but I figure it's a bit more clear this way. 1395482 4 332878 ysuzuki 2018-02-01 08:46:41 -0800 Comment on attachment 332878 Patch r=me 1395513 5 332878 commit-queue 2018-02-01 09:27:10 -0800 Comment on attachment 332878 Patch Clearing flags on attachment: 332878 Committed r227970: <https://trac.webkit.org/changeset/227970> 1395514 6 commit-queue 2018-02-01 09:27:11 -0800 All reviewed patches have been landed. Closing bug. 1395515 7 webkit-bug-importer 2018-02-01 09:29:06 -0800 <rdar://problem/37118957> 332878 2018-02-01 08:07:35 -0800 2018-02-01 09:27:10 -0800 Patch bug-182389-20180201100734.patch text/plain 2523 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3OTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 ZDkzYTllNTAwOWQ3YzkxODEzNzhkOGIzZGRlNDgzOWM1ZmViNDM5Li45NTk4OTY3OWY1NzIzZjQy OTg5YTNiYjc1Yzc1ZTczNGNiY2JhZmVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOC0wMi0wMSAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGln YWxpYS5jb20+CisKKyAgICAgICAgLVdyZXR1cm4tdHlwZSB3YXJuaW5nIGluIERGR09iamVjdEFs bG9jYXRpb25TaW5raW5nUGhhc2UuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xODIzODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGaXggdGhlIHdhcm5pbmcuCisKKyAgICAgICAgQXMgYSBib251cywg cmVtb3ZlIGEgY291cGxlIHVucmVhY2hhYmxlIGJyZWFrcyBmb3IgZ29vZCBtZWFzdXJlLgorCisg ICAgICAgICogZGZnL0RGR09iamVjdEFsbG9jYXRpb25TaW5raW5nUGhhc2UuY3BwOgorCiAyMDE4 LTAyLTAxICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgUXVldWUg YSBtaWNyb3Rhc2sgd2hlbiBhIHdhaXRVbnRpbCgpIHByb21pc2UgaXMgc2V0dGxlZApkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPYmplY3RBbGxvY2F0aW9uU2lua2lu Z1BoYXNlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT2JqZWN0QWxsb2NhdGlv blNpbmtpbmdQaGFzZS5jcHAKaW5kZXggMTljZTEyNGY5NzU2NmI3YzliMzRlMjBkYjBiMjA4ZWZm YjViNTllZC4uOTEyMzdhY2JiYjA1MjQzOThjYmZiNWI1ZGI0NzAwMjAyOGQ5OGI1NiAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPYmplY3RBbGxvY2F0aW9uU2lua2lu Z1BoYXNlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09iamVjdEFsbG9j YXRpb25TaW5raW5nUGhhc2UuY3BwCkBAIC0xNTMyLDcgKzE1MzIsNiBAQCBwcml2YXRlOgogICAg ICAgICAgICAgICAgIHdoZXJlLT5vcmlnaW4ud2l0aFNlbWFudGljKAogICAgICAgICAgICAgICAg ICAgICBhbGxvY2F0aW9uLmlkZW50aWZpZXIoKS0+b3JpZ2luLnNlbWFudGljKSwKICAgICAgICAg ICAgICAgICBPcEluZm8oZXhlY3V0YWJsZSkpOwotICAgICAgICAgICAgYnJlYWs7CiAgICAgICAg IH0KIAogICAgICAgICBjYXNlIEFsbG9jYXRpb246OktpbmQ6OkFjdGl2YXRpb246IHsKQEAgLTE1 NTMsNyArMTU1Miw2IEBAIHByaXZhdGU6CiAgICAgICAgICAgICAgICAgd2hlcmUtPm9yaWdpbi53 aXRoU2VtYW50aWMoCiAgICAgICAgICAgICAgICAgICAgIGFsbG9jYXRpb24uaWRlbnRpZmllcigp LT5vcmlnaW4uc2VtYW50aWMpLAogICAgICAgICAgICAgICAgIE9wSW5mbyhyZWdFeHApKTsKLSAg ICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAKICAgICAgICAgZGVmYXVsdDoKQEAgLTIzMDYs NyArMjMwNCw2IEBAIHByaXZhdGU6CiAgICAgICAgICAgICAgICAgT3BJbmZvKGRhdGEpLAogICAg ICAgICAgICAgICAgIEVkZ2UoYmFzZSwgS25vd25DZWxsVXNlKSwKICAgICAgICAgICAgICAgICB2 YWx1ZS0+ZGVmYXVsdEVkZ2UoKSk7Ci0gICAgICAgICAgICBicmVhazsKICAgICAgICAgfQogCiAg ICAgICAgIGNhc2UgQ2xvc3VyZVZhclBMb2M6IHsKQEAgLTIzMTYsNyArMjMxMyw2IEBAIHByaXZh dGU6CiAgICAgICAgICAgICAgICAgT3BJbmZvKGxvY2F0aW9uLmluZm8oKSksCiAgICAgICAgICAg ICAgICAgRWRnZShiYXNlLCBLbm93bkNlbGxVc2UpLAogICAgICAgICAgICAgICAgIHZhbHVlLT5k ZWZhdWx0RWRnZSgpKTsKLSAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAKICAgICAgICAg Y2FzZSBSZWdFeHBPYmplY3RMYXN0SW5kZXhQTG9jOiB7CkBAIC0yMzI2LDEzICsyMzIyLDE0IEBA IHByaXZhdGU6CiAgICAgICAgICAgICAgICAgT3BJbmZvKHRydWUpLAogICAgICAgICAgICAgICAg IEVkZ2UoYmFzZSwgS25vd25DZWxsVXNlKSwKICAgICAgICAgICAgICAgICB2YWx1ZS0+ZGVmYXVs dEVkZ2UoKSk7Ci0gICAgICAgICAgICBicmVhazsKICAgICAgICAgfQogCiAgICAgICAgIGRlZmF1 bHQ6CiAgICAgICAgICAgICBERkdfQ1JBU0gobV9ncmFwaCwgYmFzZSwgIkJhZCBsb2NhdGlvbiBr aW5kIik7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQorCisgICAgICAgIFJFTEVBU0Vf QVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgfQogCiAgICAgLy8gVGhpcyBpcyBhIGdyZWF0IHdh eSBvZiBhc2tpbmcgdmFsdWUtPmlzU3RpbGxWYWxpZCgpIHdpdGhvdXQgaGF2aW5nIHRvIHdvcnJ5 IGFib3V0IGdldHRpbmcK