18237 2008-03-31 10:26:28 -0700 wrong unref of m_frame causes segfault 2017-03-11 10:55:52 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux UNCONFIRMED P2 Normal --- 20403 0 iwkse webkit-unassigned bugs-noreply oldest_to_newest 75937 0 iwkse 2008-03-31 10:26:28 -0700 m_frame is unref without checking if it's null and it causes a segfault 75938 1 20237 iwkse 2008-03-31 10:27:33 -0700 Created attachment 20237 m_frame unref 75943 2 20237 darin 2008-03-31 10:48:48 -0700 Comment on attachment 20237 m_frame unref This looks wrong to me. I don't think this should be done in these detachedFromParent calls, and certainly not in both the (1) and (2) versions! 75949 3 iwkse 2008-03-31 11:07:08 -0700 (In reply to comment #2) > (From update of attachment 20237 [edit]) > This looks wrong to me. I don't think this should be done in these > detachedFromParent calls, and certainly not in both the (1) and (2) versions! > Actually the only one was the (4) and it segfaulted. Adding the check on m_frame fixed it. I thought it would work similar with the others but I did not find anybody to explain to me how it works with frames. So keep it as WORKSFORME and feel free to update the patch. 77221 4 20237 mrowe 2008-04-10 17:47:47 -0700 Comment on attachment 20237 m_frame unref r- based on Darin's comment. 20237 2008-03-31 10:27:33 -0700 2010-06-10 15:57:37 -0700 m_frame unref m_frame.diff text/plain 1097 iwkse SW5kZXg6IFdlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRHdGsuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGll bnRHdGsuY3BwCShyZXZpc2lvbiAzMTQ1NykKKysrIFdlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQv RnJhbWVMb2FkZXJDbGllbnRHdGsuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NDIsMjQgKzQ0Miwz OCBAQAogCiB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50OjpkZXRhY2hlZEZyb21QYXJlbnQxKCkKIHsK LSAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIEFTU0VSVChtX2ZyYW1lKTsKKyAgICBpZiAobV9m cmFtZSkgeworICAgICAgICBnX29iamVjdF91bnJlZihtX2ZyYW1lKTsKKyAgICAgICAgbV9mcmFt ZSA9IDA7CisgICAgfQogfQogCiB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50OjpkZXRhY2hlZEZyb21Q YXJlbnQyKCkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIEFTU0VSVChtX2ZyYW1lKTsK KyAgICBpZiAobV9mcmFtZSkgeworICAgICAgICBnX29iamVjdF91bnJlZihtX2ZyYW1lKTsKKyAg ICAgICAgbV9mcmFtZSA9IDA7CisgICAgfQogfQogCiB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50Ojpk ZXRhY2hlZEZyb21QYXJlbnQzKCkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIEFTU0VS VChtX2ZyYW1lKTsKKyAgICBpZiAobV9mcmFtZSkgeworICAgICAgICBnX29iamVjdF91bnJlZiht X2ZyYW1lKTsKKyAgICAgICAgbV9mcmFtZSA9IDA7CisgICAgfQogfQogCiB2b2lkIEZyYW1lTG9h ZGVyQ2xpZW50OjpkZXRhY2hlZEZyb21QYXJlbnQ0KCkKIHsKICAgICBBU1NFUlQobV9mcmFtZSk7 Ci0gICAgZ19vYmplY3RfdW5yZWYobV9mcmFtZSk7Ci0gICAgbV9mcmFtZSA9IDA7CisgICAgaWYg KG1fZnJhbWUpIHsKKyAgICAgICAgZ19vYmplY3RfdW5yZWYobV9mcmFtZSk7CisgICAgICAgIG1f ZnJhbWUgPSAwOworICAgIH0KIH0KIAogdm9pZCBGcmFtZUxvYWRlckNsaWVudDo6bG9hZGVkRnJv bUNhY2hlZFBhZ2UoKQo=