<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>182341</bug_id>
          
          <creation_ts>2018-01-31 11:01:43 -0800</creation_ts>
          <short_desc>Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https.html is flaky</short_desc>
          <delta_ts>2021-09-17 10:31:41 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Service Workers</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>182054</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Matt Lewis">jlewis3</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>beidson</cc>
    
    <cc>cdumez</cc>
    
    <cc>ehutchison</cc>
    
    <cc>ryanhaddad</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1395067</commentid>
    <comment_count>0</comment_count>
    <who name="Matt Lewis">jlewis3</who>
    <bug_when>2018-01-31 11:01:43 -0800</bug_when>
    <thetext>The following layout test is flaky on macOS WK2

imported/w3c/web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https.html


Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&amp;tests=imported%2Fw3c%2Fweb-platform-tests%2Fservice-workers%2Fservice-worker%2Fclients-matchall-client-types.https.html

The test has changed diffs recently but has been flaky since this build: https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/builds/1408

the diff at first was:

--- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https-expected.txt
+++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https-actual.txt
@@ -1,5 +1,7 @@
 
 
-PASS Verify matchAll() with window client type 
-FAIL Verify matchAll() with {window, sharedworker, worker} client types promise_test: Unhandled rejection with value: object &quot;ReferenceError: Can&apos;t find variable: SharedWorker&quot;
+Harness Error (TIMEOUT), message = null
 
+TIMEOUT Verify matchAll() with window client type Test timed out
+NOTRUN Verify matchAll() with {window, sharedworker, worker} client types 
+

But the diff changed to this:

--- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https-actual.txt
@@ -1,5 +1,4 @@
-
 
 PASS Verify matchAll() with window client type 
-FAIL Verify matchAll() with {window, sharedworker, worker} client types promise_test: Unhandled rejection with value: object &quot;ReferenceError: Can&apos;t find variable: SharedWorker&quot;
+FAIL Verify matchAll() with {window, sharedworker, worker} client types promise_test: Unhandled rejection with value: object &quot;Error: wait_for_state must be passed a ServiceWorker&quot;


Current build:

https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r227901%20(2645)/results.html
https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/builds/2645</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1396896</commentid>
    <comment_count>1</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2018-02-06 12:32:28 -0800</bug_when>
    <thetext>&gt; ReferenceError: Can&apos;t find variable: SharedWorker

Looks pretty crazy. Also, this test asserts in debug builds. What&apos;s the next step here?

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.JavaScriptCore      	0x00000001050ce404 WTFCrash + 36 (Assertions.cpp:272)
1   com.apple.WebCore             	0x000000010fac028c WebCore::MessagePortChannel::entanglePortWithProcess(WebCore::MessagePortIdentifier const&amp;, WTF::ObjectIdentifier&lt;WebCore::ProcessIdentifierType&gt;) + 524 (MessagePortChannel.cpp:87)
2   com.apple.WebCore             	0x000000010fac2a43 WebCore::MessagePortChannelRegistry::didEntangleLocalToRemote(WebCore::MessagePortIdentifier const&amp;, WebCore::MessagePortIdentifier const&amp;, WTF::ObjectIdentifier&lt;WebCore::ProcessIdentifierType&gt;) + 211 (MessagePortChannelRegistry.cpp:91)
3   com.apple.WebKit              	0x00000001097def7c WebKit::WebProcessProxy::entangleLocalPortInThisProcessToRemote(WebCore::MessagePortIdentifier const&amp;, WebCore::MessagePortIdentifier const&amp;) + 156 (WebProcessProxy.cpp:1275)
4   com.apple.WebKit              	0x000000010980f369 void IPC::callMemberFunctionImpl&lt;WebKit::WebProcessProxy, void (WebKit::WebProcessProxy::*)(WebCore::MessagePortIdentifier const&amp;, WebCore::MessagePortIdentifier const&amp;), std::__1::tuple&lt;WebCore::MessagePortIdentifier, WebCore::MessagePortIdentifier&gt;, 0ul, 1ul&gt;(WebKit::WebProcessProxy*, void (WebKit::WebProcessProxy::*)(WebCore::MessagePortIdentifier const&amp;, WebCore::MessagePortIdentifier const&amp;), std::__1::tuple&lt;WebCore::MessagePortIdentifier, WebCore::MessagePortIdentifier&gt;&amp;&amp;, std::__1::integer_sequence&lt;unsigned long, 0ul, 1ul&gt;) + 185 (HandleMessage.h:41)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1396897</commentid>
    <comment_count>2</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-02-06 12:32:53 -0800</bug_when>
    <thetext>&lt;rdar://problem/37284563&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1396898</commentid>
    <comment_count>3</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2018-02-06 12:44:29 -0800</bug_when>
    <thetext>(In reply to Alexey Proskuryakov from comment #1)
&gt; &gt; ReferenceError: Can&apos;t find variable: SharedWorker

We started to skip SharedWorker related tests but this one is doing more than SharedWorker.
Maybe we should tweak WPT testharness/serviceworker infra to check for SharedWorker and if so try starting to create one, otherwise fail gracefully.

&gt; Looks pretty crazy. Also, this test asserts in debug builds. What&apos;s the next
&gt; step here?
&gt; 
&gt; Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
&gt; 0   com.apple.JavaScriptCore      	0x00000001050ce404 WTFCrash + 36
&gt; (Assertions.cpp:272)
&gt; 1   com.apple.WebCore             	0x000000010fac028c
&gt; WebCore::MessagePortChannel::entanglePortWithProcess(WebCore::
&gt; MessagePortIdentifier const&amp;,
&gt; WTF::ObjectIdentifier&lt;WebCore::ProcessIdentifierType&gt;) + 524
&gt; (MessagePortChannel.cpp:87)
&gt; 2   com.apple.WebCore             	0x000000010fac2a43
&gt; WebCore::MessagePortChannelRegistry::didEntangleLocalToRemote(WebCore::
&gt; MessagePortIdentifier const&amp;, WebCore::MessagePortIdentifier const&amp;,
&gt; WTF::ObjectIdentifier&lt;WebCore::ProcessIdentifierType&gt;) + 211
&gt; (MessagePortChannelRegistry.cpp:91)
&gt; 3   com.apple.WebKit              	0x00000001097def7c
&gt; WebKit::WebProcessProxy::entangleLocalPortInThisProcessToRemote(WebCore::
&gt; MessagePortIdentifier const&amp;, WebCore::MessagePortIdentifier const&amp;) + 156
&gt; (WebProcessProxy.cpp:1275)
&gt; 4   com.apple.WebKit              	0x000000010980f369 void
&gt; IPC::callMemberFunctionImpl&lt;WebKit::WebProcessProxy, void
&gt; (WebKit::WebProcessProxy::*)(WebCore::MessagePortIdentifier const&amp;,
&gt; WebCore::MessagePortIdentifier const&amp;),
&gt; std::__1::tuple&lt;WebCore::MessagePortIdentifier,
&gt; WebCore::MessagePortIdentifier&gt;, 0ul, 1ul&gt;(WebKit::WebProcessProxy*, void
&gt; (WebKit::WebProcessProxy::*)(WebCore::MessagePortIdentifier const&amp;,
&gt; WebCore::MessagePortIdentifier const&amp;),
&gt; std::__1::tuple&lt;WebCore::MessagePortIdentifier,
&gt; WebCore::MessagePortIdentifier&gt;&amp;&amp;, std::__1::integer_sequence&lt;unsigned long,
&gt; 0ul, 1ul&gt;) + 185 (HandleMessage.h:41)

This is probably bug 182054.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1398176</commentid>
    <comment_count>4</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2018-02-09 17:14:08 -0800</bug_when>
    <thetext>Marked test as flaky in https://trac.webkit.org/changeset/228348/webkit</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1794493</commentid>
    <comment_count>5</comment_count>
    <who name="Eric Hutchison">ehutchison</who>
    <bug_when>2021-09-17 10:31:41 -0700</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 182054 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>