182316 2018-01-30 16:46:37 -0800 com.apple.WebKit.Storage crashing at com.apple.WebCore: WebCore::SWServerRegistration::removeClientUsingRegistration 2018-01-31 11:14:57 -0800 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf beidson cdumez commit-queue webkit-bug-importer oldest_to_newest 1394834 0 youennf 2018-01-30 16:46:37 -0800 com.apple.WebKit.Storage crashing at com.apple.WebCore: WebCore::SWServerRegistration::removeClientUsingRegistration. This means SWServer.m_clientToControllingWorker and m_clientsUsingRegistration might currently get out of sync. 1394835 1 youennf 2018-01-30 16:47:20 -0800 <rdar://problem/37025976> 1394836 2 332724 youennf 2018-01-30 16:49:52 -0800 Created attachment 332724 Patch 1395015 3 332724 cdumez 2018-01-31 09:19:54 -0800 Comment on attachment 332724 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332724&action=review > Source/WebCore/workers/service/server/SWServerRegistration.cpp:184 > + if (iterator != m_clientsUsingRegistration.end()) { I would just return early. I don't think we should run handleClientUnload() if we did not really remove a client. handleClientUnload() relies on m_clientsUsingRegistration which technically has not changed. 1395019 4 332767 youennf 2018-01-31 09:25:07 -0800 Created attachment 332767 Patch for landing 1395078 5 332767 commit-queue 2018-01-31 11:14:56 -0800 Comment on attachment 332767 Patch for landing Clearing flags on attachment: 332767 Committed r227909: <https://trac.webkit.org/changeset/227909> 1395079 6 commit-queue 2018-01-31 11:14:57 -0800 All reviewed patches have been landed. Closing bug. 332724 2018-01-30 16:49:52 -0800 2018-01-31 09:25:05 -0800 Patch bug-182316-20180130164952.patch text/plain 2380 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3Nzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGM3MzVjMjZmODdhOWQ2 ZGFlNGM0ZjBkZTQ0ZWM0MTE2OWZmYWU0NS4uZWE3MWUyYjY3NmQwMWRlYjhkNGNkMjI0ZGJmY2Jh N2ExMjUyYTI4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTAxLTMwICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBjb20uYXBwbGUuV2ViS2l0 LlN0b3JhZ2UgY3Jhc2hpbmcgYXQgY29tLmFwcGxlLldlYkNvcmU6IFdlYkNvcmU6OlNXU2VydmVy UmVnaXN0cmF0aW9uOjpyZW1vdmVDbGllbnRVc2luZ1JlZ2lzdHJhdGlvbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyMzE2CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8zNzAyNTk3Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBTV1NlcnZlci5tX2NsaWVudFRvQ29udHJvbGxpbmdXb3JrZXIgYW5kIFNX U2VydmVyUmVnaXN0cmF0aW9uLm1fY2xpZW50c1VzaW5nUmVnaXN0cmF0aW9uIG1pZ2h0IGN1cnJl bnRseSBnZXQgb3V0IG9mIHN5bmMuCisgICAgICAgIFRoaXMgaXMgYSBkZWZlbnNpdmUgZml4IHRv IGVuc3VyZSBzdG9yYWdlIHByb2Nlc3Mgd2lsbCBub3QgY3Jhc2ggaW4gUmVsZWFzZS4KKyAgICAg ICAgV2Uga2VlcCB0aGUgQVNTRVJUIGFzIHRoaXMgcHJvYmFibHkgbWVhbnMgdGhlcmUgaXMgYW4g YWJub3JtYWwgc2l0dWF0aW9uIHRoYXQgb3RoZXIgcGF0Y2hlcyBtaWdodCBmaXguCisKKyAgICAg ICAgKiB3b3JrZXJzL3NlcnZpY2Uvc2VydmVyL1NXU2VydmVyUmVnaXN0cmF0aW9uLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlNXU2VydmVyUmVnaXN0cmF0aW9uOjpyZW1vdmVDbGllbnRVc2luZ1Jl Z2lzdHJhdGlvbik6CisKIDIwMTgtMDEtMzAgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUu Y29tPgogCiAgICAgICAgIENsaWVudHMgc2hvdWxkIHJlZ2lzdGVyIHRvIFN0b3JhZ2VQcm9jZXNz IHdpdGggdGhlaXIgc2VydmljZSB3b3JrZXIgcmVnaXN0cmF0aW9uIGlkZW50aWZpZXIKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXJSZWdp c3RyYXRpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL3NlcnZlci9TV1Nl cnZlclJlZ2lzdHJhdGlvbi5jcHAKaW5kZXggNGZiYTNmM2M0MzNkNThmMjAyMmVkZDAzZDI0MDY3 ZjIxYzQ2M2VjZS4uMmU4MTVlNGNkYzhlN2RlNzNkOWYyZmE2M2I4N2MzMmM2MTYyN2MzYSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL3NlcnZlci9TV1NlcnZlclJl Z2lzdHJhdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL3NlcnZl ci9TV1NlcnZlclJlZ2lzdHJhdGlvbi5jcHAKQEAgLTE4MSwxMiArMTgxLDEzIEBAIHZvaWQgU1dT ZXJ2ZXJSZWdpc3RyYXRpb246OnJlbW92ZUNsaWVudFVzaW5nUmVnaXN0cmF0aW9uKGNvbnN0IFNl cnZpY2VXb3JrZXJDbGllCiB7CiAgICAgYXV0byBpdGVyYXRvciA9IG1fY2xpZW50c1VzaW5nUmVn aXN0cmF0aW9uLmZpbmQoY2xpZW50SWRlbnRpZmllci5zZXJ2ZXJDb25uZWN0aW9uSWRlbnRpZmll cik7CiAgICAgQVNTRVJUKGl0ZXJhdG9yICE9IG1fY2xpZW50c1VzaW5nUmVnaXN0cmF0aW9uLmVu ZCgpKTsKLSAgICBib29sIHdhc1JlbW92ZWQgPSBpdGVyYXRvci0+dmFsdWUucmVtb3ZlKGNsaWVu dElkZW50aWZpZXIuY29udGV4dElkZW50aWZpZXIpOwotICAgIEFTU0VSVF9VTlVTRUQod2FzUmVt b3ZlZCwgd2FzUmVtb3ZlZCk7Ci0KLSAgICBpZiAoaXRlcmF0b3ItPnZhbHVlLmlzRW1wdHkoKSkK LSAgICAgICAgbV9jbGllbnRzVXNpbmdSZWdpc3RyYXRpb24ucmVtb3ZlKGl0ZXJhdG9yKTsKKyAg ICBpZiAoaXRlcmF0b3IgIT0gbV9jbGllbnRzVXNpbmdSZWdpc3RyYXRpb24uZW5kKCkpIHsKKyAg ICAgICAgYm9vbCB3YXNSZW1vdmVkID0gaXRlcmF0b3ItPnZhbHVlLnJlbW92ZShjbGllbnRJZGVu dGlmaWVyLmNvbnRleHRJZGVudGlmaWVyKTsKKyAgICAgICAgQVNTRVJUX1VOVVNFRCh3YXNSZW1v dmVkLCB3YXNSZW1vdmVkKTsKIAorICAgICAgICBpZiAoaXRlcmF0b3ItPnZhbHVlLmlzRW1wdHko KSkKKyAgICAgICAgICAgIG1fY2xpZW50c1VzaW5nUmVnaXN0cmF0aW9uLnJlbW92ZShpdGVyYXRv cik7CisgICAgfQogICAgIGhhbmRsZUNsaWVudFVubG9hZCgpOwogfQogCg== 332767 2018-01-31 09:25:07 -0800 2018-01-31 11:14:56 -0800 Patch for landing bug-182316-20180131092505.patch text/plain 2005 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3OTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzI1Nzk2Yzg3MmQ4YzEw ZTlkN2UxNWIxOGNjN2M0YmNiNzJlMWM1OC4uMzNmNGUyMDZhMWYzNjI4M2MzYjRlZWI0Mjk2Zjk0 MTg4MDllZDVlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTAxLTMxICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBjb20uYXBwbGUuV2ViS2l0 LlN0b3JhZ2UgY3Jhc2hpbmcgYXQgY29tLmFwcGxlLldlYkNvcmU6IFdlYkNvcmU6OlNXU2VydmVy UmVnaXN0cmF0aW9uOjpyZW1vdmVDbGllbnRVc2luZ1JlZ2lzdHJhdGlvbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyMzE2CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8zNzAyNTk3Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBDaHJpcyBEdW1lei4K KworICAgICAgICBTV1NlcnZlci5tX2NsaWVudFRvQ29udHJvbGxpbmdXb3JrZXIgYW5kIFNXU2Vy dmVyUmVnaXN0cmF0aW9uLm1fY2xpZW50c1VzaW5nUmVnaXN0cmF0aW9uIG1pZ2h0IGN1cnJlbnRs eSBnZXQgb3V0IG9mIHN5bmMuCisgICAgICAgIFRoaXMgaXMgYSBkZWZlbnNpdmUgZml4IHRvIGVu c3VyZSBzdG9yYWdlIHByb2Nlc3Mgd2lsbCBub3QgY3Jhc2ggaW4gUmVsZWFzZS4KKyAgICAgICAg V2Uga2VlcCB0aGUgQVNTRVJUIGFzIHRoaXMgcHJvYmFibHkgbWVhbnMgdGhlcmUgaXMgYW4gYWJu b3JtYWwgc2l0dWF0aW9uIHRoYXQgb3RoZXIgcGF0Y2hlcyBtaWdodCBmaXguCisKKyAgICAgICAg KiB3b3JrZXJzL3NlcnZpY2Uvc2VydmVyL1NXU2VydmVyUmVnaXN0cmF0aW9uLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlNXU2VydmVyUmVnaXN0cmF0aW9uOjpyZW1vdmVDbGllbnRVc2luZ1JlZ2lz dHJhdGlvbik6CisKIDIwMTgtMDEtMzEgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29t PgogCiAgICAgICAgIENoYW5nZSBTV1NlcnZlcjo6Y2xhaW0gdG8gc2V0IHRoZSBpdGVyYXRvciB2 YWx1ZSBhcyBzb29uIGFzIHBvc3NpYmxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93b3Jr ZXJzL3NlcnZpY2Uvc2VydmVyL1NXU2VydmVyUmVnaXN0cmF0aW9uLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3dvcmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXJSZWdpc3RyYXRpb24uY3BwCmluZGV4 IGE1NjVkZmU0MDdmNjE2NDAwOGNiNTM0ZDU3YTM1ZTNkYWJlZGRkYTUuLjNhZTgzY2RjOWY2ZDZk MGVjMzRlZTA0NjY3MGM5MGVhMmM4NGEwNzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dv cmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXJSZWdpc3RyYXRpb24uY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXJSZWdpc3RyYXRpb24uY3Bw CkBAIC0xODEsNiArMTgxLDkgQEAgdm9pZCBTV1NlcnZlclJlZ2lzdHJhdGlvbjo6cmVtb3ZlQ2xp ZW50VXNpbmdSZWdpc3RyYXRpb24oY29uc3QgU2VydmljZVdvcmtlckNsaWUKIHsKICAgICBhdXRv IGl0ZXJhdG9yID0gbV9jbGllbnRzVXNpbmdSZWdpc3RyYXRpb24uZmluZChjbGllbnRJZGVudGlm aWVyLnNlcnZlckNvbm5lY3Rpb25JZGVudGlmaWVyKTsKICAgICBBU1NFUlQoaXRlcmF0b3IgIT0g bV9jbGllbnRzVXNpbmdSZWdpc3RyYXRpb24uZW5kKCkpOworICAgIGlmIChpdGVyYXRvciA9PSBt X2NsaWVudHNVc2luZ1JlZ2lzdHJhdGlvbi5lbmQoKSkKKyAgICAgICAgcmV0dXJuOworCiAgICAg Ym9vbCB3YXNSZW1vdmVkID0gaXRlcmF0b3ItPnZhbHVlLnJlbW92ZShjbGllbnRJZGVudGlmaWVy LmNvbnRleHRJZGVudGlmaWVyKTsKICAgICBBU1NFUlRfVU5VU0VEKHdhc1JlbW92ZWQsIHdhc1Jl bW92ZWQpOwogCg==