182307 2018-01-30 13:49:40 -0800 [iOS] API test UIPasteboardTests.DataTransferGetDataWhenPastingPlatformRepresentations fails after r223440 2018-01-30 15:06:03 -0800 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh commit-queue rniwa ryanhaddad thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1394721 0 wenson_hsieh 2018-01-30 13:49:40 -0800 After <https://trac.webkit.org/r223440>, we now always deliver sanitized markup if the page asks for "text/html" from a DataTransfer. UIPasteboardTests.DataTransferGetDataWhenPastingPlatformRepresentations writes "public.html" to the UIPasteboard using platform API, and then checks for the value of DataTransfer.getData('text/html') when pasting. After r223440, the requested HTML now contains inline styles, where it was simply the markup string written by the platform before. 1394722 1 wenson_hsieh 2018-01-30 13:49:59 -0800 <rdar://problem/36041485> 1394762 2 wenson_hsieh 2018-01-30 14:22:25 -0800 This is very similar to the existing tests PasteHTML.SanitizesHTML (and PasteWebArchive.SanitizesHTML, which is for macOS only). In both cases, we're writing web content to the pasteboard via platform API, and then expecting sanitized markup for "text/html". Both the aforementioned tests are indifferent to specific inline styles captured in the sanitized markup, so this failing test should be updated to match. 1394773 3 332709 wenson_hsieh 2018-01-30 14:28:12 -0800 Created attachment 332709 Patch 1394775 4 332709 wenson_hsieh 2018-01-30 14:32:36 -0800 Comment on attachment 332709 Patch Thanks for the review! 1394790 5 332709 commit-queue 2018-01-30 15:06:01 -0800 Comment on attachment 332709 Patch Clearing flags on attachment: 332709 Committed r227859: <https://trac.webkit.org/changeset/227859> 1394791 6 commit-queue 2018-01-30 15:06:03 -0800 All reviewed patches have been landed. Closing bug. 332709 2018-01-30 14:28:12 -0800 2018-01-30 15:06:01 -0800 Patch bug-182307-20180130142811.patch text/plain 4698 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3Nzg4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTRjY2IxZDVhYjc0NjgzZTA3N2E1NmYyZGJhMjVkMzI3 YzRiOWI2YS4uYjcxMTE4ODVjMmZlYmYzNWJhOGI5ODcyMzFhZWQ4NzcxZjA4ODFkZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDE4LTAxLTMwICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgor CisgICAgICAgIFtpT1NdIEFQSSB0ZXN0IFVJUGFzdGVib2FyZFRlc3RzLkRhdGFUcmFuc2Zlckdl dERhdGFXaGVuUGFzdGluZ1BsYXRmb3JtUmVwcmVzZW50YXRpb25zIGZhaWxzIGFmdGVyIHIyMjM0 NDAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjMw NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzYwNDE0ODU+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRqdXN0cyBhIGZhaWxpbmcgQVBJIHRlc3Qg dGhhdCB3ZSBmb3Jnb3QgdG8gcmViYXNlbGluZSBhZnRlciByMjIzNDQwLCB3aGljaCBlbnN1cmVz IHRoYXQgdGhlIHJlc3VsdCBvZiByZWFkaW5nCisgICAgICAgICJ0ZXh0L2h0bWwiIGZyb20gdGhl IERhdGFUcmFuc2ZlciBpcyBzYW5pdGl6ZWQgbWFya3VwLiBUbyBkbyB0aGlzLCB0ZWFjaCB0aGUg dGVzdCBoYXJuZXNzCisgICAgICAgIChkdW1wLWRhdGF0cmFuc2Zlci10eXBlcy5odG1sKSB0byBp Z25vcmUgaW5saW5lIHN0eWxlcyBpbiBtYXJrdXAgaWYgYSBmbGFnIGlzIHNldCwgYW5kIHRoZW4g c2V0IHRoYXQgZmxhZyBpbgorICAgICAgICBVSVBhc3RlYm9hcmRUZXN0cy5EYXRhVHJhbnNmZXJH ZXREYXRhV2hlblBhc3RpbmdQbGF0Zm9ybVJlcHJlc2VudGF0aW9ucy4KKworICAgICAgICAqIFRl c3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvZHVtcC1kYXRhdHJhbnNmZXItdHlwZXMuaHRt bDoKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL2lvcy9VSVBhc3RlYm9hcmRUZXN0cy5t bToKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgorCiAyMDE4LTAxLTMwICBTZXJnaW8g VmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXZWJWUl1bR1RL XVtXUEVdIEV4Y2x1ZGUgT3BlblZSIGZyb20gdGFyYmFsbHMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rl c3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvZHVtcC1kYXRhdHJhbnNmZXItdHlwZXMuaHRt bCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvZHVtcC1kYXRhdHJhbnNm ZXItdHlwZXMuaHRtbAppbmRleCBiNzMwYTFkMWM4OTcxNzQxYTYwNmE4OGYyNmZkYTFkOTk3OWE3 ZmQzLi5kNmUzNTQyOGY5YzQ5NmU3YTk4OGJmYjczOGRhNmQ0NDA0ZjY1YjQyIDEwMDY0NAotLS0g YS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL2R1bXAtZGF0YXRyYW5zZmVy LXR5cGVzLmh0bWwKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9k dW1wLWRhdGF0cmFuc2Zlci10eXBlcy5odG1sCkBAIC01NSw2ICs1NSw5IEBAIHJlc3VsdCA9IHt9 OwogLy8gU2V0dGluZyB0aGlzIGZsYWcgdG8gYHRydWVgIGFsbG93cyB0aGUgcGFnZSB0byB3cml0 ZSBjdXN0b20gTUlNRSB0eXBlcyB2aWEgdGhlIERhdGFUcmFuc2ZlciB3aGVuIGRyYWdnaW5nIG9y IGNvcHlpbmcuCiB3cml0ZUN1c3RvbURhdGEgPSBmYWxzZTsKIAorLy8gU2V0dGluZyB0aGlzIGZs YWcgdG8gYHRydWVgIHN0cmlwcyBvdXQgaW5saW5lIHN0eWxlcyBpbiBtYXJrdXAgZ2VuZXJhdGVk IHdoZW4gZ2V0dGluZyAidGV4dC9odG1sIiBmcm9tIGEgRGF0YVRyYW5zZmVyLgoraWdub3JlSW5s aW5lU3R5bGVzID0gZmFsc2U7CisKIC8vIEVudHJpZXMgaW4gdGhpcyBkaWN0aW9uYXJ5IHdpbGwg YmUgc3VwcGxpZWQgYXMgY3VzdG9tIGRhdGEgdXNpbmcgRGF0YVRyYW5zZmVyLnNldERhdGEgd2hl biBkcmFnZ2luZyBvciBjb3B5aW5nLgogLy8gVGhpcyBpcyBwcmVwb3B1bGF0ZWQgd2l0aCBzYW1w bGUgZGF0YSBieSBkZWZhdWx0LCBidXQgdGVzdHMgbWF5IG92ZXJyaWRlIHRoaXMgYXMgbmVlZGVk LgogY3VzdG9tRGF0YSA9IHsKQEAgLTY2LDExICs2OSwyNCBAQCBjdXN0b21EYXRhID0gewogICAg ICJiYXovdXJpLWxpc3QiIDogImh0dHBzOi8vd3d3LndlYmtpdC5vcmciCiB9OwogCitmdW5jdGlv biBzdHJpcElubGluZVN0eWxlc0Zyb21QYXN0ZWJvYXJkRGF0YShkYXRhKQoreworICAgIGNvbnN0 IHBhcnNlZERvY3VtZW50ID0gbmV3IERPTVBhcnNlcigpLnBhcnNlRnJvbVN0cmluZyhkYXRhLCAi dGV4dC9odG1sIik7CisgICAgY29uc3QgdHJlZVdhbGtlciA9IHBhcnNlZERvY3VtZW50LmNyZWF0 ZVRyZWVXYWxrZXIocGFyc2VkRG9jdW1lbnQuYm9keSwgTm9kZUZpbHRlci5TSE9XX0VMRU1FTlQp OworICAgIHdoaWxlICh0cmVlV2Fsa2VyLm5leHROb2RlKCkpCisgICAgICAgIHRyZWVXYWxrZXIu Y3VycmVudE5vZGUucmVtb3ZlQXR0cmlidXRlKCJzdHlsZSIpOworICAgIHJldHVybiBwYXJzZWRE b2N1bWVudC5ib2R5LmlubmVySFRNTDsKK30KKwogZnVuY3Rpb24gdXBkYXRlUmVzdWx0V2l0aEV2 ZW50KGV2ZW50KSB7CiAgICAgbGV0IHBhc3RlYm9hcmQgPSBldmVudC5kYXRhVHJhbnNmZXIgfHwg ZXZlbnQuY2xpcGJvYXJkRGF0YTsKICAgICBjb25zdCBldmVudERhdGEgPSB7fTsKLSAgICBmb3Ig KGNvbnN0IHR5cGUgb2YgcGFzdGVib2FyZC50eXBlcykKLSAgICAgICAgZXZlbnREYXRhW3R5cGVd ID0gcGFzdGVib2FyZC5nZXREYXRhKHR5cGUpOworICAgIGZvciAoY29uc3QgdHlwZSBvZiBwYXN0 ZWJvYXJkLnR5cGVzKSB7CisgICAgICAgIGxldCBwYXN0ZWJvYXJkRGF0YSA9IHBhc3RlYm9hcmQu Z2V0RGF0YSh0eXBlKTsKKyAgICAgICAgaWYgKGlnbm9yZUlubGluZVN0eWxlcyAmJiB0eXBlID09 PSAidGV4dC9odG1sIikKKyAgICAgICAgICAgIHBhc3RlYm9hcmREYXRhID0gc3RyaXBJbmxpbmVT dHlsZXNGcm9tUGFzdGVib2FyZERhdGEocGFzdGVib2FyZERhdGEpOworICAgICAgICBldmVudERh dGFbdHlwZV0gPSBwYXN0ZWJvYXJkRGF0YTsKKyAgICB9CiAgICAgcmVzdWx0W2V2ZW50LnR5cGVd ID0gZXZlbnREYXRhOwogICAgIGlmIChldmVudC50eXBlID09PSAicGFzdGUiIHx8IGV2ZW50LnR5 cGUgPT09ICJkcm9wIikgewogICAgICAgICBvdXRwdXQudmFsdWUgPSBKU09OLnN0cmluZ2lmeShy ZXN1bHQsIG51bGwsICIgICAgIik7CmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL2lvcy9VSVBhc3RlYm9hcmRUZXN0cy5tbSBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMv aW9zL1VJUGFzdGVib2FyZFRlc3RzLm1tCmluZGV4IDBiMDU2MGNhOTFjNGIyNTY2MDMxODhmNjU0 Nzc4MjcwNzMyMTY3NmEuLjI1NTA1NjIzYzBmMTI3MzY5MzhjOTcyNjRmMTNjNzk1Y2MzYmVmNDcg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvaW9zL1VJUGFzdGVib2FyZFRl c3RzLm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvaW9zL1VJUGFzdGVib2FyZFRl c3RzLm1tCkBAIC0xNjcsMTEgKzE2NywxMiBAQCBURVNUKFVJUGFzdGVib2FyZFRlc3RzLCBEYXRh VHJhbnNmZXJHZXREYXRhV2hlblBhc3RpbmdVUkwpCiBURVNUKFVJUGFzdGVib2FyZFRlc3RzLCBE YXRhVHJhbnNmZXJHZXREYXRhV2hlblBhc3RpbmdQbGF0Zm9ybVJlcHJlc2VudGF0aW9ucykKIHsK ICAgICBhdXRvIHdlYlZpZXcgPSBzZXRVcFdlYlZpZXdGb3JQYXN0ZWJvYXJkVGVzdHMoQCJkdW1w LWRhdGF0cmFuc2Zlci10eXBlcyIpOworICAgIFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGluZ0ph dmFTY3JpcHQ6QCJpZ25vcmVJbmxpbmVTdHlsZXMgPSB0cnVlIl07CiAKICAgICAvLyBUaGlzIHNp bXVsYXRlcyBob3cgYSBuYXRpdmUgYXBwIG9uIGlPUyBtaWdodCB3cml0ZSB0byB0aGUgcGFzdGVi b2FyZCB3aGVuIGNvcHlpbmcuCiAgICAgUmV0YWluUHRyPE5TVVJMPiB0ZXN0VVJMID0gW05TVVJM IFVSTFdpdGhTdHJpbmc6QCJodHRwczovL3d3dy5hcHBsZS5jb20vIl07CiAgICAgUmV0YWluUHRy PE5TU3RyaW5nPiB0ZXN0UGxhaW5UZXh0U3RyaW5nID0gQCJXZWJLaXQiOwotICAgIFJldGFpblB0 cjxOU1N0cmluZz4gdGVzdE1hcmt1cFN0cmluZyA9IEAiPGEgaHJlZj0naHR0cHM6Ly93d3cud2Vi a2l0Lm9yZy8nPlRoZSBXZWJLaXQgUHJvamVjdDwvYT4iOworICAgIFJldGFpblB0cjxOU1N0cmlu Zz4gdGVzdE1hcmt1cFN0cmluZyA9IEAiPGEgaHJlZj1cImh0dHBzOi8vd3d3LndlYmtpdC5vcmcv XCI+VGhlIFdlYktpdCBQcm9qZWN0PC9hPiI7CiAgICAgYXV0byBpdGVtUHJvdmlkZXIgPSBhZG9w dE5TKFtbTlNJdGVtUHJvdmlkZXIgYWxsb2NdIGluaXRdKTsKICAgICBbaXRlbVByb3ZpZGVyIHJl Z2lzdGVyRGF0YVJlcHJlc2VudGF0aW9uRm9yVHlwZUlkZW50aWZpZXI6KE5TU3RyaW5nICopa1VU VHlwZUhUTUwgdmlzaWJpbGl0eTpOU0l0ZW1Qcm92aWRlclJlcHJlc2VudGF0aW9uVmlzaWJpbGl0 eUFsbCBsb2FkSGFuZGxlcjpeTlNQcm9ncmVzcyAqKERhdGFMb2FkQ29tcGxldGlvbkJsb2NrIGNv bXBsZXRpb25IYW5kbGVyKQogICAgIHsK