<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>182298</bug_id>
          
          <creation_ts>2018-01-30 09:53:15 -0800</creation_ts>
          <short_desc>Move ENABLE_POISON to Platform.h</short_desc>
          <delta_ts>2018-01-30 10:04:57 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Mark Lam">mark.lam</reporter>
          <assigned_to name="Mark Lam">mark.lam</assigned_to>
          <cc>benjamin</cc>
    
    <cc>cdumez</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>dbates</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>jfbastien</cc>
    
    <cc>msaboff</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1394596</commentid>
    <comment_count>0</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2018-01-30 09:53:15 -0800</bug_when>
    <thetext>ENABLE_POISON belongs in Platform.h to ensure that all places that depend on ENABLE(POISON) will see it properly defined.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1394598</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-01-30 09:53:50 -0800</bug_when>
    <thetext>&lt;rdar://problem/37032686&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1394599</commentid>
    <comment_count>2</comment_count>
      <attachid>332664</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2018-01-30 09:58:56 -0800</bug_when>
    <thetext>Created attachment 332664
proposed patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1394601</commentid>
    <comment_count>3</comment_count>
      <attachid>332664</attachid>
    <who name="Michael Saboff">msaboff</who>
    <bug_when>2018-01-30 10:00:19 -0800</bug_when>
    <thetext>Comment on attachment 332664
proposed patch.

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1394602</commentid>
    <comment_count>4</comment_count>
      <attachid>332664</attachid>
    <who name="JF Bastien">jfbastien</who>
    <bug_when>2018-01-30 10:00:35 -0800</bug_when>
    <thetext>Comment on attachment 332664
proposed patch.

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1394605</commentid>
    <comment_count>5</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2018-01-30 10:04:57 -0800</bug_when>
    <thetext>Thanks for the review.  Landed in r227792: &lt;http://trac.webkit.org/r227792&gt;.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>332664</attachid>
            <date>2018-01-30 09:58:56 -0800</date>
            <delta_ts>2018-01-30 10:00:19 -0800</delta_ts>
            <desc>proposed patch.</desc>
            <filename>bug-182298.patch</filename>
            <type>text/plain</type>
            <size>2330</size>
            <attacher name="Mark Lam">mark.lam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh
bmdlTG9nCShyZXZpc2lvbiAyMjc3OTApCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu
ZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE4LTAxLTMwICBNYXJrIExhbSAgPG1hcmsubGFt
QGFwcGxlLmNvbT4KKworICAgICAgICBNb3ZlIEVOQUJMRV9QT0lTT04gdG8gUGxhdGZvcm0uaC4K
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjI5OAor
ICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzcwMzI2ODY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRU5BQkxFX1BPSVNPTiBiZWxvbmdzIGluIFBsYXRm
b3JtLmggdG8gZW5zdXJlIHRoYXQgYWxsIHBsYWNlcyB0aGF0IGRlcGVuZCBvbgorICAgICAgICBF
TkFCTEUoUE9JU09OKSB3aWxsIHNlZSBpdCBwcm9wZXJseSBkZWZpbmVkLgorCisgICAgICAgICog
d3RmL1BsYXRmb3JtLmg6CisgICAgICAgICogd3RmL1BvaXNvbmVkLmg6CisKIDIwMTgtMDEtMjYg
IE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBpbmZyYXN0cnVj
dHVyZSBmb3IgcG9pbnRlciBwcmVwYXJhdGlvbi4KSW5kZXg6IFNvdXJjZS9XVEYvd3RmL1BsYXRm
b3JtLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAkocmV2aXNpb24g
MjI3NzkwKQorKysgU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAkod29ya2luZyBjb3B5KQpAQCAt
MSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMDYtMjAxNyBBcHBsZSBJbmMuIEFs
bCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMDYtMjAxOCBBcHBsZSBJbmMu
IEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKiBDb3B5cmlnaHQgKEMpIDIwMDctMjAwOSBUb3JjaCBN
b2JpbGUsIEluYy4KICAqIENvcHlyaWdodCAoQykgMjAxMCwgMjAxMSBSZXNlYXJjaCBJbiBNb3Rp
b24gTGltaXRlZC4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCkBAIC0xMDEzLDYgKzEwMTMsMTMg
QEAKICNkZWZpbmUgRU5BQkxFX1NJR05BTF9CQVNFRF9WTV9UUkFQUyAxCiAjZW5kaWYKIAorI2Rl
ZmluZSBFTkFCTEVfUE9JU09OIDEKKy8qIE5vdCBjdXJyZW50bHkgc3VwcG9ydGVkIGZvciAzMi1i
aXQgb3IgT1MoV0lORE9XUykgYnVpbGRzIChiZWNhdXNlIG9mIG1pc3NpbmcgbGxpbnQgc3VwcG9y
dCkuIE1ha2Ugc3VyZSBpdCdzIGRpc2FibGVkLiAqLworI2lmIFVTRShKU1ZBTFVFMzJfNjQpIHx8
IE9TKFdJTkRPV1MpCisjdW5kZWYgRU5BQkxFX1BPSVNPTgorI2RlZmluZSBFTkFCTEVfUE9JU09O
IDAKKyNlbmRpZgorCiAvKiBDU1MgU2VsZWN0b3IgSklUIENvbXBpbGVyICovCiAjaWYgIWRlZmlu
ZWQoRU5BQkxFX0NTU19TRUxFQ1RPUl9KSVQpCiAjaWYgKENQVShYODZfNjQpIHx8IENQVShBUk02
NCkgfHwgKENQVShBUk1fVEhVTUIyKSAmJiBQTEFURk9STShJT1MpKSkgJiYgRU5BQkxFKEpJVCkg
JiYgKE9TKERBUldJTikgfHwgUExBVEZPUk0oR1RLKSB8fCBQTEFURk9STShXUEUpKQpJbmRleDog
U291cmNlL1dURi93dGYvUG9pc29uZWQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9Q
b2lzb25lZC5oCShyZXZpc2lvbiAyMjc3OTApCisrKyBTb3VyY2UvV1RGL3d0Zi9Qb2lzb25lZC5o
CSh3b3JraW5nIGNvcHkpCkBAIC0yOSwxNCArMjksOSBAQAogI2luY2x1ZGUgPHV0aWxpdHk+CiAj
aW5jbHVkZSA8d3RmL0Fzc2VydGlvbnMuaD4KIAotI2RlZmluZSBFTkFCTEVfUE9JU09OIDEKICNk
ZWZpbmUgRU5BQkxFX1BPSVNPTl9BU1NFUlRTIDAKIAotLy8gTm90IGN1cnJlbnRseSBzdXBwb3J0
ZWQgZm9yIDMyLWJpdCBvciBPUyhXSU5ET1dTKSBidWlsZHMgKGJlY2F1c2Ugb2YgbWlzc2luZyBs
bGludCBzdXBwb3J0KS4KLS8vIE1ha2Ugc3VyZSBpdCdzIGRpc2FibGVkLgotI2lmIFVTRShKU1ZB
TFVFMzJfNjQpIHx8IE9TKFdJTkRPV1MpCi0jdW5kZWYgRU5BQkxFX1BPSVNPTgotI2RlZmluZSBF
TkFCTEVfUE9JU09OIDAKKyNpZiAhRU5BQkxFKFBPSVNPTikKICN1bmRlZiBFTkFCTEVfUE9JU09O
X0FTU0VSVFMKICNkZWZpbmUgRU5BQkxFX1BPSVNPTl9BU1NFUlRTIDAKICNlbmRpZgo=
</data>
<flag name="review"
          id="351595"
          type_id="1"
          status="+"
          setter="msaboff"
    />
          </attachment>
      

    </bug>

</bugzilla>