182293 2018-01-30 08:18:08 -0800 Web Automation: cookies returned by automation should have expiry time in seconds 2018-01-31 01:10:49 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg webkit-bug-importer oldest_to_newest 1394551 0 cgarcia 2018-01-30 08:18:08 -0800 When creating a WebCore::Cookie from a WebDriver object we convert the given expiry time to milliseconds, but when creating a WebDriver object from a WebCore::Cookie we are keeping the milliseconds. We should convert to seconds for consistency, so that the WebDriver always handles seconds. This fixes imported/w3c/webdriver/tests/cookies/get_named_cookie.py::test_get_named_cookie ___________________________________________________________________________________ test_get_named_cookie ____________________________________________________________________________________ session = <webdriver.client.Session object at 0x7fa1cc7a5550>, url = <function url at 0x7fa1cc80ea28> def test_get_named_cookie(session, url): session.url = url("/common/blank.html") clear_all_cookies(session) # same formatting as Date.toUTCString() in javascript utc_string_format = "%a, %d %b %Y %H:%M:%S" a_year_from_now = (datetime.utcnow() + timedelta(days=365)).strftime(utc_string_format) session.execute_script("document.cookie = 'foo=bar;expires=%s'" % a_year_from_now) result = session.transport.send("GET", "session/%s/cookie" % session.session_id) assert result.status == 200 assert "value" in result.body assert isinstance(result.body["value"], list) assert len(result.body["value"]) == 1 assert isinstance(result.body["value"][0], dict) cookie = result.body["value"][0] assert "name" in cookie assert isinstance(cookie["name"], basestring) assert "value" in cookie assert isinstance(cookie["value"], basestring) assert "expiry" in cookie assert isinstance(cookie["expiry"], (int, long)) assert cookie["name"] == "foo" assert cookie["value"] == "bar" # convert from seconds since epoch > assert datetime.utcfromtimestamp(cookie["expiry"]).strftime(utc_string_format) == a_year_from_now E AssertionError: assert 'Thu, 13 Jun 1918 11:59:04' == 'Wed, 30 Jan 2019 13:52:05' E - Thu, 13 Jun 1918 11:59:04 E + Wed, 30 Jan 2019 13:52:05 a_year_from_now = 'Wed, 30 Jan 2019 13:52:05' cookie = {'domain': 'localhost', 'expiry': -1626868856, 'httpOnly': False, 'name': 'foo', ...} result = <Responsetatus=200 body={"value": [{"domain": "localhost", "name": "foo", "val...expiry": -1626868856, "path": "/common", "httpOnly": false, "secure": false}]}> session = <webdriver.client.Session object at 0x7fa1cc7a5550> url = <function url at 0x7fa1cc80ea28> utc_string_format = '%a, %d %b %Y %H:%M:%S' WebDriverTests/imported/w3c/webdriver/tests/cookies/get_named_cookie.py:62: AssertionError 1394554 1 332655 cgarcia 2018-01-30 08:20:14 -0800 Created attachment 332655 Patch 1394577 2 332655 bburg 2018-01-30 09:27:41 -0800 Comment on attachment 332655 Patch r=me Oops, we did document this as the unit of measure, but messed up: { "name": "expires", "type": "number", "description": "Cookie expiration in seconds since the UNIX epoch." }, 1394934 3 cgarcia 2018-01-31 01:09:53 -0800 Committed r227891: <https://trac.webkit.org/changeset/227891> 1394936 4 webkit-bug-importer 2018-01-31 01:10:49 -0800 <rdar://problem/37061229> 332655 2018-01-30 08:20:14 -0800 2018-01-30 09:27:41 -0800 Patch wd-cookie-expiry.diff text/plain 1859 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNGUwYjIzZTJmNzkuLjg2M2U3ZmQ4MGUyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE5IEBACisyMDE4LTAxLTMwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBXZWIgQXV0b21hdGlvbjogY29va2llcyByZXR1cm5lZCBieSBhdXRv bWF0aW9uIHNob3VsZCBoYXZlIGV4cGlyeSB0aW1lIGluIHNlY29uZHMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjI5MworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gY3JlYXRpbmcgYSBXZWJDb3Jl OjpDb29raWUgZnJvbSBhIFdlYkRyaXZlciBvYmplY3Qgd2UgY29udmVydCB0aGUgZ2l2ZW4gZXhw aXJ5IHRpbWUgdG8gbWlsbGlzZWNvbmRzLCBidXQKKyAgICAgICAgd2hlbiBjcmVhdGluZyBhIFdl YkRyaXZlciBvYmplY3QgZnJvbSBhIFdlYkNvcmU6OkNvb2tpZSB3ZSBhcmUga2VlcGluZyB0aGUg bWlsbGlzZWNvbmRzLiBXZSBzaG91bGQgY29udmVydCB0bworICAgICAgICBzZWNvbmRzIGZvciBj b25zaXN0ZW5jeSwgc28gdGhhdCB0aGUgV2ViRHJpdmVyIGFsd2F5cyBoYW5kbGVzIHNlY29uZHMu CisKKyAgICAgICAgRml4ZXM6IGltcG9ydGVkL3czYy93ZWJkcml2ZXIvdGVzdHMvY29va2llcy9n ZXRfbmFtZWRfY29va2llLnB5Ojp0ZXN0X2dldF9uYW1lZF9jb29raWUKKworICAgICAgICAqIFVJ UHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9tYXRpb25TZXNzaW9uLmNwcDoKKyAgICAgICAgKFdl YktpdDo6YnVpbGRPYmplY3RGb3JDb29raWUpOiBDb252ZXJ0IGV4cGlyeSB0byBzZWNvbmRzLgor CiAyMDE4LTAxLTMwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4K IAogICAgICAgICBSRUdSRVNTSU9OKHIyMjc1NDQpOiBbR1RLXSBjb250ZXh0TWVudUV2ZW50IGlz IE5VTEwgb24gQ09OVEVYVF9NRU5VIGNhbGwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL0F1dG9tYXRpb24vV2ViQXV0b21hdGlvblNlc3Npb24uY3BwIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvbi5jcHAKaW5kZXggNWUx NjRlZTE1NDAuLmVmMDFkMzAxNjk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9BdXRvbWF0aW9uL1dlYkF1dG9tYXRpb25TZXNzaW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9tYXRpb25TZXNzaW9uLmNwcApAQCAtMTEyMiw3 ICsxMTIyLDcgQEAgc3RhdGljIFJlZjxJbnNwZWN0b3I6OlByb3RvY29sOjpBdXRvbWF0aW9uOjpD b29raWU+IGJ1aWxkT2JqZWN0Rm9yQ29va2llKGNvbnN0IFcKICAgICAgICAgLnNldFZhbHVlKGNv b2tpZS52YWx1ZSkKICAgICAgICAgLnNldERvbWFpbihjb29raWUuZG9tYWluKQogICAgICAgICAu c2V0UGF0aChjb29raWUucGF0aCkKLSAgICAgICAgLnNldEV4cGlyZXMoY29va2llLmV4cGlyZXMp CisgICAgICAgIC5zZXRFeHBpcmVzKGNvb2tpZS5leHBpcmVzID8gY29va2llLmV4cGlyZXMgLyAx MDAwIDogMCkKICAgICAgICAgLnNldFNpemUoKGNvb2tpZS5uYW1lLmxlbmd0aCgpICsgY29va2ll LnZhbHVlLmxlbmd0aCgpKSkKICAgICAgICAgLnNldEh0dHBPbmx5KGNvb2tpZS5odHRwT25seSkK ICAgICAgICAgLnNldFNlY3VyZShjb29raWUuc2VjdXJlKQo=